[INFO] crate juniper_hyper 0.1.0 is already in cache [INFO] extracting crate juniper_hyper 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/juniper_hyper/0.1.0 [INFO] extracting crate juniper_hyper 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/juniper_hyper/0.1.0 [INFO] validating manifest of juniper_hyper-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of juniper_hyper-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing juniper_hyper-0.1.0 [INFO] finished frobbing juniper_hyper-0.1.0 [INFO] frobbed toml for juniper_hyper-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/juniper_hyper/0.1.0/Cargo.toml [INFO] started frobbing juniper_hyper-0.1.0 [INFO] finished frobbing juniper_hyper-0.1.0 [INFO] frobbed toml for juniper_hyper-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/juniper_hyper/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting juniper_hyper-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/juniper_hyper/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4436ef90c2373d9d2fda962ca7bf54edeec929dcc29f3c440af41b352bdcf4d0 [INFO] running `"docker" "start" "-a" "4436ef90c2373d9d2fda962ca7bf54edeec929dcc29f3c440af41b352bdcf4d0"` [INFO] [stderr] Checking indexmap v1.0.2 [INFO] [stderr] Compiling juniper_codegen v0.10.0 [INFO] [stderr] Checking h2 v0.1.16 [INFO] [stderr] Checking juniper v0.10.0 [INFO] [stderr] Checking hyper v0.12.23 [INFO] [stderr] Checking juniper_hyper v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:73:14 [INFO] [stderr] | [INFO] [stderr] 73 | _ => return Box::new(future::ok(new_response(StatusCode::METHOD_NOT_ALLOWED))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(future::ok(new_response(StatusCode::METHOD_NOT_ALLOWED)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / match request.method() { [INFO] [stderr] 44 | | &Method::GET => Box::new( [INFO] [stderr] 45 | | future::done( [INFO] [stderr] 46 | | request [INFO] [stderr] ... | [INFO] [stderr] 73 | | _ => return Box::new(future::ok(new_response(StatusCode::METHOD_NOT_ALLOWED))), [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 43 | match *request.method() { [INFO] [stderr] 44 | Method::GET => Box::new( [INFO] [stderr] 45 | future::done( [INFO] [stderr] 46 | request [INFO] [stderr] 47 | .uri() [INFO] [stderr] 48 | .query() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:50:22 [INFO] [stderr] | [INFO] [stderr] 50 | .unwrap_or(Err(GraphQLRequestError::Invalid( [INFO] [stderr] | ______________________^ [INFO] [stderr] 51 | | "'query' parameter is missing".to_string(), [INFO] [stderr] 52 | | ))), [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 50 | .unwrap_or_else(|| Err(GraphQLRequestError::Invalid( [INFO] [stderr] 51 | "'query' parameter is missing".to_string(), [INFO] [stderr] 52 | ))), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:203:9 [INFO] [stderr] | [INFO] [stderr] 203 | / match self { [INFO] [stderr] 204 | | &GraphQLRequest::Single(ref request) => { [INFO] [stderr] 205 | | GraphQLResponse::Single(request.execute(root_node, context)) [INFO] [stderr] 206 | | } [INFO] [stderr] ... | [INFO] [stderr] 212 | | ), [INFO] [stderr] 213 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 203 | match *self { [INFO] [stderr] 204 | GraphQLRequest::Single(ref request) => { [INFO] [stderr] 205 | GraphQLResponse::Single(request.execute(root_node, context)) [INFO] [stderr] 206 | } [INFO] [stderr] 207 | GraphQLRequest::Batch(ref requests) => GraphQLResponse::Batch( [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:226:9 [INFO] [stderr] | [INFO] [stderr] 226 | / match self { [INFO] [stderr] 227 | | &GraphQLResponse::Single(ref response) => response.is_ok(), [INFO] [stderr] 228 | | &GraphQLResponse::Batch(ref responses) => responses [INFO] [stderr] 229 | | .iter() [INFO] [stderr] 230 | | .fold(true, |ok, response| ok && response.is_ok()), [INFO] [stderr] 231 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 226 | match *self { [INFO] [stderr] 227 | GraphQLResponse::Single(ref response) => response.is_ok(), [INFO] [stderr] 228 | GraphQLResponse::Batch(ref responses) => responses [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/lib.rs:229:24 [INFO] [stderr] | [INFO] [stderr] 229 | .iter() [INFO] [stderr] | ________________________^ [INFO] [stderr] 230 | | .fold(true, |ok, response| ok && response.is_ok()), [INFO] [stderr] | |__________________________________________________________________^ help: try: `.all(|response| response.is_ok())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:73:14 [INFO] [stderr] | [INFO] [stderr] 73 | _ => return Box::new(future::ok(new_response(StatusCode::METHOD_NOT_ALLOWED))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(future::ok(new_response(StatusCode::METHOD_NOT_ALLOWED)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / match request.method() { [INFO] [stderr] 44 | | &Method::GET => Box::new( [INFO] [stderr] 45 | | future::done( [INFO] [stderr] 46 | | request [INFO] [stderr] ... | [INFO] [stderr] 73 | | _ => return Box::new(future::ok(new_response(StatusCode::METHOD_NOT_ALLOWED))), [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 43 | match *request.method() { [INFO] [stderr] 44 | Method::GET => Box::new( [INFO] [stderr] 45 | future::done( [INFO] [stderr] 46 | request [INFO] [stderr] 47 | .uri() [INFO] [stderr] 48 | .query() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:50:22 [INFO] [stderr] | [INFO] [stderr] 50 | .unwrap_or(Err(GraphQLRequestError::Invalid( [INFO] [stderr] | ______________________^ [INFO] [stderr] 51 | | "'query' parameter is missing".to_string(), [INFO] [stderr] 52 | | ))), [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 50 | .unwrap_or_else(|| Err(GraphQLRequestError::Invalid( [INFO] [stderr] 51 | "'query' parameter is missing".to_string(), [INFO] [stderr] 52 | ))), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:203:9 [INFO] [stderr] | [INFO] [stderr] 203 | / match self { [INFO] [stderr] 204 | | &GraphQLRequest::Single(ref request) => { [INFO] [stderr] 205 | | GraphQLResponse::Single(request.execute(root_node, context)) [INFO] [stderr] 206 | | } [INFO] [stderr] ... | [INFO] [stderr] 212 | | ), [INFO] [stderr] 213 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 203 | match *self { [INFO] [stderr] 204 | GraphQLRequest::Single(ref request) => { [INFO] [stderr] 205 | GraphQLResponse::Single(request.execute(root_node, context)) [INFO] [stderr] 206 | } [INFO] [stderr] 207 | GraphQLRequest::Batch(ref requests) => GraphQLResponse::Batch( [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:226:9 [INFO] [stderr] | [INFO] [stderr] 226 | / match self { [INFO] [stderr] 227 | | &GraphQLResponse::Single(ref response) => response.is_ok(), [INFO] [stderr] 228 | | &GraphQLResponse::Batch(ref responses) => responses [INFO] [stderr] 229 | | .iter() [INFO] [stderr] 230 | | .fold(true, |ok, response| ok && response.is_ok()), [INFO] [stderr] 231 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 226 | match *self { [INFO] [stderr] 227 | GraphQLResponse::Single(ref response) => response.is_ok(), [INFO] [stderr] 228 | GraphQLResponse::Batch(ref responses) => responses [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/lib.rs:229:24 [INFO] [stderr] | [INFO] [stderr] 229 | .iter() [INFO] [stderr] | ________________________^ [INFO] [stderr] 230 | | .fold(true, |ok, response| ok && response.is_ok()), [INFO] [stderr] | |__________________________________________________________________^ help: try: `.all(|response| response.is_ok())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:301:51 [INFO] [stderr] | [INFO] [stderr] 301 | make_test_response(reqwest::get(&url).expect(&format!("failed GET {}", url))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failed GET {}", url))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:311:18 [INFO] [stderr] | [INFO] [stderr] 311 | .expect(&format!("failed POST {}", url)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failed POST {}", url))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:317:27 [INFO] [stderr] | [INFO] [stderr] 317 | let status_code = response.status().as_u16() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(response.status().as_u16())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:353:21 [INFO] [stderr] | [INFO] [stderr] 353 | / match req.method() { [INFO] [stderr] 354 | | &Method::POST | &Method::GET => path == "/graphql" || path == "/graphql/", [INFO] [stderr] 355 | | _ => false, [INFO] [stderr] 356 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 353 | match *req.method() { [INFO] [stderr] 354 | Method::POST | Method::GET => path == "/graphql" || path == "/graphql/", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 37.83s [INFO] running `"docker" "inspect" "4436ef90c2373d9d2fda962ca7bf54edeec929dcc29f3c440af41b352bdcf4d0"` [INFO] running `"docker" "rm" "-f" "4436ef90c2373d9d2fda962ca7bf54edeec929dcc29f3c440af41b352bdcf4d0"` [INFO] [stdout] 4436ef90c2373d9d2fda962ca7bf54edeec929dcc29f3c440af41b352bdcf4d0