[INFO] crate juniper_codegen 0.10.0 is already in cache [INFO] extracting crate juniper_codegen 0.10.0 into work/ex/clippy-test-run/sources/stable/reg/juniper_codegen/0.10.0 [INFO] extracting crate juniper_codegen 0.10.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/juniper_codegen/0.10.0 [INFO] validating manifest of juniper_codegen-0.10.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of juniper_codegen-0.10.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing juniper_codegen-0.10.0 [INFO] finished frobbing juniper_codegen-0.10.0 [INFO] frobbed toml for juniper_codegen-0.10.0 written to work/ex/clippy-test-run/sources/stable/reg/juniper_codegen/0.10.0/Cargo.toml [INFO] started frobbing juniper_codegen-0.10.0 [INFO] finished frobbing juniper_codegen-0.10.0 [INFO] frobbed toml for juniper_codegen-0.10.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/juniper_codegen/0.10.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting juniper_codegen-0.10.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/juniper_codegen/0.10.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1068a45a34da54a5df92f84a908e01eeb1dbcc3c4a4235230b1415b6ff6410ad [INFO] running `"docker" "start" "-a" "1068a45a34da54a5df92f84a908e01eeb1dbcc3c4a4235230b1415b6ff6410ad"` [INFO] [stderr] Checking juniper_codegen v0.10.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/derive_enum.rs:45:17 [INFO] [stderr] | [INFO] [stderr] 45 | / match item { [INFO] [stderr] 46 | | NestedMeta::Meta(Meta::Word(ref ident)) => { [INFO] [stderr] 47 | | if ident == "_internal" { [INFO] [stderr] 48 | | res.internal = true; [INFO] [stderr] ... | [INFO] [stderr] 52 | | _ => {} [INFO] [stderr] 53 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 45 | if let NestedMeta::Meta(Meta::Word(ref ident)) = item { [INFO] [stderr] 46 | if ident == "_internal" { [INFO] [stderr] 47 | res.internal = true; [INFO] [stderr] 48 | continue; [INFO] [stderr] 49 | } [INFO] [stderr] 50 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/derive_enum.rs:121:27 [INFO] [stderr] | [INFO] [stderr] 121 | let name = attrs.name.unwrap_or(ast.ident.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| ast.ident.to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/derive_enum.rs:150:14 [INFO] [stderr] | [INFO] [stderr] 150 | .unwrap_or(::util::to_upper_snake_case(&variant.ident.to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| ::util::to_upper_snake_case(&variant.ident.to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/derive_input_object.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | / match item { [INFO] [stderr] 42 | | NestedMeta::Meta(Meta::Word(ref ident)) => { [INFO] [stderr] 43 | | if ident == "_internal" { [INFO] [stderr] 44 | | res.internal = true; [INFO] [stderr] ... | [INFO] [stderr] 48 | | _ => {} [INFO] [stderr] 49 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 41 | if let NestedMeta::Meta(Meta::Word(ref ident)) = item { [INFO] [stderr] 42 | if ident == "_internal" { [INFO] [stderr] 43 | res.internal = true; [INFO] [stderr] 44 | continue; [INFO] [stderr] 45 | } [INFO] [stderr] 46 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/derive_input_object.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | / match item { [INFO] [stderr] 98 | | NestedMeta::Meta(Meta::Word(ref ident)) => { [INFO] [stderr] 99 | | if ident == "default" { [INFO] [stderr] 100 | | res.default = true; [INFO] [stderr] ... | [INFO] [stderr] 104 | | _ => {} [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 97 | if let NestedMeta::Meta(Meta::Word(ref ident)) = item { [INFO] [stderr] 98 | if ident == "default" { [INFO] [stderr] 99 | res.default = true; [INFO] [stderr] 100 | continue; [INFO] [stderr] 101 | } [INFO] [stderr] 102 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/derive_input_object.rs:134:27 [INFO] [stderr] | [INFO] [stderr] 134 | let name = attrs.name.unwrap_or(ast.ident.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| ast.ident.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/derive_input_object.rs:183:25 [INFO] [stderr] | [INFO] [stderr] 183 | Err(_) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/derive_input_object.rs:179:29 [INFO] [stderr] | [INFO] [stderr] 179 | Err(_) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/derive_object.rs:85:24 [INFO] [stderr] | [INFO] [stderr] 85 | if let Some(_) = keyed_item_value(&item, "skip", AttributeValidation::Bare) { [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 86 | | res.skip = true; [INFO] [stderr] 87 | | continue; [INFO] [stderr] 88 | | } [INFO] [stderr] | |_________________- help: try this: `if keyed_item_value(&item, "skip", AttributeValidation::Bare).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/derive_enum.rs:45:17 [INFO] [stderr] | [INFO] [stderr] 45 | / match item { [INFO] [stderr] 46 | | NestedMeta::Meta(Meta::Word(ref ident)) => { [INFO] [stderr] 47 | | if ident == "_internal" { [INFO] [stderr] 48 | | res.internal = true; [INFO] [stderr] ... | [INFO] [stderr] 52 | | _ => {} [INFO] [stderr] 53 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 45 | if let NestedMeta::Meta(Meta::Word(ref ident)) = item { [INFO] [stderr] 46 | if ident == "_internal" { [INFO] [stderr] 47 | res.internal = true; [INFO] [stderr] 48 | continue; [INFO] [stderr] 49 | } [INFO] [stderr] 50 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/derive_object.rs:117:27 [INFO] [stderr] | [INFO] [stderr] 117 | let name = attrs.name.unwrap_or(ast.ident.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| ast.ident.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/derive_enum.rs:121:27 [INFO] [stderr] | [INFO] [stderr] 121 | let name = attrs.name.unwrap_or(ast.ident.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| ast.ident.to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/derive_enum.rs:150:14 [INFO] [stderr] | [INFO] [stderr] 150 | .unwrap_or(::util::to_upper_snake_case(&variant.ident.to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| ::util::to_upper_snake_case(&variant.ident.to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/util.rs:16:31 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn get_doc_comment(attrs: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Attribute]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/util.rs:26:27 [INFO] [stderr] | [INFO] [stderr] 26 | fn join_doc_strings(docs: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/util.rs:39:27 [INFO] [stderr] | [INFO] [stderr] 39 | fn get_doc_strings(items: &Vec) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[MetaNameValue]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/util.rs:58:24 [INFO] [stderr] | [INFO] [stderr] 58 | fn get_doc_attr(attrs: &Vec) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Attribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/util.rs:73:32 [INFO] [stderr] | [INFO] [stderr] 73 | pub fn get_graphql_attr(attrs: &Vec) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Attribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/util.rs:77:29 [INFO] [stderr] | [INFO] [stderr] 77 | return Some(list.nested.iter().map(|x| x.clone()).collect()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `list.nested.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/util.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | / match item { [INFO] [stderr] 87 | | // Attributes in the form of `#[graphql(name = "value")]`. [INFO] [stderr] 88 | | &NestedMeta::Meta(Meta::NameValue(ref nameval)) if nameval.ident == name => { [INFO] [stderr] 89 | | match &nameval.lit { [INFO] [stderr] ... | [INFO] [stderr] 115 | | _ => None, [INFO] [stderr] 116 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 86 | match *item { [INFO] [stderr] 87 | // Attributes in the form of `#[graphql(name = "value")]`. [INFO] [stderr] 88 | NestedMeta::Meta(Meta::NameValue(ref nameval)) if nameval.ident == name => { [INFO] [stderr] 89 | match &nameval.lit { [INFO] [stderr] 90 | // We have a string attribute value. [INFO] [stderr] 91 | &Lit::Str(ref strlit) => match validation { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/util.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | / match &nameval.lit { [INFO] [stderr] 90 | | // We have a string attribute value. [INFO] [stderr] 91 | | &Lit::Str(ref strlit) => match validation { [INFO] [stderr] 92 | | AttributeValidation::Bare => { [INFO] [stderr] ... | [INFO] [stderr] 100 | | _ => None, [INFO] [stderr] 101 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 89 | match nameval.lit { [INFO] [stderr] 90 | // We have a string attribute value. [INFO] [stderr] 91 | Lit::Str(ref strlit) => match validation { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/util.rs:104:53 [INFO] [stderr] | [INFO] [stderr] 104 | &NestedMeta::Meta(Meta::Word(ref ident)) if ident.to_string() == name => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `*ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/derive_input_object.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | / match item { [INFO] [stderr] 42 | | NestedMeta::Meta(Meta::Word(ref ident)) => { [INFO] [stderr] 43 | | if ident == "_internal" { [INFO] [stderr] 44 | | res.internal = true; [INFO] [stderr] ... | [INFO] [stderr] 48 | | _ => {} [INFO] [stderr] 49 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 41 | if let NestedMeta::Meta(Meta::Word(ref ident)) = item { [INFO] [stderr] 42 | if ident == "_internal" { [INFO] [stderr] 43 | res.internal = true; [INFO] [stderr] 44 | continue; [INFO] [stderr] 45 | } [INFO] [stderr] 46 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/derive_input_object.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | / match item { [INFO] [stderr] 98 | | NestedMeta::Meta(Meta::Word(ref ident)) => { [INFO] [stderr] 99 | | if ident == "default" { [INFO] [stderr] 100 | | res.default = true; [INFO] [stderr] ... | [INFO] [stderr] 104 | | _ => {} [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 97 | if let NestedMeta::Meta(Meta::Word(ref ident)) = item { [INFO] [stderr] 98 | if ident == "default" { [INFO] [stderr] 99 | res.default = true; [INFO] [stderr] 100 | continue; [INFO] [stderr] 101 | } [INFO] [stderr] 102 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/derive_input_object.rs:134:27 [INFO] [stderr] | [INFO] [stderr] 134 | let name = attrs.name.unwrap_or(ast.ident.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| ast.ident.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/derive_input_object.rs:183:25 [INFO] [stderr] | [INFO] [stderr] 183 | Err(_) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/derive_input_object.rs:179:29 [INFO] [stderr] | [INFO] [stderr] 179 | Err(_) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/derive_object.rs:85:24 [INFO] [stderr] | [INFO] [stderr] 85 | if let Some(_) = keyed_item_value(&item, "skip", AttributeValidation::Bare) { [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 86 | | res.skip = true; [INFO] [stderr] 87 | | continue; [INFO] [stderr] 88 | | } [INFO] [stderr] | |_________________- help: try this: `if keyed_item_value(&item, "skip", AttributeValidation::Bare).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/derive_object.rs:117:27 [INFO] [stderr] | [INFO] [stderr] 117 | let name = attrs.name.unwrap_or(ast.ident.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| ast.ident.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/util.rs:16:31 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn get_doc_comment(attrs: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Attribute]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/util.rs:26:27 [INFO] [stderr] | [INFO] [stderr] 26 | fn join_doc_strings(docs: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/util.rs:39:27 [INFO] [stderr] | [INFO] [stderr] 39 | fn get_doc_strings(items: &Vec) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[MetaNameValue]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/util.rs:58:24 [INFO] [stderr] | [INFO] [stderr] 58 | fn get_doc_attr(attrs: &Vec) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Attribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/util.rs:73:32 [INFO] [stderr] | [INFO] [stderr] 73 | pub fn get_graphql_attr(attrs: &Vec) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Attribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/util.rs:77:29 [INFO] [stderr] | [INFO] [stderr] 77 | return Some(list.nested.iter().map(|x| x.clone()).collect()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `list.nested.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/util.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | / match item { [INFO] [stderr] 87 | | // Attributes in the form of `#[graphql(name = "value")]`. [INFO] [stderr] 88 | | &NestedMeta::Meta(Meta::NameValue(ref nameval)) if nameval.ident == name => { [INFO] [stderr] 89 | | match &nameval.lit { [INFO] [stderr] ... | [INFO] [stderr] 115 | | _ => None, [INFO] [stderr] 116 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 86 | match *item { [INFO] [stderr] 87 | // Attributes in the form of `#[graphql(name = "value")]`. [INFO] [stderr] 88 | NestedMeta::Meta(Meta::NameValue(ref nameval)) if nameval.ident == name => { [INFO] [stderr] 89 | match &nameval.lit { [INFO] [stderr] 90 | // We have a string attribute value. [INFO] [stderr] 91 | &Lit::Str(ref strlit) => match validation { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/util.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | / match &nameval.lit { [INFO] [stderr] 90 | | // We have a string attribute value. [INFO] [stderr] 91 | | &Lit::Str(ref strlit) => match validation { [INFO] [stderr] 92 | | AttributeValidation::Bare => { [INFO] [stderr] ... | [INFO] [stderr] 100 | | _ => None, [INFO] [stderr] 101 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 89 | match nameval.lit { [INFO] [stderr] 90 | // We have a string attribute value. [INFO] [stderr] 91 | Lit::Str(ref strlit) => match validation { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/util.rs:104:53 [INFO] [stderr] | [INFO] [stderr] 104 | &NestedMeta::Meta(Meta::Word(ref ident)) if ident.to_string() == name => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `*ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/util.rs:202:24 [INFO] [stderr] | [INFO] [stderr] 202 | ident: ident("doc").into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ident("doc")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/util.rs:216:28 [INFO] [stderr] | [INFO] [stderr] 216 | ident: ident("doc").into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ident("doc")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/util.rs:221:28 [INFO] [stderr] | [INFO] [stderr] 221 | ident: ident("doc").into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ident("doc")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/util.rs:226:28 [INFO] [stderr] | [INFO] [stderr] 226 | ident: ident("doc").into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ident("doc")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/util.rs:240:24 [INFO] [stderr] | [INFO] [stderr] 240 | ident: ident("blah").into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ident("blah")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.97s [INFO] running `"docker" "inspect" "1068a45a34da54a5df92f84a908e01eeb1dbcc3c4a4235230b1415b6ff6410ad"` [INFO] running `"docker" "rm" "-f" "1068a45a34da54a5df92f84a908e01eeb1dbcc3c4a4235230b1415b6ff6410ad"` [INFO] [stdout] 1068a45a34da54a5df92f84a908e01eeb1dbcc3c4a4235230b1415b6ff6410ad