[INFO] crate juju 1.0.0 is already in cache
[INFO] extracting crate juju 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/juju/1.0.0
[INFO] extracting crate juju 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/juju/1.0.0
[INFO] validating manifest of juju-1.0.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of juju-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing juju-1.0.0
[INFO] finished frobbing juju-1.0.0
[INFO] frobbed toml for juju-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/juju/1.0.0/Cargo.toml
[INFO] started frobbing juju-1.0.0
[INFO] finished frobbing juju-1.0.0
[INFO] frobbed toml for juju-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/juju/1.0.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting juju-1.0.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/juju/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d9ab1b657424ddf90359ce5f1659fd6dc43c30179e8ed3dfd43ec5b492195e7c
[INFO] running `"docker" "start" "-a" "d9ab1b657424ddf90359ce5f1659fd6dc43c30179e8ed3dfd43ec5b492195e7c"`
[INFO] [stderr]     Checking juju v0.3.1
[INFO] [stderr]     Checking rusqlite v0.14.0
[INFO] [stderr]     Checking charmhelpers v0.1.3
[INFO] [stderr]     Checking juju v1.0.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/unitdata.rs:54:13
[INFO] [stderr]    |
[INFO] [stderr] 54 |             conn: conn,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `conn`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/unitdata.rs:285:17
[INFO] [stderr]     |
[INFO] [stderr] 285 |                 date: date,
[INFO] [stderr]     |                 ^^^^^^^^^^ help: replace it with: `date`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/unitdata.rs:286:17
[INFO] [stderr]     |
[INFO] [stderr] 286 |                 key: key,
[INFO] [stderr]     |                 ^^^^^^^^ help: replace it with: `key`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/unitdata.rs:287:17
[INFO] [stderr]     |
[INFO] [stderr] 287 |                 hook: hook,
[INFO] [stderr]     |                 ^^^^^^^^^^ help: replace it with: `hook`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/unitdata.rs:288:17
[INFO] [stderr]     |
[INFO] [stderr] 288 |                 revision: revision,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^ help: replace it with: `revision`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:263:13
[INFO] [stderr]     |
[INFO] [stderr] 263 |             relation_type: relation_type,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `relation_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:264:13
[INFO] [stderr]     |
[INFO] [stderr] 264 |             relation_id: relation_id,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `relation_id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:265:13
[INFO] [stderr]     |
[INFO] [stderr] 265 |             unit: unit,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `unit`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:266:13
[INFO] [stderr]     |
[INFO] [stderr] 266 |             relations: relations,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `relations`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:741:13
[INFO] [stderr]     |
[INFO] [stderr] 741 |             id: id,
[INFO] [stderr]     |             ^^^^^^ help: replace it with: `id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:768:13
[INFO] [stderr]     |
[INFO] [stderr] 768 |             id: id,
[INFO] [stderr]     |             ^^^^^^ help: replace it with: `id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:787:13
[INFO] [stderr]     |
[INFO] [stderr] 787 |             id: id,
[INFO] [stderr]     |             ^^^^^^ help: replace it with: `id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:814:13
[INFO] [stderr]     |
[INFO] [stderr] 814 |             id: id,
[INFO] [stderr]     |             ^^^^^^ help: replace it with: `id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/unitdata.rs:54:13
[INFO] [stderr]    |
[INFO] [stderr] 54 |             conn: conn,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `conn`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/unitdata.rs:285:17
[INFO] [stderr]     |
[INFO] [stderr] 285 |                 date: date,
[INFO] [stderr]     |                 ^^^^^^^^^^ help: replace it with: `date`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/unitdata.rs:286:17
[INFO] [stderr]     |
[INFO] [stderr] 286 |                 key: key,
[INFO] [stderr]     |                 ^^^^^^^^ help: replace it with: `key`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/unitdata.rs:287:17
[INFO] [stderr]     |
[INFO] [stderr] 287 |                 hook: hook,
[INFO] [stderr]     |                 ^^^^^^^^^^ help: replace it with: `hook`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/unitdata.rs:288:17
[INFO] [stderr]     |
[INFO] [stderr] 288 |                 revision: revision,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^ help: replace it with: `revision`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:263:13
[INFO] [stderr]     |
[INFO] [stderr] 263 |             relation_type: relation_type,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `relation_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:264:13
[INFO] [stderr]     |
[INFO] [stderr] 264 |             relation_id: relation_id,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `relation_id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:265:13
[INFO] [stderr]     |
[INFO] [stderr] 265 |             unit: unit,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `unit`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:266:13
[INFO] [stderr]     |
[INFO] [stderr] 266 |             relations: relations,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `relations`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:741:13
[INFO] [stderr]     |
[INFO] [stderr] 741 |             id: id,
[INFO] [stderr]     |             ^^^^^^ help: replace it with: `id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:768:13
[INFO] [stderr]     |
[INFO] [stderr] 768 |             id: id,
[INFO] [stderr]     |             ^^^^^^ help: replace it with: `id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:787:13
[INFO] [stderr]     |
[INFO] [stderr] 787 |             id: id,
[INFO] [stderr]     |             ^^^^^^ help: replace it with: `id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:814:13
[INFO] [stderr]     |
[INFO] [stderr] 814 |             id: id,
[INFO] [stderr]     |             ^^^^^^ help: replace it with: `id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/unitdata.rs:251:9
[INFO] [stderr]     |
[INFO] [stderr] 251 |         return Ok(());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:400:9
[INFO] [stderr]     |
[INFO] [stderr] 400 |         return Ok(0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:402:9
[INFO] [stderr]     |
[INFO] [stderr] 402 |         return Err(JujuError::new(String::from_utf8(output.stderr)?));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(JujuError::new(String::from_utf8(output.stderr)?))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:417:5
[INFO] [stderr]     |
[INFO] [stderr] 417 |     return process_output(output);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(output)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:425:5
[INFO] [stderr]     |
[INFO] [stderr] 425 |     return Ok(az);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(az)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:433:5
[INFO] [stderr]     |
[INFO] [stderr] 433 |     return Ok(status);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(status)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:442:5
[INFO] [stderr]     |
[INFO] [stderr] 442 |     return Ok(info);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(info)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:451:5
[INFO] [stderr]     |
[INFO] [stderr] 451 |     return process_output(output);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(output)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:463:5
[INFO] [stderr]     |
[INFO] [stderr] 463 |     return process_output(output);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(output)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:481:5
[INFO] [stderr]     |
[INFO] [stderr] 481 |     return Ok(map);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(map)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:506:5
[INFO] [stderr]     |
[INFO] [stderr] 506 |     return Ok(name);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(name)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:514:5
[INFO] [stderr]     |
[INFO] [stderr] 514 |     return Ok(uuid);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(uuid)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:522:5
[INFO] [stderr]     |
[INFO] [stderr] 522 |     return Ok(tag);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(tag)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:536:5
[INFO] [stderr]     |
[INFO] [stderr] 536 |     return process_output(output);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(output)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:548:5
[INFO] [stderr]     |
[INFO] [stderr] 548 |     return process_output(output);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(output)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:563:5
[INFO] [stderr]     |
[INFO] [stderr] 563 |     return Ok(ip);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ip)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:576:5
[INFO] [stderr]     |
[INFO] [stderr] 576 |     return Ok(ip);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ip)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:616:5
[INFO] [stderr]     |
[INFO] [stderr] 616 |     return Ok(values);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(values)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:629:5
[INFO] [stderr]     |
[INFO] [stderr] 629 |     return process_output(output);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(output)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:642:5
[INFO] [stderr]     |
[INFO] [stderr] 642 |     return process_output(output);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(output)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:654:5
[INFO] [stderr]     |
[INFO] [stderr] 654 |     return process_output(output);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(output)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:667:5
[INFO] [stderr]     |
[INFO] [stderr] 667 |     return Ok(relation);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(relation)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:745:5
[INFO] [stderr]     |
[INFO] [stderr] 745 |     return Ok(related_units);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(related_units)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:772:5
[INFO] [stderr]     |
[INFO] [stderr] 772 |     return Ok(related_units);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(related_units)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:791:5
[INFO] [stderr]     |
[INFO] [stderr] 791 |     return Ok(related_units);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(related_units)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:818:5
[INFO] [stderr]     |
[INFO] [stderr] 818 |     return Ok(related_units);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(related_units)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:831:5
[INFO] [stderr]     |
[INFO] [stderr] 831 |     return process_output(output);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(output)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:839:5
[INFO] [stderr]     |
[INFO] [stderr] 839 |     return Ok(String::from_utf8(output.stdout)?);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(String::from_utf8(output.stdout)?)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:884:5
[INFO] [stderr]     |
[INFO] [stderr] 884 |     return Ok(String::from_utf8(output.stdout)?);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(String::from_utf8(output.stdout)?)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:924:5
[INFO] [stderr]     |
[INFO] [stderr] 924 |     return Err(format!("Warning: Unknown callback for hook {}", hook_name));
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("Warning: Unknown callback for hook {}", hook_name))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:956:5
[INFO] [stderr]     |
[INFO] [stderr] 956 |     return process_output(output);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(output)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:994:9
[INFO] [stderr]     |
[INFO] [stderr] 994 |         return Ok(output);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(output)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:998:9
[INFO] [stderr]     |
[INFO] [stderr] 998 |         return Ok(output);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(output)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]     --> src/lib.rs:1013:9
[INFO] [stderr]      |
[INFO] [stderr] 1013 |         return Ok(output);
[INFO] [stderr]      |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(output)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]     --> src/lib.rs:1020:9
[INFO] [stderr]      |
[INFO] [stderr] 1020 |         return Ok(output);
[INFO] [stderr]      |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(output)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/unitdata.rs:251:9
[INFO] [stderr]     |
[INFO] [stderr] 251 |         return Ok(());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:400:9
[INFO] [stderr]     |
[INFO] [stderr] 400 |         return Ok(0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:402:9
[INFO] [stderr]     |
[INFO] [stderr] 402 |         return Err(JujuError::new(String::from_utf8(output.stderr)?));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(JujuError::new(String::from_utf8(output.stderr)?))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:417:5
[INFO] [stderr]     |
[INFO] [stderr] 417 |     return process_output(output);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(output)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:425:5
[INFO] [stderr]     |
[INFO] [stderr] 425 |     return Ok(az);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(az)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:433:5
[INFO] [stderr]     |
[INFO] [stderr] 433 |     return Ok(status);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(status)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:442:5
[INFO] [stderr]     |
[INFO] [stderr] 442 |     return Ok(info);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(info)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:451:5
[INFO] [stderr]     |
[INFO] [stderr] 451 |     return process_output(output);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(output)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:463:5
[INFO] [stderr]     |
[INFO] [stderr] 463 |     return process_output(output);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(output)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:481:5
[INFO] [stderr]     |
[INFO] [stderr] 481 |     return Ok(map);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(map)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:506:5
[INFO] [stderr]     |
[INFO] [stderr] 506 |     return Ok(name);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(name)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:514:5
[INFO] [stderr]     |
[INFO] [stderr] 514 |     return Ok(uuid);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(uuid)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:522:5
[INFO] [stderr]     |
[INFO] [stderr] 522 |     return Ok(tag);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(tag)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:536:5
[INFO] [stderr]     |
[INFO] [stderr] 536 |     return process_output(output);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(output)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:548:5
[INFO] [stderr]     |
[INFO] [stderr] 548 |     return process_output(output);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(output)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:563:5
[INFO] [stderr]     |
[INFO] [stderr] 563 |     return Ok(ip);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ip)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:576:5
[INFO] [stderr]     |
[INFO] [stderr] 576 |     return Ok(ip);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ip)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:616:5
[INFO] [stderr]     |
[INFO] [stderr] 616 |     return Ok(values);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(values)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:629:5
[INFO] [stderr]     |
[INFO] [stderr] 629 |     return process_output(output);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(output)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:642:5
[INFO] [stderr]     |
[INFO] [stderr] 642 |     return process_output(output);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(output)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:654:5
[INFO] [stderr]     |
[INFO] [stderr] 654 |     return process_output(output);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(output)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:667:5
[INFO] [stderr]     |
[INFO] [stderr] 667 |     return Ok(relation);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(relation)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:745:5
[INFO] [stderr]     |
[INFO] [stderr] 745 |     return Ok(related_units);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(related_units)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:772:5
[INFO] [stderr]     |
[INFO] [stderr] 772 |     return Ok(related_units);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(related_units)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:791:5
[INFO] [stderr]     |
[INFO] [stderr] 791 |     return Ok(related_units);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(related_units)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:818:5
[INFO] [stderr]     |
[INFO] [stderr] 818 |     return Ok(related_units);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(related_units)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:831:5
[INFO] [stderr]     |
[INFO] [stderr] 831 |     return process_output(output);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(output)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:839:5
[INFO] [stderr]     |
[INFO] [stderr] 839 |     return Ok(String::from_utf8(output.stdout)?);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(String::from_utf8(output.stdout)?)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:884:5
[INFO] [stderr]     |
[INFO] [stderr] 884 |     return Ok(String::from_utf8(output.stdout)?);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(String::from_utf8(output.stdout)?)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:924:5
[INFO] [stderr]     |
[INFO] [stderr] 924 |     return Err(format!("Warning: Unknown callback for hook {}", hook_name));
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("Warning: Unknown callback for hook {}", hook_name))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:956:5
[INFO] [stderr]     |
[INFO] [stderr] 956 |     return process_output(output);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(output)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:994:9
[INFO] [stderr]     |
[INFO] [stderr] 994 |         return Ok(output);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(output)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:998:9
[INFO] [stderr]     |
[INFO] [stderr] 998 |         return Ok(output);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(output)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]     --> src/lib.rs:1013:9
[INFO] [stderr]      |
[INFO] [stderr] 1013 |         return Ok(output);
[INFO] [stderr]      |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(output)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]     --> src/lib.rs:1020:9
[INFO] [stderr]      |
[INFO] [stderr] 1020 |         return Ok(output);
[INFO] [stderr]      |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(output)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/unitdata.rs:48:22
[INFO] [stderr]    |
[INFO] [stderr] 48 |                     .unwrap_or(format!("{}.unit-state.db", env::var("CHARM_DIR").unwrap())))
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| format!("{}.unit-state.db", env::var("CHARM_DIR").unwrap()))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/unitdata.rs:130:29
[INFO] [stderr]     |
[INFO] [stderr] 130 |         let prefix = prefix.unwrap_or("".to_string());
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/unitdata.rs:156:24
[INFO] [stderr]     |
[INFO] [stderr] 156 |         let revision = self.revision.clone().unwrap_or(0);
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.revision`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/unitdata.rs:157:29
[INFO] [stderr]     |
[INFO] [stderr] 157 |         let prefix = prefix.unwrap_or("".to_string());
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/unitdata.rs:228:12
[INFO] [stderr]     |
[INFO] [stderr] 228 |         if !self.revision.is_some() {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.revision.is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/unitdata.rs:216:9
[INFO] [stderr]     |
[INFO] [stderr] 216 | /         match exists {
[INFO] [stderr] 217 | |             true => {
[INFO] [stderr] 218 | |                 self.conn.execute("update kv set data = ? where key = ?", &[&serialized, &key])?;
[INFO] [stderr] 219 | |             }
[INFO] [stderr] ...   |
[INFO] [stderr] 224 | |             }
[INFO] [stderr] 225 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 216 |         if exists {
[INFO] [stderr] 217 |     self.conn.execute("update kv set data = ? where key = ?", &[&serialized, &key])?;
[INFO] [stderr] 218 | } else {
[INFO] [stderr] 219 |     self.conn
[INFO] [stderr] 220 |         .execute("insert into kv (key, data) values (?, ?)",
[INFO] [stderr] 221 |                  &[&key, &serialized])?;
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/unitdata.rs:237:9
[INFO] [stderr]     |
[INFO] [stderr] 237 | /         match exists_with_revision {
[INFO] [stderr] 238 | |             true => {
[INFO] [stderr] 239 | |                 self.conn
[INFO] [stderr] 240 | |                     .execute("update kv_revisions set data = ? where key = ? and revision = ?",
[INFO] [stderr] ...   |
[INFO] [stderr] 248 | |             }
[INFO] [stderr] 249 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 237 |         if exists_with_revision {
[INFO] [stderr] 238 |     self.conn
[INFO] [stderr] 239 |         .execute("update kv_revisions set data = ? where key = ? and revision = ?",
[INFO] [stderr] 240 |                  &[&serialized, &key, &self.revision])?;
[INFO] [stderr] 241 | } else {
[INFO] [stderr] 242 |     self.conn
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:188:18
[INFO] [stderr]     |
[INFO] [stderr] 188 |     fn to_string(self) -> String {
[INFO] [stderr]     |                  ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:208:22
[INFO] [stderr]     |
[INFO] [stderr] 208 |     pub fn to_string(self) -> String {
[INFO] [stderr]     |                      ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/lib.rs:254:9
[INFO] [stderr]     |
[INFO] [stderr] 254 | /         let relation_id: usize;
[INFO] [stderr] 255 | |         if parts.len() > 1 {
[INFO] [stderr] 256 | |             relation_id = parts[1].parse::<usize>().unwrap_or(0);
[INFO] [stderr] 257 | |         } else {
[INFO] [stderr] 258 | |             relation_id = 0;
[INFO] [stderr] 259 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let relation_id = if parts.len() > 1 { parts[1].parse::<usize>().unwrap_or(0) } else { 0 };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:251:55
[INFO] [stderr]     |
[INFO] [stderr] 251 |         let relation_type = env::var("JUJU_RELATION").unwrap_or("".to_string());
[INFO] [stderr]     |                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:252:60
[INFO] [stderr]     |
[INFO] [stderr] 252 |         let relation_id_str = env::var("JUJU_RELATION_ID").unwrap_or("".to_string());
[INFO] [stderr]     |                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:253:54
[INFO] [stderr]     |
[INFO] [stderr] 253 |         let parts: Vec<&str> = relation_id_str.split(":").collect();
[INFO] [stderr]     |                                                      ^^^ help: try using a char instead: `':'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:260:47
[INFO] [stderr]     |
[INFO] [stderr] 260 |         let unit = env::var("JUJU_UNIT_NAME").unwrap_or("".to_string());
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:476:43
[INFO] [stderr]     |
[INFO] [stderr] 476 |         let parts: Vec<&str> = line.split(":").collect();
[INFO] [stderr]     |                                           ^^^ help: try using a char instead: `':'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/unitdata.rs:48:22
[INFO] [stderr]    |
[INFO] [stderr] 48 |                     .unwrap_or(format!("{}.unit-state.db", env::var("CHARM_DIR").unwrap())))
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| format!("{}.unit-state.db", env::var("CHARM_DIR").unwrap()))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/unitdata.rs:130:29
[INFO] [stderr]     |
[INFO] [stderr] 130 |         let prefix = prefix.unwrap_or("".to_string());
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/unitdata.rs:156:24
[INFO] [stderr]     |
[INFO] [stderr] 156 |         let revision = self.revision.clone().unwrap_or(0);
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.revision`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/unitdata.rs:157:29
[INFO] [stderr]     |
[INFO] [stderr] 157 |         let prefix = prefix.unwrap_or("".to_string());
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/unitdata.rs:228:12
[INFO] [stderr]     |
[INFO] [stderr] 228 |         if !self.revision.is_some() {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.revision.is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/lib.rs:650:32
[INFO] [stderr]     |
[INFO] [stderr] 650 |     let arg = format!("{}={}", key.clone(), value);
[INFO] [stderr]     |                                ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 650 |     let arg = format!("{}={}", &(*key).clone(), value);
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 650 |     let arg = format!("{}={}", &str::clone(key), value);
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/unitdata.rs:216:9
[INFO] [stderr]     |
[INFO] [stderr] 216 | /         match exists {
[INFO] [stderr] 217 | |             true => {
[INFO] [stderr] 218 | |                 self.conn.execute("update kv set data = ? where key = ?", &[&serialized, &key])?;
[INFO] [stderr] 219 | |             }
[INFO] [stderr] ...   |
[INFO] [stderr] 224 | |             }
[INFO] [stderr] 225 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 216 |         if exists {
[INFO] [stderr] 217 |     self.conn.execute("update kv set data = ? where key = ?", &[&serialized, &key])?;
[INFO] [stderr] 218 | } else {
[INFO] [stderr] 219 |     self.conn
[INFO] [stderr] 220 |         .execute("insert into kv (key, data) values (?, ?)",
[INFO] [stderr] 221 |                  &[&key, &serialized])?;
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/unitdata.rs:237:9
[INFO] [stderr]     |
[INFO] [stderr] 237 | /         match exists_with_revision {
[INFO] [stderr] 238 | |             true => {
[INFO] [stderr] 239 | |                 self.conn
[INFO] [stderr] 240 | |                     .execute("update kv_revisions set data = ? where key = ? and revision = ?",
[INFO] [stderr] ...   |
[INFO] [stderr] 248 | |             }
[INFO] [stderr] 249 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 237 |         if exists_with_revision {
[INFO] [stderr] 238 |     self.conn
[INFO] [stderr] 239 |         .execute("update kv_revisions set data = ? where key = ? and revision = ?",
[INFO] [stderr] 240 |                  &[&serialized, &key, &self.revision])?;
[INFO] [stderr] 241 | } else {
[INFO] [stderr] 242 |     self.conn
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:188:18
[INFO] [stderr]     |
[INFO] [stderr] 188 |     fn to_string(self) -> String {
[INFO] [stderr]     |                  ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:208:22
[INFO] [stderr]     |
[INFO] [stderr] 208 |     pub fn to_string(self) -> String {
[INFO] [stderr]     |                      ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib.rs:712:19
[INFO] [stderr]     |
[INFO] [stderr] 712 |     arg_list.push(format!("{}", key.to_string()));
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `key.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/lib.rs:254:9
[INFO] [stderr]     |
[INFO] [stderr] 254 | /         let relation_id: usize;
[INFO] [stderr] 255 | |         if parts.len() > 1 {
[INFO] [stderr] 256 | |             relation_id = parts[1].parse::<usize>().unwrap_or(0);
[INFO] [stderr] 257 | |         } else {
[INFO] [stderr] 258 | |             relation_id = 0;
[INFO] [stderr] 259 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let relation_id = if parts.len() > 1 { parts[1].parse::<usize>().unwrap_or(0) } else { 0 };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:251:55
[INFO] [stderr]     |
[INFO] [stderr] 251 |         let relation_type = env::var("JUJU_RELATION").unwrap_or("".to_string());
[INFO] [stderr]     |                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:252:60
[INFO] [stderr]     |
[INFO] [stderr] 252 |         let relation_id_str = env::var("JUJU_RELATION_ID").unwrap_or("".to_string());
[INFO] [stderr]     |                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:253:54
[INFO] [stderr]     |
[INFO] [stderr] 253 |         let parts: Vec<&str> = relation_id_str.split(":").collect();
[INFO] [stderr]     |                                                      ^^^ help: try using a char instead: `':'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:260:47
[INFO] [stderr]     |
[INFO] [stderr] 260 |         let unit = env::var("JUJU_UNIT_NAME").unwrap_or("".to_string());
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:476:43
[INFO] [stderr]     |
[INFO] [stderr] 476 |         let parts: Vec<&str> = line.split(":").collect();
[INFO] [stderr]     |                                           ^^^ help: try using a char instead: `':'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers
[INFO] [stderr]    --> src/lib.rs:949:29
[INFO] [stderr]     |
[INFO] [stderr] 949 | pub fn leader_set(settings: HashMap<String, String>) -> Result<i32, JujuError> {
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::implicit_hasher)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]     |
[INFO] [stderr] 949 | pub fn leader_set<S: ::std::hash::BuildHasher>(settings: HashMap<String, String, S>) -> Result<i32, JujuError> {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^           ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/lib.rs:650:32
[INFO] [stderr]     |
[INFO] [stderr] 650 |     let arg = format!("{}={}", key.clone(), value);
[INFO] [stderr]     |                                ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 650 |     let arg = format!("{}={}", &(*key).clone(), value);
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 650 |     let arg = format!("{}={}", &str::clone(key), value);
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this call to `as_ref` does nothing
[INFO] [stderr]    --> src/lib.rs:983:11
[INFO] [stderr]     |
[INFO] [stderr] 983 |     match output_str.trim().as_ref() {
[INFO] [stderr]     |           ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `output_str.trim()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_asref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]     --> src/lib.rs:1003:26
[INFO] [stderr]      |
[INFO] [stderr] 1003 |                arg_list: &Vec<String>,
[INFO] [stderr]      |                          ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib.rs:712:19
[INFO] [stderr]     |
[INFO] [stderr] 712 |     arg_list.push(format!("{}", key.to_string()));
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `key.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `juju`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers
[INFO] [stderr]    --> src/lib.rs:949:29
[INFO] [stderr]     |
[INFO] [stderr] 949 | pub fn leader_set(settings: HashMap<String, String>) -> Result<i32, JujuError> {
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::implicit_hasher)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]     |
[INFO] [stderr] 949 | pub fn leader_set<S: ::std::hash::BuildHasher>(settings: HashMap<String, String, S>) -> Result<i32, JujuError> {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^           ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this call to `as_ref` does nothing
[INFO] [stderr]    --> src/lib.rs:983:11
[INFO] [stderr]     |
[INFO] [stderr] 983 |     match output_str.trim().as_ref() {
[INFO] [stderr]     |           ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `output_str.trim()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_asref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]     --> src/lib.rs:1003:26
[INFO] [stderr]      |
[INFO] [stderr] 1003 |                arg_list: &Vec<String>,
[INFO] [stderr]      |                          ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `juju`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "d9ab1b657424ddf90359ce5f1659fd6dc43c30179e8ed3dfd43ec5b492195e7c"`
[INFO] running `"docker" "rm" "-f" "d9ab1b657424ddf90359ce5f1659fd6dc43c30179e8ed3dfd43ec5b492195e7c"`
[INFO] [stdout] d9ab1b657424ddf90359ce5f1659fd6dc43c30179e8ed3dfd43ec5b492195e7c