[INFO] crate juggernaut 0.9.0 is already in cache [INFO] extracting crate juggernaut 0.9.0 into work/ex/clippy-test-run/sources/stable/reg/juggernaut/0.9.0 [INFO] extracting crate juggernaut 0.9.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/juggernaut/0.9.0 [INFO] validating manifest of juggernaut-0.9.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of juggernaut-0.9.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing juggernaut-0.9.0 [INFO] finished frobbing juggernaut-0.9.0 [INFO] frobbed toml for juggernaut-0.9.0 written to work/ex/clippy-test-run/sources/stable/reg/juggernaut/0.9.0/Cargo.toml [INFO] started frobbing juggernaut-0.9.0 [INFO] finished frobbing juggernaut-0.9.0 [INFO] frobbed toml for juggernaut-0.9.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/juggernaut/0.9.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting juggernaut-0.9.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/juggernaut/0.9.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a14c29de7483eb772627a29a89431c2a6f5777749bbfbc5d3cd3a8ea943085df [INFO] running `"docker" "start" "-a" "a14c29de7483eb772627a29a89431c2a6f5777749bbfbc5d3cd3a8ea943085df"` [INFO] [stderr] Checking assert_approx_eq v1.1.0 [INFO] [stderr] Checking juggernaut v0.9.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nl.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | inputs: inputs, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `inputs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nl.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | neurons: neurons, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `neurons` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sample.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | inputs: inputs, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `inputs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sample.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | inputs: inputs, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `inputs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nl.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | inputs: inputs, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `inputs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nl.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | neurons: neurons, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `neurons` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sample.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | inputs: inputs, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `inputs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sample.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | inputs: inputs, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `inputs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matrix.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | return Matrix::generate(self.cols(), self.rows(), &|m, n| self.get(n, m)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Matrix::generate(self.cols(), self.rows(), &|m, n| self.get(n, m))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matrix.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | return Matrix::generate(self.rows(), self.cols(), &|m, n| f(self.get(m, n), m, n)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Matrix::generate(self.rows(), self.cols(), &|m, n| f(self.get(m, n), m, n))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matrix.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | return Matrix::generate_by_row(self.rows(), self.cols(), &|m| f(self.row(m).to_vec())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Matrix::generate_by_row(self.rows(), self.cols(), &|m| f(self.row(m).to_vec()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matrix.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | return &self.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/activation/sigmoid.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | return Sigmoid; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Sigmoid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/activation/identity.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | return Identity; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Identity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/activation/hyperbolictangent.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | return HyperbolicTangent; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HyperbolicTangent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/activation/softplus.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | return SoftPlus; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `SoftPlus` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/activation/softmax.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | return SoftMax; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `SoftMax` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/activation/rectifiedlinearunit.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | return RectifiedLinearUnit; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `RectifiedLinearUnit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/activation/leakyrectifiedlinearunit.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | return LeakyRectifiedLinearUnit { alpha_gradient: alpha }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `LeakyRectifiedLinearUnit { alpha_gradient: alpha }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/nn.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | err [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/nn.rs:187:19 [INFO] [stderr] | [INFO] [stderr] 187 | let err = self.cost_function.calc(prediction, target); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | return Matrix::generate(1, sample.get_inputs_count(), &|m, n| f64_vec[m][n]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Matrix::generate(1, sample.get_inputs_count(), &|m, n| f64_vec[m][n])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | return Matrix::generate(1, sample.get_outputs_count(), &|m, n| f64_vec[m][n]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Matrix::generate(1, sample.get_outputs_count(), &|m, n| f64_vec[m][n])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/matrix.rs:12:20 [INFO] [stderr] | [INFO] [stderr] 12 | fn from_vec(v: &Vec) -> Self; [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `activation::sigmoid::Sigmoid` [INFO] [stderr] --> src/activation/sigmoid.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | / pub fn new() -> Sigmoid { [INFO] [stderr] 8 | | return Sigmoid; [INFO] [stderr] 9 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `activation::identity::Identity` [INFO] [stderr] --> src/activation/identity.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | / pub fn new() -> Identity { [INFO] [stderr] 8 | | return Identity; [INFO] [stderr] 9 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `activation::hyperbolictangent::HyperbolicTangent` [INFO] [stderr] --> src/activation/hyperbolictangent.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / pub fn new() -> HyperbolicTangent { [INFO] [stderr] 9 | | return HyperbolicTangent; [INFO] [stderr] 10 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `activation::softplus::SoftPlus` [INFO] [stderr] --> src/activation/softplus.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / pub fn new() -> SoftPlus { [INFO] [stderr] 9 | | return SoftPlus; [INFO] [stderr] 10 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `activation::softmax::SoftMax` [INFO] [stderr] --> src/activation/softmax.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | / pub fn new() -> SoftMax { [INFO] [stderr] 8 | | return SoftMax; [INFO] [stderr] 9 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `activation::rectifiedlinearunit::RectifiedLinearUnit` [INFO] [stderr] --> src/activation/rectifiedlinearunit.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | / pub fn new() -> RectifiedLinearUnit { [INFO] [stderr] 8 | | return RectifiedLinearUnit; [INFO] [stderr] 9 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `nn::NeuralNetwork` [INFO] [stderr] --> src/nn.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn new() -> NeuralNetwork { [INFO] [stderr] 23 | | NeuralNetwork { [INFO] [stderr] 24 | | layers: vec![], [INFO] [stderr] 25 | | cost_function: Box::new(SquaredError::new()), [INFO] [stderr] ... | [INFO] [stderr] 29 | | } [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | impl Default for nn::NeuralNetwork { [INFO] [stderr] 22 | fn default() -> Self { [INFO] [stderr] 23 | Self::new() [INFO] [stderr] 24 | } [INFO] [stderr] 25 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/nn.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / match self.on_error_fn { [INFO] [stderr] 66 | | Some(ref err_fn) => err_fn(err), [INFO] [stderr] 67 | | None => (), [INFO] [stderr] 68 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(ref err_fn) = self.on_error_fn { err_fn(err) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/nn.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | / match self.on_epoch_fn { [INFO] [stderr] 74 | | Some(ref epoch_fn) => epoch_fn(&self), [INFO] [stderr] 75 | | None => (), [INFO] [stderr] 76 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(ref epoch_fn) = self.on_epoch_fn { epoch_fn(&self) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/nn.rs:101:12 [INFO] [stderr] | [INFO] [stderr] 101 | if self.layers.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.layers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/nn.rs:125:12 [INFO] [stderr] | [INFO] [stderr] 125 | if self.layers.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.layers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/nn.rs:269:21 [INFO] [stderr] | [INFO] [stderr] 269 | / let mut prev_layer: Matrix = sample_input_to_matrix(&sample); [INFO] [stderr] 270 | | [INFO] [stderr] 271 | | if i != output.len() - 1 { [INFO] [stderr] 272 | | // TODO (afshinm): is this necessary to clone here? [INFO] [stderr] 273 | | prev_layer = output[i + 1].clone(); [INFO] [stderr] 274 | | } [INFO] [stderr] | |_____________________^ help: it is more idiomatic to write: `let prev_layer = if i != output.len() - 1 { output[i + 1].clone() } else { sample_input_to_matrix(&sample) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/sample.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / match &self.outputs { [INFO] [stderr] 29 | | &Some(ref outputs) => outputs.len(), [INFO] [stderr] 30 | | &None => 0, [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 28 | match self.outputs { [INFO] [stderr] 29 | Some(ref outputs) => outputs.len(), [INFO] [stderr] 30 | None => 0, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cost::squared_error::SquaredError` [INFO] [stderr] --> src/cost/squared_error.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> SquaredError { [INFO] [stderr] 10 | | SquaredError [INFO] [stderr] 11 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cost::cross_entropy::CrossEntropy` [INFO] [stderr] --> src/cost/cross_entropy.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> CrossEntropy { [INFO] [stderr] 11 | | CrossEntropy [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matrix.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | return Matrix::generate(self.cols(), self.rows(), &|m, n| self.get(n, m)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Matrix::generate(self.cols(), self.rows(), &|m, n| self.get(n, m))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matrix.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | return Matrix::generate(self.rows(), self.cols(), &|m, n| f(self.get(m, n), m, n)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Matrix::generate(self.rows(), self.cols(), &|m, n| f(self.get(m, n), m, n))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matrix.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | return Matrix::generate_by_row(self.rows(), self.cols(), &|m| f(self.row(m).to_vec())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Matrix::generate_by_row(self.rows(), self.cols(), &|m| f(self.row(m).to_vec()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matrix.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | return &self.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/activation/sigmoid.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | return Sigmoid; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Sigmoid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/activation/sigmoid.rs:34:59 [INFO] [stderr] | [INFO] [stderr] 34 | assert_approx_eq!(activation.calc(vec![5f64])[0], 0.9933071490f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `0.993_307_149_0f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/activation/identity.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | return Identity; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Identity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/activation/hyperbolictangent.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | return HyperbolicTangent; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HyperbolicTangent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/activation/hyperbolictangent.rs:39:59 [INFO] [stderr] | [INFO] [stderr] 39 | assert_approx_eq!(activation.calc(vec![3f64])[0], 0.995054754f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0.995_054_754f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/activation/hyperbolictangent.rs:45:65 [INFO] [stderr] | [INFO] [stderr] 45 | assert_approx_eq!(activation.derivative(vec![3f64])[0], 0.0098660372f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `0.009_866_037_2f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/activation/softplus.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | return SoftPlus; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `SoftPlus` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/activation/softplus.rs:35:60 [INFO] [stderr] | [INFO] [stderr] 35 | assert_approx_eq!(activation.calc(vec![-1f64])[0], 0.3132616875f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `0.313_261_687_5f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/activation/softplus.rs:41:66 [INFO] [stderr] | [INFO] [stderr] 41 | assert_approx_eq!(activation.derivative(vec![-1f64])[0], 0.2689414214f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `0.268_941_421_4f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/activation/softmax.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | return SoftMax; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `SoftMax` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/activation/softmax.rs:51:30 [INFO] [stderr] | [INFO] [stderr] 51 | let validate = vec![-0.011963105252f64, 0.751918768228f64, 0.260044337024f64]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0.011_963_105_252f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/activation/softmax.rs:51:49 [INFO] [stderr] | [INFO] [stderr] 51 | let validate = vec![-0.011963105252f64, 0.751918768228f64, 0.260044337024f64]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0.751_918_768_228f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/activation/softmax.rs:51:68 [INFO] [stderr] | [INFO] [stderr] 51 | let validate = vec![-0.011963105252f64, 0.751918768228f64, 0.260044337024f64]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0.260_044_337_024f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/activation/softmax.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | 43.8291271898136f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `43.829_127_189_813_6f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/activation/softmax.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | 10.3468229622968f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `10.346_822_962_296_8f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/activation/softmax.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | 90.4820701302356f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `90.482_070_130_235_6f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/activation/softmax.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | 143.8291271898136f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `143.829_127_189_813_6f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/activation/softmax.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | 710.3468229622968f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `710.346_822_962_296_8f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/activation/softmax.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | 690.4820701302356f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `690.482_070_130_235_6f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/activation/rectifiedlinearunit.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | return RectifiedLinearUnit; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `RectifiedLinearUnit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/activation/leakyrectifiedlinearunit.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | return LeakyRectifiedLinearUnit { alpha_gradient: alpha }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `LeakyRectifiedLinearUnit { alpha_gradient: alpha }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/nn.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | err [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/nn.rs:187:19 [INFO] [stderr] | [INFO] [stderr] 187 | let err = self.cost_function.calc(prediction, target); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cost/cross_entropy.rs:79:35 [INFO] [stderr] | [INFO] [stderr] 79 | assert_approx_eq!(result, 0.01005033f64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.010_050_33f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cost/cross_entropy.rs:90:35 [INFO] [stderr] | [INFO] [stderr] 90 | assert_approx_eq!(result, 0.59783700075562041f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0.597_837_000_755_620_41f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | return Matrix::generate(1, sample.get_inputs_count(), &|m, n| f64_vec[m][n]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Matrix::generate(1, sample.get_inputs_count(), &|m, n| f64_vec[m][n])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | return Matrix::generate(1, sample.get_outputs_count(), &|m, n| f64_vec[m][n]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Matrix::generate(1, sample.get_outputs_count(), &|m, n| f64_vec[m][n])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/matrix.rs:12:20 [INFO] [stderr] | [INFO] [stderr] 12 | fn from_vec(v: &Vec) -> Self; [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/matrix.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | assert_ne!(test.0[0][0], test.0[0][1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/matrix.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | assert_ne!(test.0[0][0], test.0[0][1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/matrix.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | assert_ne!(test.0[1][0], test.0[1][1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/matrix.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | assert_ne!(test.0[1][0], test.0[1][1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `activation::sigmoid::Sigmoid` [INFO] [stderr] --> src/activation/sigmoid.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | / pub fn new() -> Sigmoid { [INFO] [stderr] 8 | | return Sigmoid; [INFO] [stderr] 9 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `activation::identity::Identity` [INFO] [stderr] --> src/activation/identity.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | / pub fn new() -> Identity { [INFO] [stderr] 8 | | return Identity; [INFO] [stderr] 9 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `activation::hyperbolictangent::HyperbolicTangent` [INFO] [stderr] --> src/activation/hyperbolictangent.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / pub fn new() -> HyperbolicTangent { [INFO] [stderr] 9 | | return HyperbolicTangent; [INFO] [stderr] 10 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `activation::softplus::SoftPlus` [INFO] [stderr] --> src/activation/softplus.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / pub fn new() -> SoftPlus { [INFO] [stderr] 9 | | return SoftPlus; [INFO] [stderr] 10 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `activation::softmax::SoftMax` [INFO] [stderr] --> src/activation/softmax.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | / pub fn new() -> SoftMax { [INFO] [stderr] 8 | | return SoftMax; [INFO] [stderr] 9 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `activation::rectifiedlinearunit::RectifiedLinearUnit` [INFO] [stderr] --> src/activation/rectifiedlinearunit.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | / pub fn new() -> RectifiedLinearUnit { [INFO] [stderr] 8 | | return RectifiedLinearUnit; [INFO] [stderr] 9 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `nn::NeuralNetwork` [INFO] [stderr] --> src/nn.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn new() -> NeuralNetwork { [INFO] [stderr] 23 | | NeuralNetwork { [INFO] [stderr] 24 | | layers: vec![], [INFO] [stderr] 25 | | cost_function: Box::new(SquaredError::new()), [INFO] [stderr] ... | [INFO] [stderr] 29 | | } [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | impl Default for nn::NeuralNetwork { [INFO] [stderr] 22 | fn default() -> Self { [INFO] [stderr] 23 | Self::new() [INFO] [stderr] 24 | } [INFO] [stderr] 25 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/nn.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / match self.on_error_fn { [INFO] [stderr] 66 | | Some(ref err_fn) => err_fn(err), [INFO] [stderr] 67 | | None => (), [INFO] [stderr] 68 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(ref err_fn) = self.on_error_fn { err_fn(err) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/nn.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | / match self.on_epoch_fn { [INFO] [stderr] 74 | | Some(ref epoch_fn) => epoch_fn(&self), [INFO] [stderr] 75 | | None => (), [INFO] [stderr] 76 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(ref epoch_fn) = self.on_epoch_fn { epoch_fn(&self) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/nn.rs:101:12 [INFO] [stderr] | [INFO] [stderr] 101 | if self.layers.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.layers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/nn.rs:125:12 [INFO] [stderr] | [INFO] [stderr] 125 | if self.layers.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.layers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/nn.rs:269:21 [INFO] [stderr] | [INFO] [stderr] 269 | / let mut prev_layer: Matrix = sample_input_to_matrix(&sample); [INFO] [stderr] 270 | | [INFO] [stderr] 271 | | if i != output.len() - 1 { [INFO] [stderr] 272 | | // TODO (afshinm): is this necessary to clone here? [INFO] [stderr] 273 | | prev_layer = output[i + 1].clone(); [INFO] [stderr] 274 | | } [INFO] [stderr] | |_____________________^ help: it is more idiomatic to write: `let prev_layer = if i != output.len() - 1 { output[i + 1].clone() } else { sample_input_to_matrix(&sample) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/sample.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / match &self.outputs { [INFO] [stderr] 29 | | &Some(ref outputs) => outputs.len(), [INFO] [stderr] 30 | | &None => 0, [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 28 | match self.outputs { [INFO] [stderr] 29 | Some(ref outputs) => outputs.len(), [INFO] [stderr] 30 | None => 0, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cost::squared_error::SquaredError` [INFO] [stderr] --> src/cost/squared_error.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> SquaredError { [INFO] [stderr] 10 | | SquaredError [INFO] [stderr] 11 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cost::cross_entropy::CrossEntropy` [INFO] [stderr] --> src/cost/cross_entropy.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> CrossEntropy { [INFO] [stderr] 11 | | CrossEntropy [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/cost/cross_entropy.rs:90:35 [INFO] [stderr] | [INFO] [stderr] 90 | assert_approx_eq!(result, 0.59783700075562041f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.597_837_000_755_620_4` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `juggernaut`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "a14c29de7483eb772627a29a89431c2a6f5777749bbfbc5d3cd3a8ea943085df"` [INFO] running `"docker" "rm" "-f" "a14c29de7483eb772627a29a89431c2a6f5777749bbfbc5d3cd3a8ea943085df"` [INFO] [stdout] a14c29de7483eb772627a29a89431c2a6f5777749bbfbc5d3cd3a8ea943085df