[INFO] crate jsonwebtoken 5.0.1 is already in cache [INFO] extracting crate jsonwebtoken 5.0.1 into work/ex/clippy-test-run/sources/stable/reg/jsonwebtoken/5.0.1 [INFO] extracting crate jsonwebtoken 5.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/jsonwebtoken/5.0.1 [INFO] validating manifest of jsonwebtoken-5.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jsonwebtoken-5.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jsonwebtoken-5.0.1 [INFO] finished frobbing jsonwebtoken-5.0.1 [INFO] frobbed toml for jsonwebtoken-5.0.1 written to work/ex/clippy-test-run/sources/stable/reg/jsonwebtoken/5.0.1/Cargo.toml [INFO] started frobbing jsonwebtoken-5.0.1 [INFO] finished frobbing jsonwebtoken-5.0.1 [INFO] frobbed toml for jsonwebtoken-5.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/jsonwebtoken/5.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jsonwebtoken-5.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/jsonwebtoken/5.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] abd7024ccd83d17e68d72d2055068c904e510e1bf5d4a5eb00417906f09f5d38 [INFO] running `"docker" "start" "-a" "abd7024ccd83d17e68d72d2055068c904e510e1bf5d4a5eb00417906f09f5d38"` [INFO] [stderr] Checking jsonwebtoken v5.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:148:20 [INFO] [stderr] | [INFO] [stderr] 148 | Ok(TokenData { header: header, claims: decoded_claims }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:148:20 [INFO] [stderr] | [INFO] [stderr] 148 | Ok(TokenData { header: header, claims: decoded_claims }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/validation.rs:201:76 [INFO] [stderr] | [INFO] [stderr] 201 | claims.insert("iat".to_string(), to_value(Utc::now().timestamp() + 100000).unwrap()); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/validation.rs:237:76 [INFO] [stderr] | [INFO] [stderr] 237 | claims.insert("exp".to_string(), to_value(Utc::now().timestamp() - 100000).unwrap()); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/validation.rs:283:76 [INFO] [stderr] | [INFO] [stderr] 283 | claims.insert("nbf".to_string(), to_value(Utc::now().timestamp() + 100000).unwrap()); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/lib.rs:67:43 [INFO] [stderr] | [INFO] [stderr] 67 | let signature = sign(&*signing_input, key.as_ref(), header.alg)?; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/validation.rs:206:9 [INFO] [stderr] | [INFO] [stderr] 206 | / match res.unwrap_err().kind() { [INFO] [stderr] 207 | | &ErrorKind::InvalidIssuedAt => (), [INFO] [stderr] 208 | | _ => assert!(false), [INFO] [stderr] 209 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 206 | match *res.unwrap_err().kind() { [INFO] [stderr] 207 | ErrorKind::InvalidIssuedAt => (), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/validation.rs:241:9 [INFO] [stderr] | [INFO] [stderr] 241 | / match res.unwrap_err().kind() { [INFO] [stderr] 242 | | &ErrorKind::ExpiredSignature => (), [INFO] [stderr] 243 | | _ => assert!(false), [INFO] [stderr] 244 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 241 | match *res.unwrap_err().kind() { [INFO] [stderr] 242 | ErrorKind::ExpiredSignature => (), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/validation.rs:265:9 [INFO] [stderr] | [INFO] [stderr] 265 | / match res.unwrap_err().kind() { [INFO] [stderr] 266 | | &ErrorKind::ExpiredSignature => (), [INFO] [stderr] 267 | | _ => assert!(false), [INFO] [stderr] 268 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 265 | match *res.unwrap_err().kind() { [INFO] [stderr] 266 | ErrorKind::ExpiredSignature => (), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/validation.rs:288:9 [INFO] [stderr] | [INFO] [stderr] 288 | / match res.unwrap_err().kind() { [INFO] [stderr] 289 | | &ErrorKind::ImmatureSignature => (), [INFO] [stderr] 290 | | _ => assert!(false), [INFO] [stderr] 291 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 288 | match *res.unwrap_err().kind() { [INFO] [stderr] 289 | ErrorKind::ImmatureSignature => (), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/validation.rs:333:9 [INFO] [stderr] | [INFO] [stderr] 333 | / match res.unwrap_err().kind() { [INFO] [stderr] 334 | | &ErrorKind::InvalidIssuer => (), [INFO] [stderr] 335 | | _ => assert!(false), [INFO] [stderr] 336 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 333 | match *res.unwrap_err().kind() { [INFO] [stderr] 334 | ErrorKind::InvalidIssuer => (), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/validation.rs:350:9 [INFO] [stderr] | [INFO] [stderr] 350 | / match res.unwrap_err().kind() { [INFO] [stderr] 351 | | &ErrorKind::InvalidIssuer => (), [INFO] [stderr] 352 | | _ => assert!(false), [INFO] [stderr] 353 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 350 | match *res.unwrap_err().kind() { [INFO] [stderr] 351 | ErrorKind::InvalidIssuer => (), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/validation.rs:381:9 [INFO] [stderr] | [INFO] [stderr] 381 | / match res.unwrap_err().kind() { [INFO] [stderr] 382 | | &ErrorKind::InvalidSubject => (), [INFO] [stderr] 383 | | _ => assert!(false), [INFO] [stderr] 384 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 381 | match *res.unwrap_err().kind() { [INFO] [stderr] 382 | ErrorKind::InvalidSubject => (), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/validation.rs:398:9 [INFO] [stderr] | [INFO] [stderr] 398 | / match res.unwrap_err().kind() { [INFO] [stderr] 399 | | &ErrorKind::InvalidSubject => (), [INFO] [stderr] 400 | | _ => assert!(false), [INFO] [stderr] 401 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 398 | match *res.unwrap_err().kind() { [INFO] [stderr] 399 | ErrorKind::InvalidSubject => (), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/validation.rs:442:9 [INFO] [stderr] | [INFO] [stderr] 442 | / match res.unwrap_err().kind() { [INFO] [stderr] 443 | | &ErrorKind::InvalidAudience => (), [INFO] [stderr] 444 | | _ => assert!(false), [INFO] [stderr] 445 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 442 | match *res.unwrap_err().kind() { [INFO] [stderr] 443 | ErrorKind::InvalidAudience => (), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/validation.rs:460:9 [INFO] [stderr] | [INFO] [stderr] 460 | / match res.unwrap_err().kind() { [INFO] [stderr] 461 | | &ErrorKind::InvalidAudience => (), [INFO] [stderr] 462 | | _ => assert!(false), [INFO] [stderr] 463 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 460 | match *res.unwrap_err().kind() { [INFO] [stderr] 461 | ErrorKind::InvalidAudience => (), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/validation.rs:477:9 [INFO] [stderr] | [INFO] [stderr] 477 | / match res.unwrap_err().kind() { [INFO] [stderr] 478 | | &ErrorKind::InvalidAudience => (), [INFO] [stderr] 479 | | _ => assert!(false), [INFO] [stderr] 480 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 477 | match *res.unwrap_err().kind() { [INFO] [stderr] 478 | ErrorKind::InvalidAudience => (), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/lib.rs:67:43 [INFO] [stderr] | [INFO] [stderr] 67 | let signature = sign(&*signing_input, key.as_ref(), header.alg)?; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> examples/custom_header.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | Err(_) => panic!() // in practice you would return the error [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/jwt.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `jsonwebtoken`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> examples/validation.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | Err(_) => panic!() // in practice you would return the error [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "abd7024ccd83d17e68d72d2055068c904e510e1bf5d4a5eb00417906f09f5d38"` [INFO] running `"docker" "rm" "-f" "abd7024ccd83d17e68d72d2055068c904e510e1bf5d4a5eb00417906f09f5d38"` [INFO] [stdout] abd7024ccd83d17e68d72d2055068c904e510e1bf5d4a5eb00417906f09f5d38