[INFO] crate jsonrpc-ipc-server 9.0.0 is already in cache [INFO] extracting crate jsonrpc-ipc-server 9.0.0 into work/ex/clippy-test-run/sources/stable/reg/jsonrpc-ipc-server/9.0.0 [INFO] extracting crate jsonrpc-ipc-server 9.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/jsonrpc-ipc-server/9.0.0 [INFO] validating manifest of jsonrpc-ipc-server-9.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jsonrpc-ipc-server-9.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jsonrpc-ipc-server-9.0.0 [INFO] finished frobbing jsonrpc-ipc-server-9.0.0 [INFO] frobbed toml for jsonrpc-ipc-server-9.0.0 written to work/ex/clippy-test-run/sources/stable/reg/jsonrpc-ipc-server/9.0.0/Cargo.toml [INFO] started frobbing jsonrpc-ipc-server-9.0.0 [INFO] finished frobbing jsonrpc-ipc-server-9.0.0 [INFO] frobbed toml for jsonrpc-ipc-server-9.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/jsonrpc-ipc-server/9.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jsonrpc-ipc-server-9.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/jsonrpc-ipc-server/9.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 60d12ce251f45fc6b558e59976d3093a7bc4b9b0cf5ebf6734f071ecfeeebe43 [INFO] running `"docker" "start" "-a" "60d12ce251f45fc6b558e59976d3093a7bc4b9b0cf5ebf6734f071ecfeeebe43"` [INFO] [stderr] Compiling winapi v0.3.6 [INFO] [stderr] Checking mio-named-pipes v0.1.6 [INFO] [stderr] Checking jsonrpc-core v9.0.0 [INFO] [stderr] Checking tokio-named-pipes v0.1.0 [INFO] [stderr] Checking jsonrpc-server-utils v9.0.0 [INFO] [stderr] Checking miow v0.3.3 [INFO] [stderr] Checking parity-tokio-ipc v0.1.0 [INFO] [stderr] Checking jsonrpc-ipc-server v9.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | Service { handler: handler, meta: meta } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `handler` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:32:31 [INFO] [stderr] | [INFO] [stderr] 32 | Service { handler: handler, meta: meta } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `meta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | Service { handler: handler, meta: meta } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `handler` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:32:31 [INFO] [stderr] | [INFO] [stderr] 32 | Service { handler: handler, meta: meta } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `meta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/server.rs:225:7 [INFO] [stderr] | [INFO] [stderr] 225 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/server.rs:170:5 [INFO] [stderr] | [INFO] [stderr] 170 | session_stats.as_ref().map(|stats| stats.open_session(session_id)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(stats) = session_stats.as_ref() { stats.open_session(session_id) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/server.rs:210:6 [INFO] [stderr] | [INFO] [stderr] 210 | session_stats.as_ref().map(|stats| stats.close_session(session_id)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(stats) = session_stats.as_ref() { stats.close_session(session_id) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/server.rs:286:3 [INFO] [stderr] | [INFO] [stderr] 286 | self.executor.take().map(|executor| executor.close()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(executor) = self.executor.take() { executor.close() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/server.rs:225:7 [INFO] [stderr] | [INFO] [stderr] 225 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/server.rs:343:3 [INFO] [stderr] | [INFO] [stderr] 343 | server [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/server.rs:342:16 [INFO] [stderr] | [INFO] [stderr] 342 | let server = builder.start(path).expect("Server must run with no issues"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/server.rs:359:4 [INFO] [stderr] | [INFO] [stderr] 359 | reply [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/server.rs:351:16 [INFO] [stderr] | [INFO] [stderr] 351 | let reply = stream [INFO] [stderr] | _________________________^ [INFO] [stderr] 352 | | .send(data.to_owned()) [INFO] [stderr] 353 | | .and_then(move |stream| { [INFO] [stderr] 354 | | stream.into_future().map_err(|(err, _)| err) [INFO] [stderr] ... | [INFO] [stderr] 357 | | future::ok(reply.expect("there should be one reply")) [INFO] [stderr] 358 | | }); [INFO] [stderr] | |__________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/logger.rs:16:10 [INFO] [stderr] | [INFO] [stderr] 16 | if let Ok(_) = builder.try_init() { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 17 | | println!("logger initialized"); [INFO] [stderr] 18 | | } [INFO] [stderr] | |_________- help: try this: `if builder.try_init().is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/server.rs:170:5 [INFO] [stderr] | [INFO] [stderr] 170 | session_stats.as_ref().map(|stats| stats.open_session(session_id)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(stats) = session_stats.as_ref() { stats.open_session(session_id) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/server.rs:210:6 [INFO] [stderr] | [INFO] [stderr] 210 | session_stats.as_ref().map(|stats| stats.close_session(session_id)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(stats) = session_stats.as_ref() { stats.close_session(session_id) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/server.rs:286:3 [INFO] [stderr] | [INFO] [stderr] 286 | self.executor.take().map(|executor| executor.close()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(executor) = self.executor.take() { executor.close() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/server.rs:423:15 [INFO] [stderr] | [INFO] [stderr] 423 | let path = path.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 423 | let path = &(*path).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 423 | let path = &str::clone(path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `jsonrpc-ipc-server`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "60d12ce251f45fc6b558e59976d3093a7bc4b9b0cf5ebf6734f071ecfeeebe43"` [INFO] running `"docker" "rm" "-f" "60d12ce251f45fc6b558e59976d3093a7bc4b9b0cf5ebf6734f071ecfeeebe43"` [INFO] [stdout] 60d12ce251f45fc6b558e59976d3093a7bc4b9b0cf5ebf6734f071ecfeeebe43