[INFO] crate jsonrpc-http-server-plus 7.1.0 is already in cache [INFO] extracting crate jsonrpc-http-server-plus 7.1.0 into work/ex/clippy-test-run/sources/stable/reg/jsonrpc-http-server-plus/7.1.0 [INFO] extracting crate jsonrpc-http-server-plus 7.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/jsonrpc-http-server-plus/7.1.0 [INFO] validating manifest of jsonrpc-http-server-plus-7.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jsonrpc-http-server-plus-7.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jsonrpc-http-server-plus-7.1.0 [INFO] finished frobbing jsonrpc-http-server-plus-7.1.0 [INFO] frobbed toml for jsonrpc-http-server-plus-7.1.0 written to work/ex/clippy-test-run/sources/stable/reg/jsonrpc-http-server-plus/7.1.0/Cargo.toml [INFO] started frobbing jsonrpc-http-server-plus-7.1.0 [INFO] finished frobbing jsonrpc-http-server-plus-7.1.0 [INFO] frobbed toml for jsonrpc-http-server-plus-7.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/jsonrpc-http-server-plus/7.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jsonrpc-http-server-plus-7.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/jsonrpc-http-server-plus/7.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 765515f645e8f5cadd1d4263cfdacc6a5959574156b7ad0b74d6319e76ea6b1e [INFO] running `"docker" "start" "-a" "765515f645e8f5cadd1d4263cfdacc6a5959574156b7ad0b74d6319e76ea6b1e"` [INFO] [stderr] Checking globset v0.1.4 [INFO] [stderr] Checking jsonrpc-core v7.1.1 [INFO] [stderr] Checking jsonrpc-server-utils v7.1.1 [INFO] [stderr] Checking jsonrpc-http-server-plus v7.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handler.rs:36:4 [INFO] [stderr] | [INFO] [stderr] 36 | jsonrpc_handler: jsonrpc_handler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `jsonrpc_handler` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handler.rs:37:4 [INFO] [stderr] | [INFO] [stderr] 37 | allowed_hosts: allowed_hosts, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allowed_hosts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handler.rs:38:4 [INFO] [stderr] | [INFO] [stderr] 38 | cors_domains: cors_domains, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cors_domains` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handler.rs:39:4 [INFO] [stderr] | [INFO] [stderr] 39 | middleware: middleware, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `middleware` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handler.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | request: request, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `request` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handler.rs:229:6 [INFO] [stderr] | [INFO] [stderr] 229 | metadata: metadata, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handler.rs:277:7 [INFO] [stderr] | [INFO] [stderr] 277 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handler.rs:278:7 [INFO] [stderr] | [INFO] [stderr] 278 | request: request, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `request` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handler.rs:279:7 [INFO] [stderr] | [INFO] [stderr] 279 | metadata: metadata [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handler.rs:36:4 [INFO] [stderr] | [INFO] [stderr] 36 | jsonrpc_handler: jsonrpc_handler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `jsonrpc_handler` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handler.rs:37:4 [INFO] [stderr] | [INFO] [stderr] 37 | allowed_hosts: allowed_hosts, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allowed_hosts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handler.rs:38:4 [INFO] [stderr] | [INFO] [stderr] 38 | cors_domains: cors_domains, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cors_domains` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handler.rs:39:4 [INFO] [stderr] | [INFO] [stderr] 39 | middleware: middleware, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `middleware` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handler.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | request: request, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `request` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handler.rs:229:6 [INFO] [stderr] | [INFO] [stderr] 229 | metadata: metadata, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handler.rs:277:7 [INFO] [stderr] | [INFO] [stderr] 277 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handler.rs:278:7 [INFO] [stderr] | [INFO] [stderr] 278 | request: request, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `request` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handler.rs:279:7 [INFO] [stderr] | [INFO] [stderr] 279 | metadata: metadata [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests.rs:78:3 [INFO] [stderr] | [INFO] [stderr] 78 | status: status, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `status` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests.rs:79:3 [INFO] [stderr] | [INFO] [stderr] 79 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests.rs:80:3 [INFO] [stderr] | [INFO] [stderr] 80 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:218:22 [INFO] [stderr] | [INFO] [stderr] 218 | const SENDER_PROOF: &'static str = "Server initialization awaits local address."; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:473:15 [INFO] [stderr] | [INFO] [stderr] 473 | const PROOF: &'static str = "Server is always Some until self is consumed."; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'jsonrpc::futures::BoxFuture': removed without replacement, recommended to use a local extension trait or function if needed, more details in https://github.com/rust-lang-nursery/futures-rs/issues/228 [INFO] [stderr] --> src/handler.rs:11:45 [INFO] [stderr] | [INFO] [stderr] 11 | use jsonrpc::futures::{Future, Poll, Async, BoxFuture, Stream}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'jsonrpc::futures::BoxFuture': removed without replacement, recommended to use a local extension trait or function if needed, more details in https://github.com/rust-lang-nursery/futures-rs/issues/228 [INFO] [stderr] --> src/handler.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | Middleware(BoxFuture), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'jsonrpc::futures::BoxFuture': removed without replacement, recommended to use a local extension trait or function if needed, more details in https://github.com/rust-lang-nursery/futures-rs/issues/228 [INFO] [stderr] --> src/handler.rs:133:10 [INFO] [stderr] | [INFO] [stderr] 133 | Waiting(BoxFuture, ()>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'jsonrpc::futures::BoxFuture': removed without replacement, recommended to use a local extension trait or function if needed, more details in https://github.com/rust-lang-nursery/futures-rs/issues/228 [INFO] [stderr] --> src/lib.rs:42:50 [INFO] [stderr] | [INFO] [stderr] 42 | use jsonrpc::futures::{self, Future, IntoFuture, BoxFuture, Stream}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'jsonrpc::futures::BoxFuture': removed without replacement, recommended to use a local extension trait or function if needed, more details in https://github.com/rust-lang-nursery/futures-rs/issues/228 [INFO] [stderr] --> src/lib.rs:115:12 [INFO] [stderr] | [INFO] [stderr] 115 | handler: BoxFuture, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:218:22 [INFO] [stderr] | [INFO] [stderr] 218 | const SENDER_PROOF: &'static str = "Server initialization awaits local address."; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:473:15 [INFO] [stderr] | [INFO] [stderr] 473 | const PROOF: &'static str = "Server is always Some until self is consumed."; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'jsonrpc::futures::BoxFuture': removed without replacement, recommended to use a local extension trait or function if needed, more details in https://github.com/rust-lang-nursery/futures-rs/issues/228 [INFO] [stderr] --> src/handler.rs:11:45 [INFO] [stderr] | [INFO] [stderr] 11 | use jsonrpc::futures::{Future, Poll, Async, BoxFuture, Stream}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'jsonrpc::futures::BoxFuture': removed without replacement, recommended to use a local extension trait or function if needed, more details in https://github.com/rust-lang-nursery/futures-rs/issues/228 [INFO] [stderr] --> src/handler.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | Middleware(BoxFuture), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'jsonrpc::futures::BoxFuture': removed without replacement, recommended to use a local extension trait or function if needed, more details in https://github.com/rust-lang-nursery/futures-rs/issues/228 [INFO] [stderr] --> src/handler.rs:133:10 [INFO] [stderr] | [INFO] [stderr] 133 | Waiting(BoxFuture, ()>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'jsonrpc::futures::BoxFuture': removed without replacement, recommended to use a local extension trait or function if needed, more details in https://github.com/rust-lang-nursery/futures-rs/issues/228 [INFO] [stderr] --> src/lib.rs:42:50 [INFO] [stderr] | [INFO] [stderr] 42 | use jsonrpc::futures::{self, Future, IntoFuture, BoxFuture, Stream}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'jsonrpc::futures::BoxFuture': removed without replacement, recommended to use a local extension trait or function if needed, more details in https://github.com/rust-lang-nursery/futures-rs/issues/228 [INFO] [stderr] --> src/lib.rs:115:12 [INFO] [stderr] | [INFO] [stderr] 115 | handler: BoxFuture, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'jsonrpc::futures::Future::boxed': removed without replacement, recommended to use a local extension trait or function if needed, more details in https://github.com/rust-lang-nursery/futures-rs/issues/228 [INFO] [stderr] --> src/lib.rs:135:36 [INFO] [stderr] | [INFO] [stderr] 135 | handler: handler.into_future().boxed(), [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'jsonrpc::futures::Future::boxed': removed without replacement, recommended to use a local extension trait or function if needed, more details in https://github.com/rust-lang-nursery/futures-rs/issues/228 [INFO] [stderr] --> src/lib.rs:135:36 [INFO] [stderr] | [INFO] [stderr] 135 | handler: handler.into_future().boxed(), [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'hyper::server::server_proto::>::bind_connection': All usage of the tokio-proto crate is going away. [INFO] [stderr] --> src/lib.rs:430:11 [INFO] [stderr] | [INFO] [stderr] 430 | http.bind_connection(&handle, socket, addr, ServerHandler::new( [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'hyper::server::server_proto::>::bind_connection': All usage of the tokio-proto crate is going away. [INFO] [stderr] --> src/lib.rs:430:11 [INFO] [stderr] | [INFO] [stderr] 430 | http.bind_connection(&handle, socket, addr, ServerHandler::new( [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'jsonrpc::futures::Future::boxed': removed without replacement, recommended to use a local extension trait or function if needed, more details in https://github.com/rust-lang-nursery/futures-rs/issues/228 [INFO] [stderr] --> src/tests.rs:24:52 [INFO] [stderr] | [INFO] [stderr] 24 | futures::finished(Value::String("world".into())).boxed() [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'jsonrpc::futures::Future::boxed': removed without replacement, recommended to use a local extension trait or function if needed, more details in https://github.com/rust-lang-nursery/futures-rs/issues/228 [INFO] [stderr] --> src/tests.rs:32:43 [INFO] [stderr] | [INFO] [stderr] 32 | p.map_err(|_| Error::invalid_request()).boxed() [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/handler.rs:122:2 [INFO] [stderr] | [INFO] [stderr] 122 | ReadingHeaders { [INFO] [stderr] | _____^ [INFO] [stderr] 123 | | request: server::Request, [INFO] [stderr] 124 | | cors_domains: CorsDomains, [INFO] [stderr] 125 | | continue_on_invalid_cors: bool, [INFO] [stderr] 126 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/handler.rs:122:2 [INFO] [stderr] | [INFO] [stderr] 122 | ReadingHeaders { [INFO] [stderr] | _____^ [INFO] [stderr] 123 | | request: server::Request, [INFO] [stderr] 124 | | cors_domains: CorsDomains, [INFO] [stderr] 125 | | continue_on_invalid_cors: bool, [INFO] [stderr] 126 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/handler.rs:177:52 [INFO] [stderr] | [INFO] [stderr] 177 | RpcPollState::Ready(RpcHandlerState::Writing(match response { [INFO] [stderr] | ______________________________________________________________________^ [INFO] [stderr] 178 | | // Notification, just return empty response. [INFO] [stderr] 179 | | None => Response::ok(String::new()), [INFO] [stderr] 180 | | // Add new line to have nice output when using CLI clients (curl) [INFO] [stderr] 181 | | Some(result) => Response::ok(format!("{}\n", result)), [INFO] [stderr] 182 | | }.into())) [INFO] [stderr] | |________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 177 | RpcPollState::Ready(RpcHandlerState::Writing(match response { [INFO] [stderr] 178 | // Notification, just return empty response. [INFO] [stderr] 179 | None => Response::ok(String::new()), [INFO] [stderr] 180 | // Add new line to have nice output when using CLI clients (curl) [INFO] [stderr] 181 | Some(result) => Response::ok(format!("{}\n", result)), [INFO] [stderr] 182 | })) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/lib.rs:372:1 [INFO] [stderr] | [INFO] [stderr] 372 | / fn serve>( [INFO] [stderr] 373 | | signals: (oneshot::Receiver<()>, mpsc::Sender>), [INFO] [stderr] 374 | | remote: tokio_core::reactor::Remote, [INFO] [stderr] 375 | | addr: SocketAddr, [INFO] [stderr] ... | [INFO] [stderr] 447 | | }); [INFO] [stderr] 448 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/lib.rs:501:3 [INFO] [stderr] | [INFO] [stderr] 501 | self.remote.take().map(|remotes| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 502 | || for remote in remotes { remote.close(); } [INFO] [stderr] 503 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(remotes) = self.remote.take() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/handler.rs:122:2 [INFO] [stderr] | [INFO] [stderr] 122 | ReadingHeaders { [INFO] [stderr] | _____^ [INFO] [stderr] 123 | | request: server::Request, [INFO] [stderr] 124 | | cors_domains: CorsDomains, [INFO] [stderr] 125 | | continue_on_invalid_cors: bool, [INFO] [stderr] 126 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/handler.rs:122:2 [INFO] [stderr] | [INFO] [stderr] 122 | ReadingHeaders { [INFO] [stderr] | _____^ [INFO] [stderr] 123 | | request: server::Request, [INFO] [stderr] 124 | | cors_domains: CorsDomains, [INFO] [stderr] 125 | | continue_on_invalid_cors: bool, [INFO] [stderr] 126 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/handler.rs:177:52 [INFO] [stderr] | [INFO] [stderr] 177 | RpcPollState::Ready(RpcHandlerState::Writing(match response { [INFO] [stderr] | ______________________________________________________________________^ [INFO] [stderr] 178 | | // Notification, just return empty response. [INFO] [stderr] 179 | | None => Response::ok(String::new()), [INFO] [stderr] 180 | | // Add new line to have nice output when using CLI clients (curl) [INFO] [stderr] 181 | | Some(result) => Response::ok(format!("{}\n", result)), [INFO] [stderr] 182 | | }.into())) [INFO] [stderr] | |________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 177 | RpcPollState::Ready(RpcHandlerState::Writing(match response { [INFO] [stderr] 178 | // Notification, just return empty response. [INFO] [stderr] 179 | None => Response::ok(String::new()), [INFO] [stderr] 180 | // Add new line to have nice output when using CLI clients (curl) [INFO] [stderr] 181 | Some(result) => Response::ok(format!("{}\n", result)), [INFO] [stderr] 182 | })) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tests.rs:423:13 [INFO] [stderr] | [INFO] [stderr] 423 | let addr = server.address().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*server.address()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tests.rs:448:13 [INFO] [stderr] | [INFO] [stderr] 448 | let addr = server.address().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*server.address()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tests.rs:473:13 [INFO] [stderr] | [INFO] [stderr] 473 | let addr = server.address().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*server.address()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tests.rs:498:13 [INFO] [stderr] | [INFO] [stderr] 498 | let addr = server.address().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*server.address()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tests.rs:523:13 [INFO] [stderr] | [INFO] [stderr] 523 | let addr = server.address().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*server.address()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tests.rs:548:13 [INFO] [stderr] | [INFO] [stderr] 548 | let addr = server.address().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*server.address()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/lib.rs:372:1 [INFO] [stderr] | [INFO] [stderr] 372 | / fn serve>( [INFO] [stderr] 373 | | signals: (oneshot::Receiver<()>, mpsc::Sender>), [INFO] [stderr] 374 | | remote: tokio_core::reactor::Remote, [INFO] [stderr] 375 | | addr: SocketAddr, [INFO] [stderr] ... | [INFO] [stderr] 447 | | }); [INFO] [stderr] 448 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/lib.rs:501:3 [INFO] [stderr] | [INFO] [stderr] 501 | self.remote.take().map(|remotes| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 502 | || for remote in remotes { remote.close(); } [INFO] [stderr] 503 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(remotes) = self.remote.take() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 30.00s [INFO] running `"docker" "inspect" "765515f645e8f5cadd1d4263cfdacc6a5959574156b7ad0b74d6319e76ea6b1e"` [INFO] running `"docker" "rm" "-f" "765515f645e8f5cadd1d4263cfdacc6a5959574156b7ad0b74d6319e76ea6b1e"` [INFO] [stdout] 765515f645e8f5cadd1d4263cfdacc6a5959574156b7ad0b74d6319e76ea6b1e