[INFO] crate jsonrpc-http-server 9.0.0 is already in cache [INFO] extracting crate jsonrpc-http-server 9.0.0 into work/ex/clippy-test-run/sources/stable/reg/jsonrpc-http-server/9.0.0 [INFO] extracting crate jsonrpc-http-server 9.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/jsonrpc-http-server/9.0.0 [INFO] validating manifest of jsonrpc-http-server-9.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jsonrpc-http-server-9.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jsonrpc-http-server-9.0.0 [INFO] finished frobbing jsonrpc-http-server-9.0.0 [INFO] frobbed toml for jsonrpc-http-server-9.0.0 written to work/ex/clippy-test-run/sources/stable/reg/jsonrpc-http-server/9.0.0/Cargo.toml [INFO] started frobbing jsonrpc-http-server-9.0.0 [INFO] finished frobbing jsonrpc-http-server-9.0.0 [INFO] frobbed toml for jsonrpc-http-server-9.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/jsonrpc-http-server/9.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jsonrpc-http-server-9.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/jsonrpc-http-server/9.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 227e802c08dbcb6213c59b6d9f15121df6b8c2b330f0b828309656ba96625842 [INFO] running `"docker" "start" "-a" "227e802c08dbcb6213c59b6d9f15121df6b8c2b330f0b828309656ba96625842"` [INFO] [stderr] Checking jsonrpc-core v9.0.0 [INFO] [stderr] Checking jsonrpc-server-utils v9.0.0 [INFO] [stderr] Checking jsonrpc-http-server v9.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests.rs:116:3 [INFO] [stderr] | [INFO] [stderr] 116 | status: status, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `status` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests.rs:117:3 [INFO] [stderr] | [INFO] [stderr] 117 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests.rs:118:3 [INFO] [stderr] | [INFO] [stderr] 118 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/handler.rs:407:3 [INFO] [stderr] | [INFO] [stderr] 407 | return Ok(RpcPollState::Ready(RpcHandlerState::WaitingForResponse( [INFO] [stderr] | _________^ [INFO] [stderr] 408 | | future::Either::B(self.jsonrpc_handler.handler.handle_rpc_request(call, metadata)) [INFO] [stderr] 409 | | .map(|res| match res { [INFO] [stderr] 410 | | Some(core::Response::Single(Output::Success(Success { result, .. }))) => { [INFO] [stderr] ... | [INFO] [stderr] 423 | | }) [INFO] [stderr] 424 | | ))); [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 407 | Ok(RpcPollState::Ready(RpcHandlerState::WaitingForResponse( [INFO] [stderr] 408 | future::Either::B(self.jsonrpc_handler.handler.handle_rpc_request(call, metadata)) [INFO] [stderr] 409 | .map(|res| match res { [INFO] [stderr] 410 | Some(core::Response::Single(Output::Success(Success { result, .. }))) => { [INFO] [stderr] 411 | let result = serde_json::to_string(&result) [INFO] [stderr] 412 | .expect("Serialization of result is infallible;qed"); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/handler.rs:455:3 [INFO] [stderr] | [INFO] [stderr] 455 | return Ok(RpcPollState::Ready(RpcHandlerState::Waiting( [INFO] [stderr] | _________^ [INFO] [stderr] 456 | | future::Either::B(self.jsonrpc_handler.handler.handle_rpc_request(call, metadata)) [INFO] [stderr] 457 | | .map(|res| res.map(|x| serde_json::to_string(&x) [INFO] [stderr] 458 | | .expect("Serialization of response is infallible;qed") [INFO] [stderr] 459 | | )) [INFO] [stderr] 460 | | ))); [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 455 | Ok(RpcPollState::Ready(RpcHandlerState::Waiting( [INFO] [stderr] 456 | future::Either::B(self.jsonrpc_handler.handler.handle_rpc_request(call, metadata)) [INFO] [stderr] 457 | .map(|res| res.map(|x| serde_json::to_string(&x) [INFO] [stderr] 458 | .expect("Serialization of response is infallible;qed") [INFO] [stderr] 459 | )) [INFO] [stderr] 460 | ))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:561:15 [INFO] [stderr] | [INFO] [stderr] 561 | const PROOF: &'static str = "Server is always Some until self is consumed."; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'server_utils::tokio::reactor::Handle::current': semantics were sometimes surprising, use Handle::default() [INFO] [stderr] --> src/lib.rs:462:16 [INFO] [stderr] | [INFO] [stderr] 462 | let handle = tokio::reactor::Handle::current(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/handler.rs:407:3 [INFO] [stderr] | [INFO] [stderr] 407 | return Ok(RpcPollState::Ready(RpcHandlerState::WaitingForResponse( [INFO] [stderr] | _________^ [INFO] [stderr] 408 | | future::Either::B(self.jsonrpc_handler.handler.handle_rpc_request(call, metadata)) [INFO] [stderr] 409 | | .map(|res| match res { [INFO] [stderr] 410 | | Some(core::Response::Single(Output::Success(Success { result, .. }))) => { [INFO] [stderr] ... | [INFO] [stderr] 423 | | }) [INFO] [stderr] 424 | | ))); [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 407 | Ok(RpcPollState::Ready(RpcHandlerState::WaitingForResponse( [INFO] [stderr] 408 | future::Either::B(self.jsonrpc_handler.handler.handle_rpc_request(call, metadata)) [INFO] [stderr] 409 | .map(|res| match res { [INFO] [stderr] 410 | Some(core::Response::Single(Output::Success(Success { result, .. }))) => { [INFO] [stderr] 411 | let result = serde_json::to_string(&result) [INFO] [stderr] 412 | .expect("Serialization of result is infallible;qed"); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/handler.rs:455:3 [INFO] [stderr] | [INFO] [stderr] 455 | return Ok(RpcPollState::Ready(RpcHandlerState::Waiting( [INFO] [stderr] | _________^ [INFO] [stderr] 456 | | future::Either::B(self.jsonrpc_handler.handler.handle_rpc_request(call, metadata)) [INFO] [stderr] 457 | | .map(|res| res.map(|x| serde_json::to_string(&x) [INFO] [stderr] 458 | | .expect("Serialization of response is infallible;qed") [INFO] [stderr] 459 | | )) [INFO] [stderr] 460 | | ))); [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 455 | Ok(RpcPollState::Ready(RpcHandlerState::Waiting( [INFO] [stderr] 456 | future::Either::B(self.jsonrpc_handler.handler.handle_rpc_request(call, metadata)) [INFO] [stderr] 457 | .map(|res| res.map(|x| serde_json::to_string(&x) [INFO] [stderr] 458 | .expect("Serialization of response is infallible;qed") [INFO] [stderr] 459 | )) [INFO] [stderr] 460 | ))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:561:15 [INFO] [stderr] | [INFO] [stderr] 561 | const PROOF: &'static str = "Server is always Some until self is consumed."; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'server_utils::tokio::reactor::Handle::current': semantics were sometimes surprising, use Handle::default() [INFO] [stderr] --> src/lib.rs:462:16 [INFO] [stderr] | [INFO] [stderr] 462 | let handle = tokio::reactor::Handle::current(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/handler.rs:33:2 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn new( [INFO] [stderr] | _____^ [INFO] [stderr] 34 | | jsonrpc_handler: Rpc, [INFO] [stderr] 35 | | cors_domains: CorsDomains, [INFO] [stderr] 36 | | cors_max_age: Option, [INFO] [stderr] ... | [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/handler.rs:163:2 [INFO] [stderr] | [INFO] [stderr] 163 | ReadingHeaders { [INFO] [stderr] | _____^ [INFO] [stderr] 164 | | request: hyper::Request, [INFO] [stderr] 165 | | cors_domains: CorsDomains, [INFO] [stderr] 166 | | cors_headers: cors::AccessControlAllowHeaders, [INFO] [stderr] 167 | | continue_on_invalid_cors: bool, [INFO] [stderr] 168 | | keep_alive: bool, [INFO] [stderr] 169 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/handler.rs:163:2 [INFO] [stderr] | [INFO] [stderr] 163 | ReadingHeaders { [INFO] [stderr] | _____^ [INFO] [stderr] 164 | | request: hyper::Request, [INFO] [stderr] 165 | | cors_domains: CorsDomains, [INFO] [stderr] 166 | | cors_headers: cors::AccessControlAllowHeaders, [INFO] [stderr] 167 | | continue_on_invalid_cors: bool, [INFO] [stderr] 168 | | keep_alive: bool, [INFO] [stderr] 169 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/handler.rs:263:81 [INFO] [stderr] | [INFO] [stderr] 263 | Ok(Async::Ready(response)) => RpcPollState::Ready(RpcHandlerState::Writing(response.into())), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `response` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/handler.rs:273:52 [INFO] [stderr] | [INFO] [stderr] 273 | RpcPollState::Ready(RpcHandlerState::Writing(match response { [INFO] [stderr] | ______________________________________________________________________^ [INFO] [stderr] 274 | | // Notification, just return empty response. [INFO] [stderr] 275 | | None => Response::ok(String::new()), [INFO] [stderr] 276 | | // Add new line to have nice output when using CLI clients (curl) [INFO] [stderr] 277 | | Some(result) => Response::ok(format!("{}\n", result)), [INFO] [stderr] 278 | | }.into())) [INFO] [stderr] | |________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 273 | RpcPollState::Ready(RpcHandlerState::Writing(match response { [INFO] [stderr] 274 | // Notification, just return empty response. [INFO] [stderr] 275 | None => Response::ok(String::new()), [INFO] [stderr] 276 | // Add new line to have nice output when using CLI clients (curl) [INFO] [stderr] 277 | Some(result) => Response::ok(format!("{}\n", result)), [INFO] [stderr] 278 | })) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/response.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | content: format!("{}", msg.into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `msg.into().to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/utils.rs:26:57 [INFO] [stderr] | [INFO] [stderr] 26 | Value(ref val) => header::HeaderValue::from_str(val).unwrap_or(header::HeaderValue::from_static("null")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| header::HeaderValue::from_static("null"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utils.rs:45:29 [INFO] [stderr] | [INFO] [stderr] 45 | .flat_map(|val| val.split(",")); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/utils.rs:50:3 [INFO] [stderr] | [INFO] [stderr] 50 | cors_allow_headers.into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `cors_allow_headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/lib.rs:64:2 [INFO] [stderr] | [INFO] [stderr] 64 | Proceed { [INFO] [stderr] | _____^ [INFO] [stderr] 65 | | /// Should the request be processed even if invalid CORS headers are detected? [INFO] [stderr] 66 | | /// This allows for side effects to take place. [INFO] [stderr] 67 | | should_continue_on_invalid_cors: bool, [INFO] [stderr] 68 | | /// The request object returned [INFO] [stderr] 69 | | request: hyper::Request, [INFO] [stderr] 70 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/lib.rs:64:2 [INFO] [stderr] | [INFO] [stderr] 64 | Proceed { [INFO] [stderr] | _____^ [INFO] [stderr] 65 | | /// Should the request be processed even if invalid CORS headers are detected? [INFO] [stderr] 66 | | /// This allows for side effects to take place. [INFO] [stderr] 67 | | should_continue_on_invalid_cors: bool, [INFO] [stderr] 68 | | /// The request object returned [INFO] [stderr] 69 | | request: hyper::Request, [INFO] [stderr] 70 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:327:26 [INFO] [stderr] | [INFO] [stderr] 327 | self.allowed_headers = allowed_headers.into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `allowed_headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (14/7) [INFO] [stderr] --> src/lib.rs:444:1 [INFO] [stderr] | [INFO] [stderr] 444 | / fn serve>( [INFO] [stderr] 445 | | signals: (oneshot::Receiver<()>, mpsc::Sender>), [INFO] [stderr] 446 | | executor: tokio::runtime::TaskExecutor, [INFO] [stderr] 447 | | addr: SocketAddr, [INFO] [stderr] ... | [INFO] [stderr] 535 | | })); [INFO] [stderr] 536 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/lib.rs:589:3 [INFO] [stderr] | [INFO] [stderr] 589 | self.executor.take().map(|executors| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 590 | || for executor in executors { executor.close(); } [INFO] [stderr] 591 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(executors) = self.executor.take() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/handler.rs:33:2 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn new( [INFO] [stderr] | _____^ [INFO] [stderr] 34 | | jsonrpc_handler: Rpc, [INFO] [stderr] 35 | | cors_domains: CorsDomains, [INFO] [stderr] 36 | | cors_max_age: Option, [INFO] [stderr] ... | [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/handler.rs:163:2 [INFO] [stderr] | [INFO] [stderr] 163 | ReadingHeaders { [INFO] [stderr] | _____^ [INFO] [stderr] 164 | | request: hyper::Request, [INFO] [stderr] 165 | | cors_domains: CorsDomains, [INFO] [stderr] 166 | | cors_headers: cors::AccessControlAllowHeaders, [INFO] [stderr] 167 | | continue_on_invalid_cors: bool, [INFO] [stderr] 168 | | keep_alive: bool, [INFO] [stderr] 169 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/handler.rs:163:2 [INFO] [stderr] | [INFO] [stderr] 163 | ReadingHeaders { [INFO] [stderr] | _____^ [INFO] [stderr] 164 | | request: hyper::Request, [INFO] [stderr] 165 | | cors_domains: CorsDomains, [INFO] [stderr] 166 | | cors_headers: cors::AccessControlAllowHeaders, [INFO] [stderr] 167 | | continue_on_invalid_cors: bool, [INFO] [stderr] 168 | | keep_alive: bool, [INFO] [stderr] 169 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/handler.rs:263:81 [INFO] [stderr] | [INFO] [stderr] 263 | Ok(Async::Ready(response)) => RpcPollState::Ready(RpcHandlerState::Writing(response.into())), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `response` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/handler.rs:273:52 [INFO] [stderr] | [INFO] [stderr] 273 | RpcPollState::Ready(RpcHandlerState::Writing(match response { [INFO] [stderr] | ______________________________________________________________________^ [INFO] [stderr] 274 | | // Notification, just return empty response. [INFO] [stderr] 275 | | None => Response::ok(String::new()), [INFO] [stderr] 276 | | // Add new line to have nice output when using CLI clients (curl) [INFO] [stderr] 277 | | Some(result) => Response::ok(format!("{}\n", result)), [INFO] [stderr] 278 | | }.into())) [INFO] [stderr] | |________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 273 | RpcPollState::Ready(RpcHandlerState::Writing(match response { [INFO] [stderr] 274 | // Notification, just return empty response. [INFO] [stderr] 275 | None => Response::ok(String::new()), [INFO] [stderr] 276 | // Add new line to have nice output when using CLI clients (curl) [INFO] [stderr] 277 | Some(result) => Response::ok(format!("{}\n", result)), [INFO] [stderr] 278 | })) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/response.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | content: format!("{}", msg.into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `msg.into().to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/utils.rs:26:57 [INFO] [stderr] | [INFO] [stderr] 26 | Value(ref val) => header::HeaderValue::from_str(val).unwrap_or(header::HeaderValue::from_static("null")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| header::HeaderValue::from_static("null"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utils.rs:45:29 [INFO] [stderr] | [INFO] [stderr] 45 | .flat_map(|val| val.split(",")); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/utils.rs:50:3 [INFO] [stderr] | [INFO] [stderr] 50 | cors_allow_headers.into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `cors_allow_headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/tests.rs:613:4 [INFO] [stderr] | [INFO] [stderr] 613 | &format!("\ [INFO] [stderr] | __________^ [INFO] [stderr] 614 | | OPTIONS / HTTP/1.1\r\n\ [INFO] [stderr] 615 | | Host: 127.0.0.1:8080\r\n\ [INFO] [stderr] 616 | | Origin: http://parity.io\r\n\ [INFO] [stderr] ... | [INFO] [stderr] 620 | | \r\n\ [INFO] [stderr] 621 | | ") [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 613 | &"\ [INFO] [stderr] 614 | OPTIONS / HTTP/1.1\r\n\ [INFO] [stderr] 615 | Host: 127.0.0.1:8080\r\n\ [INFO] [stderr] 616 | Origin: http://parity.io\r\n\ [INFO] [stderr] 617 | Connection: close\r\n\ [INFO] [stderr] 618 | Content-Type: application/json\r\n\ [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/tests.rs:637:4 [INFO] [stderr] | [INFO] [stderr] 637 | &format!("\ [INFO] [stderr] | __________^ [INFO] [stderr] 638 | | OPTIONS / HTTP/1.1\r\n\ [INFO] [stderr] 639 | | Host: 127.0.0.1:8080\r\n\ [INFO] [stderr] 640 | | Origin: http://parity.io\r\n\ [INFO] [stderr] ... | [INFO] [stderr] 645 | | \r\n\ [INFO] [stderr] 646 | | ") [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 637 | &"\ [INFO] [stderr] 638 | OPTIONS / HTTP/1.1\r\n\ [INFO] [stderr] 639 | Host: 127.0.0.1:8080\r\n\ [INFO] [stderr] 640 | Origin: http://parity.io\r\n\ [INFO] [stderr] 641 | Content-Length: 0\r\n\ [INFO] [stderr] 642 | Content-Type: application/json\r\n\ [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/tests.rs:726:4 [INFO] [stderr] | [INFO] [stderr] 726 | &format!("\ [INFO] [stderr] | __________^ [INFO] [stderr] 727 | | POST / HTTP/1.1\r\n\ [INFO] [stderr] 728 | | Host: 127.0.0.1:8080\r\n\ [INFO] [stderr] 729 | | Origin: http://parity.io\r\n\ [INFO] [stderr] ... | [INFO] [stderr] 734 | | \r\n\ [INFO] [stderr] 735 | | ") [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 726 | &"\ [INFO] [stderr] 727 | POST / HTTP/1.1\r\n\ [INFO] [stderr] 728 | Host: 127.0.0.1:8080\r\n\ [INFO] [stderr] 729 | Origin: http://parity.io\r\n\ [INFO] [stderr] 730 | Content-Length: 0\r\n\ [INFO] [stderr] 731 | Content-Type: application/json\r\n\ [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tests.rs:751:13 [INFO] [stderr] | [INFO] [stderr] 751 | let addr = server.address().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*server.address()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tests.rs:781:13 [INFO] [stderr] | [INFO] [stderr] 781 | let addr = server.address().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*server.address()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/tests.rs:815:4 [INFO] [stderr] | [INFO] [stderr] 815 | &format!("\ [INFO] [stderr] | __________^ [INFO] [stderr] 816 | | OPTIONS / HTTP/1.1\r\n\ [INFO] [stderr] 817 | | Host: 127.0.0.1:8080\r\n\ [INFO] [stderr] 818 | | Origin: http://parity.io\r\n\ [INFO] [stderr] ... | [INFO] [stderr] 823 | | \r\n\ [INFO] [stderr] 824 | | ") [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 815 | &"\ [INFO] [stderr] 816 | OPTIONS / HTTP/1.1\r\n\ [INFO] [stderr] 817 | Host: 127.0.0.1:8080\r\n\ [INFO] [stderr] 818 | Origin: http://parity.io\r\n\ [INFO] [stderr] 819 | Content-Length: 0\r\n\ [INFO] [stderr] 820 | Content-Type: application/json\r\n\ [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/tests.rs:873:4 [INFO] [stderr] | [INFO] [stderr] 873 | &format!("\ [INFO] [stderr] | __________^ [INFO] [stderr] 874 | | OPTIONS / HTTP/1.1\r\n\ [INFO] [stderr] 875 | | Host: 127.0.0.1:8080\r\n\ [INFO] [stderr] 876 | | Origin: http://parity.io\r\n\ [INFO] [stderr] ... | [INFO] [stderr] 881 | | \r\n\ [INFO] [stderr] 882 | | ") [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 873 | &"\ [INFO] [stderr] 874 | OPTIONS / HTTP/1.1\r\n\ [INFO] [stderr] 875 | Host: 127.0.0.1:8080\r\n\ [INFO] [stderr] 876 | Origin: http://parity.io\r\n\ [INFO] [stderr] 877 | Content-Length: 0\r\n\ [INFO] [stderr] 878 | Content-Type: application/json\r\n\ [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/tests.rs:900:4 [INFO] [stderr] | [INFO] [stderr] 900 | &format!("\ [INFO] [stderr] | __________^ [INFO] [stderr] 901 | | OPTIONS / HTTP/1.1\r\n\ [INFO] [stderr] 902 | | Host: 127.0.0.1:8080\r\n\ [INFO] [stderr] 903 | | Origin: http://parity.io\r\n\ [INFO] [stderr] ... | [INFO] [stderr] 908 | | \r\n\ [INFO] [stderr] 909 | | ") [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 900 | &"\ [INFO] [stderr] 901 | OPTIONS / HTTP/1.1\r\n\ [INFO] [stderr] 902 | Host: 127.0.0.1:8080\r\n\ [INFO] [stderr] 903 | Origin: http://parity.io\r\n\ [INFO] [stderr] 904 | Content-Length: 0\r\n\ [INFO] [stderr] 905 | Content-Type: application/json\r\n\ [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tests.rs:946:13 [INFO] [stderr] | [INFO] [stderr] 946 | let addr = server.address().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*server.address()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tests.rs:971:13 [INFO] [stderr] | [INFO] [stderr] 971 | let addr = server.address().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*server.address()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tests.rs:996:13 [INFO] [stderr] | [INFO] [stderr] 996 | let addr = server.address().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*server.address()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tests.rs:1021:13 [INFO] [stderr] | [INFO] [stderr] 1021 | let addr = server.address().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*server.address()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tests.rs:1046:13 [INFO] [stderr] | [INFO] [stderr] 1046 | let addr = server.address().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*server.address()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tests.rs:1071:13 [INFO] [stderr] | [INFO] [stderr] 1071 | let addr = server.address().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*server.address()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tests.rs:1096:13 [INFO] [stderr] | [INFO] [stderr] 1096 | let addr = server.address().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*server.address()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tests.rs:1121:13 [INFO] [stderr] | [INFO] [stderr] 1121 | let addr = server.address().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*server.address()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tests.rs:1145:13 [INFO] [stderr] | [INFO] [stderr] 1145 | let addr = server.address().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*server.address()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tests.rs:1172:13 [INFO] [stderr] | [INFO] [stderr] 1172 | let addr = server.address().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*server.address()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tests.rs:1198:13 [INFO] [stderr] | [INFO] [stderr] 1198 | let addr = server.address().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*server.address()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/lib.rs:64:2 [INFO] [stderr] | [INFO] [stderr] 64 | Proceed { [INFO] [stderr] | _____^ [INFO] [stderr] 65 | | /// Should the request be processed even if invalid CORS headers are detected? [INFO] [stderr] 66 | | /// This allows for side effects to take place. [INFO] [stderr] 67 | | should_continue_on_invalid_cors: bool, [INFO] [stderr] 68 | | /// The request object returned [INFO] [stderr] 69 | | request: hyper::Request, [INFO] [stderr] 70 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/lib.rs:64:2 [INFO] [stderr] | [INFO] [stderr] 64 | Proceed { [INFO] [stderr] | _____^ [INFO] [stderr] 65 | | /// Should the request be processed even if invalid CORS headers are detected? [INFO] [stderr] 66 | | /// This allows for side effects to take place. [INFO] [stderr] 67 | | should_continue_on_invalid_cors: bool, [INFO] [stderr] 68 | | /// The request object returned [INFO] [stderr] 69 | | request: hyper::Request, [INFO] [stderr] 70 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:327:26 [INFO] [stderr] | [INFO] [stderr] 327 | self.allowed_headers = allowed_headers.into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `allowed_headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (14/7) [INFO] [stderr] --> src/lib.rs:444:1 [INFO] [stderr] | [INFO] [stderr] 444 | / fn serve>( [INFO] [stderr] 445 | | signals: (oneshot::Receiver<()>, mpsc::Sender>), [INFO] [stderr] 446 | | executor: tokio::runtime::TaskExecutor, [INFO] [stderr] 447 | | addr: SocketAddr, [INFO] [stderr] ... | [INFO] [stderr] 535 | | })); [INFO] [stderr] 536 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/lib.rs:589:3 [INFO] [stderr] | [INFO] [stderr] 589 | self.executor.take().map(|executors| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 590 | || for executor in executors { executor.close(); } [INFO] [stderr] 591 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(executors) = self.executor.take() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 30.27s [INFO] running `"docker" "inspect" "227e802c08dbcb6213c59b6d9f15121df6b8c2b330f0b828309656ba96625842"` [INFO] running `"docker" "rm" "-f" "227e802c08dbcb6213c59b6d9f15121df6b8c2b330f0b828309656ba96625842"` [INFO] [stdout] 227e802c08dbcb6213c59b6d9f15121df6b8c2b330f0b828309656ba96625842