[INFO] crate jsonrpc-client-http 0.5.0 is already in cache
[INFO] extracting crate jsonrpc-client-http 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/jsonrpc-client-http/0.5.0
[INFO] extracting crate jsonrpc-client-http 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/jsonrpc-client-http/0.5.0
[INFO] validating manifest of jsonrpc-client-http-0.5.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of jsonrpc-client-http-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing jsonrpc-client-http-0.5.0
[INFO] finished frobbing jsonrpc-client-http-0.5.0
[INFO] frobbed toml for jsonrpc-client-http-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/jsonrpc-client-http/0.5.0/Cargo.toml
[INFO] started frobbing jsonrpc-client-http-0.5.0
[INFO] finished frobbing jsonrpc-client-http-0.5.0
[INFO] frobbed toml for jsonrpc-client-http-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/jsonrpc-client-http/0.5.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting jsonrpc-client-http-0.5.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/jsonrpc-client-http/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 7e79ed4e97f6b40dad86c64a041576d127613095a06027d8bf7684bf684b94a0
[INFO] running `"docker" "start" "-a" "7e79ed4e97f6b40dad86c64a041576d127613095a06027d8bf7684bf684b94a0"`
[INFO] [stderr]     Checking globset v0.1.4
[INFO] [stderr]     Checking jsonrpc-core v8.0.1
[INFO] [stderr]     Checking jsonrpc-client-core v0.5.0
[INFO] [stderr]     Checking jsonrpc-pubsub v8.0.0
[INFO] [stderr]     Checking jsonrpc-server-utils v8.0.0
[INFO] [stderr]     Checking jsonrpc-client-http v0.5.0 (/opt/crater/workdir)
[INFO] [stderr]     Checking jsonrpc-macros v8.0.0
[INFO] [stderr]     Checking jsonrpc-http-server v8.0.0
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr]    --> src/lib.rs:161:5
[INFO] [stderr]     |
[INFO] [stderr] 161 | /     pub fn new() -> HttpTransportBuilder<DefaultClient> {
[INFO] [stderr] 162 | |         HttpTransportBuilder::with_client(DefaultClient)
[INFO] [stderr] 163 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_ret_no_self)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]    --> src/lib.rs:243:28
[INFO] [stderr]     |
[INFO] [stderr] 243 |                       if let Err(_) = core.run(future) {
[INFO] [stderr]     |  _____________________-      ^^^^^^
[INFO] [stderr] 244 | |                         error!("JSON-RPC processing thread had an error");
[INFO] [stderr] 245 | |                     }
[INFO] [stderr]     | |_____________________- help: try this: `if core.run(future).is_err()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/lib.rs:333:6
[INFO] [stderr]     |
[INFO] [stderr] 333 | ) -> Result<(Core, CoreSender, Box<Future<Item = (), Error = ()>>)> {
[INFO] [stderr]     |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]    --> src/lib.rs:367:24
[INFO] [stderr]     |
[INFO] [stderr] 367 |                   if let Err(_) = response_tx.send(response_result) {
[INFO] [stderr]     |  _________________-      ^^^^^^
[INFO] [stderr] 368 | |                     warn!("Unable to send response back to caller");
[INFO] [stderr] 369 | |                 }
[INFO] [stderr]     | |_________________- help: try this: `if response_tx.send(response_result).is_err()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> tests/timeout.rs:114:39
[INFO] [stderr]     |
[INFO] [stderr] 114 |           Err(Either::B((error, _))) => match error.kind() {
[INFO] [stderr]     |  _______________________________________^
[INFO] [stderr] 115 | |             &ErrorKind::RequestTimeout => (),
[INFO] [stderr] 116 | |             _ => panic!("failed to send request: {}", error),
[INFO] [stderr] 117 | |         },
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 114 |         Err(Either::B((error, _))) => match *error.kind() {
[INFO] [stderr] 115 |             ErrorKind::RequestTimeout => (),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr]    --> src/lib.rs:161:5
[INFO] [stderr]     |
[INFO] [stderr] 161 | /     pub fn new() -> HttpTransportBuilder<DefaultClient> {
[INFO] [stderr] 162 | |         HttpTransportBuilder::with_client(DefaultClient)
[INFO] [stderr] 163 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_ret_no_self)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]    --> src/lib.rs:243:28
[INFO] [stderr]     |
[INFO] [stderr] 243 |                       if let Err(_) = core.run(future) {
[INFO] [stderr]     |  _____________________-      ^^^^^^
[INFO] [stderr] 244 | |                         error!("JSON-RPC processing thread had an error");
[INFO] [stderr] 245 | |                     }
[INFO] [stderr]     | |_____________________- help: try this: `if core.run(future).is_err()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/lib.rs:333:6
[INFO] [stderr]     |
[INFO] [stderr] 333 | ) -> Result<(Core, CoreSender, Box<Future<Item = (), Error = ()>>)> {
[INFO] [stderr]     |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]    --> src/lib.rs:367:24
[INFO] [stderr]     |
[INFO] [stderr] 367 |                   if let Err(_) = response_tx.send(response_result) {
[INFO] [stderr]     |  _________________-      ^^^^^^
[INFO] [stderr] 368 | |                     warn!("Unable to send response back to caller");
[INFO] [stderr] 369 | |                 }
[INFO] [stderr]     | |_________________- help: try this: `if response_tx.send(response_result).is_err()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 32.89s
[INFO] running `"docker" "inspect" "7e79ed4e97f6b40dad86c64a041576d127613095a06027d8bf7684bf684b94a0"`
[INFO] running `"docker" "rm" "-f" "7e79ed4e97f6b40dad86c64a041576d127613095a06027d8bf7684bf684b94a0"`
[INFO] [stdout] 7e79ed4e97f6b40dad86c64a041576d127613095a06027d8bf7684bf684b94a0