[INFO] crate json_pretty 0.1.2 is already in cache
[INFO] extracting crate json_pretty 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/json_pretty/0.1.2
[INFO] extracting crate json_pretty 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/json_pretty/0.1.2
[INFO] validating manifest of json_pretty-0.1.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of json_pretty-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing json_pretty-0.1.2
[INFO] finished frobbing json_pretty-0.1.2
[INFO] frobbed toml for json_pretty-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/json_pretty/0.1.2/Cargo.toml
[INFO] started frobbing json_pretty-0.1.2
[INFO] finished frobbing json_pretty-0.1.2
[INFO] frobbed toml for json_pretty-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/json_pretty/0.1.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting json_pretty-0.1.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/json_pretty/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c84ecbb88962d2b153981ecb136c3bae831f4c883d15679fa92297cab9235350
[INFO] running `"docker" "start" "-a" "c84ecbb88962d2b153981ecb136c3bae831f4c883d15679fa92297cab9235350"`
[INFO] [stderr]     Checking json_pretty v0.1.2 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:27:13
[INFO] [stderr]    |
[INFO] [stderr] 27 |             indent: indent,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `indent`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:27:13
[INFO] [stderr]    |
[INFO] [stderr] 27 |             indent: indent,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `indent`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/lib.rs:91:26
[INFO] [stderr]    |
[INFO] [stderr] 91 |                       }else{
[INFO] [stderr]    |  __________________________^
[INFO] [stderr] 92 | |                         if need_indent {
[INFO] [stderr] 93 | |                             continue;
[INFO] [stderr] 94 | |                         }else{
[INFO] [stderr] 95 | |                             result.push(ch);
[INFO] [stderr] 96 | |                         }
[INFO] [stderr] 97 | |                     }
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 91 |                     }elseif need_indent {
[INFO] [stderr] 92 |     continue;
[INFO] [stderr] 93 | }else{
[INFO] [stderr] 94 |     result.push(ch);
[INFO] [stderr] 95 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name
[INFO] [stderr]   --> src/lib.rs:10:4
[INFO] [stderr]    |
[INFO] [stderr] 10 | /    pub fn from_str(s: &str) -> PrettyFormatter {
[INFO] [stderr] 11 | |         PrettyFormatter {
[INFO] [stderr] 12 | |             string: s.to_owned(),
[INFO] [stderr] 13 | |             indent: 2
[INFO] [stderr] 14 | |         }
[INFO] [stderr] 15 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:17:27
[INFO] [stderr]    |
[INFO] [stderr] 17 |     pub fn from_string(s: &String) -> PrettyFormatter {
[INFO] [stderr]    |                           ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 17 |     pub fn from_string(s: &str) -> PrettyFormatter {
[INFO] [stderr]    |                           ^^^^
[INFO] [stderr] help: change `s.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 19 |             string: s.to_string(),
[INFO] [stderr]    |                     ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/lib.rs:91:26
[INFO] [stderr]    |
[INFO] [stderr] 91 |                       }else{
[INFO] [stderr]    |  __________________________^
[INFO] [stderr] 92 | |                         if need_indent {
[INFO] [stderr] 93 | |                             continue;
[INFO] [stderr] 94 | |                         }else{
[INFO] [stderr] 95 | |                             result.push(ch);
[INFO] [stderr] 96 | |                         }
[INFO] [stderr] 97 | |                     }
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 91 |                     }elseif need_indent {
[INFO] [stderr] 92 |     continue;
[INFO] [stderr] 93 | }else{
[INFO] [stderr] 94 |     result.push(ch);
[INFO] [stderr] 95 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name
[INFO] [stderr]   --> src/lib.rs:10:4
[INFO] [stderr]    |
[INFO] [stderr] 10 | /    pub fn from_str(s: &str) -> PrettyFormatter {
[INFO] [stderr] 11 | |         PrettyFormatter {
[INFO] [stderr] 12 | |             string: s.to_owned(),
[INFO] [stderr] 13 | |             indent: 2
[INFO] [stderr] 14 | |         }
[INFO] [stderr] 15 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:17:27
[INFO] [stderr]    |
[INFO] [stderr] 17 |     pub fn from_string(s: &String) -> PrettyFormatter {
[INFO] [stderr]    |                           ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 17 |     pub fn from_string(s: &str) -> PrettyFormatter {
[INFO] [stderr]    |                           ^^^^
[INFO] [stderr] help: change `s.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 19 |             string: s.to_string(),
[INFO] [stderr]    |                     ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.24s
[INFO] running `"docker" "inspect" "c84ecbb88962d2b153981ecb136c3bae831f4c883d15679fa92297cab9235350"`
[INFO] running `"docker" "rm" "-f" "c84ecbb88962d2b153981ecb136c3bae831f4c883d15679fa92297cab9235350"`
[INFO] [stdout] c84ecbb88962d2b153981ecb136c3bae831f4c883d15679fa92297cab9235350