[INFO] crate json_config 0.1.4 is already in cache
[INFO] extracting crate json_config 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/json_config/0.1.4
[INFO] extracting crate json_config 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/json_config/0.1.4
[INFO] validating manifest of json_config-0.1.4 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of json_config-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing json_config-0.1.4
[INFO] finished frobbing json_config-0.1.4
[INFO] frobbed toml for json_config-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/json_config/0.1.4/Cargo.toml
[INFO] started frobbing json_config-0.1.4
[INFO] finished frobbing json_config-0.1.4
[INFO] frobbed toml for json_config-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/json_config/0.1.4/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting json_config-0.1.4 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/json_config/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 2a4ad1833f41d4f39457a9b66dbc0891fd29824186c1fa7ed11beceaabb6830d
[INFO] running `"docker" "start" "-a" "2a4ad1833f41d4f39457a9b66dbc0891fd29824186c1fa7ed11beceaabb6830d"`
[INFO] [stderr]     Checking json_config v0.1.4 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:45:9
[INFO] [stderr]    |
[INFO] [stderr] 45 |         return config_builder;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `config_builder`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:58:9
[INFO] [stderr]    |
[INFO] [stderr] 58 |         return builder;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^ help: remove `return` as shown: `builder`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:105:9
[INFO] [stderr]     |
[INFO] [stderr] 105 |         return self.config.to_string();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.config.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:109:9
[INFO] [stderr]     |
[INFO] [stderr] 109 |         return to_string_pretty(&self.config).unwrap();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `to_string_pretty(&self.config).unwrap()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:113:9
[INFO] [stderr]     |
[INFO] [stderr] 113 |         return self.config.clone();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.config.clone()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/lib.rs:61:53
[INFO] [stderr]    |
[INFO] [stderr] 61 |     pub fn merge_sources(&mut self, config_sources: &Vec<ConfigurationSource>){        
[INFO] [stderr]    |                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ConfigurationSource]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/lib.rs:68:9
[INFO] [stderr]    |
[INFO] [stderr] 68 | /         match config_source {
[INFO] [stderr] 69 | |             &ConfigurationSource::JsonContent(ref config_override) => {                
[INFO] [stderr] 70 | |                 merge(&mut self.config, &config_override);
[INFO] [stderr] 71 | |             },
[INFO] [stderr] ...  |
[INFO] [stderr] 83 | |             }
[INFO] [stderr] 84 | |         }      
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 68 |         match *config_source {
[INFO] [stderr] 69 |             ConfigurationSource::JsonContent(ref config_override) => {                
[INFO] [stderr] 70 |                 merge(&mut self.config, &config_override);
[INFO] [stderr] 71 |             },
[INFO] [stderr] 72 |             ConfigurationSource::StringContent(ref content) => {                
[INFO] [stderr] 73 |                 let config_override: Value = from_str(&content[..]).unwrap();
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/lib.rs:92:23
[INFO] [stderr]    |
[INFO] [stderr] 92 |         let sources = self.bundles.get(bundle_key).unwrap().clone();
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.bundles[bundle_key]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/lib.rs:96:24
[INFO] [stderr]    |
[INFO] [stderr] 96 |     pub fn to_compiled(&mut self, filename: &str){
[INFO] [stderr]    |                        ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:45:9
[INFO] [stderr]    |
[INFO] [stderr] 45 |         return config_builder;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `config_builder`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:58:9
[INFO] [stderr]    |
[INFO] [stderr] 58 |         return builder;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^ help: remove `return` as shown: `builder`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:105:9
[INFO] [stderr]     |
[INFO] [stderr] 105 |         return self.config.to_string();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.config.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:109:9
[INFO] [stderr]     |
[INFO] [stderr] 109 |         return to_string_pretty(&self.config).unwrap();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `to_string_pretty(&self.config).unwrap()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:113:9
[INFO] [stderr]     |
[INFO] [stderr] 113 |         return self.config.clone();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.config.clone()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/lib.rs:61:53
[INFO] [stderr]    |
[INFO] [stderr] 61 |     pub fn merge_sources(&mut self, config_sources: &Vec<ConfigurationSource>){        
[INFO] [stderr]    |                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ConfigurationSource]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/lib.rs:68:9
[INFO] [stderr]    |
[INFO] [stderr] 68 | /         match config_source {
[INFO] [stderr] 69 | |             &ConfigurationSource::JsonContent(ref config_override) => {                
[INFO] [stderr] 70 | |                 merge(&mut self.config, &config_override);
[INFO] [stderr] 71 | |             },
[INFO] [stderr] ...  |
[INFO] [stderr] 83 | |             }
[INFO] [stderr] 84 | |         }      
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 68 |         match *config_source {
[INFO] [stderr] 69 |             ConfigurationSource::JsonContent(ref config_override) => {                
[INFO] [stderr] 70 |                 merge(&mut self.config, &config_override);
[INFO] [stderr] 71 |             },
[INFO] [stderr] 72 |             ConfigurationSource::StringContent(ref content) => {                
[INFO] [stderr] 73 |                 let config_override: Value = from_str(&content[..]).unwrap();
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/lib.rs:92:23
[INFO] [stderr]    |
[INFO] [stderr] 92 |         let sources = self.bundles.get(bundle_key).unwrap().clone();
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.bundles[bundle_key]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/lib.rs:96:24
[INFO] [stderr]    |
[INFO] [stderr] 96 |     pub fn to_compiled(&mut self, filename: &str){
[INFO] [stderr]    |                        ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.38s
[INFO] running `"docker" "inspect" "2a4ad1833f41d4f39457a9b66dbc0891fd29824186c1fa7ed11beceaabb6830d"`
[INFO] running `"docker" "rm" "-f" "2a4ad1833f41d4f39457a9b66dbc0891fd29824186c1fa7ed11beceaabb6830d"`
[INFO] [stdout] 2a4ad1833f41d4f39457a9b66dbc0891fd29824186c1fa7ed11beceaabb6830d