[INFO] crate json5 0.2.2 is already in cache [INFO] extracting crate json5 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/json5/0.2.2 [INFO] extracting crate json5 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/json5/0.2.2 [INFO] validating manifest of json5-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of json5-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing json5-0.2.2 [INFO] finished frobbing json5-0.2.2 [INFO] frobbed toml for json5-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/json5/0.2.2/Cargo.toml [INFO] started frobbing json5-0.2.2 [INFO] finished frobbing json5-0.2.2 [INFO] frobbed toml for json5-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/json5/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting json5-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/json5/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 18d48e7e941051b617c8e8c6bfe29302c58701c2b2210d3f330f022bba8ad9a3 [INFO] running `"docker" "start" "-a" "18d48e7e941051b617c8e8c6bfe29302c58701c2b2210d3f330f022bba8ad9a3"` [INFO] [stderr] Compiling pest_generator v2.1.0 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Checking json5 v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/de.rs:241:35 [INFO] [stderr] | [INFO] [stderr] 241 | s if is_hex_literal(s) => parse_hex(&s[2..]) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(parse_hex(&s[2..]))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/de.rs:241:35 [INFO] [stderr] | [INFO] [stderr] 241 | s if is_hex_literal(s) => parse_hex(&s[2..]) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(parse_hex(&s[2..]))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> tests/common.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn deserializes_to_nan<'a>(s: &'a str) { [INFO] [stderr] 19 | | match json5::from_str::(s) { [INFO] [stderr] 20 | | Ok(value) => assert!(value.is_nan()), [INFO] [stderr] 21 | | Err(err) => panic!(format!("{}", err)), [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/json5_dot_org_example.rs:40:32 [INFO] [stderr] | [INFO] [stderr] 40 | leading_decimal_point: 0.8675309, [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.867_530_9` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/json5_dot_org_example.rs:41:23 [INFO] [stderr] | [INFO] [stderr] 41 | and_trailing: 8675309.0, [INFO] [stderr] | ^^^^^^^^^ help: consider: `8_675_309.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> tests/common.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn deserializes_to_nan<'a>(s: &'a str) { [INFO] [stderr] 19 | | match json5::from_str::(s) { [INFO] [stderr] 20 | | Ok(value) => assert!(value.is_nan()), [INFO] [stderr] 21 | | Err(err) => panic!(format!("{}", err)), [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> tests/common.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn deserializes_to_nan<'a>(s: &'a str) { [INFO] [stderr] 19 | | match json5::from_str::(s) { [INFO] [stderr] 20 | | Ok(value) => assert!(value.is_nan()), [INFO] [stderr] 21 | | Err(err) => panic!(format!("{}", err)), [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> tests/common.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn deserializes_to_nan<'a>(s: &'a str) { [INFO] [stderr] 19 | | match json5::from_str::(s) { [INFO] [stderr] 20 | | Ok(value) => assert!(value.is_nan()), [INFO] [stderr] 21 | | Err(err) => panic!(format!("{}", err)), [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> tests/common.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn deserializes_to_nan<'a>(s: &'a str) { [INFO] [stderr] 19 | | match json5::from_str::(s) { [INFO] [stderr] 20 | | Ok(value) => assert!(value.is_nan()), [INFO] [stderr] 21 | | Err(err) => panic!(format!("{}", err)), [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.81s [INFO] running `"docker" "inspect" "18d48e7e941051b617c8e8c6bfe29302c58701c2b2210d3f330f022bba8ad9a3"` [INFO] running `"docker" "rm" "-f" "18d48e7e941051b617c8e8c6bfe29302c58701c2b2210d3f330f022bba8ad9a3"` [INFO] [stdout] 18d48e7e941051b617c8e8c6bfe29302c58701c2b2210d3f330f022bba8ad9a3