[INFO] crate json-pointer 0.3.2 is already in cache [INFO] extracting crate json-pointer 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/json-pointer/0.3.2 [INFO] extracting crate json-pointer 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/json-pointer/0.3.2 [INFO] validating manifest of json-pointer-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of json-pointer-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing json-pointer-0.3.2 [INFO] finished frobbing json-pointer-0.3.2 [INFO] frobbed toml for json-pointer-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/json-pointer/0.3.2/Cargo.toml [INFO] started frobbing json-pointer-0.3.2 [INFO] finished frobbing json-pointer-0.3.2 [INFO] frobbed toml for json-pointer-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/json-pointer/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting json-pointer-0.3.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/json-pointer/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] aada87bde42f4418dd013078429e89c24e16b6c235234bde472049e939ee3062 [INFO] running `"docker" "start" "-a" "aada87bde42f4418dd013078429e89c24e16b6c235234bde472049e939ee3062"` [INFO] [stderr] Checking json-pointer v0.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ptr.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | ref_toks: ref_toks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `ref_toks` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ptr.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | ref_toks: ref_toks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `ref_toks` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/string_repr.rs:46:28 [INFO] [stderr] | [INFO] [stderr] 46 | if iter.next().map(|s| s.len() > 0).unwrap_or(false) { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> src/parser/mod.rs:9:8 [INFO] [stderr] | [INFO] [stderr] 9 | if s.chars().next() == Some('#') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `s.starts_with('#')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_next_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ptr.rs:43:34 [INFO] [stderr] | [INFO] [stderr] 43 | arr.get(idx).ok_or(IndexError::OutOfBounds(idx)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndexError::OutOfBounds(idx))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ptr.rs:65:38 [INFO] [stderr] | [INFO] [stderr] 65 | arr.get_mut(idx).ok_or(IndexError::OutOfBounds(idx)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndexError::OutOfBounds(idx))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/string_repr.rs:46:28 [INFO] [stderr] | [INFO] [stderr] 46 | if iter.next().map(|s| s.len() > 0).unwrap_or(false) { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> src/parser/mod.rs:9:8 [INFO] [stderr] | [INFO] [stderr] 9 | if s.chars().next() == Some('#') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `s.starts_with('#')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_next_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ptr.rs:43:34 [INFO] [stderr] | [INFO] [stderr] 43 | arr.get(idx).ok_or(IndexError::OutOfBounds(idx)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndexError::OutOfBounds(idx))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ptr.rs:65:38 [INFO] [stderr] | [INFO] [stderr] 65 | arr.get_mut(idx).ok_or(IndexError::OutOfBounds(idx)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndexError::OutOfBounds(idx))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> tests/parsing.rs:17:8 [INFO] [stderr] | [INFO] [stderr] 17 | if s.chars().next() == Some('#') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `s.starts_with('#')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_next_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.33s [INFO] running `"docker" "inspect" "aada87bde42f4418dd013078429e89c24e16b6c235234bde472049e939ee3062"` [INFO] running `"docker" "rm" "-f" "aada87bde42f4418dd013078429e89c24e16b6c235234bde472049e939ee3062"` [INFO] [stdout] aada87bde42f4418dd013078429e89c24e16b6c235234bde472049e939ee3062