[INFO] crate json-model 0.2.1 is already in cache [INFO] extracting crate json-model 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/json-model/0.2.1 [INFO] extracting crate json-model 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/json-model/0.2.1 [INFO] validating manifest of json-model-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of json-model-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing json-model-0.2.1 [INFO] finished frobbing json-model-0.2.1 [INFO] frobbed toml for json-model-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/json-model/0.2.1/Cargo.toml [INFO] started frobbing json-model-0.2.1 [INFO] finished frobbing json-model-0.2.1 [INFO] frobbed toml for json-model-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/json-model/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting json-model-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/json-model/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2cd24f8feb55ce7396518b37650c0e86f033452752623caef232ac5cd50b1603 [INFO] running `"docker" "start" "-a" "2cd24f8feb55ce7396518b37650c0e86f033452752623caef232ac5cd50b1603"` [INFO] [stderr] Checking json-model v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/array_items.rs:88:21 [INFO] [stderr] | [INFO] [stderr] 88 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/array_items.rs:111:21 [INFO] [stderr] | [INFO] [stderr] 111 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/const_value.rs:66:17 [INFO] [stderr] | [INFO] [stderr] 66 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/enum_values.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/numeric_max.rs:92:25 [INFO] [stderr] | [INFO] [stderr] 92 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/numeric_max.rs:101:21 [INFO] [stderr] | [INFO] [stderr] 101 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/numeric_max.rs:107:21 [INFO] [stderr] | [INFO] [stderr] 107 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/numeric_max.rs:117:25 [INFO] [stderr] | [INFO] [stderr] 117 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/numeric_max.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/numeric_max.rs:132:21 [INFO] [stderr] | [INFO] [stderr] 132 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/numeric_min.rs:92:25 [INFO] [stderr] | [INFO] [stderr] 92 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/numeric_min.rs:101:21 [INFO] [stderr] | [INFO] [stderr] 101 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/numeric_min.rs:107:21 [INFO] [stderr] | [INFO] [stderr] 107 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/numeric_min.rs:117:25 [INFO] [stderr] | [INFO] [stderr] 117 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/numeric_min.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/numeric_min.rs:132:21 [INFO] [stderr] | [INFO] [stderr] 132 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/object_properties.rs:376:21 [INFO] [stderr] | [INFO] [stderr] 376 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/object_properties.rs:399:33 [INFO] [stderr] | [INFO] [stderr] 399 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/string_max_length.rs:75:21 [INFO] [stderr] | [INFO] [stderr] 75 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/string_max_length.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/string_min_length.rs:75:21 [INFO] [stderr] | [INFO] [stderr] 75 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/string_min_length.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/string_pattern.rs:85:21 [INFO] [stderr] | [INFO] [stderr] 85 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/string_pattern.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/typ.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/array_items.rs:88:21 [INFO] [stderr] | [INFO] [stderr] 88 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/array_items.rs:111:21 [INFO] [stderr] | [INFO] [stderr] 111 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/const_value.rs:66:17 [INFO] [stderr] | [INFO] [stderr] 66 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/enum_values.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/numeric_max.rs:92:25 [INFO] [stderr] | [INFO] [stderr] 92 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/numeric_max.rs:101:21 [INFO] [stderr] | [INFO] [stderr] 101 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/numeric_max.rs:107:21 [INFO] [stderr] | [INFO] [stderr] 107 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/numeric_max.rs:117:25 [INFO] [stderr] | [INFO] [stderr] 117 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/numeric_max.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/numeric_max.rs:132:21 [INFO] [stderr] | [INFO] [stderr] 132 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/numeric_min.rs:92:25 [INFO] [stderr] | [INFO] [stderr] 92 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/numeric_min.rs:101:21 [INFO] [stderr] | [INFO] [stderr] 101 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/numeric_min.rs:107:21 [INFO] [stderr] | [INFO] [stderr] 107 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/numeric_min.rs:117:25 [INFO] [stderr] | [INFO] [stderr] 117 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/numeric_min.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/numeric_min.rs:132:21 [INFO] [stderr] | [INFO] [stderr] 132 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/object_properties.rs:376:21 [INFO] [stderr] | [INFO] [stderr] 376 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/object_properties.rs:399:33 [INFO] [stderr] | [INFO] [stderr] 399 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/string_max_length.rs:75:21 [INFO] [stderr] | [INFO] [stderr] 75 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/string_max_length.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/string_min_length.rs:75:21 [INFO] [stderr] | [INFO] [stderr] 75 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/string_min_length.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/string_pattern.rs:85:21 [INFO] [stderr] | [INFO] [stderr] 85 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/string_pattern.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute/typ.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/attribute/enum_values.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | / return Err(ValidationError::Failure { [INFO] [stderr] 78 | | rule: "value".to_string(), [INFO] [stderr] 79 | | path: path, [INFO] [stderr] 80 | | message: "Value is invalid.".to_string(), [INFO] [stderr] 81 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 77 | Err(ValidationError::Failure { [INFO] [stderr] 78 | rule: "value".to_string(), [INFO] [stderr] 79 | path: path, [INFO] [stderr] 80 | message: "Value is invalid.".to_string(), [INFO] [stderr] 81 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/attribute.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | / return Err(Error::InvalidValue { [INFO] [stderr] 85 | | path: path.clone(), [INFO] [stderr] 86 | | value: id.clone(), [INFO] [stderr] 87 | | }); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 84 | Err(Error::InvalidValue { [INFO] [stderr] 85 | path: path.clone(), [INFO] [stderr] 86 | value: id.clone(), [INFO] [stderr] 87 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/attribute.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | / return Err(Error::MissingAttribute { [INFO] [stderr] 92 | | path: path.clone(), [INFO] [stderr] 93 | | attr: "id".to_string(), [INFO] [stderr] 94 | | }) [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 91 | Err(Error::MissingAttribute { [INFO] [stderr] 92 | path: path.clone(), [INFO] [stderr] 93 | attr: "id".to_string(), [INFO] [stderr] 94 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/attribute/enum_values.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | / return Err(ValidationError::Failure { [INFO] [stderr] 78 | | rule: "value".to_string(), [INFO] [stderr] 79 | | path: path, [INFO] [stderr] 80 | | message: "Value is invalid.".to_string(), [INFO] [stderr] 81 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 77 | Err(ValidationError::Failure { [INFO] [stderr] 78 | rule: "value".to_string(), [INFO] [stderr] 79 | path: path, [INFO] [stderr] 80 | message: "Value is invalid.".to_string(), [INFO] [stderr] 81 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/attribute.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | / return Err(Error::InvalidValue { [INFO] [stderr] 85 | | path: path.clone(), [INFO] [stderr] 86 | | value: id.clone(), [INFO] [stderr] 87 | | }); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 84 | Err(Error::InvalidValue { [INFO] [stderr] 85 | path: path.clone(), [INFO] [stderr] 86 | value: id.clone(), [INFO] [stderr] 87 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/attribute.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | / return Err(Error::MissingAttribute { [INFO] [stderr] 92 | | path: path.clone(), [INFO] [stderr] 93 | | attr: "id".to_string(), [INFO] [stderr] 94 | | }) [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 91 | Err(Error::MissingAttribute { [INFO] [stderr] 92 | path: path.clone(), [INFO] [stderr] 93 | attr: "id".to_string(), [INFO] [stderr] 94 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/attribute/array_items.rs:103:24 [INFO] [stderr] | [INFO] [stderr] 103 | if let Ok(_) = def.validate(state, value, path.clone()) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 104 | | found = true; [INFO] [stderr] 105 | | break; [INFO] [stderr] 106 | | } [INFO] [stderr] | |_________________- help: try this: `if def.validate(state, value, path.clone()).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/attribute/array_items.rs:103:24 [INFO] [stderr] | [INFO] [stderr] 103 | if let Ok(_) = def.validate(state, value, path.clone()) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 104 | | found = true; [INFO] [stderr] 105 | | break; [INFO] [stderr] 106 | | } [INFO] [stderr] | |_________________- help: try this: `if def.validate(state, value, path.clone()).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/attribute/object_properties.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | / match props.get("required") { [INFO] [stderr] 125 | | Some(req) => match req.as_array() { [INFO] [stderr] 126 | | Some(req) => { [INFO] [stderr] 127 | | let mut path = path.clone(); [INFO] [stderr] ... | [INFO] [stderr] 158 | | None => (), [INFO] [stderr] 159 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 124 | if let Some(req) = props.get("required") { match req.as_array() { [INFO] [stderr] 125 | Some(req) => { [INFO] [stderr] 126 | let mut path = path.clone(); [INFO] [stderr] 127 | path.add("required"); [INFO] [stderr] 128 | for (i, id) in req.iter().enumerate() { [INFO] [stderr] 129 | let mut path = path.clone(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/attribute/object_properties.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | / match props.get("names") { [INFO] [stderr] 162 | | Some(n) => match n.as_object() { [INFO] [stderr] 163 | | Some(n) => { [INFO] [stderr] 164 | | let mut path = path.clone(); [INFO] [stderr] ... | [INFO] [stderr] 209 | | None => (), [INFO] [stderr] 210 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 161 | if let Some(n) = props.get("names") { match n.as_object() { [INFO] [stderr] 162 | Some(n) => { [INFO] [stderr] 163 | let mut path = path.clone(); [INFO] [stderr] 164 | path.add("names"); [INFO] [stderr] 165 | for (id, name) in n { [INFO] [stderr] 166 | let mut path = path.clone(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/attribute/object_properties.rs:212:9 [INFO] [stderr] | [INFO] [stderr] 212 | / match props.get("namePatterns") { [INFO] [stderr] 213 | | Some(p) => match p.as_object() { [INFO] [stderr] 214 | | Some(p) => { [INFO] [stderr] 215 | | let mut path = path.clone(); [INFO] [stderr] ... | [INFO] [stderr] 274 | | None => (), [INFO] [stderr] 275 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 212 | if let Some(p) = props.get("namePatterns") { match p.as_object() { [INFO] [stderr] 213 | Some(p) => { [INFO] [stderr] 214 | let mut path = path.clone(); [INFO] [stderr] 215 | path.add("namePatterns"); [INFO] [stderr] 216 | for (id, pattern) in p { [INFO] [stderr] 217 | let mut path = path.clone(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/attribute/object_properties.rs:304:15 [INFO] [stderr] | [INFO] [stderr] 304 | path: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 304 | path: &[String], [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] help: change `path.clone()` to [INFO] [stderr] | [INFO] [stderr] 319 | path: path.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/attribute/object_properties.rs:332:15 [INFO] [stderr] | [INFO] [stderr] 332 | path: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 332 | path: &[String], [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] help: change `path.clone()` to [INFO] [stderr] | [INFO] [stderr] 338 | path: path.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `path.clone()` to [INFO] [stderr] | [INFO] [stderr] 355 | path: path.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/attribute/object_properties.rs:335:20 [INFO] [stderr] | [INFO] [stderr] 335 | if let None = obj.get(name.as_str()) { [INFO] [stderr] | _____________- ^^^^ [INFO] [stderr] 336 | | return Err(ValidationError::Failure { [INFO] [stderr] 337 | | rule: REQUIRED_RULE.to_string(), [INFO] [stderr] 338 | | path: path.clone(), [INFO] [stderr] 339 | | message: format!("{} is required.", name), [INFO] [stderr] 340 | | }); [INFO] [stderr] 341 | | } [INFO] [stderr] | |_____________- help: try this: `if obj.get(name.as_str()).is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/attribute/object_properties.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | / match props.get("required") { [INFO] [stderr] 125 | | Some(req) => match req.as_array() { [INFO] [stderr] 126 | | Some(req) => { [INFO] [stderr] 127 | | let mut path = path.clone(); [INFO] [stderr] ... | [INFO] [stderr] 158 | | None => (), [INFO] [stderr] 159 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 124 | if let Some(req) = props.get("required") { match req.as_array() { [INFO] [stderr] 125 | Some(req) => { [INFO] [stderr] 126 | let mut path = path.clone(); [INFO] [stderr] 127 | path.add("required"); [INFO] [stderr] 128 | for (i, id) in req.iter().enumerate() { [INFO] [stderr] 129 | let mut path = path.clone(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/attribute/object_properties.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | / match props.get("names") { [INFO] [stderr] 162 | | Some(n) => match n.as_object() { [INFO] [stderr] 163 | | Some(n) => { [INFO] [stderr] 164 | | let mut path = path.clone(); [INFO] [stderr] ... | [INFO] [stderr] 209 | | None => (), [INFO] [stderr] 210 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 161 | if let Some(n) = props.get("names") { match n.as_object() { [INFO] [stderr] 162 | Some(n) => { [INFO] [stderr] 163 | let mut path = path.clone(); [INFO] [stderr] 164 | path.add("names"); [INFO] [stderr] 165 | for (id, name) in n { [INFO] [stderr] 166 | let mut path = path.clone(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/attribute/object_properties.rs:212:9 [INFO] [stderr] | [INFO] [stderr] 212 | / match props.get("namePatterns") { [INFO] [stderr] 213 | | Some(p) => match p.as_object() { [INFO] [stderr] 214 | | Some(p) => { [INFO] [stderr] 215 | | let mut path = path.clone(); [INFO] [stderr] ... | [INFO] [stderr] 274 | | None => (), [INFO] [stderr] 275 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 212 | if let Some(p) = props.get("namePatterns") { match p.as_object() { [INFO] [stderr] 213 | Some(p) => { [INFO] [stderr] 214 | let mut path = path.clone(); [INFO] [stderr] 215 | path.add("namePatterns"); [INFO] [stderr] 216 | for (id, pattern) in p { [INFO] [stderr] 217 | let mut path = path.clone(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/attribute/object_properties.rs:304:15 [INFO] [stderr] | [INFO] [stderr] 304 | path: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 304 | path: &[String], [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] help: change `path.clone()` to [INFO] [stderr] | [INFO] [stderr] 319 | path: path.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/attribute/object_properties.rs:332:15 [INFO] [stderr] | [INFO] [stderr] 332 | path: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 332 | path: &[String], [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] help: change `path.clone()` to [INFO] [stderr] | [INFO] [stderr] 338 | path: path.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `path.clone()` to [INFO] [stderr] | [INFO] [stderr] 355 | path: path.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/attribute/object_properties.rs:335:20 [INFO] [stderr] | [INFO] [stderr] 335 | if let None = obj.get(name.as_str()) { [INFO] [stderr] | _____________- ^^^^ [INFO] [stderr] 336 | | return Err(ValidationError::Failure { [INFO] [stderr] 337 | | rule: REQUIRED_RULE.to_string(), [INFO] [stderr] 338 | | path: path.clone(), [INFO] [stderr] 339 | | message: format!("{} is required.", name), [INFO] [stderr] 340 | | }); [INFO] [stderr] 341 | | } [INFO] [stderr] | |_____________- help: try this: `if obj.get(name.as_str()).is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/definition.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | / match state.get_required_attributes(typ.clone()) { [INFO] [stderr] 98 | | Some(set) => { [INFO] [stderr] 99 | | for a in set { [INFO] [stderr] 100 | | if let None = obj.get(a.as_str()) { [INFO] [stderr] ... | [INFO] [stderr] 108 | | None => (), [INFO] [stderr] 109 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 97 | if let Some(set) = state.get_required_attributes(typ.clone()) { [INFO] [stderr] 98 | for a in set { [INFO] [stderr] 99 | if let None = obj.get(a.as_str()) { [INFO] [stderr] 100 | return Err(Error::MissingAttribute { [INFO] [stderr] 101 | path, [INFO] [stderr] 102 | attr: a.to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/definition.rs:100:28 [INFO] [stderr] | [INFO] [stderr] 100 | if let None = obj.get(a.as_str()) { [INFO] [stderr] | _____________________- ^^^^ [INFO] [stderr] 101 | | return Err(Error::MissingAttribute { [INFO] [stderr] 102 | | path, [INFO] [stderr] 103 | | attr: a.to_string(), [INFO] [stderr] 104 | | }); [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____________________- help: try this: `if obj.get(a.as_str()).is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/validator.rs:128:16 [INFO] [stderr] | [INFO] [stderr] 128 | if let Some(_) = self.defs.get(ptr.as_str()) { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 129 | | return Err(Error::DuplicatePointer { path, ptr }); [INFO] [stderr] 130 | | } [INFO] [stderr] | |_________- help: try this: `if self.defs.get(ptr.as_str()).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/validator.rs:156:24 [INFO] [stderr] | [INFO] [stderr] 156 | if let None = self.required_attrs.get(&t.typ()) { [INFO] [stderr] | _________________- ^^^^ [INFO] [stderr] 157 | | self.required_attrs.insert(t.typ(), HashSet::new()); [INFO] [stderr] 158 | | } [INFO] [stderr] | |_________________- help: try this: `if self.required_attrs.get(&t.typ()).is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/validator.rs:170:20 [INFO] [stderr] | [INFO] [stderr] 170 | if let None = self.unresolved_ptrs.get(target.as_str()) { [INFO] [stderr] | _____________- ^^^^ [INFO] [stderr] 171 | | self.unresolved_ptrs.insert(target.clone(), HashSet::new()); [INFO] [stderr] 172 | | } [INFO] [stderr] | |_____________- help: try this: `if self.unresolved_ptrs.get(target.as_str()).is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/validator.rs:204:9 [INFO] [stderr] | [INFO] [stderr] 204 | / for (target, sources) in &self.unresolved_ptrs { [INFO] [stderr] 205 | | return Some((target.clone(), sources.clone())); [INFO] [stderr] 206 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/definition.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | / match state.get_required_attributes(typ.clone()) { [INFO] [stderr] 98 | | Some(set) => { [INFO] [stderr] 99 | | for a in set { [INFO] [stderr] 100 | | if let None = obj.get(a.as_str()) { [INFO] [stderr] ... | [INFO] [stderr] 108 | | None => (), [INFO] [stderr] 109 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 97 | if let Some(set) = state.get_required_attributes(typ.clone()) { [INFO] [stderr] 98 | for a in set { [INFO] [stderr] 99 | if let None = obj.get(a.as_str()) { [INFO] [stderr] 100 | return Err(Error::MissingAttribute { [INFO] [stderr] 101 | path, [INFO] [stderr] 102 | attr: a.to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/definition.rs:100:28 [INFO] [stderr] | [INFO] [stderr] 100 | if let None = obj.get(a.as_str()) { [INFO] [stderr] | _____________________- ^^^^ [INFO] [stderr] 101 | | return Err(Error::MissingAttribute { [INFO] [stderr] 102 | | path, [INFO] [stderr] 103 | | attr: a.to_string(), [INFO] [stderr] 104 | | }); [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____________________- help: try this: `if obj.get(a.as_str()).is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `json-model`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/validator.rs:128:16 [INFO] [stderr] | [INFO] [stderr] 128 | if let Some(_) = self.defs.get(ptr.as_str()) { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 129 | | return Err(Error::DuplicatePointer { path, ptr }); [INFO] [stderr] 130 | | } [INFO] [stderr] | |_________- help: try this: `if self.defs.get(ptr.as_str()).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/validator.rs:156:24 [INFO] [stderr] | [INFO] [stderr] 156 | if let None = self.required_attrs.get(&t.typ()) { [INFO] [stderr] | _________________- ^^^^ [INFO] [stderr] 157 | | self.required_attrs.insert(t.typ(), HashSet::new()); [INFO] [stderr] 158 | | } [INFO] [stderr] | |_________________- help: try this: `if self.required_attrs.get(&t.typ()).is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/validator.rs:170:20 [INFO] [stderr] | [INFO] [stderr] 170 | if let None = self.unresolved_ptrs.get(target.as_str()) { [INFO] [stderr] | _____________- ^^^^ [INFO] [stderr] 171 | | self.unresolved_ptrs.insert(target.clone(), HashSet::new()); [INFO] [stderr] 172 | | } [INFO] [stderr] | |_____________- help: try this: `if self.unresolved_ptrs.get(target.as_str()).is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/validator.rs:204:9 [INFO] [stderr] | [INFO] [stderr] 204 | / for (target, sources) in &self.unresolved_ptrs { [INFO] [stderr] 205 | | return Some((target.clone(), sources.clone())); [INFO] [stderr] 206 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `json-model`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "2cd24f8feb55ce7396518b37650c0e86f033452752623caef232ac5cd50b1603"` [INFO] running `"docker" "rm" "-f" "2cd24f8feb55ce7396518b37650c0e86f033452752623caef232ac5cd50b1603"` [INFO] [stdout] 2cd24f8feb55ce7396518b37650c0e86f033452752623caef232ac5cd50b1603