[INFO] crate json-color 0.7.0 is already in cache [INFO] extracting crate json-color 0.7.0 into work/ex/clippy-test-run/sources/stable/reg/json-color/0.7.0 [INFO] extracting crate json-color 0.7.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/json-color/0.7.0 [INFO] validating manifest of json-color-0.7.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of json-color-0.7.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing json-color-0.7.0 [INFO] finished frobbing json-color-0.7.0 [INFO] frobbed toml for json-color-0.7.0 written to work/ex/clippy-test-run/sources/stable/reg/json-color/0.7.0/Cargo.toml [INFO] started frobbing json-color-0.7.0 [INFO] finished frobbing json-color-0.7.0 [INFO] frobbed toml for json-color-0.7.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/json-color/0.7.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting json-color-0.7.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/json-color/0.7.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 14c741bd066e427c4f061b55a4bdaab5a925aa2ae3961550497d9d6df1a8faad [INFO] running `"docker" "start" "-a" "14c741bd066e427c4f061b55a4bdaab5a925aa2ae3961550497d9d6df1a8faad"` [INFO] [stderr] Checking json-color v0.7.0 (/opt/crater/workdir) [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | let colored_string = match *$color { [INFO] [stderr] | ^^^^^^^ help: try this: `self.null` [INFO] [stderr] ... [INFO] [stderr] 221 | write!(writer, "{}", colorize!("null", &self.null)) [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | let colored_string = match *$color { [INFO] [stderr] | ^^^^^^^ help: try this: `self.boolean` [INFO] [stderr] ... [INFO] [stderr] 228 | write!(writer, "{}", colorize!(&value_as_string, &self.boolean)) [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | let colored_string = match *$color { [INFO] [stderr] | ^^^^^^^ help: try this: `self.number` [INFO] [stderr] ... [INFO] [stderr] 235 | write!(writer, "{}", colorize!(&value_as_string, &self.number)) [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | let colored_string = match *$color { [INFO] [stderr] | ^^^^^^^ help: try this: `self.number` [INFO] [stderr] ... [INFO] [stderr] 242 | write!(writer, "{}", colorize!(&value_as_string, &self.number)) [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | let colored_string = match *$color { [INFO] [stderr] | ^^^^^^^ help: try this: `self.number` [INFO] [stderr] ... [INFO] [stderr] 249 | write!(writer, "{}", colorize!(&value_as_string, &self.number)) [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | let colored_string = match *$color { [INFO] [stderr] | ^^^^^^^ help: try this: `self.number` [INFO] [stderr] ... [INFO] [stderr] 256 | write!(writer, "{}", colorize!(&value_as_string, &self.number)) [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | let colored_string = match *$color { [INFO] [stderr] | ^^^^^^^ help: try this: `self.number` [INFO] [stderr] ... [INFO] [stderr] 263 | write!(writer, "{}", colorize!(&value_as_string, &self.number)) [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | let colored_string = match *$color { [INFO] [stderr] | ^^^^^^^ help: try this: `self.number` [INFO] [stderr] ... [INFO] [stderr] 270 | write!(writer, "{}", colorize!(&value_as_string, &self.number)) [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | let colored_string = match *$color { [INFO] [stderr] | ^^^^^^^ help: try this: `self.number` [INFO] [stderr] ... [INFO] [stderr] 277 | write!(writer, "{}", colorize!(&value_as_string, &self.number)) [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | let colored_string = match *$color { [INFO] [stderr] | ^^^^^^^ help: try this: `self.number` [INFO] [stderr] ... [INFO] [stderr] 284 | write!(writer, "{}", colorize!(&value_as_string, &self.number)) [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | let colored_string = match *$color { [INFO] [stderr] | ^^^^^^^ help: try this: `self.number` [INFO] [stderr] ... [INFO] [stderr] 291 | write!(writer, "{}", colorize!(&value_as_string, &self.number)) [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | let colored_string = match *$color { [INFO] [stderr] | ^^^^^^^ help: try this: `self.number` [INFO] [stderr] ... [INFO] [stderr] 298 | write!(writer, "{}", colorize!(&value_as_string, &self.number)) [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | let colored_string = match *$color { [INFO] [stderr] | ^^^^^^^ help: try this: `self.escape_sequence` [INFO] [stderr] ... [INFO] [stderr] 343 | return write!(writer, "{}", colorize!(bytes, &self.escape_sequence)); [INFO] [stderr] | --------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | let colored_string = match *$color { [INFO] [stderr] | ^^^^^^^ help: try this: `self.escape_sequence` [INFO] [stderr] ... [INFO] [stderr] 347 | write!(writer, "{}", colorize!(s, &self.escape_sequence)) [INFO] [stderr] | ----------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | let colored_string = match *$color { [INFO] [stderr] | ^^^^^^^ help: try this: `self.null` [INFO] [stderr] ... [INFO] [stderr] 221 | write!(writer, "{}", colorize!("null", &self.null)) [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | let colored_string = match *$color { [INFO] [stderr] | ^^^^^^^ help: try this: `self.boolean` [INFO] [stderr] ... [INFO] [stderr] 228 | write!(writer, "{}", colorize!(&value_as_string, &self.boolean)) [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | let colored_string = match *$color { [INFO] [stderr] | ^^^^^^^ help: try this: `self.number` [INFO] [stderr] ... [INFO] [stderr] 235 | write!(writer, "{}", colorize!(&value_as_string, &self.number)) [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | let colored_string = match *$color { [INFO] [stderr] | ^^^^^^^ help: try this: `self.number` [INFO] [stderr] ... [INFO] [stderr] 242 | write!(writer, "{}", colorize!(&value_as_string, &self.number)) [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | let colored_string = match *$color { [INFO] [stderr] | ^^^^^^^ help: try this: `self.number` [INFO] [stderr] ... [INFO] [stderr] 249 | write!(writer, "{}", colorize!(&value_as_string, &self.number)) [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | let colored_string = match *$color { [INFO] [stderr] | ^^^^^^^ help: try this: `self.number` [INFO] [stderr] ... [INFO] [stderr] 256 | write!(writer, "{}", colorize!(&value_as_string, &self.number)) [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | let colored_string = match *$color { [INFO] [stderr] | ^^^^^^^ help: try this: `self.number` [INFO] [stderr] ... [INFO] [stderr] 263 | write!(writer, "{}", colorize!(&value_as_string, &self.number)) [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | let colored_string = match *$color { [INFO] [stderr] | ^^^^^^^ help: try this: `self.number` [INFO] [stderr] ... [INFO] [stderr] 270 | write!(writer, "{}", colorize!(&value_as_string, &self.number)) [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | let colored_string = match *$color { [INFO] [stderr] | ^^^^^^^ help: try this: `self.number` [INFO] [stderr] ... [INFO] [stderr] 277 | write!(writer, "{}", colorize!(&value_as_string, &self.number)) [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | let colored_string = match *$color { [INFO] [stderr] | ^^^^^^^ help: try this: `self.number` [INFO] [stderr] ... [INFO] [stderr] 284 | write!(writer, "{}", colorize!(&value_as_string, &self.number)) [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | let colored_string = match *$color { [INFO] [stderr] | ^^^^^^^ help: try this: `self.number` [INFO] [stderr] ... [INFO] [stderr] 291 | write!(writer, "{}", colorize!(&value_as_string, &self.number)) [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | let colored_string = match *$color { [INFO] [stderr] | ^^^^^^^ help: try this: `self.number` [INFO] [stderr] ... [INFO] [stderr] 298 | write!(writer, "{}", colorize!(&value_as_string, &self.number)) [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | let colored_string = match *$color { [INFO] [stderr] | ^^^^^^^ help: try this: `self.escape_sequence` [INFO] [stderr] ... [INFO] [stderr] 343 | return write!(writer, "{}", colorize!(bytes, &self.escape_sequence)); [INFO] [stderr] | --------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | let colored_string = match *$color { [INFO] [stderr] | ^^^^^^^ help: try this: `self.escape_sequence` [INFO] [stderr] ... [INFO] [stderr] 347 | write!(writer, "{}", colorize!(s, &self.escape_sequence)) [INFO] [stderr] | ----------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/lib.rs:138:5 [INFO] [stderr] | [INFO] [stderr] 138 | / pub fn new() -> ColorizerBuilder { [INFO] [stderr] 139 | | ColorizerBuilder::new() [INFO] [stderr] 140 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/lib.rs:138:5 [INFO] [stderr] | [INFO] [stderr] 138 | / pub fn new() -> ColorizerBuilder { [INFO] [stderr] 139 | | ColorizerBuilder::new() [INFO] [stderr] 140 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.42s [INFO] running `"docker" "inspect" "14c741bd066e427c4f061b55a4bdaab5a925aa2ae3961550497d9d6df1a8faad"` [INFO] running `"docker" "rm" "-f" "14c741bd066e427c4f061b55a4bdaab5a925aa2ae3961550497d9d6df1a8faad"` [INFO] [stdout] 14c741bd066e427c4f061b55a4bdaab5a925aa2ae3961550497d9d6df1a8faad