[INFO] crate jrpc 0.4.0 is already in cache [INFO] extracting crate jrpc 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/jrpc/0.4.0 [INFO] extracting crate jrpc 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/jrpc/0.4.0 [INFO] validating manifest of jrpc-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jrpc-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jrpc-0.4.0 [INFO] finished frobbing jrpc-0.4.0 [INFO] frobbed toml for jrpc-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/jrpc/0.4.0/Cargo.toml [INFO] started frobbing jrpc-0.4.0 [INFO] finished frobbing jrpc-0.4.0 [INFO] frobbed toml for jrpc-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/jrpc/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jrpc-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/jrpc/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7ed1fbd9bd9a5ec933c4746a0f13d09bfabf7c7cae3b4bad9cf047c2c735b76c [INFO] running `"docker" "start" "-a" "7ed1fbd9bd9a5ec933c4746a0f13d09bfabf7c7cae3b4bad9cf047c2c735b76c"` [INFO] [stderr] Checking jrpc v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `redundant_field_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:111:10 [INFO] [stderr] | [INFO] [stderr] 111 | #![allow(redundant_field_names)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_field_names` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `redundant_field_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:111:10 [INFO] [stderr] | [INFO] [stderr] 111 | #![allow(redundant_field_names)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_field_names` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `redundant_field_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:111:10 [INFO] [stderr] | [INFO] [stderr] 111 | #![allow(redundant_field_names)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_field_names` [INFO] [stderr] [INFO] [stderr] warning: lint name `redundant_field_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:111:10 [INFO] [stderr] | [INFO] [stderr] 111 | #![allow(redundant_field_names)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_field_names` [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:268:18 [INFO] [stderr] | [INFO] [stderr] 268 | pub fn to_id(self) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:362:5 [INFO] [stderr] | [INFO] [stderr] 362 | / pub fn from_str(s: &str) -> serde_json::Result { [INFO] [stderr] 363 | | serde_json::from_str(s) [INFO] [stderr] 364 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:639:5 [INFO] [stderr] | [INFO] [stderr] 639 | / pub fn from_str(s: &str) -> serde_json::Result { [INFO] [stderr] 640 | | serde_json::from_str(s) [INFO] [stderr] 641 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:704:5 [INFO] [stderr] | [INFO] [stderr] 704 | / pub fn from_str(s: &str) -> serde_json::Result { [INFO] [stderr] 705 | | serde_json::from_str(s) [INFO] [stderr] 706 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:795:5 [INFO] [stderr] | [INFO] [stderr] 795 | / pub fn from_str(s: &str) -> serde_json::Result { [INFO] [stderr] 796 | | serde_json::from_str(s) [INFO] [stderr] 797 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:268:18 [INFO] [stderr] | [INFO] [stderr] 268 | pub fn to_id(self) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:362:5 [INFO] [stderr] | [INFO] [stderr] 362 | / pub fn from_str(s: &str) -> serde_json::Result { [INFO] [stderr] 363 | | serde_json::from_str(s) [INFO] [stderr] 364 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:639:5 [INFO] [stderr] | [INFO] [stderr] 639 | / pub fn from_str(s: &str) -> serde_json::Result { [INFO] [stderr] 640 | | serde_json::from_str(s) [INFO] [stderr] 641 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:704:5 [INFO] [stderr] | [INFO] [stderr] 704 | / pub fn from_str(s: &str) -> serde_json::Result { [INFO] [stderr] 705 | | serde_json::from_str(s) [INFO] [stderr] 706 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:795:5 [INFO] [stderr] | [INFO] [stderr] 795 | / pub fn from_str(s: &str) -> serde_json::Result { [INFO] [stderr] 796 | | serde_json::from_str(s) [INFO] [stderr] 797 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.47s [INFO] running `"docker" "inspect" "7ed1fbd9bd9a5ec933c4746a0f13d09bfabf7c7cae3b4bad9cf047c2c735b76c"` [INFO] running `"docker" "rm" "-f" "7ed1fbd9bd9a5ec933c4746a0f13d09bfabf7c7cae3b4bad9cf047c2c735b76c"` [INFO] [stdout] 7ed1fbd9bd9a5ec933c4746a0f13d09bfabf7c7cae3b4bad9cf047c2c735b76c