[INFO] crate jrnl 0.1.1 is already in cache [INFO] extracting crate jrnl 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/jrnl/0.1.1 [INFO] extracting crate jrnl 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/jrnl/0.1.1 [INFO] validating manifest of jrnl-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jrnl-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jrnl-0.1.1 [INFO] finished frobbing jrnl-0.1.1 [INFO] frobbed toml for jrnl-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/jrnl/0.1.1/Cargo.toml [INFO] started frobbing jrnl-0.1.1 [INFO] finished frobbing jrnl-0.1.1 [INFO] frobbed toml for jrnl-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/jrnl/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jrnl-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/jrnl/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e0bb5e629e74c0a8ac112e898e954dbc33f838a3a0fd1fe6982dae4257b2274f [INFO] running `"docker" "start" "-a" "e0bb5e629e74c0a8ac112e898e954dbc33f838a3a0fd1fe6982dae4257b2274f"` [INFO] [stderr] Checking heck v0.3.1 [INFO] [stderr] Compiling configure_derive v0.1.1 [INFO] [stderr] Checking erased-serde v0.3.8 [INFO] [stderr] Checking configure v0.1.1 [INFO] [stderr] Checking jrnl v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/jrnl.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | v [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/jrnl.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | let v = stdin.lock().lines().map(|x| x.unwrap()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/bin/jrnl.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | Journal::from_file(&cfg.data_file).unwrap_or(Journal::default()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `Journal::from_file(&cfg.data_file).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/jrnl.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | v [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/jrnl.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | let v = stdin.lock().lines().map(|x| x.unwrap()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/bin/jrnl.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | Journal::from_file(&cfg.data_file).unwrap_or(Journal::default()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `Journal::from_file(&cfg.data_file).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.79s [INFO] running `"docker" "inspect" "e0bb5e629e74c0a8ac112e898e954dbc33f838a3a0fd1fe6982dae4257b2274f"` [INFO] running `"docker" "rm" "-f" "e0bb5e629e74c0a8ac112e898e954dbc33f838a3a0fd1fe6982dae4257b2274f"` [INFO] [stdout] e0bb5e629e74c0a8ac112e898e954dbc33f838a3a0fd1fe6982dae4257b2274f