[INFO] crate jpeg-decoder 0.1.15 is already in cache [INFO] extracting crate jpeg-decoder 0.1.15 into work/ex/clippy-test-run/sources/stable/reg/jpeg-decoder/0.1.15 [INFO] extracting crate jpeg-decoder 0.1.15 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/jpeg-decoder/0.1.15 [INFO] validating manifest of jpeg-decoder-0.1.15 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jpeg-decoder-0.1.15 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jpeg-decoder-0.1.15 [INFO] finished frobbing jpeg-decoder-0.1.15 [INFO] frobbed toml for jpeg-decoder-0.1.15 written to work/ex/clippy-test-run/sources/stable/reg/jpeg-decoder/0.1.15/Cargo.toml [INFO] started frobbing jpeg-decoder-0.1.15 [INFO] finished frobbing jpeg-decoder-0.1.15 [INFO] frobbed toml for jpeg-decoder-0.1.15 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/jpeg-decoder/0.1.15/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jpeg-decoder-0.1.15 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/jpeg-decoder/0.1.15:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 56c6e2412f2b47c0394ede8b55b6d0abfa8ed791981c2cb73c63d058143e72bb [INFO] running `"docker" "start" "-a" "56c6e2412f2b47c0394ede8b55b6d0abfa8ed791981c2cb73c63d058143e72bb"` [INFO] [stderr] Checking png v0.5.2 [INFO] [stderr] Checking docopt v0.7.0 [INFO] [stderr] Checking jpeg-decoder v0.1.15 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoder.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoder.rs:105:21 [INFO] [stderr] | [INFO] [stderr] 105 | pixel_format: pixel_format, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pixel_format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/huffman.rs:243:13 [INFO] [stderr] | [INFO] [stderr] 243 | delta: delta, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `delta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/huffman.rs:244:13 [INFO] [stderr] | [INFO] [stderr] 244 | maxcode: maxcode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `maxcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/huffman.rs:245:13 [INFO] [stderr] | [INFO] [stderr] 245 | lut: lut, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `lut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/huffman.rs:246:13 [INFO] [stderr] | [INFO] [stderr] 246 | ac_lut: ac_lut, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `ac_lut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | identifier: identifier, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `identifier` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | horizontal_sampling_factor: horizontal_sampling_factor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `horizontal_sampling_factor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | vertical_sampling_factor: vertical_sampling_factor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vertical_sampling_factor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:221:9 [INFO] [stderr] | [INFO] [stderr] 221 | is_baseline: is_baseline, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_baseline` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:222:9 [INFO] [stderr] | [INFO] [stderr] 222 | is_differential: is_differential, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_differential` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:223:9 [INFO] [stderr] | [INFO] [stderr] 223 | coding_process: coding_process, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `coding_process` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:224:9 [INFO] [stderr] | [INFO] [stderr] 224 | entropy_coding: entropy_coding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entropy_coding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:225:9 [INFO] [stderr] | [INFO] [stderr] 225 | precision: precision, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `precision` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | mcu_size: mcu_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mcu_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | components: components, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `components` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:226:33 [INFO] [stderr] | [INFO] [stderr] 226 | image_size: Dimensions {width: width, height: height}, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:226:47 [INFO] [stderr] | [INFO] [stderr] 226 | image_size: Dimensions {width: width, height: height}, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:328:9 [INFO] [stderr] | [INFO] [stderr] 328 | component_indices: component_indices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `component_indices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:329:9 [INFO] [stderr] | [INFO] [stderr] 329 | dc_table_indices: dc_table_indices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dc_table_indices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:330:9 [INFO] [stderr] | [INFO] [stderr] 330 | ac_table_indices: ac_table_indices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ac_table_indices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:335:9 [INFO] [stderr] | [INFO] [stderr] 335 | successive_approximation_high: successive_approximation_high, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `successive_approximation_high` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:336:9 [INFO] [stderr] | [INFO] [stderr] 336 | successive_approximation_low: successive_approximation_low, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `successive_approximation_low` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/upsampler.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | upsampler: upsampler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `upsampler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/idct.rs:39:64 [INFO] [stderr] | [INFO] [stderr] 39 | let p1 = p2.wrapping_add(p3).wrapping_mul(stbi_f2f(0.5411961)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.541_196_1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/idct.rs:40:64 [INFO] [stderr] | [INFO] [stderr] 40 | let t2 = p1.wrapping_add(p3.wrapping_mul(stbi_f2f(-1.847759065))); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `1.847_759_065` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/idct.rs:41:63 [INFO] [stderr] | [INFO] [stderr] 41 | let t3 = p1.wrapping_add(p2.wrapping_mul(stbi_f2f(0.765366865))); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.765_366_865` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/idct.rs:58:64 [INFO] [stderr] | [INFO] [stderr] 58 | let p5 = p3.wrapping_add(p4).wrapping_mul(stbi_f2f(1.175875602)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `1.175_875_602` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/idct.rs:59:47 [INFO] [stderr] | [INFO] [stderr] 59 | let t0 = t0.wrapping_mul(stbi_f2f(0.298631336)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.298_631_336` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/idct.rs:60:47 [INFO] [stderr] | [INFO] [stderr] 60 | let t1 = t1.wrapping_mul(stbi_f2f(2.053119869)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `2.053_119_869` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/idct.rs:61:47 [INFO] [stderr] | [INFO] [stderr] 61 | let t2 = t2.wrapping_mul(stbi_f2f(3.072711026)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `3.072_711_026` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/idct.rs:62:47 [INFO] [stderr] | [INFO] [stderr] 62 | let t3 = t3.wrapping_mul(stbi_f2f(1.501321110)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `1.501_321_110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/idct.rs:63:64 [INFO] [stderr] | [INFO] [stderr] 63 | let p1 = p5.wrapping_add(p1.wrapping_mul(stbi_f2f(-0.899976223))); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.899_976_223` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/idct.rs:64:64 [INFO] [stderr] | [INFO] [stderr] 64 | let p2 = p5.wrapping_add(p2.wrapping_mul(stbi_f2f(-2.562915447))); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `2.562_915_447` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/idct.rs:65:48 [INFO] [stderr] | [INFO] [stderr] 65 | let p3 = p3.wrapping_mul(stbi_f2f(-1.961570560)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `1.961_570_560` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/idct.rs:66:48 [INFO] [stderr] | [INFO] [stderr] 66 | let p4 = p4.wrapping_mul(stbi_f2f(-0.390180644)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.390_180_644` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/idct.rs:103:60 [INFO] [stderr] | [INFO] [stderr] 103 | let p1 = p2.wrapping_add(p3).wrapping_mul(stbi_f2f(0.5411961)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.541_196_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/idct.rs:104:60 [INFO] [stderr] | [INFO] [stderr] 104 | let t2 = p1.wrapping_add(p3.wrapping_mul(stbi_f2f(-1.847759065))); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `1.847_759_065` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/idct.rs:105:59 [INFO] [stderr] | [INFO] [stderr] 105 | let t3 = p1.wrapping_add(p2.wrapping_mul(stbi_f2f(0.765366865))); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.765_366_865` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/idct.rs:122:60 [INFO] [stderr] | [INFO] [stderr] 122 | let p5 = p3.wrapping_add(p4).wrapping_mul(stbi_f2f(1.175875602)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `1.175_875_602` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/idct.rs:123:43 [INFO] [stderr] | [INFO] [stderr] 123 | let t0 = t0.wrapping_mul(stbi_f2f(0.298631336)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.298_631_336` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/idct.rs:124:43 [INFO] [stderr] | [INFO] [stderr] 124 | let t1 = t1.wrapping_mul(stbi_f2f(2.053119869)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `2.053_119_869` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/idct.rs:125:43 [INFO] [stderr] | [INFO] [stderr] 125 | let t2 = t2.wrapping_mul(stbi_f2f(3.072711026)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `3.072_711_026` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/idct.rs:126:43 [INFO] [stderr] | [INFO] [stderr] 126 | let t3 = t3.wrapping_mul(stbi_f2f(1.501321110)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `1.501_321_110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/idct.rs:127:60 [INFO] [stderr] | [INFO] [stderr] 127 | let p1 = p5.wrapping_add(p1.wrapping_mul(stbi_f2f(-0.899976223))); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.899_976_223` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/idct.rs:128:60 [INFO] [stderr] | [INFO] [stderr] 128 | let p2 = p5.wrapping_add(p2.wrapping_mul(stbi_f2f(-2.562915447))); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `2.562_915_447` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/idct.rs:129:44 [INFO] [stderr] | [INFO] [stderr] 129 | let p3 = p3.wrapping_mul(stbi_f2f(-1.961570560)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `1.961_570_560` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/idct.rs:130:44 [INFO] [stderr] | [INFO] [stderr] 130 | let p4 = p4.wrapping_mul(stbi_f2f(-0.390180644)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.390_180_644` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/upsampler.rs:96:10 [INFO] [stderr] | [INFO] [stderr] 96 | else { [INFO] [stderr] | __________^ [INFO] [stderr] 97 | | if max_sampling_factors.0 % sampling_factors.0 != 0 || max_sampling_factors.1 % sampling_factors.1 != 0 { [INFO] [stderr] 98 | | Err(Error::Unsupported(UnsupportedFeature::NonIntegerSubsamplingRatio)) [INFO] [stderr] 99 | | } [INFO] [stderr] ... | [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 96 | else if max_sampling_factors.0 % sampling_factors.0 != 0 || max_sampling_factors.1 % sampling_factors.1 != 0 { [INFO] [stderr] 97 | Err(Error::Unsupported(UnsupportedFeature::NonIntegerSubsamplingRatio)) [INFO] [stderr] 98 | } [INFO] [stderr] 99 | else { [INFO] [stderr] 100 | Ok(Box::new(UpsamplerGeneric { [INFO] [stderr] 101 | horizontal_scaling_factor: max_sampling_factors.0 / sampling_factors.0, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/decoder.rs:235:47 [INFO] [stderr] | [INFO] [stderr] 235 | for (i, &table) in tables.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/decoder.rs:361:23 [INFO] [stderr] | [INFO] [stderr] 361 | -> Result<(Option, Option>>)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:401:59 [INFO] [stderr] | [INFO] [stderr] 401 | .map(|c| c.horizontal_sampling_factor as u16 * c.vertical_sampling_factor as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(c.horizontal_sampling_factor)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:401:97 [INFO] [stderr] | [INFO] [stderr] 401 | .map(|c| c.horizontal_sampling_factor as u16 * c.vertical_sampling_factor as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(c.vertical_sampling_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:426:38 [INFO] [stderr] | [INFO] [stderr] 426 | (mcu_x * component.horizontal_sampling_factor as u16 + j % component.horizontal_sampling_factor as u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(component.horizontal_sampling_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:426:88 [INFO] [stderr] | [INFO] [stderr] 426 | (mcu_x * component.horizontal_sampling_factor as u16 + j % component.horizontal_sampling_factor as u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(component.horizontal_sampling_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:427:38 [INFO] [stderr] | [INFO] [stderr] 427 | mcu_y * component.vertical_sampling_factor as u16 + j / component.horizontal_sampling_factor as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(component.vertical_sampling_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:427:86 [INFO] [stderr] | [INFO] [stderr] 427 | mcu_y * component.vertical_sampling_factor as u16 + j / component.horizontal_sampling_factor as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(component.horizontal_sampling_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/decoder.rs:541:1 [INFO] [stderr] | [INFO] [stderr] 541 | / fn decode_block(reader: &mut R, [INFO] [stderr] 542 | | coefficients: &mut [i16], [INFO] [stderr] 543 | | huffman: &mut HuffmanDecoder, [INFO] [stderr] 544 | | dc_table: Option<&HuffmanTable>, [INFO] [stderr] ... | [INFO] [stderr] 626 | | Ok(()) [INFO] [stderr] 627 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:888:13 [INFO] [stderr] | [INFO] [stderr] 888 | let y = y as f32; [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:889:14 [INFO] [stderr] | [INFO] [stderr] 889 | let cb = cb as f32 - 128.0; [INFO] [stderr] | ^^^^^^^^^ help: try: `f32::from(cb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:890:14 [INFO] [stderr] | [INFO] [stderr] 890 | let cr = cr as f32 - 128.0; [INFO] [stderr] | ^^^^^^^^^ help: try: `f32::from(cr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/huffman.rs:43:28 [INFO] [stderr] | [INFO] [stderr] 43 | let code = (bits >> (15 - i)) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(bits >> (15 - i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/huffman.rs:152:26 [INFO] [stderr] | [INFO] [stderr] 152 | self.bits |= (byte as u64) << (56 - self.num_bits); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/huffman.rs:163:20 [INFO] [stderr] | [INFO] [stderr] 163 | let vt = 1 << (count as u16 - 1); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/huffman.rs:166:31 [INFO] [stderr] | [INFO] [stderr] 166 | value as i16 + (-1 << count as i16) + 1 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i16::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/huffman.rs:200:39 [INFO] [stderr] | [INFO] [stderr] 200 | delta[i] = j as i32 - huffcode[j] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(huffcode[j])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/huffman.rs:202:30 [INFO] [stderr] | [INFO] [stderr] 202 | maxcode[i] = huffcode[j - 1] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(huffcode[j - 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/idct.rs:17:27 [INFO] [stderr] | [INFO] [stderr] 17 | let dcterm = (coefficients[i] as i32 * quantization_table[i] as i32).wrapping_shl(2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(coefficients[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/idct.rs:17:52 [INFO] [stderr] | [INFO] [stderr] 17 | let dcterm = (coefficients[i] as i32 * quantization_table[i] as i32).wrapping_shl(2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(quantization_table[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/idct.rs:28:22 [INFO] [stderr] | [INFO] [stderr] 28 | let s0 = coefficients[i] as i32 * quantization_table[i] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(coefficients[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/idct.rs:28:52 [INFO] [stderr] | [INFO] [stderr] 28 | let s0 = coefficients[i] as i32 * quantization_table[i] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(quantization_table[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/idct.rs:29:22 [INFO] [stderr] | [INFO] [stderr] 29 | let s1 = coefficients[i + 8] as i32 * quantization_table[i + 8] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(coefficients[i + 8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/idct.rs:29:52 [INFO] [stderr] | [INFO] [stderr] 29 | let s1 = coefficients[i + 8] as i32 * quantization_table[i + 8] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(quantization_table[i + 8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/idct.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | let s2 = coefficients[i + 16] as i32 * quantization_table[i + 16] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(coefficients[i + 16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/idct.rs:30:52 [INFO] [stderr] | [INFO] [stderr] 30 | let s2 = coefficients[i + 16] as i32 * quantization_table[i + 16] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(quantization_table[i + 16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/idct.rs:31:22 [INFO] [stderr] | [INFO] [stderr] 31 | let s3 = coefficients[i + 24] as i32 * quantization_table[i + 24] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(coefficients[i + 24])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/idct.rs:31:52 [INFO] [stderr] | [INFO] [stderr] 31 | let s3 = coefficients[i + 24] as i32 * quantization_table[i + 24] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(quantization_table[i + 24])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/idct.rs:32:22 [INFO] [stderr] | [INFO] [stderr] 32 | let s4 = coefficients[i + 32] as i32 * quantization_table[i + 32] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(coefficients[i + 32])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/idct.rs:32:52 [INFO] [stderr] | [INFO] [stderr] 32 | let s4 = coefficients[i + 32] as i32 * quantization_table[i + 32] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(quantization_table[i + 32])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/idct.rs:33:22 [INFO] [stderr] | [INFO] [stderr] 33 | let s5 = coefficients[i + 40] as i32 * quantization_table[i + 40] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(coefficients[i + 40])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/idct.rs:33:52 [INFO] [stderr] | [INFO] [stderr] 33 | let s5 = coefficients[i + 40] as i32 * quantization_table[i + 40] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(quantization_table[i + 40])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/idct.rs:34:22 [INFO] [stderr] | [INFO] [stderr] 34 | let s6 = coefficients[i + 48] as i32 * quantization_table[i + 48] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(coefficients[i + 48])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/idct.rs:34:52 [INFO] [stderr] | [INFO] [stderr] 34 | let s6 = coefficients[i + 48] as i32 * quantization_table[i + 48] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(quantization_table[i + 48])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/idct.rs:35:22 [INFO] [stderr] | [INFO] [stderr] 35 | let s7 = coefficients[i + 56] as i32 * quantization_table[i + 56] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(coefficients[i + 56])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/idct.rs:35:52 [INFO] [stderr] | [INFO] [stderr] 35 | let s7 = coefficients[i + 56] as i32 * quantization_table[i + 56] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(quantization_table[i + 56])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/idct.rs:40:64 [INFO] [stderr] | [INFO] [stderr] 40 | let t2 = p1.wrapping_add(p3.wrapping_mul(stbi_f2f(-1.847759065))); [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.847_759` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/idct.rs:41:63 [INFO] [stderr] | [INFO] [stderr] 41 | let t3 = p1.wrapping_add(p2.wrapping_mul(stbi_f2f(0.765366865))); [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.765_366_85` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/idct.rs:58:64 [INFO] [stderr] | [INFO] [stderr] 58 | let p5 = p3.wrapping_add(p4).wrapping_mul(stbi_f2f(1.175875602)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.175_875_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/idct.rs:59:47 [INFO] [stderr] | [INFO] [stderr] 59 | let t0 = t0.wrapping_mul(stbi_f2f(0.298631336)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.298_631_34` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/idct.rs:60:47 [INFO] [stderr] | [INFO] [stderr] 60 | let t1 = t1.wrapping_mul(stbi_f2f(2.053119869)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `2.053_12` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/idct.rs:61:47 [INFO] [stderr] | [INFO] [stderr] 61 | let t2 = t2.wrapping_mul(stbi_f2f(3.072711026)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `3.072_711` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/idct.rs:62:47 [INFO] [stderr] | [INFO] [stderr] 62 | let t3 = t3.wrapping_mul(stbi_f2f(1.501321110)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.501_321_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/idct.rs:63:64 [INFO] [stderr] | [INFO] [stderr] 63 | let p1 = p5.wrapping_add(p1.wrapping_mul(stbi_f2f(-0.899976223))); [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.899_976_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/idct.rs:64:64 [INFO] [stderr] | [INFO] [stderr] 64 | let p2 = p5.wrapping_add(p2.wrapping_mul(stbi_f2f(-2.562915447))); [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `2.562_915_6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/idct.rs:65:48 [INFO] [stderr] | [INFO] [stderr] 65 | let p3 = p3.wrapping_mul(stbi_f2f(-1.961570560)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.961_570_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/idct.rs:66:48 [INFO] [stderr] | [INFO] [stderr] 66 | let p4 = p4.wrapping_mul(stbi_f2f(-0.390180644)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.390_180_65` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/idct.rs:104:60 [INFO] [stderr] | [INFO] [stderr] 104 | let t2 = p1.wrapping_add(p3.wrapping_mul(stbi_f2f(-1.847759065))); [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.847_759` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/idct.rs:105:59 [INFO] [stderr] | [INFO] [stderr] 105 | let t3 = p1.wrapping_add(p2.wrapping_mul(stbi_f2f(0.765366865))); [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.765_366_85` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/idct.rs:122:60 [INFO] [stderr] | [INFO] [stderr] 122 | let p5 = p3.wrapping_add(p4).wrapping_mul(stbi_f2f(1.175875602)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.175_875_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/idct.rs:123:43 [INFO] [stderr] | [INFO] [stderr] 123 | let t0 = t0.wrapping_mul(stbi_f2f(0.298631336)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.298_631_34` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/idct.rs:124:43 [INFO] [stderr] | [INFO] [stderr] 124 | let t1 = t1.wrapping_mul(stbi_f2f(2.053119869)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `2.053_12` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/idct.rs:125:43 [INFO] [stderr] | [INFO] [stderr] 125 | let t2 = t2.wrapping_mul(stbi_f2f(3.072711026)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `3.072_711` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/idct.rs:126:43 [INFO] [stderr] | [INFO] [stderr] 126 | let t3 = t3.wrapping_mul(stbi_f2f(1.501321110)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.501_321_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/idct.rs:127:60 [INFO] [stderr] | [INFO] [stderr] 127 | let p1 = p5.wrapping_add(p1.wrapping_mul(stbi_f2f(-0.899976223))); [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.899_976_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/idct.rs:128:60 [INFO] [stderr] | [INFO] [stderr] 128 | let p2 = p5.wrapping_add(p2.wrapping_mul(stbi_f2f(-2.562915447))); [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `2.562_915_6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/idct.rs:129:44 [INFO] [stderr] | [INFO] [stderr] 129 | let p3 = p3.wrapping_mul(stbi_f2f(-1.961570560)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.961_570_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/idct.rs:130:44 [INFO] [stderr] | [INFO] [stderr] 130 | let p4 = p4.wrapping_mul(stbi_f2f(-0.390180644)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.390_180_65` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:208:17 [INFO] [stderr] | [INFO] [stderr] 208 | width: (width as f32 / (h_max as f32 * 8.0)).ceil() as u16, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:208:33 [INFO] [stderr] | [INFO] [stderr] 208 | width: (width as f32 / (h_max as f32 * 8.0)).ceil() as u16, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(h_max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:209:18 [INFO] [stderr] | [INFO] [stderr] 209 | height: (height as f32 / (v_max as f32 * 8.0)).ceil() as u16, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:209:35 [INFO] [stderr] | [INFO] [stderr] 209 | height: (height as f32 / (v_max as f32 * 8.0)).ceil() as u16, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(v_max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:213:33 [INFO] [stderr] | [INFO] [stderr] 213 | component.size.width = (width as f32 * (component.horizontal_sampling_factor as f32 / h_max as f32)).ceil() as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:213:49 [INFO] [stderr] | [INFO] [stderr] 213 | component.size.width = (width as f32 * (component.horizontal_sampling_factor as f32 / h_max as f32)).ceil() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(component.horizontal_sampling_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:213:95 [INFO] [stderr] | [INFO] [stderr] 213 | component.size.width = (width as f32 * (component.horizontal_sampling_factor as f32 / h_max as f32)).ceil() as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(h_max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:214:34 [INFO] [stderr] | [INFO] [stderr] 214 | component.size.height = (height as f32 * (component.vertical_sampling_factor as f32 / v_max as f32)).ceil() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:214:51 [INFO] [stderr] | [INFO] [stderr] 214 | component.size.height = (height as f32 * (component.vertical_sampling_factor as f32 / v_max as f32)).ceil() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(component.vertical_sampling_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:214:95 [INFO] [stderr] | [INFO] [stderr] 214 | component.size.height = (height as f32 * (component.vertical_sampling_factor as f32 / v_max as f32)).ceil() as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(v_max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:216:55 [INFO] [stderr] | [INFO] [stderr] 216 | component.block_size.width = mcu_size.width * component.horizontal_sampling_factor as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(component.horizontal_sampling_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:217:57 [INFO] [stderr] | [INFO] [stderr] 217 | component.block_size.height = mcu_size.height * component.vertical_sampling_factor as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(component.vertical_sampling_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:284:9 [INFO] [stderr] | [INFO] [stderr] 284 | frame.components[i].horizontal_sampling_factor as u32 * frame.components[i].vertical_sampling_factor as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(frame.components[i].horizontal_sampling_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:284:65 [INFO] [stderr] | [INFO] [stderr] 284 | frame.components[i].horizontal_sampling_factor as u32 * frame.components[i].vertical_sampling_factor as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(frame.components[i].vertical_sampling_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/parser.rs:331:29 [INFO] [stderr] | [INFO] [stderr] 331 | spectral_selection: Range { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 332 | | start: spectral_selection_start, [INFO] [stderr] 333 | | end: spectral_selection_end + 1, [INFO] [stderr] 334 | | }, [INFO] [stderr] | |_________^ help: use: `spectral_selection_start..=spectral_selection_end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `table`. [INFO] [stderr] --> src/parser.rs:371:18 [INFO] [stderr] | [INFO] [stderr] 371 | for i in 0 .. 64 { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 371 | for in &mut table { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:373:22 [INFO] [stderr] | [INFO] [stderr] 373 | 0 => reader.read_u8()? as u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/parser.rs:391:73 [INFO] [stderr] | [INFO] [stderr] 391 | pub fn parse_dht(reader: &mut R, is_baseline: Option) -> Result<(Vec>, Vec>)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/parser.rs:481:20 [INFO] [stderr] | [INFO] [stderr] 481 | if &buffer[0 .. 5] == &[b'J', b'F', b'I', b'F', b'\0'] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 481 | if buffer[0 .. 5] == [b'J', b'F', b'I', b'F', b'\0'] { [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/parser.rs:484:27 [INFO] [stderr] | [INFO] [stderr] 484 | } else if &buffer[0 .. 5] == &[b'A', b'V', b'I', b'1', b'\0'] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 484 | } else if buffer[0 .. 5] == [b'A', b'V', b'I', b'1', b'\0'] { [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/parser.rs:496:20 [INFO] [stderr] | [INFO] [stderr] 496 | if &buffer[0 .. 6] == &[b'A', b'd', b'o', b'b', b'e', b'\0'] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 496 | if buffer[0 .. 6] == [b'A', b'd', b'o', b'b', b'e', b'\0'] { [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/upsampler.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | / fn upsample_row(&self, [INFO] [stderr] 111 | | input: &[u8], [INFO] [stderr] 112 | | input_width: usize, [INFO] [stderr] 113 | | input_height: usize, [INFO] [stderr] ... | [INFO] [stderr] 116 | | output_width: usize, [INFO] [stderr] 117 | | output: &mut [u8]); [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/upsampler.rs:131:18 [INFO] [stderr] | [INFO] [stderr] 131 | for i in 0 .. output_width { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `output[..output_width].clone_from_slice(&input[..output_width])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/upsampler.rs:155:23 [INFO] [stderr] | [INFO] [stderr] 155 | output[1] = ((input[0] as u32 * 3 + input[1] as u32 + 2) >> 2) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(input[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/upsampler.rs:155:45 [INFO] [stderr] | [INFO] [stderr] 155 | output[1] = ((input[0] as u32 * 3 + input[1] as u32 + 2) >> 2) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(input[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/upsampler.rs:158:30 [INFO] [stderr] | [INFO] [stderr] 158 | let sample = 3 * input[i] as u32 + 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(input[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/upsampler.rs:159:44 [INFO] [stderr] | [INFO] [stderr] 159 | output[i * 2] = ((sample + input[i - 1] as u32) >> 2) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(input[i - 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/upsampler.rs:160:44 [INFO] [stderr] | [INFO] [stderr] 160 | output[i * 2 + 1] = ((sample + input[i + 1] as u32) >> 2) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(input[i + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/upsampler.rs:163:43 [INFO] [stderr] | [INFO] [stderr] 163 | output[(input_width - 1) * 2] = ((input[input_width - 1] as u32 * 3 + input[input_width - 2] as u32 + 2) >> 2) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(input[input_width - 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/upsampler.rs:163:79 [INFO] [stderr] | [INFO] [stderr] 163 | output[(input_width - 1) * 2] = ((input[input_width - 1] as u32 * 3 + input[input_width - 2] as u32 + 2) >> 2) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(input[input_width - 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/upsampler.rs:186:31 [INFO] [stderr] | [INFO] [stderr] 186 | output[i] = ((3 * input_near[i] as u32 + input_far[i] as u32 + 2) >> 2) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(input_near[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/upsampler.rs:186:54 [INFO] [stderr] | [INFO] [stderr] 186 | output[i] = ((3 * input_near[i] as u32 + input_far[i] as u32 + 2) >> 2) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(input_far[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/upsampler.rs:209:31 [INFO] [stderr] | [INFO] [stderr] 209 | let value = ((3 * input_near[0] as u32 + input_far[0] as u32 + 2) >> 2) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(input_near[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/upsampler.rs:209:54 [INFO] [stderr] | [INFO] [stderr] 209 | let value = ((3 * input_near[0] as u32 + input_far[0] as u32 + 2) >> 2) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(input_far[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/upsampler.rs:215:26 [INFO] [stderr] | [INFO] [stderr] 215 | let mut t1 = 3 * input_near[0] as u32 + input_far[0] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(input_near[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/upsampler.rs:215:49 [INFO] [stderr] | [INFO] [stderr] 215 | let mut t1 = 3 * input_near[0] as u32 + input_far[0] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(input_far[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/upsampler.rs:220:22 [INFO] [stderr] | [INFO] [stderr] 220 | t1 = 3 * input_near[i] as u32 + input_far[i] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(input_near[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/upsampler.rs:220:45 [INFO] [stderr] | [INFO] [stderr] 220 | t1 = 3 * input_near[i] as u32 + input_far[i] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(input_far[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/worker/threaded.rs:43:12 [INFO] [stderr] | [INFO] [stderr] 43 | Ok(self.sender.send(WorkerMsg::Start(row_data))?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 43 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/worker/threaded.rs:46:12 [INFO] [stderr] | [INFO] [stderr] 46 | Ok(self.sender.send(WorkerMsg::AppendRow(row))?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 46 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `jpeg-decoder`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "56c6e2412f2b47c0394ede8b55b6d0abfa8ed791981c2cb73c63d058143e72bb"` [INFO] running `"docker" "rm" "-f" "56c6e2412f2b47c0394ede8b55b6d0abfa8ed791981c2cb73c63d058143e72bb"` [INFO] [stdout] 56c6e2412f2b47c0394ede8b55b6d0abfa8ed791981c2cb73c63d058143e72bb