[INFO] crate journal_gateway 0.2.1 is already in cache [INFO] extracting crate journal_gateway 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/journal_gateway/0.2.1 [INFO] extracting crate journal_gateway 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/journal_gateway/0.2.1 [INFO] validating manifest of journal_gateway-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of journal_gateway-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing journal_gateway-0.2.1 [INFO] finished frobbing journal_gateway-0.2.1 [INFO] frobbed toml for journal_gateway-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/journal_gateway/0.2.1/Cargo.toml [INFO] started frobbing journal_gateway-0.2.1 [INFO] finished frobbing journal_gateway-0.2.1 [INFO] frobbed toml for journal_gateway-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/journal_gateway/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting journal_gateway-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/journal_gateway/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e377efad850050b2dccf01c39a36504a50022f1be04eae029abb40c6283e754e [INFO] running `"docker" "start" "-a" "e377efad850050b2dccf01c39a36504a50022f1be04eae029abb40c6283e754e"` [INFO] [stderr] Checking journal_gateway v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | / match list.is_empty() { [INFO] [stderr] 189 | | true => Err(error::ErrorKind::NoEntries.into()), [INFO] [stderr] 190 | | false => Ok(list[0].clone()), [INFO] [stderr] 191 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if list.is_empty() { Err(error::ErrorKind::NoEntries.into()) } else { Ok(list[0].clone()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:242:32 [INFO] [stderr] | [INFO] [stderr] 242 | for line in body.split("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:243:16 [INFO] [stderr] | [INFO] [stderr] 243 | if line.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | / match list.is_empty() { [INFO] [stderr] 189 | | true => Err(error::ErrorKind::NoEntries.into()), [INFO] [stderr] 190 | | false => Ok(list[0].clone()), [INFO] [stderr] 191 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if list.is_empty() { Err(error::ErrorKind::NoEntries.into()) } else { Ok(list[0].clone()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:242:32 [INFO] [stderr] | [INFO] [stderr] 242 | for line in body.split("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:243:16 [INFO] [stderr] | [INFO] [stderr] 243 | if line.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.11s [INFO] running `"docker" "inspect" "e377efad850050b2dccf01c39a36504a50022f1be04eae029abb40c6283e754e"` [INFO] running `"docker" "rm" "-f" "e377efad850050b2dccf01c39a36504a50022f1be04eae029abb40c6283e754e"` [INFO] [stdout] e377efad850050b2dccf01c39a36504a50022f1be04eae029abb40c6283e754e