[INFO] crate joseki 0.0.1 is already in cache [INFO] extracting crate joseki 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/joseki/0.0.1 [INFO] extracting crate joseki 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/joseki/0.0.1 [INFO] validating manifest of joseki-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of joseki-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing joseki-0.0.1 [INFO] finished frobbing joseki-0.0.1 [INFO] frobbed toml for joseki-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/joseki/0.0.1/Cargo.toml [INFO] started frobbing joseki-0.0.1 [INFO] finished frobbing joseki-0.0.1 [INFO] frobbed toml for joseki-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/joseki/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting joseki-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/joseki/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fac4dd865bee74c9cd81c7320031c32e3855c2d3e25bd109c72ad448c59c99f5 [INFO] running `"docker" "start" "-a" "fac4dd865bee74c9cd81c7320031c32e3855c2d3e25bd109c72ad448c59c99f5"` [INFO] [stderr] Checking joseki v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/board.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | fn char(&self) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/board.rs:24:12 [INFO] [stderr] | [INFO] [stderr] 24 | fn not(&self) -> Stone { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/board.rs:81:48 [INFO] [stderr] | [INFO] [stderr] 81 | } else if self[(x, y)] != Stone::Empty { [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 82 | | return false; [INFO] [stderr] 83 | | } else if (x >= self.size) || (y >= self.size) { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/board.rs:79:34 [INFO] [stderr] | [INFO] [stderr] 79 | if stone == Stone::Empty { [INFO] [stderr] | __________________________________^ [INFO] [stderr] 80 | | return false; [INFO] [stderr] 81 | | } else if self[(x, y)] != Stone::Empty { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/board.rs:102:12 [INFO] [stderr] | [INFO] [stderr] 102 | if liberties.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `liberties.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/board.rs:113:41 [INFO] [stderr] | [INFO] [stderr] 113 | } else if stone == Stone::Empty { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 114 | | return false; [INFO] [stderr] 115 | | } else if !self.legal_move(stone, x, y) { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/board.rs:111:41 [INFO] [stderr] | [INFO] [stderr] 111 | if self[(x, y)] != Stone::Empty { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 112 | | return false; [INFO] [stderr] 113 | | } else if stone == Stone::Empty { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/board.rs:169:15 [INFO] [stderr] | [INFO] [stderr] 169 | while horizon.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!horizon.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/board.rs:198:15 [INFO] [stderr] | [INFO] [stderr] 198 | while horizon.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!horizon.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/board.rs:232:5 [INFO] [stderr] | [INFO] [stderr] 232 | / fn index<'a>(&'a self, index: (usize, usize)) -> &'a Stone { [INFO] [stderr] 233 | | let (x, y) = index; [INFO] [stderr] 234 | | &self.state[y * self.size + x] [INFO] [stderr] 235 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/board.rs:239:5 [INFO] [stderr] | [INFO] [stderr] 239 | / fn index_mut<'a>(&'a mut self, index: (usize, usize)) -> &'a mut Stone { [INFO] [stderr] 240 | | let (x, y) = index; [INFO] [stderr] 241 | | &mut self.state[y * self.size + x] [INFO] [stderr] 242 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::Game` [INFO] [stderr] --> src/game.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> Game { [INFO] [stderr] 21 | | Game { [INFO] [stderr] 22 | | board: Board::new(), [INFO] [stderr] 23 | | last_board: None, [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 18 | impl Default for game::Game { [INFO] [stderr] 19 | fn default() -> Self { [INFO] [stderr] 20 | Self::new() [INFO] [stderr] 21 | } [INFO] [stderr] 22 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/game.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / pub fn from_str(board: &str) -> Game { [INFO] [stderr] 31 | | Game { [INFO] [stderr] 32 | | board: Board::from_str(board), [INFO] [stderr] 33 | | last_board: None, [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/game.rs:133:54 [INFO] [stderr] | [INFO] [stderr] 133 | let black_player = self.clone().black_player.unwrap_or(unknown.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| unknown.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/game.rs:134:54 [INFO] [stderr] | [INFO] [stderr] 134 | let white_player = self.clone().white_player.unwrap_or(unknown.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| unknown.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `joseki`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/board.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | fn char(&self) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/board.rs:24:12 [INFO] [stderr] | [INFO] [stderr] 24 | fn not(&self) -> Stone { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/board.rs:81:48 [INFO] [stderr] | [INFO] [stderr] 81 | } else if self[(x, y)] != Stone::Empty { [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 82 | | return false; [INFO] [stderr] 83 | | } else if (x >= self.size) || (y >= self.size) { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/board.rs:79:34 [INFO] [stderr] | [INFO] [stderr] 79 | if stone == Stone::Empty { [INFO] [stderr] | __________________________________^ [INFO] [stderr] 80 | | return false; [INFO] [stderr] 81 | | } else if self[(x, y)] != Stone::Empty { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/board.rs:102:12 [INFO] [stderr] | [INFO] [stderr] 102 | if liberties.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `liberties.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/board.rs:113:41 [INFO] [stderr] | [INFO] [stderr] 113 | } else if stone == Stone::Empty { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 114 | | return false; [INFO] [stderr] 115 | | } else if !self.legal_move(stone, x, y) { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/board.rs:111:41 [INFO] [stderr] | [INFO] [stderr] 111 | if self[(x, y)] != Stone::Empty { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 112 | | return false; [INFO] [stderr] 113 | | } else if stone == Stone::Empty { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/board.rs:169:15 [INFO] [stderr] | [INFO] [stderr] 169 | while horizon.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!horizon.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/board.rs:198:15 [INFO] [stderr] | [INFO] [stderr] 198 | while horizon.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!horizon.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/board.rs:232:5 [INFO] [stderr] | [INFO] [stderr] 232 | / fn index<'a>(&'a self, index: (usize, usize)) -> &'a Stone { [INFO] [stderr] 233 | | let (x, y) = index; [INFO] [stderr] 234 | | &self.state[y * self.size + x] [INFO] [stderr] 235 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/board.rs:239:5 [INFO] [stderr] | [INFO] [stderr] 239 | / fn index_mut<'a>(&'a mut self, index: (usize, usize)) -> &'a mut Stone { [INFO] [stderr] 240 | | let (x, y) = index; [INFO] [stderr] 241 | | &mut self.state[y * self.size + x] [INFO] [stderr] 242 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/board.rs:329:9 [INFO] [stderr] | [INFO] [stderr] 329 | board[(20, 20)]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::Game` [INFO] [stderr] --> src/game.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> Game { [INFO] [stderr] 21 | | Game { [INFO] [stderr] 22 | | board: Board::new(), [INFO] [stderr] 23 | | last_board: None, [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 18 | impl Default for game::Game { [INFO] [stderr] 19 | fn default() -> Self { [INFO] [stderr] 20 | Self::new() [INFO] [stderr] 21 | } [INFO] [stderr] 22 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/game.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / pub fn from_str(board: &str) -> Game { [INFO] [stderr] 31 | | Game { [INFO] [stderr] 32 | | board: Board::from_str(board), [INFO] [stderr] 33 | | last_board: None, [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/game.rs:133:54 [INFO] [stderr] | [INFO] [stderr] 133 | let black_player = self.clone().black_player.unwrap_or(unknown.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| unknown.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/game.rs:134:54 [INFO] [stderr] | [INFO] [stderr] 134 | let white_player = self.clone().white_player.unwrap_or(unknown.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| unknown.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `joseki`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "fac4dd865bee74c9cd81c7320031c32e3855c2d3e25bd109c72ad448c59c99f5"` [INFO] running `"docker" "rm" "-f" "fac4dd865bee74c9cd81c7320031c32e3855c2d3e25bd109c72ad448c59c99f5"` [INFO] [stdout] fac4dd865bee74c9cd81c7320031c32e3855c2d3e25bd109c72ad448c59c99f5