[INFO] crate jockey_derive 0.3.0 is already in cache [INFO] extracting crate jockey_derive 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/jockey_derive/0.3.0 [INFO] extracting crate jockey_derive 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/jockey_derive/0.3.0 [INFO] validating manifest of jockey_derive-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jockey_derive-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jockey_derive-0.3.0 [INFO] finished frobbing jockey_derive-0.3.0 [INFO] frobbed toml for jockey_derive-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/jockey_derive/0.3.0/Cargo.toml [INFO] started frobbing jockey_derive-0.3.0 [INFO] finished frobbing jockey_derive-0.3.0 [INFO] frobbed toml for jockey_derive-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/jockey_derive/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jockey_derive-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/jockey_derive/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 89105a8d83f003649ff79d1e730b0718bbabbf733d6e79e907e9335f4e85e741 [INFO] running `"docker" "start" "-a" "89105a8d83f003649ff79d1e730b0718bbabbf733d6e79e907e9335f4e85e741"` [INFO] [stderr] Checking jockey v0.3.0 [INFO] [stderr] Checking jockey_derive v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | ident: ident, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util.rs:10:13 [INFO] [stderr] | [INFO] [stderr] 10 | fields: fields, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | ident: ident, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | ident: ident, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util.rs:10:13 [INFO] [stderr] | [INFO] [stderr] 10 | fields: fields, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | ident: ident, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/util.rs:110:14 [INFO] [stderr] | [INFO] [stderr] 110 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 111 | | if field.long_option.is_none() { [INFO] [stderr] 112 | | // Long option name is not set. Make up one based on the field name. [INFO] [stderr] 113 | | field.long_option = Some(field.ident.to_string().replace("_", "-")); [INFO] [stderr] 114 | | } [INFO] [stderr] 115 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 110 | else if field.long_option.is_none() { [INFO] [stderr] 111 | // Long option name is not set. Make up one based on the field name. [INFO] [stderr] 112 | field.long_option = Some(field.ident.to_string().replace("_", "-")); [INFO] [stderr] 113 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/derive_parse_args.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | for ref field in struct_def.fields { [INFO] [stderr] | ^^^^^^^^^ ----------------- help: try: `let field = &struct_def.fields;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/derive_parse_args.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | result.into() [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/util.rs:110:14 [INFO] [stderr] | [INFO] [stderr] 110 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 111 | | if field.long_option.is_none() { [INFO] [stderr] 112 | | // Long option name is not set. Make up one based on the field name. [INFO] [stderr] 113 | | field.long_option = Some(field.ident.to_string().replace("_", "-")); [INFO] [stderr] 114 | | } [INFO] [stderr] 115 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 110 | else if field.long_option.is_none() { [INFO] [stderr] 111 | // Long option name is not set. Make up one based on the field name. [INFO] [stderr] 112 | field.long_option = Some(field.ident.to_string().replace("_", "-")); [INFO] [stderr] 113 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/derive_parse_args.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | for ref field in struct_def.fields { [INFO] [stderr] | ^^^^^^^^^ ----------------- help: try: `let field = &struct_def.fields;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/derive_parse_args.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | result.into() [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.89s [INFO] running `"docker" "inspect" "89105a8d83f003649ff79d1e730b0718bbabbf733d6e79e907e9335f4e85e741"` [INFO] running `"docker" "rm" "-f" "89105a8d83f003649ff79d1e730b0718bbabbf733d6e79e907e9335f4e85e741"` [INFO] [stdout] 89105a8d83f003649ff79d1e730b0718bbabbf733d6e79e907e9335f4e85e741