[INFO] crate jens 0.4.2 is already in cache [INFO] extracting crate jens 0.4.2 into work/ex/clippy-test-run/sources/stable/reg/jens/0.4.2 [INFO] extracting crate jens 0.4.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/jens/0.4.2 [INFO] validating manifest of jens-0.4.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jens-0.4.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jens-0.4.2 [INFO] finished frobbing jens-0.4.2 [INFO] frobbed toml for jens-0.4.2 written to work/ex/clippy-test-run/sources/stable/reg/jens/0.4.2/Cargo.toml [INFO] started frobbing jens-0.4.2 [INFO] finished frobbing jens-0.4.2 [INFO] frobbed toml for jens-0.4.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/jens/0.4.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jens-0.4.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/jens/0.4.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 93bc7ec18b8aa70016959aca33da83d4fdeb9e795a25cf98c6456af08f3dffa7 [INFO] running `"docker" "start" "-a" "93bc7ec18b8aa70016959aca33da83d4fdeb9e795a25cf98c6456af08f3dffa7"` [INFO] [stderr] Checking jens v0.4.2 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parser.rs:8:18 [INFO] [stderr] | [INFO] [stderr] 8 | const _GRAMMAR: &'static str = include_str!("parser/grammar.pest"); // relative to this file [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parser.rs:8:18 [INFO] [stderr] | [INFO] [stderr] 8 | const _GRAMMAR: &'static str = include_str!("parser/grammar.pest"); // relative to this file [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/block.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | / match self.clone() { [INFO] [stderr] 53 | | LineSegment::Placeholder(_) => { [INFO] [stderr] 54 | | *self = new_segment; [INFO] [stderr] 55 | | } [INFO] [stderr] 56 | | _ => (), [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 52 | if let LineSegment::Placeholder(_) = self.clone() { [INFO] [stderr] 53 | *self = new_segment; [INFO] [stderr] 54 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/block.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | / match segment { [INFO] [stderr] 82 | | LineSegment::Content(x) => sub_prefix = sub_prefix + x, [INFO] [stderr] 83 | | _ => (), [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____________^ help: try this: `if let LineSegment::Content(x) = segment { sub_prefix = sub_prefix + x }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/block.rs:129:17 [INFO] [stderr] | [INFO] [stderr] 129 | write!(f, "\n{}", prefix); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/block.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | / match self.clone() { [INFO] [stderr] 53 | | LineSegment::Placeholder(_) => { [INFO] [stderr] 54 | | *self = new_segment; [INFO] [stderr] 55 | | } [INFO] [stderr] 56 | | _ => (), [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 52 | if let LineSegment::Placeholder(_) = self.clone() { [INFO] [stderr] 53 | *self = new_segment; [INFO] [stderr] 54 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/block.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | / match segment { [INFO] [stderr] 82 | | LineSegment::Content(x) => sub_prefix = sub_prefix + x, [INFO] [stderr] 83 | | _ => (), [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____________^ help: try this: `if let LineSegment::Content(x) = segment { sub_prefix = sub_prefix + x }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/block.rs:129:17 [INFO] [stderr] | [INFO] [stderr] 129 | write!(f, "\n{}", prefix); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/block.rs:257:9 [INFO] [stderr] | [INFO] [stderr] 257 | write!(&mut s, "{}", function); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `Js` [INFO] [stderr] --> examples/json_validator/main.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | / enum Json { [INFO] [stderr] 6 | | JsString, [INFO] [stderr] 7 | | JsNumber, [INFO] [stderr] 8 | | JsArray(Box), [INFO] [stderr] 9 | | JsObject(String), [INFO] [stderr] 10 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> examples/json_validator/main.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | JsString => format!("noop"), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"noop".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> examples/json_validator/main.rs:27:25 [INFO] [stderr] | [INFO] [stderr] 27 | JsNumber => format!("noop"), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"noop".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> examples/json_validator/main.rs:36:25 [INFO] [stderr] | [INFO] [stderr] 36 | JsString => format!("deserialize_string"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"deserialize_string".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> examples/json_validator/main.rs:37:25 [INFO] [stderr] | [INFO] [stderr] 37 | JsNumber => format!("deserialize_number"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"deserialize_number".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.53s [INFO] running `"docker" "inspect" "93bc7ec18b8aa70016959aca33da83d4fdeb9e795a25cf98c6456af08f3dffa7"` [INFO] running `"docker" "rm" "-f" "93bc7ec18b8aa70016959aca33da83d4fdeb9e795a25cf98c6456af08f3dffa7"` [INFO] [stdout] 93bc7ec18b8aa70016959aca33da83d4fdeb9e795a25cf98c6456af08f3dffa7