[INFO] crate jconfig 0.1.0 is already in cache [INFO] extracting crate jconfig 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/jconfig/0.1.0 [INFO] extracting crate jconfig 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/jconfig/0.1.0 [INFO] validating manifest of jconfig-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jconfig-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jconfig-0.1.0 [INFO] finished frobbing jconfig-0.1.0 [INFO] frobbed toml for jconfig-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/jconfig/0.1.0/Cargo.toml [INFO] started frobbing jconfig-0.1.0 [INFO] finished frobbing jconfig-0.1.0 [INFO] frobbed toml for jconfig-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/jconfig/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jconfig-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/jconfig/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 33eeb96d728fd0b3665dac39f213cdbdcb60bdae70ea9341e9855f21e7889e1a [INFO] running `"docker" "start" "-a" "33eeb96d728fd0b3665dac39f213cdbdcb60bdae70ea9341e9855f21e7889e1a"` [INFO] [stderr] Checking jconfig v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/field.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | return Json::from_str(&s).unwrap_or(Json::Null); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Json::from_str(&s).unwrap_or(Json::Null)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/item.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | let mut inner = unsafe { &mut *self.inner.get() }; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/item.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | let mut inner = unsafe { &mut *self.inner.get() }; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/field.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | return Json::from_str(&s).unwrap_or(Json::Null); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Json::from_str(&s).unwrap_or(Json::Null)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/field.rs:47:29 [INFO] [stderr] | [INFO] [stderr] 47 | let s = json::encode(x).unwrap_or("".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: item `config::Config` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/config.rs:38:1 [INFO] [stderr] | [INFO] [stderr] 38 | / impl Config { [INFO] [stderr] 39 | | /// Creates a new, empty configuration [INFO] [stderr] 40 | | pub fn new() -> Self { Config { data: HashMap::new() } } [INFO] [stderr] 41 | | [INFO] [stderr] ... | [INFO] [stderr] 147 | | pub fn clear(&mut self) { self.data.clear() } [INFO] [stderr] 148 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/config.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / pub fn from_str<'a>(s: &'a str) -> Result { [INFO] [stderr] 58 | | match try!(Json::from_str(s)) { [INFO] [stderr] 59 | | Json::Object(ref obj) => { [INFO] [stderr] 60 | | let mut config = Config::new(); [INFO] [stderr] ... | [INFO] [stderr] 72 | | } [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/config.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / pub fn from_str<'a>(s: &'a str) -> Result { [INFO] [stderr] 58 | | match try!(Json::from_str(s)) { [INFO] [stderr] 59 | | Json::Object(ref obj) => { [INFO] [stderr] 60 | | let mut config = Config::new(); [INFO] [stderr] ... | [INFO] [stderr] 72 | | } [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const ()`) to a reference type (`&T`) [INFO] [stderr] --> src/item.rs:42:65 [INFO] [stderr] | [INFO] [stderr] 42 | unsafe fn downcast_ref_unchecked(&self) -> &T { mem::transmute(traitobject::data(self)) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(traitobject::data(self) as *const T)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut ()`) to a reference type (`&mut T`) [INFO] [stderr] --> src/item.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | mem::transmute(traitobject::data_mut(self)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(traitobject::data_mut(self) as *mut T)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/item.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | let mut inner = unsafe { &mut *self.inner.get() }; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/item.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | let mut inner = unsafe { &mut *self.inner.get() }; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/field.rs:47:29 [INFO] [stderr] | [INFO] [stderr] 47 | let s = json::encode(x).unwrap_or("".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: item `config::Config` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/config.rs:38:1 [INFO] [stderr] | [INFO] [stderr] 38 | / impl Config { [INFO] [stderr] 39 | | /// Creates a new, empty configuration [INFO] [stderr] 40 | | pub fn new() -> Self { Config { data: HashMap::new() } } [INFO] [stderr] 41 | | [INFO] [stderr] ... | [INFO] [stderr] 147 | | pub fn clear(&mut self) { self.data.clear() } [INFO] [stderr] 148 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/config.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / pub fn from_str<'a>(s: &'a str) -> Result { [INFO] [stderr] 58 | | match try!(Json::from_str(s)) { [INFO] [stderr] 59 | | Json::Object(ref obj) => { [INFO] [stderr] 60 | | let mut config = Config::new(); [INFO] [stderr] ... | [INFO] [stderr] 72 | | } [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/config.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / pub fn from_str<'a>(s: &'a str) -> Result { [INFO] [stderr] 58 | | match try!(Json::from_str(s)) { [INFO] [stderr] 59 | | Json::Object(ref obj) => { [INFO] [stderr] 60 | | let mut config = Config::new(); [INFO] [stderr] ... | [INFO] [stderr] 72 | | } [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const ()`) to a reference type (`&T`) [INFO] [stderr] --> src/item.rs:42:65 [INFO] [stderr] | [INFO] [stderr] 42 | unsafe fn downcast_ref_unchecked(&self) -> &T { mem::transmute(traitobject::data(self)) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(traitobject::data(self) as *const T)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut ()`) to a reference type (`&mut T`) [INFO] [stderr] --> src/item.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | mem::transmute(traitobject::data_mut(self)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(traitobject::data_mut(self) as *mut T)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> examples/basic.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | / config_field!{ [INFO] [stderr] 20 | | /// Indicates some port of sorts... [INFO] [stderr] 21 | | /// [INFO] [stderr] 22 | | /// This will show up in your documentation. [INFO] [stderr] 23 | | struct Port: u16, [INFO] [stderr] 24 | | key: "port" [INFO] [stderr] 25 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.14s [INFO] running `"docker" "inspect" "33eeb96d728fd0b3665dac39f213cdbdcb60bdae70ea9341e9855f21e7889e1a"` [INFO] running `"docker" "rm" "-f" "33eeb96d728fd0b3665dac39f213cdbdcb60bdae70ea9341e9855f21e7889e1a"` [INFO] [stdout] 33eeb96d728fd0b3665dac39f213cdbdcb60bdae70ea9341e9855f21e7889e1a