[INFO] crate jbcrs-basic 0.1.4 is already in cache [INFO] extracting crate jbcrs-basic 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/jbcrs-basic/0.1.4 [INFO] extracting crate jbcrs-basic 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/jbcrs-basic/0.1.4 [INFO] validating manifest of jbcrs-basic-0.1.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jbcrs-basic-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jbcrs-basic-0.1.4 [INFO] finished frobbing jbcrs-basic-0.1.4 [INFO] frobbed toml for jbcrs-basic-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/jbcrs-basic/0.1.4/Cargo.toml [INFO] started frobbing jbcrs-basic-0.1.4 [INFO] finished frobbing jbcrs-basic-0.1.4 [INFO] frobbed toml for jbcrs-basic-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/jbcrs-basic/0.1.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jbcrs-basic-0.1.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/jbcrs-basic/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] beba8de136b0cb43ecd8eaceaeb3aeeb111b9d519885d7572391e65d34d7bfb4 [INFO] running `"docker" "start" "-a" "beba8de136b0cb43ecd8eaceaeb3aeeb111b9d519885d7572391e65d34d7bfb4"` [INFO] [stderr] Compiling yade v0.1.2 [INFO] [stderr] Checking jbcrs-basic v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/decode.rs:206:38 [INFO] [stderr] | [INFO] [stderr] 206 | [0x00, 0xFE, 0x00, 0xAB] => [0x00FE00AB], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00FE_00AB` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/decode.rs:207:38 [INFO] [stderr] | [INFO] [stderr] 207 | [0xCA, 0xFE, 0xBA, 0xBE] => [0xCAFEBABE], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xCAFE_BABE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/decode.rs:208:38 [INFO] [stderr] | [INFO] [stderr] 208 | [0x00, 0x00, 0x00, 0x00] => [0x00000000], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/decode.rs:209:38 [INFO] [stderr] | [INFO] [stderr] 209 | [0xFF, 0xFF, 0xFF, 0xFF] => [0xFFFFFFFF], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/parser/decode.rs:213:62 [INFO] [stderr] | [INFO] [stderr] 213 | [0x00, 0xFE, 0x00, 0xAB, 0xCD, 0x00, 0xEF, 0x00] => [0x00FE00AB_CD00EF00], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0x00FE_00AB_CD00_EF00` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_digit_groups)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/parser/decode.rs:214:62 [INFO] [stderr] | [INFO] [stderr] 214 | [0xCA, 0xFE, 0xBA, 0xBE, 0xCA, 0xFE, 0xD0, 0x0D] => [0xCAFEBABE_CAFED00D], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0xCAFE_BABE_CAFE_D00D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/parser/decode.rs:215:62 [INFO] [stderr] | [INFO] [stderr] 215 | [0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00] => [0x00000000_00000000], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/parser/decode.rs:216:62 [INFO] [stderr] | [INFO] [stderr] 216 | [0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF] => [0xFFFFFFFF_FFFFFFFF], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/decode.rs:233:39 [INFO] [stderr] | [INFO] [stderr] 233 | [0xFF, 0x01, 0xFF, 0x55] => [-0x00FE00AB], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00FE_00AB` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/decode.rs:234:39 [INFO] [stderr] | [INFO] [stderr] 234 | [0xCA, 0xFE, 0xBA, 0xBE] => [-0x35014542], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3501_4542` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/decode.rs:235:39 [INFO] [stderr] | [INFO] [stderr] 235 | [0xFF, 0xFF, 0xFF, 0xFF] => [-0x00000001], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/decode.rs:236:39 [INFO] [stderr] | [INFO] [stderr] 236 | [0x00, 0x00, 0x00, 0x00] => [ 0x00000000], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/parser/decode.rs:240:63 [INFO] [stderr] | [INFO] [stderr] 240 | [0xA0, 0xFE, 0x00, 0xAB, 0xCD, 0x00, 0xEF, 0x00] => [-0x5F01FF54_32FF1100], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0x5F01_FF54_32FF_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/parser/decode.rs:241:63 [INFO] [stderr] | [INFO] [stderr] 241 | [0xA5, 0x01, 0x45, 0x41, 0x35, 0x01, 0x2F, 0xF3] => [-0x5AFEBABE_CAFED00D], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0x5AFE_BABE_CAFE_D00D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/parser/decode.rs:242:62 [INFO] [stderr] | [INFO] [stderr] 242 | [0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00] => [0x00000000_00000000], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/parser/decode.rs:243:62 [INFO] [stderr] | [INFO] [stderr] 243 | [0x7F, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF] => [0x7FFFFFFF_FFFFFFFF], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0x7FFF_FFFF_FFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: method is never used: `with_capacity` [INFO] [stderr] --> src/writer/encode.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn with_capacity(cap: usize) -> Encoder { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `len` [INFO] [stderr] --> src/writer/encode.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn len(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `write_u32` [INFO] [stderr] --> src/writer/encode.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn write_u32(&mut self, u: u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `write_u64` [INFO] [stderr] --> src/writer/encode.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn write_u64(&mut self, u: u64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `write_i8` [INFO] [stderr] --> src/writer/encode.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn write_i8(&mut self, u: i8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `write_i16` [INFO] [stderr] --> src/writer/encode.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn write_i16(&mut self, u: i16) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/parser/code.rs:254:22 [INFO] [stderr] | [INFO] [stderr] 254 | for _ in low..(high + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `low..=high` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: method is never used: `with_capacity` [INFO] [stderr] --> src/writer/encode.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn with_capacity(cap: usize) -> Encoder { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `len` [INFO] [stderr] --> src/writer/encode.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn len(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `write_u32` [INFO] [stderr] --> src/writer/encode.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn write_u32(&mut self, u: u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `write_u64` [INFO] [stderr] --> src/writer/encode.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn write_u64(&mut self, u: u64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `write_i8` [INFO] [stderr] --> src/writer/encode.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn write_i8(&mut self, u: i8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `write_i16` [INFO] [stderr] --> src/writer/encode.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn write_i16(&mut self, u: i16) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/parser/decode.rs:249:47 [INFO] [stderr] | [INFO] [stderr] 249 | let mut decoder = super::Decoder::new("Hello, world!".as_bytes(), &mut cursor); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Hello, world!"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/parser/code.rs:254:22 [INFO] [stderr] | [INFO] [stderr] 254 | for _ in low..(high + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `low..=high` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.18s [INFO] running `"docker" "inspect" "beba8de136b0cb43ecd8eaceaeb3aeeb111b9d519885d7572391e65d34d7bfb4"` [INFO] running `"docker" "rm" "-f" "beba8de136b0cb43ecd8eaceaeb3aeeb111b9d519885d7572391e65d34d7bfb4"` [INFO] [stdout] beba8de136b0cb43ecd8eaceaeb3aeeb111b9d519885d7572391e65d34d7bfb4