[INFO] crate javelin 0.2.3 is already in cache [INFO] extracting crate javelin 0.2.3 into work/ex/clippy-test-run/sources/stable/reg/javelin/0.2.3 [INFO] extracting crate javelin 0.2.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/javelin/0.2.3 [INFO] validating manifest of javelin-0.2.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of javelin-0.2.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing javelin-0.2.3 [INFO] finished frobbing javelin-0.2.3 [INFO] frobbed toml for javelin-0.2.3 written to work/ex/clippy-test-run/sources/stable/reg/javelin/0.2.3/Cargo.toml [INFO] started frobbing javelin-0.2.3 [INFO] finished frobbing javelin-0.2.3 [INFO] frobbed toml for javelin-0.2.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/javelin/0.2.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rml_rtmp v0.2.1 [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting javelin-0.2.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/javelin/0.2.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6f56a638cdcf45ba98e0b8d7c0acd7c58c3d766b8efb6bdb2a7cc4832cb7efd0 [INFO] running `"docker" "start" "-a" "6f56a638cdcf45ba98e0b8d7c0acd7c58c3d766b8efb6bdb2a7cc4832cb7efd0"` [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking tokio-io v0.1.11 [INFO] [stderr] Checking simplelog v0.5.3 [INFO] [stderr] Checking rml_amf0 v0.1.1 [INFO] [stderr] Checking tokio-threadpool v0.1.11 [INFO] [stderr] Checking rml_rtmp v0.2.1 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking tokio-tls v0.2.1 [INFO] [stderr] Checking tokio-reactor v0.1.8 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking tokio-fs v0.1.5 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-uds v0.2.5 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking javelin v0.2.3 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/peer/event.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | / match streams.get(&app_name) { [INFO] [stderr] 147 | | Some(stream) => { [INFO] [stderr] 148 | | match stream.has_publisher() { [INFO] [stderr] 149 | | false => (), [INFO] [stderr] ... | [INFO] [stderr] 153 | | None => (), [INFO] [stderr] 154 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 146 | if let Some(stream) = streams.get(&app_name) { [INFO] [stderr] 147 | match stream.has_publisher() { [INFO] [stderr] 148 | false => (), [INFO] [stderr] 149 | true => return Err(Error::SessionError(format!("App '{}' is already being published to", app_name))), [INFO] [stderr] 150 | } [INFO] [stderr] 151 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/peer/event.rs:148:21 [INFO] [stderr] | [INFO] [stderr] 148 | / match stream.has_publisher() { [INFO] [stderr] 149 | | false => (), [INFO] [stderr] 150 | | true => return Err(Error::SessionError(format!("App '{}' is already being published to", app_name))), [INFO] [stderr] 151 | | } [INFO] [stderr] | |_____________________^ help: consider using an if/else expression: `if stream.has_publisher() { return Err(Error::SessionError(format!("App '{}' is already being published to", app_name))) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/peer/event.rs:161:62 [INFO] [stderr] | [INFO] [stderr] 161 | let mut stream = streams.entry(app_name.clone()).or_insert(Channel::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Channel::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/peer/event.rs:210:66 [INFO] [stderr] | [INFO] [stderr] 210 | let mut stream = streams.entry(app_name.clone()).or_insert(Channel::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Channel::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/peer/event.rs:275:14 [INFO] [stderr] | [INFO] [stderr] 275 | .ok_or(Error::SessionError("No app for stream key".to_string()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::SessionError("No app for stream key".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/peer/event.rs:303:90 [INFO] [stderr] | [INFO] [stderr] 303 | client.session.send_audio_data(active_stream, bytes.clone(), timestamp.clone(), true)? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `timestamp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/peer/event.rs:309:90 [INFO] [stderr] | [INFO] [stderr] 309 | client.session.send_video_data(active_stream, bytes.clone(), timestamp.clone(), true)? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/peer/mod.rs:53:14 [INFO] [stderr] | [INFO] [stderr] 53 | .expect(&format!("Failed to create event handler for peer {}", id)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to create event handler for peer {}", id))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/peer/mod.rs:98:12 [INFO] [stderr] | [INFO] [stderr] 98 | if response_bytes.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!response_bytes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/args.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | / fn capitalize<'a>(string: &'a str) -> String { [INFO] [stderr] 46 | | string [INFO] [stderr] 47 | | .chars() [INFO] [stderr] 48 | | .enumerate() [INFO] [stderr] ... | [INFO] [stderr] 55 | | .collect() [INFO] [stderr] 56 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/peer/event.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | / match streams.get(&app_name) { [INFO] [stderr] 147 | | Some(stream) => { [INFO] [stderr] 148 | | match stream.has_publisher() { [INFO] [stderr] 149 | | false => (), [INFO] [stderr] ... | [INFO] [stderr] 153 | | None => (), [INFO] [stderr] 154 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 146 | if let Some(stream) = streams.get(&app_name) { [INFO] [stderr] 147 | match stream.has_publisher() { [INFO] [stderr] 148 | false => (), [INFO] [stderr] 149 | true => return Err(Error::SessionError(format!("App '{}' is already being published to", app_name))), [INFO] [stderr] 150 | } [INFO] [stderr] 151 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/peer/event.rs:148:21 [INFO] [stderr] | [INFO] [stderr] 148 | / match stream.has_publisher() { [INFO] [stderr] 149 | | false => (), [INFO] [stderr] 150 | | true => return Err(Error::SessionError(format!("App '{}' is already being published to", app_name))), [INFO] [stderr] 151 | | } [INFO] [stderr] | |_____________________^ help: consider using an if/else expression: `if stream.has_publisher() { return Err(Error::SessionError(format!("App '{}' is already being published to", app_name))) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/peer/event.rs:161:62 [INFO] [stderr] | [INFO] [stderr] 161 | let mut stream = streams.entry(app_name.clone()).or_insert(Channel::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Channel::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/peer/event.rs:210:66 [INFO] [stderr] | [INFO] [stderr] 210 | let mut stream = streams.entry(app_name.clone()).or_insert(Channel::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Channel::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/peer/event.rs:275:14 [INFO] [stderr] | [INFO] [stderr] 275 | .ok_or(Error::SessionError("No app for stream key".to_string()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::SessionError("No app for stream key".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/peer/event.rs:303:90 [INFO] [stderr] | [INFO] [stderr] 303 | client.session.send_audio_data(active_stream, bytes.clone(), timestamp.clone(), true)? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `timestamp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/peer/event.rs:309:90 [INFO] [stderr] | [INFO] [stderr] 309 | client.session.send_video_data(active_stream, bytes.clone(), timestamp.clone(), true)? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/peer/mod.rs:53:14 [INFO] [stderr] | [INFO] [stderr] 53 | .expect(&format!("Failed to create event handler for peer {}", id)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to create event handler for peer {}", id))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/peer/mod.rs:98:12 [INFO] [stderr] | [INFO] [stderr] 98 | if response_bytes.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!response_bytes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/args.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | / fn capitalize<'a>(string: &'a str) -> String { [INFO] [stderr] 46 | | string [INFO] [stderr] 47 | | .chars() [INFO] [stderr] 48 | | .enumerate() [INFO] [stderr] ... | [INFO] [stderr] 55 | | .collect() [INFO] [stderr] 56 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 31.66s [INFO] running `"docker" "inspect" "6f56a638cdcf45ba98e0b8d7c0acd7c58c3d766b8efb6bdb2a7cc4832cb7efd0"` [INFO] running `"docker" "rm" "-f" "6f56a638cdcf45ba98e0b8d7c0acd7c58c3d766b8efb6bdb2a7cc4832cb7efd0"` [INFO] [stdout] 6f56a638cdcf45ba98e0b8d7c0acd7c58c3d766b8efb6bdb2a7cc4832cb7efd0