[INFO] crate jamal 0.1.0 is already in cache [INFO] extracting crate jamal 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/jamal/0.1.0 [INFO] extracting crate jamal 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/jamal/0.1.0 [INFO] validating manifest of jamal-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jamal-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jamal-0.1.0 [INFO] finished frobbing jamal-0.1.0 [INFO] frobbed toml for jamal-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/jamal/0.1.0/Cargo.toml [INFO] started frobbing jamal-0.1.0 [INFO] finished frobbing jamal-0.1.0 [INFO] frobbed toml for jamal-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/jamal/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jamal-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/jamal/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b7f57cdcbae05fac2e37719e6742ad8d2ec28d036c33c81f4c6d14cc3116807a [INFO] running `"docker" "start" "-a" "b7f57cdcbae05fac2e37719e6742ad8d2ec28d036c33c81f4c6d14cc3116807a"` [INFO] [stderr] Checking jamal v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / match json { [INFO] [stderr] 57 | | &JsonValue::Null => Ok(YamlValue::Null), [INFO] [stderr] 58 | | &JsonValue::Bool(ref value) => Ok(YamlValue::Boolean(value.clone())), [INFO] [stderr] 59 | | &JsonValue::I64(ref value) => Ok(YamlValue::Integer(value.clone())), [INFO] [stderr] ... | [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 56 | match *json { [INFO] [stderr] 57 | JsonValue::Null => Ok(YamlValue::Null), [INFO] [stderr] 58 | JsonValue::Bool(ref value) => Ok(YamlValue::Boolean(value.clone())), [INFO] [stderr] 59 | JsonValue::I64(ref value) => Ok(YamlValue::Integer(value.clone())), [INFO] [stderr] 60 | JsonValue::U64(ref value) => Ok(YamlValue::Integer(value.clone() as i64)), [INFO] [stderr] 61 | JsonValue::F64(ref value) => Ok(YamlValue::Real(value.to_string())), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:58:62 [INFO] [stderr] | [INFO] [stderr] 58 | &JsonValue::Bool(ref value) => Ok(YamlValue::Boolean(value.clone())), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:59:61 [INFO] [stderr] | [INFO] [stderr] 59 | &JsonValue::I64(ref value) => Ok(YamlValue::Integer(value.clone())), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:60:61 [INFO] [stderr] | [INFO] [stderr] 60 | &JsonValue::U64(ref value) => Ok(YamlValue::Integer(value.clone() as i64)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:85:61 [INFO] [stderr] | [INFO] [stderr] 85 | &YamlValue::Integer(ref value) => Ok(JsonValue::I64(value.clone())), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:87:62 [INFO] [stderr] | [INFO] [stderr] 87 | &YamlValue::Boolean(ref value) => Ok(JsonValue::Bool(value.clone())), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / match json { [INFO] [stderr] 57 | | &JsonValue::Null => Ok(YamlValue::Null), [INFO] [stderr] 58 | | &JsonValue::Bool(ref value) => Ok(YamlValue::Boolean(value.clone())), [INFO] [stderr] 59 | | &JsonValue::I64(ref value) => Ok(YamlValue::Integer(value.clone())), [INFO] [stderr] ... | [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 56 | match *json { [INFO] [stderr] 57 | JsonValue::Null => Ok(YamlValue::Null), [INFO] [stderr] 58 | JsonValue::Bool(ref value) => Ok(YamlValue::Boolean(value.clone())), [INFO] [stderr] 59 | JsonValue::I64(ref value) => Ok(YamlValue::Integer(value.clone())), [INFO] [stderr] 60 | JsonValue::U64(ref value) => Ok(YamlValue::Integer(value.clone() as i64)), [INFO] [stderr] 61 | JsonValue::F64(ref value) => Ok(YamlValue::Real(value.to_string())), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:58:62 [INFO] [stderr] | [INFO] [stderr] 58 | &JsonValue::Bool(ref value) => Ok(YamlValue::Boolean(value.clone())), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:59:61 [INFO] [stderr] | [INFO] [stderr] 59 | &JsonValue::I64(ref value) => Ok(YamlValue::Integer(value.clone())), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:60:61 [INFO] [stderr] | [INFO] [stderr] 60 | &JsonValue::U64(ref value) => Ok(YamlValue::Integer(value.clone() as i64)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:85:61 [INFO] [stderr] | [INFO] [stderr] 85 | &YamlValue::Integer(ref value) => Ok(JsonValue::I64(value.clone())), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:87:62 [INFO] [stderr] | [INFO] [stderr] 87 | &YamlValue::Boolean(ref value) => Ok(JsonValue::Bool(value.clone())), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.16s [INFO] running `"docker" "inspect" "b7f57cdcbae05fac2e37719e6742ad8d2ec28d036c33c81f4c6d14cc3116807a"` [INFO] running `"docker" "rm" "-f" "b7f57cdcbae05fac2e37719e6742ad8d2ec28d036c33c81f4c6d14cc3116807a"` [INFO] [stdout] b7f57cdcbae05fac2e37719e6742ad8d2ec28d036c33c81f4c6d14cc3116807a