[INFO] crate ispc 0.3.8 is already in cache [INFO] extracting crate ispc 0.3.8 into work/ex/clippy-test-run/sources/stable/reg/ispc/0.3.8 [INFO] extracting crate ispc 0.3.8 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ispc/0.3.8 [INFO] validating manifest of ispc-0.3.8 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ispc-0.3.8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ispc-0.3.8 [INFO] finished frobbing ispc-0.3.8 [INFO] frobbed toml for ispc-0.3.8 written to work/ex/clippy-test-run/sources/stable/reg/ispc/0.3.8/Cargo.toml [INFO] started frobbing ispc-0.3.8 [INFO] finished frobbing ispc-0.3.8 [INFO] frobbed toml for ispc-0.3.8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ispc/0.3.8/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ispc-0.3.8 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ispc/0.3.8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0deb64155ec0c27020c75dd676857e321a31a320845858727d44ec8850b6ae72 [INFO] running `"docker" "start" "-a" "0deb64155ec0c27020c75dd676857e321a31a320845858727d44ec8850b6ae72"` [INFO] [stderr] Checking gcc v0.3.55 [INFO] [stderr] Checking proc-macro2 v0.3.5 [INFO] [stderr] Checking nom v4.1.1 [INFO] [stderr] Checking clang-sys v0.26.4 [INFO] [stderr] Checking aligned_alloc v0.1.3 [INFO] [stderr] Checking quote v0.5.2 [INFO] [stderr] Checking cexpr v0.3.4 [INFO] [stderr] Checking bindgen v0.43.2 [INFO] [stderr] Checking ispc v0.3.8 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/task.rs:57:80 [INFO] [stderr] | [INFO] [stderr] 57 | Context { tasks: RwLock::new(Vec::new()), mem: Mutex::new(Vec::new()), id: id } [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/task.rs:178:17 [INFO] [stderr] | [INFO] [stderr] 178 | total: total, data: data, fcn: fcn, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/task.rs:178:31 [INFO] [stderr] | [INFO] [stderr] 178 | total: total, data: data, fcn: fcn, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/task.rs:178:43 [INFO] [stderr] | [INFO] [stderr] 178 | total: total, data: data, fcn: fcn, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `fcn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/task.rs:183:36 [INFO] [stderr] | [INFO] [stderr] 183 | GroupChunks { group: self, chunk_size: chunk_size } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `chunk_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/task.rs:257:42 [INFO] [stderr] | [INFO] [stderr] 257 | fcn: group.fcn, data: d, group: group [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `group` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:473:9 [INFO] [stderr] | [INFO] [stderr] 473 | write!(include_file, "#include \n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:474:9 [INFO] [stderr] | [INFO] [stderr] 474 | write!(include_file, "#include \n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:477:13 [INFO] [stderr] | [INFO] [stderr] 477 | write!(include_file, "#include \"{}\"\n", h.display()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/task.rs:57:80 [INFO] [stderr] | [INFO] [stderr] 57 | Context { tasks: RwLock::new(Vec::new()), mem: Mutex::new(Vec::new()), id: id } [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/task.rs:178:17 [INFO] [stderr] | [INFO] [stderr] 178 | total: total, data: data, fcn: fcn, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/task.rs:178:31 [INFO] [stderr] | [INFO] [stderr] 178 | total: total, data: data, fcn: fcn, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/task.rs:178:43 [INFO] [stderr] | [INFO] [stderr] 178 | total: total, data: data, fcn: fcn, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `fcn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/task.rs:183:36 [INFO] [stderr] | [INFO] [stderr] 183 | GroupChunks { group: self, chunk_size: chunk_size } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `chunk_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/task.rs:257:42 [INFO] [stderr] | [INFO] [stderr] 257 | fcn: group.fcn, data: d, group: group [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `group` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:473:9 [INFO] [stderr] | [INFO] [stderr] 473 | write!(include_file, "#include \n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:474:9 [INFO] [stderr] | [INFO] [stderr] 474 | write!(include_file, "#include \n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:477:13 [INFO] [stderr] | [INFO] [stderr] 477 | write!(include_file, "#include \"{}\"\n", h.display()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/task.rs:71:42 [INFO] [stderr] | [INFO] [stderr] 71 | self.tasks.read().unwrap().iter().fold(true, |done, t| done && t.is_finished()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.all(|t| t.is_finished())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/exec.rs:157:44 [INFO] [stderr] | [INFO] [stderr] 157 | let handle_ctx: *mut Context = mem::transmute(*handle_ptr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*handle_ptr as *mut task::Context` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/lib.rs:622:40 [INFO] [stderr] | [INFO] [stderr] 622 | let s: *const TaskSystem = mem::transmute(&*task_sys); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*task_sys as *const dyn exec::TaskSystem as *const (dyn exec::TaskSystem + 'static)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/lib.rs:636:40 [INFO] [stderr] | [INFO] [stderr] 636 | let s: *const TaskSystem = mem::transmute(&*task_sys); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*task_sys as *const dyn exec::TaskSystem as *const (dyn exec::TaskSystem + 'static)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/lib.rs:652:40 [INFO] [stderr] | [INFO] [stderr] 652 | let s: *const Instrument = mem::transmute(&*instrument); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*instrument as *const dyn instrument::Instrument as *const (dyn instrument::Instrument + 'static)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/lib.rs:671:40 [INFO] [stderr] | [INFO] [stderr] 671 | let s: *const Instrument = mem::transmute(&*instrument); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*instrument as *const dyn instrument::Instrument as *const (dyn instrument::Instrument + 'static)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/task.rs:71:42 [INFO] [stderr] | [INFO] [stderr] 71 | self.tasks.read().unwrap().iter().fold(true, |done, t| done && t.is_finished()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.all(|t| t.is_finished())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/exec.rs:157:44 [INFO] [stderr] | [INFO] [stderr] 157 | let handle_ctx: *mut Context = mem::transmute(*handle_ptr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*handle_ptr as *mut task::Context` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/lib.rs:622:40 [INFO] [stderr] | [INFO] [stderr] 622 | let s: *const TaskSystem = mem::transmute(&*task_sys); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*task_sys as *const dyn exec::TaskSystem as *const (dyn exec::TaskSystem + 'static)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/lib.rs:636:40 [INFO] [stderr] | [INFO] [stderr] 636 | let s: *const TaskSystem = mem::transmute(&*task_sys); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*task_sys as *const dyn exec::TaskSystem as *const (dyn exec::TaskSystem + 'static)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/lib.rs:652:40 [INFO] [stderr] | [INFO] [stderr] 652 | let s: *const Instrument = mem::transmute(&*instrument); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*instrument as *const dyn instrument::Instrument as *const (dyn instrument::Instrument + 'static)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/lib.rs:671:40 [INFO] [stderr] | [INFO] [stderr] 671 | let s: *const Instrument = mem::transmute(&*instrument); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*instrument as *const dyn instrument::Instrument as *const (dyn instrument::Instrument + 'static)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 20.24s [INFO] running `"docker" "inspect" "0deb64155ec0c27020c75dd676857e321a31a320845858727d44ec8850b6ae72"` [INFO] running `"docker" "rm" "-f" "0deb64155ec0c27020c75dd676857e321a31a320845858727d44ec8850b6ae72"` [INFO] [stdout] 0deb64155ec0c27020c75dd676857e321a31a320845858727d44ec8850b6ae72