[INFO] crate iso3166-3 0.3.0 is already in cache [INFO] extracting crate iso3166-3 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/iso3166-3/0.3.0 [INFO] extracting crate iso3166-3 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/iso3166-3/0.3.0 [INFO] validating manifest of iso3166-3-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of iso3166-3-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing iso3166-3-0.3.0 [INFO] finished frobbing iso3166-3-0.3.0 [INFO] frobbed toml for iso3166-3-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/iso3166-3/0.3.0/Cargo.toml [INFO] started frobbing iso3166-3-0.3.0 [INFO] finished frobbing iso3166-3-0.3.0 [INFO] frobbed toml for iso3166-3-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/iso3166-3/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting iso3166-3-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/iso3166-3/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c8cc01c95ebc202c01a9ef30864c13c6ed825122eb3f7c657b0694684a267daf [INFO] running `"docker" "start" "-a" "c8cc01c95ebc202c01a9ef30864c13c6ed825122eb3f7c657b0694684a267daf"` [INFO] [stderr] Checking iso3166-3 v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | / all() [INFO] [stderr] 66 | | .iter() [INFO] [stderr] 67 | | .find(|code| code.code == code_given) [INFO] [stderr] 68 | | .map(|code| *code) [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 65 | all() [INFO] [stderr] 66 | .iter() [INFO] [stderr] 67 | .find(|code| code.code == code_given).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | / all().iter() [INFO] [stderr] 101 | | .filter(|code| { [INFO] [stderr] 102 | | if do_from && do_to { [INFO] [stderr] 103 | | code.validity[0] >= val_from && code.validity[1] <= val_to [INFO] [stderr] ... | [INFO] [stderr] 111 | | }) [INFO] [stderr] 112 | | .map(|code| *code) [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 100 | all().iter() [INFO] [stderr] 101 | .filter(|code| { [INFO] [stderr] 102 | if do_from && do_to { [INFO] [stderr] 103 | code.validity[0] >= val_from && code.validity[1] <= val_to [INFO] [stderr] 104 | } else if do_from { [INFO] [stderr] 105 | code.validity[0] >= val_from [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | / all() [INFO] [stderr] 66 | | .iter() [INFO] [stderr] 67 | | .find(|code| code.code == code_given) [INFO] [stderr] 68 | | .map(|code| *code) [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 65 | all() [INFO] [stderr] 66 | .iter() [INFO] [stderr] 67 | .find(|code| code.code == code_given).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | / all().iter() [INFO] [stderr] 101 | | .filter(|code| { [INFO] [stderr] 102 | | if do_from && do_to { [INFO] [stderr] 103 | | code.validity[0] >= val_from && code.validity[1] <= val_to [INFO] [stderr] ... | [INFO] [stderr] 111 | | }) [INFO] [stderr] 112 | | .map(|code| *code) [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 100 | all().iter() [INFO] [stderr] 101 | .filter(|code| { [INFO] [stderr] 102 | if do_from && do_to { [INFO] [stderr] 103 | code.validity[0] >= val_from && code.validity[1] <= val_to [INFO] [stderr] 104 | } else if do_from { [INFO] [stderr] 105 | code.validity[0] >= val_from [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/lib.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | assert!(all().len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!all().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/lib.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | assert!(validity(Some(1980), Some(1990)).len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `validity(Some(1980), Some(1990)).is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/lib.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | assert!(validity(None, None).len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `validity(None, None).is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/lib.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | assert!(validity(Some(1993), Some(1994)).len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `validity(Some(1993), Some(1994)).is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.10s [INFO] running `"docker" "inspect" "c8cc01c95ebc202c01a9ef30864c13c6ed825122eb3f7c657b0694684a267daf"` [INFO] running `"docker" "rm" "-f" "c8cc01c95ebc202c01a9ef30864c13c6ed825122eb3f7c657b0694684a267daf"` [INFO] [stdout] c8cc01c95ebc202c01a9ef30864c13c6ed825122eb3f7c657b0694684a267daf