[INFO] crate isbnid 0.1.3 is already in cache [INFO] extracting crate isbnid 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/isbnid/0.1.3 [INFO] extracting crate isbnid 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/isbnid/0.1.3 [INFO] validating manifest of isbnid-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of isbnid-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing isbnid-0.1.3 [INFO] finished frobbing isbnid-0.1.3 [INFO] frobbed toml for isbnid-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/isbnid/0.1.3/Cargo.toml [INFO] started frobbing isbnid-0.1.3 [INFO] finished frobbing isbnid-0.1.3 [INFO] frobbed toml for isbnid-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/isbnid/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting isbnid-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/isbnid/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ccd4fb3bb5b73e0e08174a1ea9e6f2f80156e5a709f762f3780b874c9f653f2b [INFO] running `"docker" "start" "-a" "ccd4fb3bb5b73e0e08174a1ea9e6f2f80156e5a709f762f3780b874c9f653f2b"` [INFO] [stderr] Checking isbnid v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/isbn.rs:81:6 [INFO] [stderr] | [INFO] [stderr] 81 | (100000000000000000u64 - d) % 10 // 10^17 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `100_000_000_000_000_000u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/isbn.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/isbn.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/isbn.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | d = d + (10 - i) * (n % 10); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `d += (10 - i) * (n % 10)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/isbn.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | n = n / 10; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `n /= 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/isbn.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | d = d + (1 + 2 * (i % 2)) * (n % 10); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `d += (1 + 2 * (i % 2)) * (n % 10)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/isbn.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | n = n / 10; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `n /= 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/isbn.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | format!("{}", &self.id) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `&self.id.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/isbn.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | / match ISBN::new(id) { [INFO] [stderr] 178 | | Ok(_) => true, [INFO] [stderr] 179 | | Err(_) => false [INFO] [stderr] 180 | | } [INFO] [stderr] | |_________^ help: try this: `ISBN::new(id).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/isbn.rs:81:6 [INFO] [stderr] | [INFO] [stderr] 81 | (100000000000000000u64 - d) % 10 // 10^17 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `100_000_000_000_000_000u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/isbn.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/isbn.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/isbn.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | d = d + (10 - i) * (n % 10); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `d += (10 - i) * (n % 10)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/isbn.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | n = n / 10; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `n /= 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/isbn.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | d = d + (1 + 2 * (i % 2)) * (n % 10); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `d += (1 + 2 * (i % 2)) * (n % 10)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/isbn.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | n = n / 10; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `n /= 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/isbn.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | format!("{}", &self.id) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `&self.id.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/isbn.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | / match ISBN::new(id) { [INFO] [stderr] 178 | | Ok(_) => true, [INFO] [stderr] 179 | | Err(_) => false [INFO] [stderr] 180 | | } [INFO] [stderr] | |_________^ help: try this: `ISBN::new(id).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.99s [INFO] running `"docker" "inspect" "ccd4fb3bb5b73e0e08174a1ea9e6f2f80156e5a709f762f3780b874c9f653f2b"` [INFO] running `"docker" "rm" "-f" "ccd4fb3bb5b73e0e08174a1ea9e6f2f80156e5a709f762f3780b874c9f653f2b"` [INFO] [stdout] ccd4fb3bb5b73e0e08174a1ea9e6f2f80156e5a709f762f3780b874c9f653f2b