[INFO] crate iron_config 0.1.1 is already in cache [INFO] extracting crate iron_config 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/iron_config/0.1.1 [INFO] extracting crate iron_config 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/iron_config/0.1.1 [INFO] validating manifest of iron_config-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of iron_config-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing iron_config-0.1.1 [INFO] finished frobbing iron_config-0.1.1 [INFO] frobbed toml for iron_config-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/iron_config/0.1.1/Cargo.toml [INFO] started frobbing iron_config-0.1.1 [INFO] finished frobbing iron_config-0.1.1 [INFO] frobbed toml for iron_config-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/iron_config/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting iron_config-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/iron_config/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a96dfff5da9d2c419a163c1c2765d3d71b920a287858df014da1568dbc5f2b2d [INFO] running `"docker" "start" "-a" "a96dfff5da9d2c419a163c1c2765d3d71b920a287858df014da1568dbc5f2b2d"` [INFO] [stderr] Checking iron_config v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | return re; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `re` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / match tail { [INFO] [stderr] 55 | | Some(t) => { [INFO] [stderr] 56 | | let mut s2=t.splitn(2,"}"); [INFO] [stderr] 57 | | let name=s2.next().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 71 | | None => {} [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 54 | if let Some(t) = tail { [INFO] [stderr] 55 | let mut s2=t.splitn(2,"}"); [INFO] [stderr] 56 | let name=s2.next().unwrap(); [INFO] [stderr] 57 | let tail2=s2.next(); [INFO] [stderr] 58 | match tail2{ [INFO] [stderr] 59 | Some(t2) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:56:35 [INFO] [stderr] | [INFO] [stderr] 56 | let mut s2=t.splitn(2,"}"); [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | / match tail2{ [INFO] [stderr] 60 | | Some(t2) => { [INFO] [stderr] 61 | | if let Some(val) = env::var_os(name){ [INFO] [stderr] 62 | | re.push_str(&env_recur(val.to_str().unwrap())); [INFO] [stderr] ... | [INFO] [stderr] 68 | | None => {} [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 59 | if let Some(t2) = tail2 { [INFO] [stderr] 60 | if let Some(val) = env::var_os(name){ [INFO] [stderr] 61 | re.push_str(&env_recur(val.to_str().unwrap())); [INFO] [stderr] 62 | } [INFO] [stderr] 63 | if t2 != ""{ [INFO] [stderr] 64 | re.push_str(&env_recur(t2)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | return re; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `re` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / match tail { [INFO] [stderr] 55 | | Some(t) => { [INFO] [stderr] 56 | | let mut s2=t.splitn(2,"}"); [INFO] [stderr] 57 | | let name=s2.next().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 71 | | None => {} [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 54 | if let Some(t) = tail { [INFO] [stderr] 55 | let mut s2=t.splitn(2,"}"); [INFO] [stderr] 56 | let name=s2.next().unwrap(); [INFO] [stderr] 57 | let tail2=s2.next(); [INFO] [stderr] 58 | match tail2{ [INFO] [stderr] 59 | Some(t2) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:56:35 [INFO] [stderr] | [INFO] [stderr] 56 | let mut s2=t.splitn(2,"}"); [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | / match tail2{ [INFO] [stderr] 60 | | Some(t2) => { [INFO] [stderr] 61 | | if let Some(val) = env::var_os(name){ [INFO] [stderr] 62 | | re.push_str(&env_recur(val.to_str().unwrap())); [INFO] [stderr] ... | [INFO] [stderr] 68 | | None => {} [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 59 | if let Some(t2) = tail2 { [INFO] [stderr] 60 | if let Some(val) = env::var_os(name){ [INFO] [stderr] 61 | re.push_str(&env_recur(val.to_str().unwrap())); [INFO] [stderr] 62 | } [INFO] [stderr] 63 | if t2 != ""{ [INFO] [stderr] 64 | re.push_str(&env_recur(t2)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.88s [INFO] running `"docker" "inspect" "a96dfff5da9d2c419a163c1c2765d3d71b920a287858df014da1568dbc5f2b2d"` [INFO] running `"docker" "rm" "-f" "a96dfff5da9d2c419a163c1c2765d3d71b920a287858df014da1568dbc5f2b2d"` [INFO] [stdout] a96dfff5da9d2c419a163c1c2765d3d71b920a287858df014da1568dbc5f2b2d