[INFO] crate iron-sessionstorage 0.6.6 is already in cache [INFO] extracting crate iron-sessionstorage 0.6.6 into work/ex/clippy-test-run/sources/stable/reg/iron-sessionstorage/0.6.6 [INFO] extracting crate iron-sessionstorage 0.6.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/iron-sessionstorage/0.6.6 [INFO] validating manifest of iron-sessionstorage-0.6.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of iron-sessionstorage-0.6.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing iron-sessionstorage-0.6.6 [INFO] finished frobbing iron-sessionstorage-0.6.6 [INFO] frobbed toml for iron-sessionstorage-0.6.6 written to work/ex/clippy-test-run/sources/stable/reg/iron-sessionstorage/0.6.6/Cargo.toml [INFO] started frobbing iron-sessionstorage-0.6.6 [INFO] finished frobbing iron-sessionstorage-0.6.6 [INFO] frobbed toml for iron-sessionstorage-0.6.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/iron-sessionstorage/0.6.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting iron-sessionstorage-0.6.6 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/iron-sessionstorage/0.6.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] aac1a5e7cd28b34959cb8f38fa2ae914334e98b5c8d67d05748cc8b2cdc1cabf [INFO] running `"docker" "start" "-a" "aac1a5e7cd28b34959cb8f38fa2ae914334e98b5c8d67d05748cc8b2cdc1cabf"` [INFO] [stderr] Checking cookie v0.5.1 [INFO] [stderr] Checking iron-sessionstorage v0.6.6 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | backend: backend [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `backend` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | backend: backend [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `backend` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/backends/signedcookie.rs:13:22 [INFO] [stderr] | [INFO] [stderr] 13 | cookie_modifier: Option cookie::Cookie + Send + Sync>>> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/backends/signedcookie.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / fn jar<'a>(&'a self) -> cookie::CookieJar<'a> { [INFO] [stderr] 18 | | self.unsigned_jar.signed() [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/backends/signedcookie.rs:65:22 [INFO] [stderr] | [INFO] [stderr] 65 | cookie_modifier: Option cookie::Cookie + Send + Sync + 'static>>> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/backends/signedcookie.rs:13:22 [INFO] [stderr] | [INFO] [stderr] 13 | cookie_modifier: Option cookie::Cookie + Send + Sync>>> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/backends/signedcookie.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / fn jar<'a>(&'a self) -> cookie::CookieJar<'a> { [INFO] [stderr] 18 | | self.unsigned_jar.signed() [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/backends/signedcookie.rs:65:22 [INFO] [stderr] | [INFO] [stderr] 65 | cookie_modifier: Option cookie::Cookie + Send + Sync + 'static>>> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> examples/basic.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] extern crate iron; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> examples/login.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / format!("This is an insecure demo, so which username do you want to log in as?
\n\ [INFO] [stderr] 42 | |
\n\ [INFO] [stderr] 43 | | \n\ [INFO] [stderr] 44 | | \n\ [INFO] [stderr] 45 | |
") [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 41 | "This is an insecure demo, so which username do you want to log in as?
\n\ [INFO] [stderr] 42 |
\n\ [INFO] [stderr] 43 | \n\ [INFO] [stderr] 44 | \n\ [INFO] [stderr] 45 |
".to_string() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.40s [INFO] running `"docker" "inspect" "aac1a5e7cd28b34959cb8f38fa2ae914334e98b5c8d67d05748cc8b2cdc1cabf"` [INFO] running `"docker" "rm" "-f" "aac1a5e7cd28b34959cb8f38fa2ae914334e98b5c8d67d05748cc8b2cdc1cabf"` [INFO] [stdout] aac1a5e7cd28b34959cb8f38fa2ae914334e98b5c8d67d05748cc8b2cdc1cabf