[INFO] crate iron-params 0.1.3 is already in cache
[INFO] extracting crate iron-params 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/iron-params/0.1.3
[INFO] extracting crate iron-params 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/iron-params/0.1.3
[INFO] validating manifest of iron-params-0.1.3 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of iron-params-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing iron-params-0.1.3
[INFO] finished frobbing iron-params-0.1.3
[INFO] frobbed toml for iron-params-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/iron-params/0.1.3/Cargo.toml
[INFO] started frobbing iron-params-0.1.3
[INFO] finished frobbing iron-params-0.1.3
[INFO] frobbed toml for iron-params-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/iron-params/0.1.3/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting iron-params-0.1.3 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/iron-params/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e850c981138dd46ec7b0e72a0857123aa20a898dcd7ab822290214f14930190c
[INFO] running `"docker" "start" "-a" "e850c981138dd46ec7b0e72a0857123aa20a898dcd7ab822290214f14930190c"`
[INFO] [stderr]     Checking iron v0.4.0
[INFO] [stderr]     Checking iron-params v0.1.3 (/opt/crater/workdir)
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/lib.rs:67:9
[INFO] [stderr]    |
[INFO] [stderr] 67 |     let mut reader = &mut req.body;
[INFO] [stderr]    |         ----^^^^^^
[INFO] [stderr]    |         |
[INFO] [stderr]    |         help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/lib.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     fn param<'c, 'd, F: FromStr>(&'c self, name: &'d str) -> Option<F>;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/lib.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 |     fn body<'c, 'd>(&'c self) -> Option<&'c String>;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/lib.rs:15:17
[INFO] [stderr]    |
[INFO] [stderr] 15 |     fn body<'c, 'd>(&'c self) -> Option<&'c String>;
[INFO] [stderr]    |                 ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/lib.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 | /     fn param<'c, 'd, F: FromStr>(&'c self, name: &'d str) -> Option<F> {
[INFO] [stderr] 26 | |         match self.params(name) {
[INFO] [stderr] 27 | |             Some(vec) if vec.len() > 0 => vec[0].clone().parse().ok(),
[INFO] [stderr] 28 | |             _ => None,
[INFO] [stderr] 29 | |         }
[INFO] [stderr] 30 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/lib.rs:27:26
[INFO] [stderr]    |
[INFO] [stderr] 27 |             Some(vec) if vec.len() > 0 => vec[0].clone().parse().ok(),
[INFO] [stderr]    |                          ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vec.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/lib.rs:31:5
[INFO] [stderr]    |
[INFO] [stderr] 31 | /     fn body<'c, 'd>(&'c self) -> Option<&'c String> {
[INFO] [stderr] 32 | |         use std::borrow::Borrow;
[INFO] [stderr] 33 | |         self.extensions.get::<Body>().map(|v| v.borrow())
[INFO] [stderr] 34 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/lib.rs:31:17
[INFO] [stderr]    |
[INFO] [stderr] 31 |     fn body<'c, 'd>(&'c self) -> Option<&'c String> {
[INFO] [stderr]    |                 ^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
[INFO] [stderr]   --> src/lib.rs:71:12
[INFO] [stderr]    |
[INFO] [stderr] 71 |         if n <= 0 {
[INFO] [stderr]    |            ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::absurd_extreme_comparisons)] on by default
[INFO] [stderr]    = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using n == 0 instead
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:76:47
[INFO] [stderr]    |
[INFO] [stderr] 76 |     let body = String::from_utf8(vec.clone()).unwrap_or("".into());
[INFO] [stderr]    |                                               ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".into())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/lib.rs:82:19
[INFO] [stderr]    |
[INFO] [stderr] 82 |     for (k, v) in q.into_iter() {
[INFO] [stderr]    |                   ^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `q`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `iron-params`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/lib.rs:67:9
[INFO] [stderr]    |
[INFO] [stderr] 67 |     let mut reader = &mut req.body;
[INFO] [stderr]    |         ----^^^^^^
[INFO] [stderr]    |         |
[INFO] [stderr]    |         help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/lib.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     fn param<'c, 'd, F: FromStr>(&'c self, name: &'d str) -> Option<F>;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/lib.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 |     fn body<'c, 'd>(&'c self) -> Option<&'c String>;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/lib.rs:15:17
[INFO] [stderr]    |
[INFO] [stderr] 15 |     fn body<'c, 'd>(&'c self) -> Option<&'c String>;
[INFO] [stderr]    |                 ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/lib.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 | /     fn param<'c, 'd, F: FromStr>(&'c self, name: &'d str) -> Option<F> {
[INFO] [stderr] 26 | |         match self.params(name) {
[INFO] [stderr] 27 | |             Some(vec) if vec.len() > 0 => vec[0].clone().parse().ok(),
[INFO] [stderr] 28 | |             _ => None,
[INFO] [stderr] 29 | |         }
[INFO] [stderr] 30 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/lib.rs:27:26
[INFO] [stderr]    |
[INFO] [stderr] 27 |             Some(vec) if vec.len() > 0 => vec[0].clone().parse().ok(),
[INFO] [stderr]    |                          ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vec.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/lib.rs:31:5
[INFO] [stderr]    |
[INFO] [stderr] 31 | /     fn body<'c, 'd>(&'c self) -> Option<&'c String> {
[INFO] [stderr] 32 | |         use std::borrow::Borrow;
[INFO] [stderr] 33 | |         self.extensions.get::<Body>().map(|v| v.borrow())
[INFO] [stderr] 34 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/lib.rs:31:17
[INFO] [stderr]    |
[INFO] [stderr] 31 |     fn body<'c, 'd>(&'c self) -> Option<&'c String> {
[INFO] [stderr]    |                 ^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
[INFO] [stderr]   --> src/lib.rs:71:12
[INFO] [stderr]    |
[INFO] [stderr] 71 |         if n <= 0 {
[INFO] [stderr]    |            ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::absurd_extreme_comparisons)] on by default
[INFO] [stderr]    = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using n == 0 instead
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:76:47
[INFO] [stderr]    |
[INFO] [stderr] 76 |     let body = String::from_utf8(vec.clone()).unwrap_or("".into());
[INFO] [stderr]    |                                               ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".into())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/lib.rs:82:19
[INFO] [stderr]    |
[INFO] [stderr] 82 |     for (k, v) in q.into_iter() {
[INFO] [stderr]    |                   ^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `q`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `iron-params`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "e850c981138dd46ec7b0e72a0857123aa20a898dcd7ab822290214f14930190c"`
[INFO] running `"docker" "rm" "-f" "e850c981138dd46ec7b0e72a0857123aa20a898dcd7ab822290214f14930190c"`
[INFO] [stdout] e850c981138dd46ec7b0e72a0857123aa20a898dcd7ab822290214f14930190c