[INFO] crate iron-csrf 0.3.1 is already in cache [INFO] extracting crate iron-csrf 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/iron-csrf/0.3.1 [INFO] extracting crate iron-csrf 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/iron-csrf/0.3.1 [INFO] validating manifest of iron-csrf-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of iron-csrf-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing iron-csrf-0.3.1 [INFO] finished frobbing iron-csrf-0.3.1 [INFO] frobbed toml for iron-csrf-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/iron-csrf/0.3.1/Cargo.toml [INFO] started frobbing iron-csrf-0.3.1 [INFO] finished frobbing iron-csrf-0.3.1 [INFO] frobbed toml for iron-csrf-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/iron-csrf/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting iron-csrf-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/iron-csrf/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 25315b7192c217ac90f523dc891e91293dff2eea69f560dbc67fd18b1a9586a1 [INFO] running `"docker" "start" "-a" "25315b7192c217ac90f523dc891e91293dff2eea69f560dbc67fd18b1a9586a1"` [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking cookie v0.8.1 [INFO] [stderr] Checking chrono v0.3.0 [INFO] [stderr] Checking persistent v0.4.0 [INFO] [stderr] Checking bodyparser v0.8.0 [INFO] [stderr] Checking csrf v0.3.0 [INFO] [stderr] Checking urlencoded v0.6.0 [INFO] [stderr] Checking iron-csrf v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | protected_methods: protected_methods, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `protected_methods` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | protect: protect, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `protect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | handler: handler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `handler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | protect: protect, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `protect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core.rs:293:13 [INFO] [stderr] | [INFO] [stderr] 293 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | protected_methods: protected_methods, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `protected_methods` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | protect: protect, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `protect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | handler: handler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `handler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | protect: protect, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `protect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core.rs:293:13 [INFO] [stderr] | [INFO] [stderr] 293 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/core.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | / raw_cookie [INFO] [stderr] 133 | | .0 [INFO] [stderr] 134 | | .iter() [INFO] [stderr] 135 | | .filter_map(|c| { [INFO] [stderr] ... | [INFO] [stderr] 145 | | .first() [INFO] [stderr] 146 | | .map(|c| c.clone()) [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 132 | raw_cookie [INFO] [stderr] 133 | .0 [INFO] [stderr] 134 | .iter() [INFO] [stderr] 135 | .filter_map(|c| { [INFO] [stderr] 136 | Cookie::parse_encoded(c.clone()) [INFO] [stderr] 137 | .ok() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/core.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | / request [INFO] [stderr] 169 | | .get_ref::() [INFO] [stderr] 170 | | .ok() [INFO] [stderr] 171 | | .and_then(|form| form.get(CSRF_FORM_FIELD)) [INFO] [stderr] ... | [INFO] [stderr] 176 | | }) [INFO] [stderr] 177 | | .map(|t| t.clone()) [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 168 | request [INFO] [stderr] 169 | .get_ref::() [INFO] [stderr] 170 | .ok() [INFO] [stderr] 171 | .and_then(|form| form.get(CSRF_FORM_FIELD)) [INFO] [stderr] 172 | .and_then(|vs| { [INFO] [stderr] 173 | vs.iter() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/core.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | / request [INFO] [stderr] 183 | | .get_ref::() [INFO] [stderr] 184 | | .ok() [INFO] [stderr] 185 | | .and_then(|query| query.get(CSRF_QUERY_STRING)) [INFO] [stderr] ... | [INFO] [stderr] 190 | | }) [INFO] [stderr] 191 | | .map(|t| t.clone()) [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 182 | request [INFO] [stderr] 183 | .get_ref::() [INFO] [stderr] 184 | .ok() [INFO] [stderr] 185 | .and_then(|query| query.get(CSRF_QUERY_STRING)) [INFO] [stderr] 186 | .and_then(|vs| { [INFO] [stderr] 187 | vs.iter() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/core.rs:333:30 [INFO] [stderr] | [INFO] [stderr] 333 | const TEST_QUERY_PARAM: &'static str = "test-param"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/core.rs:334:30 [INFO] [stderr] | [INFO] [stderr] 334 | const TEST_QUERY_VALUE: &'static str = "test-value"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/core.rs:335:30 [INFO] [stderr] | [INFO] [stderr] 335 | const TEST_COOKIE_NAME: &'static str = "some-cookie"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/core.rs:336:31 [INFO] [stderr] | [INFO] [stderr] 336 | const TEST_COOKIE_VALUE: &'static str = "some-value"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/core.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | / raw_cookie [INFO] [stderr] 133 | | .0 [INFO] [stderr] 134 | | .iter() [INFO] [stderr] 135 | | .filter_map(|c| { [INFO] [stderr] ... | [INFO] [stderr] 145 | | .first() [INFO] [stderr] 146 | | .map(|c| c.clone()) [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 132 | raw_cookie [INFO] [stderr] 133 | .0 [INFO] [stderr] 134 | .iter() [INFO] [stderr] 135 | .filter_map(|c| { [INFO] [stderr] 136 | Cookie::parse_encoded(c.clone()) [INFO] [stderr] 137 | .ok() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/core.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | / request [INFO] [stderr] 169 | | .get_ref::() [INFO] [stderr] 170 | | .ok() [INFO] [stderr] 171 | | .and_then(|form| form.get(CSRF_FORM_FIELD)) [INFO] [stderr] ... | [INFO] [stderr] 176 | | }) [INFO] [stderr] 177 | | .map(|t| t.clone()) [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 168 | request [INFO] [stderr] 169 | .get_ref::() [INFO] [stderr] 170 | .ok() [INFO] [stderr] 171 | .and_then(|form| form.get(CSRF_FORM_FIELD)) [INFO] [stderr] 172 | .and_then(|vs| { [INFO] [stderr] 173 | vs.iter() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/core.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | / request [INFO] [stderr] 183 | | .get_ref::() [INFO] [stderr] 184 | | .ok() [INFO] [stderr] 185 | | .and_then(|query| query.get(CSRF_QUERY_STRING)) [INFO] [stderr] ... | [INFO] [stderr] 190 | | }) [INFO] [stderr] 191 | | .map(|t| t.clone()) [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 182 | request [INFO] [stderr] 183 | .get_ref::() [INFO] [stderr] 184 | .ok() [INFO] [stderr] 185 | .and_then(|query| query.get(CSRF_QUERY_STRING)) [INFO] [stderr] 186 | .and_then(|vs| { [INFO] [stderr] 187 | vs.iter() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/core.rs:415:9 [INFO] [stderr] | [INFO] [stderr] 415 | token[0] = token[0] ^ 0x01; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `token[0] ^= 0x01` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/core.rs:417:9 [INFO] [stderr] | [INFO] [stderr] 417 | token[0] = token[0] ^ 0x01; // flip the bit back [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `token[0] ^= 0x01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/core.rs:420:9 [INFO] [stderr] | [INFO] [stderr] 420 | token[16] = token[16] ^ 0x01; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `token[16] ^= 0x01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/core.rs:422:9 [INFO] [stderr] | [INFO] [stderr] 422 | token[16] = token[16] ^ 0x01; // flip the bit back [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `token[16] ^= 0x01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/core.rs:426:9 [INFO] [stderr] | [INFO] [stderr] 426 | token[len - 1] = token[len - 1] ^ 0x01; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `token[len - 1] ^= 0x01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/core.rs:440:9 [INFO] [stderr] | [INFO] [stderr] 440 | cookie[0] = cookie[0] ^ 0x01; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cookie[0] ^= 0x01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/core.rs:442:9 [INFO] [stderr] | [INFO] [stderr] 442 | cookie[0] = cookie[0] ^ 0x01; // flip the bit back [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cookie[0] ^= 0x01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/core.rs:445:9 [INFO] [stderr] | [INFO] [stderr] 445 | cookie[16] = cookie[16] ^ 0x01; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cookie[16] ^= 0x01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/core.rs:447:9 [INFO] [stderr] | [INFO] [stderr] 447 | cookie[16] = cookie[16] ^ 0x01; // flip the bit back [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cookie[16] ^= 0x01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/core.rs:451:9 [INFO] [stderr] | [INFO] [stderr] 451 | cookie[len - 1] = cookie[len - 1] ^ 0x01; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cookie[len - 1] ^= 0x01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/core.rs:512:14 [INFO] [stderr] | [INFO] [stderr] 512 | .unwrap_or("".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/core.rs:522:14 [INFO] [stderr] | [INFO] [stderr] 522 | .unwrap_or("".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/core.rs:532:14 [INFO] [stderr] | [INFO] [stderr] 532 | .unwrap_or("".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/core.rs:554:14 [INFO] [stderr] | [INFO] [stderr] 554 | .unwrap_or("".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/core.rs:732:27 [INFO] [stderr] | [INFO] [stderr] 732 | .find(|c| { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 733 | | c.contains(TEST_COOKIE_NAME) && c.contains(TEST_COOKIE_VALUE) [INFO] [stderr] 734 | | }) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/core.rs:729:13 [INFO] [stderr] | [INFO] [stderr] 729 | / set_cookie [INFO] [stderr] 730 | | .0 [INFO] [stderr] 731 | | .iter() [INFO] [stderr] 732 | | .find(|c| { [INFO] [stderr] 733 | | c.contains(TEST_COOKIE_NAME) && c.contains(TEST_COOKIE_VALUE) [INFO] [stderr] 734 | | }) [INFO] [stderr] 735 | | .is_some() [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 20.22s [INFO] running `"docker" "inspect" "25315b7192c217ac90f523dc891e91293dff2eea69f560dbc67fd18b1a9586a1"` [INFO] running `"docker" "rm" "-f" "25315b7192c217ac90f523dc891e91293dff2eea69f560dbc67fd18b1a9586a1"` [INFO] [stdout] 25315b7192c217ac90f523dc891e91293dff2eea69f560dbc67fd18b1a9586a1