[INFO] crate iridium 0.0.33 is already in cache [INFO] extracting crate iridium 0.0.33 into work/ex/clippy-test-run/sources/stable/reg/iridium/0.0.33 [INFO] extracting crate iridium 0.0.33 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/iridium/0.0.33 [INFO] validating manifest of iridium-0.0.33 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of iridium-0.0.33 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing iridium-0.0.33 [INFO] finished frobbing iridium-0.0.33 [INFO] frobbed toml for iridium-0.0.33 written to work/ex/clippy-test-run/sources/stable/reg/iridium/0.0.33/Cargo.toml [INFO] started frobbing iridium-0.0.33 [INFO] finished frobbing iridium-0.0.33 [INFO] frobbed toml for iridium-0.0.33 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/iridium/0.0.33/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting iridium-0.0.33 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/iridium/0.0.33:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ae70c2bd4ba0909024e773d06b6c1a34b59dc4166a96289508704ee0004144e2 [INFO] running `"docker" "start" "-a" "ae70c2bd4ba0909024e773d06b6c1a34b59dc4166a96289508704ee0004144e2"` [INFO] [stderr] Checking rand_xoshiro v0.1.0 [INFO] [stderr] Checking iridium v0.0.33 (/opt/crater/workdir) [INFO] [stderr] Checking criterion v0.2.9 [INFO] [stderr] warning: unused import: `NodeInfo` [INFO] [stderr] --> src/cluster/client.rs:11:15 [INFO] [stderr] | [INFO] [stderr] 11 | use cluster::{NodeInfo}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `NodeAlias` [INFO] [stderr] --> src/cluster/manager.rs:2:15 [INFO] [stderr] | [INFO] [stderr] 2 | use cluster::{NodeAlias, NodeInfo}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `register` [INFO] [stderr] --> src/assembler/mod.rs:132:21 [INFO] [stderr] | [INFO] [stderr] 132 | let register = i.get_register_number(); [INFO] [stderr] | ^^^^^^^^ help: consider using `_register` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `alias` [INFO] [stderr] --> src/cluster/client.rs:183:33 [INFO] [stderr] | [INFO] [stderr] 183 | ref alias, [INFO] [stderr] | ^^^^^ help: try ignoring the field: `alias: _` [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/assembler/instruction_parsers.rs:115:30 [INFO] [stderr] | [INFO] [stderr] 115 | Some(reg_num.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*reg_num` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/assembler/mod.rs:134:17 [INFO] [stderr] | [INFO] [stderr] 134 | wtr.write_i16::(value.unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cluster/client.rs:180:21 [INFO] [stderr] | [INFO] [stderr] 180 | / match message { [INFO] [stderr] 181 | | &IridiumMessage::HelloAck { [INFO] [stderr] 182 | | ref nodes, [INFO] [stderr] 183 | | ref alias, [INFO] [stderr] ... | [INFO] [stderr] 213 | | } [INFO] [stderr] 214 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 180 | match *message { [INFO] [stderr] 181 | IridiumMessage::HelloAck { [INFO] [stderr] 182 | ref nodes, [INFO] [stderr] 183 | ref alias, [INFO] [stderr] 184 | } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/repl/mod.rs:314:42 [INFO] [stderr] | [INFO] [stderr] 314 | let addr = ip.to_owned() + ":" + port.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 314 | let addr = ip.to_owned() + ":" + &(*port).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 314 | let addr = ip.to_owned() + ":" + &str::clone(port); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `iridium`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "ae70c2bd4ba0909024e773d06b6c1a34b59dc4166a96289508704ee0004144e2"` [INFO] running `"docker" "rm" "-f" "ae70c2bd4ba0909024e773d06b6c1a34b59dc4166a96289508704ee0004144e2"` [INFO] [stdout] ae70c2bd4ba0909024e773d06b6c1a34b59dc4166a96289508704ee0004144e2