[INFO] crate iri-string 0.1.1 is already in cache [INFO] extracting crate iri-string 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/iri-string/0.1.1 [INFO] extracting crate iri-string 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/iri-string/0.1.1 [INFO] validating manifest of iri-string-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of iri-string-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing iri-string-0.1.1 [INFO] finished frobbing iri-string-0.1.1 [INFO] frobbed toml for iri-string-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/iri-string/0.1.1/Cargo.toml [INFO] started frobbing iri-string-0.1.1 [INFO] finished frobbing iri-string-0.1.1 [INFO] frobbed toml for iri-string-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/iri-string/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting iri-string-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/iri-string/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 73662a39b753ff1b6a9ea533981e2765097702f21796a23f46c35d2b6e339c41 [INFO] running `"docker" "start" "-a" "73662a39b753ff1b6a9ea533981e2765097702f21796a23f46c35d2b6e339c41"` [INFO] [stderr] Compiling strum v0.9.0 [INFO] [stderr] Checking opaque_typedef v0.0.3 [INFO] [stderr] Compiling strum_macros v0.9.1 [INFO] [stderr] Compiling opaque_typedef_macros v0.0.3 [INFO] [stderr] Checking iri-string v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `derive_hash_xor_eq` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/absolute.rs:154:24 [INFO] [stderr] | [INFO] [stderr] 154 | #[allow(unknown_lints, derive_hash_xor_eq)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::derive_hash_xor_eq` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `derive_hash_xor_eq` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/absolute.rs:285:24 [INFO] [stderr] | [INFO] [stderr] 285 | #[allow(unknown_lints, derive_hash_xor_eq)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::derive_hash_xor_eq` [INFO] [stderr] [INFO] [stderr] warning: lint name `derive_hash_xor_eq` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/relative.rs:140:24 [INFO] [stderr] | [INFO] [stderr] 140 | #[allow(unknown_lints, derive_hash_xor_eq)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::derive_hash_xor_eq` [INFO] [stderr] [INFO] [stderr] warning: lint name `derive_hash_xor_eq` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/relative.rs:238:24 [INFO] [stderr] | [INFO] [stderr] 238 | #[allow(unknown_lints, derive_hash_xor_eq)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::derive_hash_xor_eq` [INFO] [stderr] [INFO] [stderr] warning: lint name `derive_hash_xor_eq` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/absolute.rs:154:24 [INFO] [stderr] | [INFO] [stderr] 154 | #[allow(unknown_lints, derive_hash_xor_eq)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::derive_hash_xor_eq` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `derive_hash_xor_eq` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/absolute.rs:285:24 [INFO] [stderr] | [INFO] [stderr] 285 | #[allow(unknown_lints, derive_hash_xor_eq)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::derive_hash_xor_eq` [INFO] [stderr] [INFO] [stderr] warning: lint name `derive_hash_xor_eq` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/relative.rs:140:24 [INFO] [stderr] | [INFO] [stderr] 140 | #[allow(unknown_lints, derive_hash_xor_eq)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::derive_hash_xor_eq` [INFO] [stderr] [INFO] [stderr] warning: lint name `derive_hash_xor_eq` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/relative.rs:238:24 [INFO] [stderr] | [INFO] [stderr] 238 | #[allow(unknown_lints, derive_hash_xor_eq)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::derive_hash_xor_eq` [INFO] [stderr] [INFO] [stderr] warning: lint name `derive_hash_xor_eq` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/absolute.rs:154:24 [INFO] [stderr] | [INFO] [stderr] 154 | #[allow(unknown_lints, derive_hash_xor_eq)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::derive_hash_xor_eq` [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/relative.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | return Ok(s); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(s)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/relative.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | return Ok(s); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/relative.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | return Err(RelativeIriParseError::FirstComponentHasColon); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(RelativeIriParseError::FirstComponentHasColon)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/relative.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | return Ok(s); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: lint name `derive_hash_xor_eq` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/absolute.rs:154:24 [INFO] [stderr] | [INFO] [stderr] 154 | #[allow(unknown_lints, derive_hash_xor_eq)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::derive_hash_xor_eq` [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/relative.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | return Ok(s); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(s)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/relative.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | return Ok(s); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/relative.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | return Err(RelativeIriParseError::FirstComponentHasColon); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(RelativeIriParseError::FirstComponentHasColon)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/relative.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | return Ok(s); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/absolute.rs:155:55 [INFO] [stderr] | [INFO] [stderr] 155 | #[derive(Debug, PartialEq, Eq, PartialOrd, Ord, Hash, OpaqueTypedefUnsized)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/absolute.rs:155:55 [INFO] [stderr] | [INFO] [stderr] 155 | #[derive(Debug, PartialEq, Eq, PartialOrd, Ord, Hash, OpaqueTypedefUnsized)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/relative.rs:120:38 [INFO] [stderr] | [INFO] [stderr] 120 | } else if s.as_ref().starts_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/relative.rs:141:55 [INFO] [stderr] | [INFO] [stderr] 141 | #[derive(Debug, PartialEq, Eq, PartialOrd, Ord, Hash, OpaqueTypedefUnsized)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/absolute.rs:155:55 [INFO] [stderr] | [INFO] [stderr] 155 | #[derive(Debug, PartialEq, Eq, PartialOrd, Ord, Hash, OpaqueTypedefUnsized)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/absolute.rs:155:55 [INFO] [stderr] | [INFO] [stderr] 155 | #[derive(Debug, PartialEq, Eq, PartialOrd, Ord, Hash, OpaqueTypedefUnsized)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/absolute.rs:497:18 [INFO] [stderr] | [INFO] [stderr] 497 | ok_cases.into_iter().for_each(|&s| ensure_ok(s)); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/relative.rs:120:38 [INFO] [stderr] | [INFO] [stderr] 120 | } else if s.as_ref().starts_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/relative.rs:141:55 [INFO] [stderr] | [INFO] [stderr] 141 | #[derive(Debug, PartialEq, Eq, PartialOrd, Ord, Hash, OpaqueTypedefUnsized)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `iri-string`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "73662a39b753ff1b6a9ea533981e2765097702f21796a23f46c35d2b6e339c41"` [INFO] running `"docker" "rm" "-f" "73662a39b753ff1b6a9ea533981e2765097702f21796a23f46c35d2b6e339c41"` [INFO] [stdout] 73662a39b753ff1b6a9ea533981e2765097702f21796a23f46c35d2b6e339c41