[INFO] crate irc 0.13.6 is already in cache [INFO] extracting crate irc 0.13.6 into work/ex/clippy-test-run/sources/stable/reg/irc/0.13.6 [INFO] extracting crate irc 0.13.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/irc/0.13.6 [INFO] validating manifest of irc-0.13.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of irc-0.13.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing irc-0.13.6 [INFO] finished frobbing irc-0.13.6 [INFO] frobbed toml for irc-0.13.6 written to work/ex/clippy-test-run/sources/stable/reg/irc/0.13.6/Cargo.toml [INFO] started frobbing irc-0.13.6 [INFO] finished frobbing irc-0.13.6 [INFO] frobbed toml for irc-0.13.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/irc/0.13.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting irc-0.13.6 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/irc/0.13.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1e88c25327f56d9d2dc8e9d823e012e02b4858667858859d8e78fecfce65771b [INFO] running `"docker" "start" "-a" "1e88c25327f56d9d2dc8e9d823e012e02b4858667858859d8e78fecfce65771b"` [INFO] [stderr] Checking args v2.2.0 [INFO] [stderr] Checking tokio-mockstream v1.1.0 [INFO] [stderr] Checking tokio-tls v0.2.1 [INFO] [stderr] Checking irc v0.13.6 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/data/user.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | nickname: nickname, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `nickname` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/data/user.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | username: username, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `username` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/data/user.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | hostname: hostname, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `hostname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/transport.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/transport.rs:236:13 [INFO] [stderr] | [INFO] [stderr] 236 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/mod.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/mod.rs:296:13 [INFO] [stderr] | [INFO] [stderr] 296 | outgoing: outgoing, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `outgoing` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/mod.rs:766:13 [INFO] [stderr] | [INFO] [stderr] 766 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/mod.rs:822:13 [INFO] [stderr] | [INFO] [stderr] 822 | view: view, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `view` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/proto/command.rs:224:70 [INFO] [stderr] | [INFO] [stderr] 224 | Command::SERVICE(ref n, ref r, ref d, ref t, ref re, ref i) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/proto/message.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | tags: tags, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/proto/mode.rs:230:73 [INFO] [stderr] | [INFO] [stderr] 230 | Mode::Plus(ref mode, Some(ref arg)) => write!(f, "{}{} {}", "+", mode, arg), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/proto/mode.rs:231:74 [INFO] [stderr] | [INFO] [stderr] 231 | Mode::Minus(ref mode, Some(ref arg)) => write!(f, "{}{} {}", "-", mode, arg), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/proto/mode.rs:232:61 [INFO] [stderr] | [INFO] [stderr] 232 | Mode::Plus(ref mode, None) => write!(f, "{}{}", "+", mode), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/proto/mode.rs:233:62 [INFO] [stderr] | [INFO] [stderr] 233 | Mode::Minus(ref mode, None) => write!(f, "{}{}", "-", mode), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/data/user.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | nickname: nickname, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `nickname` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/data/user.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | username: username, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `username` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/data/user.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | hostname: hostname, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `hostname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/transport.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/transport.rs:236:13 [INFO] [stderr] | [INFO] [stderr] 236 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/mod.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/mod.rs:296:13 [INFO] [stderr] | [INFO] [stderr] 296 | outgoing: outgoing, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `outgoing` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/mod.rs:766:13 [INFO] [stderr] | [INFO] [stderr] 766 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/mod.rs:822:13 [INFO] [stderr] | [INFO] [stderr] 822 | view: view, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `view` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/proto/command.rs:224:70 [INFO] [stderr] | [INFO] [stderr] 224 | Command::SERVICE(ref n, ref r, ref d, ref t, ref re, ref i) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/proto/message.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | tags: tags, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/proto/mode.rs:230:73 [INFO] [stderr] | [INFO] [stderr] 230 | Mode::Plus(ref mode, Some(ref arg)) => write!(f, "{}{} {}", "+", mode, arg), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/proto/mode.rs:231:74 [INFO] [stderr] | [INFO] [stderr] 231 | Mode::Minus(ref mode, Some(ref arg)) => write!(f, "{}{} {}", "-", mode, arg), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/proto/mode.rs:232:61 [INFO] [stderr] | [INFO] [stderr] 232 | Mode::Plus(ref mode, None) => write!(f, "{}{}", "+", mode), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/proto/mode.rs:233:62 [INFO] [stderr] | [INFO] [stderr] 233 | Mode::Minus(ref mode, None) => write!(f, "{}{}", "-", mode), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/client/mod.rs:1043:13 [INFO] [stderr] | [INFO] [stderr] 1043 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/client/conn.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | / pub fn new<'a>(config: &'a Config, handle: &Handle) -> error::Result> { [INFO] [stderr] 127 | | if config.use_mock_connection() { [INFO] [stderr] 128 | | Ok(ConnectionFuture::Mock(config)) [INFO] [stderr] 129 | | } else if config.use_ssl() { [INFO] [stderr] ... | [INFO] [stderr] 166 | | } [INFO] [stderr] 167 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/conn.rs:130:26 [INFO] [stderr] | [INFO] [stderr] 130 | let domain = format!("{}", config.server()?); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `config.server()?.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/client/mod.rs:246:12 [INFO] [stderr] | [INFO] [stderr] 246 | Ok(self.outgoing.unbounded_send(msg)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 246 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client/mod.rs:315:9 [INFO] [stderr] | [INFO] [stderr] 315 | / match msg.command { [INFO] [stderr] 316 | | PART(ref chan, _) => { [INFO] [stderr] 317 | | let _ = self.chanlists.lock().unwrap().remove(chan); [INFO] [stderr] 318 | | } [INFO] [stderr] 319 | | _ => (), [INFO] [stderr] 320 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 315 | if let PART(ref chan, _) = msg.command { [INFO] [stderr] 316 | let _ = self.chanlists.lock().unwrap().remove(chan); [INFO] [stderr] 317 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 288 [INFO] [stderr] --> src/proto/command.rs:468:5 [INFO] [stderr] | [INFO] [stderr] 468 | / pub fn new(cmd: &str, args: Vec<&str>, suffix: Option<&str>) -> Result { [INFO] [stderr] 469 | | Ok(if cmd.eq_ignore_ascii_case("PASS") { [INFO] [stderr] 470 | | match suffix { [INFO] [stderr] 471 | | Some(suffix) => { [INFO] [stderr] ... | [INFO] [stderr] 1624 | | }) [INFO] [stderr] 1625 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/proto/message.rs:222:60 [INFO] [stderr] | [INFO] [stderr] 222 | state = state.find(" :").map_or("", |i| &state[..i + 1]); [INFO] [stderr] | ^^^^^^^ help: use: `..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/proto/mode.rs:247:26 [INFO] [stderr] | [INFO] [stderr] 247 | pub fn as_user_modes(s: &str) -> Result>, MessageParseError> { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/proto/mode.rs:293:29 [INFO] [stderr] | [INFO] [stderr] 293 | pub fn as_channel_modes(s: &str) -> Result>, MessageParseError> { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/proto/response.rs:415:21 [INFO] [stderr] | [INFO] [stderr] 415 | pub fn is_error(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/client/conn.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | / pub fn new<'a>(config: &'a Config, handle: &Handle) -> error::Result> { [INFO] [stderr] 127 | | if config.use_mock_connection() { [INFO] [stderr] 128 | | Ok(ConnectionFuture::Mock(config)) [INFO] [stderr] 129 | | } else if config.use_ssl() { [INFO] [stderr] ... | [INFO] [stderr] 166 | | } [INFO] [stderr] 167 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/conn.rs:130:26 [INFO] [stderr] | [INFO] [stderr] 130 | let domain = format!("{}", config.server()?); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `config.server()?.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/data/config.rs:562:31 [INFO] [stderr] | [INFO] [stderr] 562 | owners: Some(vec![format!("test")]), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/data/config.rs:563:28 [INFO] [stderr] | [INFO] [stderr] 563 | nickname: Some(format!("test")), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/data/config.rs:566:28 [INFO] [stderr] | [INFO] [stderr] 566 | username: Some(format!("test")), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/data/config.rs:567:28 [INFO] [stderr] | [INFO] [stderr] 567 | realname: Some(format!("test")), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/data/config.rs:569:26 [INFO] [stderr] | [INFO] [stderr] 569 | umodes: Some(format!("+BR")), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `"+BR".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/data/config.rs:570:26 [INFO] [stderr] | [INFO] [stderr] 570 | server: Some(format!("irc.test.net")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"irc.test.net".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/data/config.rs:576:28 [INFO] [stderr] | [INFO] [stderr] 576 | encoding: Some(format!("UTF-8")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"UTF-8".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/data/config.rs:577:33 [INFO] [stderr] | [INFO] [stderr] 577 | channels: Some(vec![format!("#test"), format!("#test2")]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"#test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/data/config.rs:577:51 [INFO] [stderr] | [INFO] [stderr] 577 | channels: Some(vec![format!("#test"), format!("#test2")]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"#test2".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/data/config.rs:617:31 [INFO] [stderr] | [INFO] [stderr] 617 | owners: Some(vec![format!("test"), format!("test2")]), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/data/config.rs:617:48 [INFO] [stderr] | [INFO] [stderr] 617 | owners: Some(vec![format!("test"), format!("test2")]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"test2".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/data/config.rs:630:28 [INFO] [stderr] | [INFO] [stderr] 630 | map.insert(format!("testing"), format!("test")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"testing".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/data/config.rs:630:48 [INFO] [stderr] | [INFO] [stderr] 630 | map.insert(format!("testing"), format!("test")); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/data/user.rs:248:23 [INFO] [stderr] | [INFO] [stderr] 248 | nickname: format!("owner"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"owner".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/data/user.rs:263:23 [INFO] [stderr] | [INFO] [stderr] 263 | nickname: format!("user"), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"user".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/ext.rs:447:28 [INFO] [stderr] | [INFO] [stderr] 447 | nickname: Some(format!("test")), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/ext.rs:448:28 [INFO] [stderr] | [INFO] [stderr] 448 | password: Some(format!("password")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"password".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/client/mod.rs:246:12 [INFO] [stderr] | [INFO] [stderr] 246 | Ok(self.outgoing.unbounded_send(msg)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 246 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client/mod.rs:315:9 [INFO] [stderr] | [INFO] [stderr] 315 | / match msg.command { [INFO] [stderr] 316 | | PART(ref chan, _) => { [INFO] [stderr] 317 | | let _ = self.chanlists.lock().unwrap().remove(chan); [INFO] [stderr] 318 | | } [INFO] [stderr] 319 | | _ => (), [INFO] [stderr] 320 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 315 | if let PART(ref chan, _) = msg.command { [INFO] [stderr] 316 | let _ = self.chanlists.lock().unwrap().remove(chan); [INFO] [stderr] 317 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:853:31 [INFO] [stderr] | [INFO] [stderr] 853 | owners: Some(vec![format!("test")]), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:854:28 [INFO] [stderr] | [INFO] [stderr] 854 | nickname: Some(format!("test")), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:855:34 [INFO] [stderr] | [INFO] [stderr] 855 | alt_nicks: Some(vec![format!("test2")]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"test2".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:856:26 [INFO] [stderr] | [INFO] [stderr] 856 | server: Some(format!("irc.test.net")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"irc.test.net".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:857:33 [INFO] [stderr] | [INFO] [stderr] 857 | channels: Some(vec![format!("#test"), format!("#test2")]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"#test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:857:51 [INFO] [stderr] | [INFO] [stderr] 857 | channels: Some(vec![format!("#test"), format!("#test2")]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"#test2".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:858:29 [INFO] [stderr] | [INFO] [stderr] 858 | user_info: Some(format!("Testing.")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Testing.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:913:33 [INFO] [stderr] | [INFO] [stderr] 913 | nick_password: Some(format!("password")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"password".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:914:33 [INFO] [stderr] | [INFO] [stderr] 914 | channels: Some(vec![format!("#test"), format!("#test2")]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"#test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:914:51 [INFO] [stderr] | [INFO] [stderr] 914 | channels: Some(vec![format!("#test"), format!("#test2")]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"#test2".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:932:28 [INFO] [stderr] | [INFO] [stderr] 932 | nickname: Some(format!("test")), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:933:33 [INFO] [stderr] | [INFO] [stderr] 933 | channels: Some(vec![format!("#test"), format!("#test2")]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"#test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:933:51 [INFO] [stderr] | [INFO] [stderr] 933 | channels: Some(vec![format!("#test"), format!("#test2")]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"#test2".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:936:28 [INFO] [stderr] | [INFO] [stderr] 936 | map.insert(format!("#test2"), format!("password")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"#test2".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:936:47 [INFO] [stderr] | [INFO] [stderr] 936 | map.insert(format!("#test2"), format!("password")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"password".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:956:28 [INFO] [stderr] | [INFO] [stderr] 956 | nickname: Some(format!("test")), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:957:34 [INFO] [stderr] | [INFO] [stderr] 957 | alt_nicks: Some(vec![format!("test2")]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"test2".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:958:33 [INFO] [stderr] | [INFO] [stderr] 958 | nick_password: Some(format!("password")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"password".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:959:33 [INFO] [stderr] | [INFO] [stderr] 959 | channels: Some(vec![format!("#test"), format!("#test2")]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"#test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:959:51 [INFO] [stderr] | [INFO] [stderr] 959 | channels: Some(vec![format!("#test"), format!("#test2")]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"#test2".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:979:28 [INFO] [stderr] | [INFO] [stderr] 979 | nickname: Some(format!("test")), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:980:34 [INFO] [stderr] | [INFO] [stderr] 980 | alt_nicks: Some(vec![format!("test2")]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"test2".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:981:33 [INFO] [stderr] | [INFO] [stderr] 981 | nick_password: Some(format!("password")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"password".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:982:33 [INFO] [stderr] | [INFO] [stderr] 982 | channels: Some(vec![format!("#test"), format!("#test2")]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"#test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:982:51 [INFO] [stderr] | [INFO] [stderr] 982 | channels: Some(vec![format!("#test"), format!("#test2")]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"#test2".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:984:39 [INFO] [stderr] | [INFO] [stderr] 984 | ghost_sequence: Some(vec![format!("RECOVER"), format!("RELEASE")]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"RECOVER".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:984:59 [INFO] [stderr] | [INFO] [stderr] 984 | ghost_sequence: Some(vec![format!("RECOVER"), format!("RELEASE")]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"RELEASE".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:1003:28 [INFO] [stderr] | [INFO] [stderr] 1003 | nickname: Some(format!("test")), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:1004:26 [INFO] [stderr] | [INFO] [stderr] 1004 | umodes: Some(format!("+B")), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using .to_string(): `"+B".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:1005:33 [INFO] [stderr] | [INFO] [stderr] 1005 | channels: Some(vec![format!("#test"), format!("#test2")]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"#test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:1005:51 [INFO] [stderr] | [INFO] [stderr] 1005 | channels: Some(vec![format!("#test"), format!("#test2")]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"#test2".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:1054:31 [INFO] [stderr] | [INFO] [stderr] 1054 | .send(PRIVMSG(format!("#test"), format!("Hi there!"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"#test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:1054:49 [INFO] [stderr] | [INFO] [stderr] 1054 | .send(PRIVMSG(format!("#test"), format!("Hi there!"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Hi there!".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:1068:31 [INFO] [stderr] | [INFO] [stderr] 1068 | .send(PRIVMSG(format!("#test"), format!("Hi there!\r\nJOIN #bad"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"#test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:1068:49 [INFO] [stderr] | [INFO] [stderr] 1068 | .send(PRIVMSG(format!("#test"), format!("Hi there!\r\nJOIN #bad"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Hi there!\r\nJOIN #bad".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:1111:34 [INFO] [stderr] | [INFO] [stderr] 1111 | assert!(client.send(PART(format!("#test"), None)).is_ok()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"#test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 288 [INFO] [stderr] --> src/proto/command.rs:468:5 [INFO] [stderr] | [INFO] [stderr] 468 | / pub fn new(cmd: &str, args: Vec<&str>, suffix: Option<&str>) -> Result { [INFO] [stderr] 469 | | Ok(if cmd.eq_ignore_ascii_case("PASS") { [INFO] [stderr] 470 | | match suffix { [INFO] [stderr] 471 | | Some(suffix) => { [INFO] [stderr] ... | [INFO] [stderr] 1624 | | }) [INFO] [stderr] 1625 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/proto/message.rs:222:60 [INFO] [stderr] | [INFO] [stderr] 222 | state = state.find(" :").map_or("", |i| &state[..i + 1]); [INFO] [stderr] | ^^^^^^^ help: use: `..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/proto/message.rs:287:30 [INFO] [stderr] | [INFO] [stderr] 287 | command: PRIVMSG(format!("test"), format!("Testing!")), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/proto/message.rs:287:47 [INFO] [stderr] | [INFO] [stderr] 287 | command: PRIVMSG(format!("test"), format!("Testing!")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Testing!".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/proto/message.rs:359:30 [INFO] [stderr] | [INFO] [stderr] 359 | command: PRIVMSG(format!("test"), format!("Testing!")), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/proto/message.rs:359:47 [INFO] [stderr] | [INFO] [stderr] 359 | command: PRIVMSG(format!("test"), format!("Testing!")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Testing!".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/proto/message.rs:364:26 [INFO] [stderr] | [INFO] [stderr] 364 | prefix: Some(format!("test!test@test")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"test!test@test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/proto/message.rs:365:30 [INFO] [stderr] | [INFO] [stderr] 365 | command: PRIVMSG(format!("test"), format!("Still testing!")), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/proto/message.rs:365:47 [INFO] [stderr] | [INFO] [stderr] 365 | command: PRIVMSG(format!("test"), format!("Still testing!")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Still testing!".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/proto/message.rs:378:30 [INFO] [stderr] | [INFO] [stderr] 378 | command: PRIVMSG(format!("test"), format!("Testing!")), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/proto/message.rs:378:47 [INFO] [stderr] | [INFO] [stderr] 378 | command: PRIVMSG(format!("test"), format!("Testing!")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Testing!".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/proto/message.rs:386:26 [INFO] [stderr] | [INFO] [stderr] 386 | prefix: Some(format!("test!test@test")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"test!test@test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/proto/message.rs:387:30 [INFO] [stderr] | [INFO] [stderr] 387 | command: PRIVMSG(format!("test"), format!("Still testing!")), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/proto/message.rs:387:47 [INFO] [stderr] | [INFO] [stderr] 387 | command: PRIVMSG(format!("test"), format!("Still testing!")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Still testing!".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/proto/message.rs:397:21 [INFO] [stderr] | [INFO] [stderr] 397 | Tag(format!("aaa"), Some(format!("bbb"))), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `"aaa".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/proto/message.rs:397:42 [INFO] [stderr] | [INFO] [stderr] 397 | Tag(format!("aaa"), Some(format!("bbb"))), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `"bbb".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/proto/message.rs:398:21 [INFO] [stderr] | [INFO] [stderr] 398 | Tag(format!("ccc"), None), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `"ccc".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/proto/message.rs:399:21 [INFO] [stderr] | [INFO] [stderr] 399 | Tag(format!("example.com/ddd"), Some(format!("eee"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"example.com/ddd".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/proto/message.rs:399:54 [INFO] [stderr] | [INFO] [stderr] 399 | Tag(format!("example.com/ddd"), Some(format!("eee"))), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `"eee".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/proto/message.rs:401:26 [INFO] [stderr] | [INFO] [stderr] 401 | prefix: Some(format!("test!test@test")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"test!test@test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/proto/message.rs:402:30 [INFO] [stderr] | [INFO] [stderr] 402 | command: PRIVMSG(format!("test"), format!("Testing with tags!")), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/proto/message.rs:402:47 [INFO] [stderr] | [INFO] [stderr] 402 | command: PRIVMSG(format!("test"), format!("Testing with tags!")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Testing with tags!".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/proto/message.rs:418:30 [INFO] [stderr] | [INFO] [stderr] 418 | command: PRIVMSG(format!("test"), format!("Testing!")), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/proto/message.rs:418:47 [INFO] [stderr] | [INFO] [stderr] 418 | command: PRIVMSG(format!("test"), format!("Testing!")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Testing!".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/proto/message.rs:446:30 [INFO] [stderr] | [INFO] [stderr] 446 | command: PRIVMSG(format!("test"), format!("Testing!")), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/proto/message.rs:446:47 [INFO] [stderr] | [INFO] [stderr] 446 | command: PRIVMSG(format!("test"), format!("Testing!")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Testing!".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/proto/message.rs:452:26 [INFO] [stderr] | [INFO] [stderr] 452 | prefix: Some(format!("test!test@test")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"test!test@test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/proto/message.rs:453:30 [INFO] [stderr] | [INFO] [stderr] 453 | command: PRIVMSG(format!("test"), format!("Still testing!")), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/proto/message.rs:453:47 [INFO] [stderr] | [INFO] [stderr] 453 | command: PRIVMSG(format!("test"), format!("Still testing!")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Still testing!".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/proto/message.rs:465:26 [INFO] [stderr] | [INFO] [stderr] 465 | prefix: Some(format!("test!test@test")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"test!test@test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/proto/message.rs:467:17 [INFO] [stderr] | [INFO] [stderr] 467 | format!("COMMAND"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"COMMAND".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/proto/message.rs:468:22 [INFO] [stderr] | [INFO] [stderr] 468 | vec![format!("ARG:test")], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"ARG:test".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/proto/message.rs:469:22 [INFO] [stderr] | [INFO] [stderr] 469 | Some(format!("Testing!")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Testing!".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/proto/mode.rs:247:26 [INFO] [stderr] | [INFO] [stderr] 247 | pub fn as_user_modes(s: &str) -> Result>, MessageParseError> { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/proto/mode.rs:293:29 [INFO] [stderr] | [INFO] [stderr] 293 | pub fn as_channel_modes(s: &str) -> Result>, MessageParseError> { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/proto/response.rs:415:21 [INFO] [stderr] | [INFO] [stderr] 415 | pub fn is_error(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> examples/multiserver.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / match message.command { [INFO] [stderr] 43 | | Command::PRIVMSG(ref target, ref msg) => { [INFO] [stderr] 44 | | if msg.contains("pickles") { [INFO] [stderr] 45 | | client.send_privmsg(target, "Hi!")?; [INFO] [stderr] ... | [INFO] [stderr] 48 | | _ => (), [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 42 | if let Command::PRIVMSG(ref target, ref msg) = message.command { [INFO] [stderr] 43 | if msg.contains("pickles") { [INFO] [stderr] 44 | client.send_privmsg(target, "Hi!")?; [INFO] [stderr] 45 | } [INFO] [stderr] 46 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 30.92s [INFO] running `"docker" "inspect" "1e88c25327f56d9d2dc8e9d823e012e02b4858667858859d8e78fecfce65771b"` [INFO] running `"docker" "rm" "-f" "1e88c25327f56d9d2dc8e9d823e012e02b4858667858859d8e78fecfce65771b"` [INFO] [stdout] 1e88c25327f56d9d2dc8e9d823e012e02b4858667858859d8e78fecfce65771b