[INFO] crate iploc 0.1.0 is already in cache
[INFO] extracting crate iploc 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/iploc/0.1.0
[INFO] extracting crate iploc 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/iploc/0.1.0
[INFO] validating manifest of iploc-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of iploc-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing iploc-0.1.0
[INFO] finished frobbing iploc-0.1.0
[INFO] frobbed toml for iploc-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/iploc/0.1.0/Cargo.toml
[INFO] started frobbing iploc-0.1.0
[INFO] finished frobbing iploc-0.1.0
[INFO] frobbed toml for iploc-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/iploc/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting iploc-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/iploc/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a4818296d12e97dd147f980e10983d8d8a042379f7ff83b58d02a3a409a6d22a
[INFO] running `"docker" "start" "-a" "a4818296d12e97dd147f980e10983d8d8a042379f7ff83b58d02a3a409a6d22a"`
[INFO] [stderr]     Checking iploc v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/table.rs:27:5
[INFO] [stderr]    |
[INFO] [stderr] 27 |     return Ok(content);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(content)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/table.rs:39:28
[INFO] [stderr]    |
[INFO] [stderr] 39 |         let mut filename = env::home_dir().unwrap();
[INFO] [stderr]    |                            ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]  --> src/util.rs:8:41
[INFO] [stderr]   |
[INFO] [stderr] 8 |         let slices: Vec<_> = self.split(".").collect();
[INFO] [stderr]   |                                         ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array
[INFO] [stderr]   --> src/util.rs:35:27
[INFO] [stderr]    |
[INFO] [stderr] 35 |         let mut s = bytes.into_iter().map(|x| x.to_string() + ".").collect::<Vec<_>>().concat();
[INFO] [stderr]    |                           ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::into_iter_on_array)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `table::IpTable`
[INFO] [stderr]   --> src/table.rs:38:5
[INFO] [stderr]    |
[INFO] [stderr] 38 | /     pub fn new() -> IpTable {
[INFO] [stderr] 39 | |         let mut filename = env::home_dir().unwrap();
[INFO] [stderr] 40 | |         filename.push(".iploc");
[INFO] [stderr] 41 | |         create_dir_all(filename.as_path()).unwrap();
[INFO] [stderr] ...  |
[INFO] [stderr] 47 | |         }
[INFO] [stderr] 48 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 16 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/table.rs:59:13
[INFO] [stderr]    |
[INFO] [stderr] 59 | /             match line.starts_with('#') {
[INFO] [stderr] 60 | |                 true => (),
[INFO] [stderr] 61 | |                 false => {
[INFO] [stderr] 62 | |                     let fields: Vec<_> = line.split("|").collect();
[INFO] [stderr] ...  |
[INFO] [stderr] 74 | |                 }
[INFO] [stderr] 75 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]    |
[INFO] [stderr] 59 |             if !line.starts_with('#') {
[INFO] [stderr] 60 |     let fields: Vec<_> = line.split("|").collect();
[INFO] [stderr] 61 |     if fields.len() > 6 && fields[2] == "ipv4" {
[INFO] [stderr] 62 |         let mut record = Record {
[INFO] [stderr] 63 |             size: 0,
[INFO] [stderr] 64 |             start: 0,
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/table.rs:62:53
[INFO] [stderr]    |
[INFO] [stderr] 62 |                     let fields: Vec<_> = line.split("|").collect();
[INFO] [stderr]    |                                                     ^^^ help: try using a char instead: `'|'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/table.rs:85:24
[INFO] [stderr]    |
[INFO] [stderr] 85 |                   return match ul >= record.start {
[INFO] [stderr]    |  ________________________^
[INFO] [stderr] 86 | |                     true => record.country.clone(),
[INFO] [stderr] 87 | |                     false => String::from("unknown") 
[INFO] [stderr] 88 | |                 }
[INFO] [stderr]    | |_________________^ help: consider using an if/else expression: `if ul >= record.start { record.country.clone() } else { String::from("unknown") }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `iploc`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/table.rs:27:5
[INFO] [stderr]    |
[INFO] [stderr] 27 |     return Ok(content);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(content)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/table.rs:39:28
[INFO] [stderr]    |
[INFO] [stderr] 39 |         let mut filename = env::home_dir().unwrap();
[INFO] [stderr]    |                            ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]  --> src/util.rs:8:41
[INFO] [stderr]   |
[INFO] [stderr] 8 |         let slices: Vec<_> = self.split(".").collect();
[INFO] [stderr]   |                                         ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array
[INFO] [stderr]   --> src/util.rs:35:27
[INFO] [stderr]    |
[INFO] [stderr] 35 |         let mut s = bytes.into_iter().map(|x| x.to_string() + ".").collect::<Vec<_>>().concat();
[INFO] [stderr]    |                           ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::into_iter_on_array)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `table::IpTable`
[INFO] [stderr]   --> src/table.rs:38:5
[INFO] [stderr]    |
[INFO] [stderr] 38 | /     pub fn new() -> IpTable {
[INFO] [stderr] 39 | |         let mut filename = env::home_dir().unwrap();
[INFO] [stderr] 40 | |         filename.push(".iploc");
[INFO] [stderr] 41 | |         create_dir_all(filename.as_path()).unwrap();
[INFO] [stderr] ...  |
[INFO] [stderr] 47 | |         }
[INFO] [stderr] 48 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 16 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/table.rs:59:13
[INFO] [stderr]    |
[INFO] [stderr] 59 | /             match line.starts_with('#') {
[INFO] [stderr] 60 | |                 true => (),
[INFO] [stderr] 61 | |                 false => {
[INFO] [stderr] 62 | |                     let fields: Vec<_> = line.split("|").collect();
[INFO] [stderr] ...  |
[INFO] [stderr] 74 | |                 }
[INFO] [stderr] 75 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]    |
[INFO] [stderr] 59 |             if !line.starts_with('#') {
[INFO] [stderr] 60 |     let fields: Vec<_> = line.split("|").collect();
[INFO] [stderr] 61 |     if fields.len() > 6 && fields[2] == "ipv4" {
[INFO] [stderr] 62 |         let mut record = Record {
[INFO] [stderr] 63 |             size: 0,
[INFO] [stderr] 64 |             start: 0,
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/table.rs:62:53
[INFO] [stderr]    |
[INFO] [stderr] 62 |                     let fields: Vec<_> = line.split("|").collect();
[INFO] [stderr]    |                                                     ^^^ help: try using a char instead: `'|'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/table.rs:85:24
[INFO] [stderr]    |
[INFO] [stderr] 85 |                   return match ul >= record.start {
[INFO] [stderr]    |  ________________________^
[INFO] [stderr] 86 | |                     true => record.country.clone(),
[INFO] [stderr] 87 | |                     false => String::from("unknown") 
[INFO] [stderr] 88 | |                 }
[INFO] [stderr]    | |_________________^ help: consider using an if/else expression: `if ul >= record.start { record.country.clone() } else { String::from("unknown") }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `iploc`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "a4818296d12e97dd147f980e10983d8d8a042379f7ff83b58d02a3a409a6d22a"`
[INFO] running `"docker" "rm" "-f" "a4818296d12e97dd147f980e10983d8d8a042379f7ff83b58d02a3a409a6d22a"`
[INFO] [stdout] a4818296d12e97dd147f980e10983d8d8a042379f7ff83b58d02a3a409a6d22a