[INFO] crate ipgen 0.0.4 is already in cache [INFO] extracting crate ipgen 0.0.4 into work/ex/clippy-test-run/sources/stable/reg/ipgen/0.0.4 [INFO] extracting crate ipgen 0.0.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ipgen/0.0.4 [INFO] validating manifest of ipgen-0.0.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ipgen-0.0.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ipgen-0.0.4 [INFO] finished frobbing ipgen-0.0.4 [INFO] frobbed toml for ipgen-0.0.4 written to work/ex/clippy-test-run/sources/stable/reg/ipgen/0.0.4/Cargo.toml [INFO] started frobbing ipgen-0.0.4 [INFO] finished frobbing ipgen-0.0.4 [INFO] frobbed toml for ipgen-0.0.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ipgen/0.0.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ipgen-0.0.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ipgen/0.0.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8f4f4f1591f00241f30da7090e6002c3e489ad3a7a731a7d2b74472c75eb93f0 [INFO] running `"docker" "start" "-a" "8f4f4f1591f00241f30da7090e6002c3e489ad3a7a731a7d2b74472c75eb93f0"` [INFO] [stderr] Checking ipnetwork v0.10.0 [INFO] [stderr] Checking ipgen v0.0.4 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:39:21 [INFO] [stderr] | [INFO] [stderr] 39 | return ip6(name, net).map(|ip| IpAddr::V6(ip)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ip6(name, net).map(|ip| IpAddr::V6(ip))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:41:29 [INFO] [stderr] | [INFO] [stderr] 41 | Err(msg) => return Err(msg), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(msg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:63:51 [INFO] [stderr] | [INFO] [stderr] 63 | Ok(ip) => return Ok(IpAddr::V4(ip)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(IpAddr::V4(ip))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:65:45 [INFO] [stderr] | [INFO] [stderr] 65 | / return Err(format!("generated IPv4 address ({}) has \ [INFO] [stderr] 66 | | {}", [INFO] [stderr] 67 | | addr, [INFO] [stderr] 68 | | msg)) [INFO] [stderr] | |____________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 65 | Err(format!("generated IPv4 address ({}) has \ [INFO] [stderr] 66 | {}", [INFO] [stderr] 67 | addr, [INFO] [stderr] 68 | msg)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:72:45 [INFO] [stderr] | [INFO] [stderr] 72 | Err(msg) => return Err(msg), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(msg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:75:37 [INFO] [stderr] | [INFO] [stderr] 75 | Err(msg) => return Err(msg), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(msg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:78:29 [INFO] [stderr] | [INFO] [stderr] 78 | Err(msg) => return Err(msg), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(msg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:39:21 [INFO] [stderr] | [INFO] [stderr] 39 | return ip6(name, net).map(|ip| IpAddr::V6(ip)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ip6(name, net).map(|ip| IpAddr::V6(ip))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:41:29 [INFO] [stderr] | [INFO] [stderr] 41 | Err(msg) => return Err(msg), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(msg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:63:51 [INFO] [stderr] | [INFO] [stderr] 63 | Ok(ip) => return Ok(IpAddr::V4(ip)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(IpAddr::V4(ip))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:65:45 [INFO] [stderr] | [INFO] [stderr] 65 | / return Err(format!("generated IPv4 address ({}) has \ [INFO] [stderr] 66 | | {}", [INFO] [stderr] 67 | | addr, [INFO] [stderr] 68 | | msg)) [INFO] [stderr] | |____________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 65 | Err(format!("generated IPv4 address ({}) has \ [INFO] [stderr] 66 | {}", [INFO] [stderr] 67 | addr, [INFO] [stderr] 68 | msg)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:72:45 [INFO] [stderr] | [INFO] [stderr] 72 | Err(msg) => return Err(msg), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(msg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:75:37 [INFO] [stderr] | [INFO] [stderr] 75 | Err(msg) => return Err(msg), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(msg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:78:29 [INFO] [stderr] | [INFO] [stderr] 78 | Err(msg) => return Err(msg), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(msg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:24:53 [INFO] [stderr] | [INFO] [stderr] 24 | let ip_addr = match IpAddr::from_str(cidr.split("/").collect::>()[0]) [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:39:47 [INFO] [stderr] | [INFO] [stderr] 39 | return ip6(name, net).map(|ip| IpAddr::V6(ip)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `IpAddr::V6` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:24:53 [INFO] [stderr] | [INFO] [stderr] 24 | let ip_addr = match IpAddr::from_str(cidr.split("/").collect::>()[0]) [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:39:47 [INFO] [stderr] | [INFO] [stderr] 39 | return ip6(name, net).map(|ip| IpAddr::V6(ip)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `IpAddr::V6` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.06s [INFO] running `"docker" "inspect" "8f4f4f1591f00241f30da7090e6002c3e489ad3a7a731a7d2b74472c75eb93f0"` [INFO] running `"docker" "rm" "-f" "8f4f4f1591f00241f30da7090e6002c3e489ad3a7a731a7d2b74472c75eb93f0"` [INFO] [stdout] 8f4f4f1591f00241f30da7090e6002c3e489ad3a7a731a7d2b74472c75eb93f0