[INFO] crate ipfsapi 0.2.2 is already in cache [INFO] extracting crate ipfsapi 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/ipfsapi/0.2.2 [INFO] extracting crate ipfsapi 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ipfsapi/0.2.2 [INFO] validating manifest of ipfsapi-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ipfsapi-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ipfsapi-0.2.2 [INFO] finished frobbing ipfsapi-0.2.2 [INFO] frobbed toml for ipfsapi-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/ipfsapi/0.2.2/Cargo.toml [INFO] started frobbing ipfsapi-0.2.2 [INFO] finished frobbing ipfsapi-0.2.2 [INFO] frobbed toml for ipfsapi-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ipfsapi/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ipfsapi-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ipfsapi/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c3d840a9f172a5e5406a9545147a988ab01684962fb29178903a706c81f29c1b [INFO] running `"docker" "start" "-a" "c3d840a9f172a5e5406a9545147a988ab01684962fb29178903a706c81f29c1b"` [INFO] [stderr] Checking ipfsapi v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | port: port [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | port: port [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/pin.rs:63:74 [INFO] [stderr] | [INFO] [stderr] 63 | let keys = json_resp.get("Keys").ok_or(err_msg(""))?.as_object().ok_or(err_msg(""))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg(""))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/pin.rs:63:42 [INFO] [stderr] | [INFO] [stderr] 63 | let keys = json_resp.get("Keys").ok_or(err_msg(""))?.as_object().ok_or(err_msg(""))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg(""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/pin.rs:68:27 [INFO] [stderr] | [INFO] [stderr] 68 | pin_type: match &value.get("Type").ok_or(err_msg(""))?.as_str().ok_or(err_msg(""))? { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 69 | | &"direct" => PinType::Direct, [INFO] [stderr] 70 | | &"indirect" => PinType::Indirect, [INFO] [stderr] 71 | | &"recursive" => PinType::Recursive, [INFO] [stderr] 72 | | _ => PinType::Direct [INFO] [stderr] 73 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 68 | pin_type: match value.get("Type").ok_or(err_msg(""))?.as_str().ok_or(err_msg(""))? { [INFO] [stderr] 69 | "direct" => PinType::Direct, [INFO] [stderr] 70 | "indirect" => PinType::Indirect, [INFO] [stderr] 71 | "recursive" => PinType::Recursive, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/pin.rs:68:81 [INFO] [stderr] | [INFO] [stderr] 68 | pin_type: match &value.get("Type").ok_or(err_msg(""))?.as_str().ok_or(err_msg(""))? { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg(""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/pin.rs:68:52 [INFO] [stderr] | [INFO] [stderr] 68 | pin_type: match &value.get("Type").ok_or(err_msg(""))?.as_str().ok_or(err_msg(""))? { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg(""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/pin.rs:63:74 [INFO] [stderr] | [INFO] [stderr] 63 | let keys = json_resp.get("Keys").ok_or(err_msg(""))?.as_object().ok_or(err_msg(""))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg(""))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/pin.rs:63:42 [INFO] [stderr] | [INFO] [stderr] 63 | let keys = json_resp.get("Keys").ok_or(err_msg(""))?.as_object().ok_or(err_msg(""))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg(""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/pin.rs:68:27 [INFO] [stderr] | [INFO] [stderr] 68 | pin_type: match &value.get("Type").ok_or(err_msg(""))?.as_str().ok_or(err_msg(""))? { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 69 | | &"direct" => PinType::Direct, [INFO] [stderr] 70 | | &"indirect" => PinType::Indirect, [INFO] [stderr] 71 | | &"recursive" => PinType::Recursive, [INFO] [stderr] 72 | | _ => PinType::Direct [INFO] [stderr] 73 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 68 | pin_type: match value.get("Type").ok_or(err_msg(""))?.as_str().ok_or(err_msg(""))? { [INFO] [stderr] 69 | "direct" => PinType::Direct, [INFO] [stderr] 70 | "indirect" => PinType::Indirect, [INFO] [stderr] 71 | "recursive" => PinType::Recursive, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/pin.rs:68:81 [INFO] [stderr] | [INFO] [stderr] 68 | pin_type: match &value.get("Type").ok_or(err_msg(""))?.as_str().ok_or(err_msg(""))? { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg(""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/pin.rs:68:52 [INFO] [stderr] | [INFO] [stderr] 68 | pin_type: match &value.get("Type").ok_or(err_msg(""))?.as_str().ok_or(err_msg(""))? { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg(""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:50:34 [INFO] [stderr] | [INFO] [stderr] 50 | let hash = api.block_put("Hello world".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Hello world"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 26.75s [INFO] running `"docker" "inspect" "c3d840a9f172a5e5406a9545147a988ab01684962fb29178903a706c81f29c1b"` [INFO] running `"docker" "rm" "-f" "c3d840a9f172a5e5406a9545147a988ab01684962fb29178903a706c81f29c1b"` [INFO] [stdout] c3d840a9f172a5e5406a9545147a988ab01684962fb29178903a706c81f29c1b