[INFO] crate ipfs-api 0.5.0-alpha2 is already in cache [INFO] extracting crate ipfs-api 0.5.0-alpha2 into work/ex/clippy-test-run/sources/stable/reg/ipfs-api/0.5.0-alpha2 [INFO] extracting crate ipfs-api 0.5.0-alpha2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ipfs-api/0.5.0-alpha2 [INFO] validating manifest of ipfs-api-0.5.0-alpha2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ipfs-api-0.5.0-alpha2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ipfs-api-0.5.0-alpha2 [INFO] finished frobbing ipfs-api-0.5.0-alpha2 [INFO] frobbed toml for ipfs-api-0.5.0-alpha2 written to work/ex/clippy-test-run/sources/stable/reg/ipfs-api/0.5.0-alpha2/Cargo.toml [INFO] started frobbing ipfs-api-0.5.0-alpha2 [INFO] finished frobbing ipfs-api-0.5.0-alpha2 [INFO] frobbed toml for ipfs-api-0.5.0-alpha2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ipfs-api/0.5.0-alpha2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ipfs-api-0.5.0-alpha2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ipfs-api/0.5.0-alpha2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fb9bc5a8ce1f9ae59e01ef0500f6d00b64c4df702b51a565fd69392fc662c47e [INFO] running `"docker" "start" "-a" "fb9bc5a8ce1f9ae59e01ef0500f6d00b64c4df702b51a565fd69392fc662c47e"` [INFO] [stderr] Checking hyper-multipart-rfc7578 v0.2.0-alpha2 [INFO] [stderr] Checking ipfs-api v0.5.0-alpha2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/read.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/read.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `DagPut` [INFO] [stderr] --> src/request/dag.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | pub struct DagPut; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/client.rs:108:22 [INFO] [stderr] | [INFO] [stderr] 108 | Ok(e) => Error::Api(e).into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::Api(e)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/client.rs:110:26 [INFO] [stderr] | [INFO] [stderr] 110 | Ok(s) => Error::Uncategorized(s).into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::Uncategorized(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/client.rs:310:54 [INFO] [stderr] | [INFO] [stderr] 310 | return Box::new(stream::once(Err(err.into()))); [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/read.rs:78:37 [INFO] [stderr] | [INFO] [stderr] 78 | Err(e.into()) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/request/key.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | let s = match self { [INFO] [stderr] | _________________^ [INFO] [stderr] 24 | | &KeyType::Rsa => "rsa", [INFO] [stderr] 25 | | &KeyType::Ed25519 => "ed25519", [INFO] [stderr] 26 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 23 | let s = match *self { [INFO] [stderr] 24 | KeyType::Rsa => "rsa", [INFO] [stderr] 25 | KeyType::Ed25519 => "ed25519", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/request/log.rs:27:17 [INFO] [stderr] | [INFO] [stderr] 27 | let s = match self { [INFO] [stderr] | _________________^ [INFO] [stderr] 28 | | &LoggingLevel::Debug => "debug", [INFO] [stderr] 29 | | &LoggingLevel::Info => "info", [INFO] [stderr] 30 | | &LoggingLevel::Warning => "warning", [INFO] [stderr] 31 | | &LoggingLevel::Error => "error", [INFO] [stderr] 32 | | &LoggingLevel::Critical => "critical", [INFO] [stderr] 33 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 27 | let s = match *self { [INFO] [stderr] 28 | LoggingLevel::Debug => "debug", [INFO] [stderr] 29 | LoggingLevel::Info => "info", [INFO] [stderr] 30 | LoggingLevel::Warning => "warning", [INFO] [stderr] 31 | LoggingLevel::Error => "error", [INFO] [stderr] 32 | LoggingLevel::Critical => "critical", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/request/log.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | let s = match self { [INFO] [stderr] | _________________^ [INFO] [stderr] 50 | | &Logger::All => "*", [INFO] [stderr] 51 | | &Logger::Specific(ref logger) => logger.as_ref(), [INFO] [stderr] 52 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 49 | let s = match *self { [INFO] [stderr] 50 | Logger::All => "*", [INFO] [stderr] 51 | Logger::Specific(ref logger) => logger.as_ref(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/request/object.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | let s = match self { [INFO] [stderr] | _________________^ [INFO] [stderr] 66 | | &ObjectTemplate::UnixFsDir => "unixfs-dir", [INFO] [stderr] 67 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 65 | let s = match *self { [INFO] [stderr] 66 | ObjectTemplate::UnixFsDir => "unixfs-dir", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `DagPut` [INFO] [stderr] --> src/request/dag.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | pub struct DagPut; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/client.rs:108:22 [INFO] [stderr] | [INFO] [stderr] 108 | Ok(e) => Error::Api(e).into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::Api(e)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/client.rs:110:26 [INFO] [stderr] | [INFO] [stderr] 110 | Ok(s) => Error::Uncategorized(s).into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::Uncategorized(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/client.rs:310:54 [INFO] [stderr] | [INFO] [stderr] 310 | return Box::new(stream::once(Err(err.into()))); [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/read.rs:78:37 [INFO] [stderr] | [INFO] [stderr] 78 | Err(e.into()) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/request/key.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | let s = match self { [INFO] [stderr] | _________________^ [INFO] [stderr] 24 | | &KeyType::Rsa => "rsa", [INFO] [stderr] 25 | | &KeyType::Ed25519 => "ed25519", [INFO] [stderr] 26 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 23 | let s = match *self { [INFO] [stderr] 24 | KeyType::Rsa => "rsa", [INFO] [stderr] 25 | KeyType::Ed25519 => "ed25519", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/request/log.rs:27:17 [INFO] [stderr] | [INFO] [stderr] 27 | let s = match self { [INFO] [stderr] | _________________^ [INFO] [stderr] 28 | | &LoggingLevel::Debug => "debug", [INFO] [stderr] 29 | | &LoggingLevel::Info => "info", [INFO] [stderr] 30 | | &LoggingLevel::Warning => "warning", [INFO] [stderr] 31 | | &LoggingLevel::Error => "error", [INFO] [stderr] 32 | | &LoggingLevel::Critical => "critical", [INFO] [stderr] 33 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 27 | let s = match *self { [INFO] [stderr] 28 | LoggingLevel::Debug => "debug", [INFO] [stderr] 29 | LoggingLevel::Info => "info", [INFO] [stderr] 30 | LoggingLevel::Warning => "warning", [INFO] [stderr] 31 | LoggingLevel::Error => "error", [INFO] [stderr] 32 | LoggingLevel::Critical => "critical", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/request/log.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | let s = match self { [INFO] [stderr] | _________________^ [INFO] [stderr] 50 | | &Logger::All => "*", [INFO] [stderr] 51 | | &Logger::Specific(ref logger) => logger.as_ref(), [INFO] [stderr] 52 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 49 | let s = match *self { [INFO] [stderr] 50 | Logger::All => "*", [INFO] [stderr] 51 | Logger::Specific(ref logger) => logger.as_ref(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/request/object.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | let s = match self { [INFO] [stderr] | _________________^ [INFO] [stderr] 66 | | &ObjectTemplate::UnixFsDir => "unixfs-dir", [INFO] [stderr] 67 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 65 | let s = match *self { [INFO] [stderr] 66 | ObjectTemplate::UnixFsDir => "unixfs-dir", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/response/serde.rs:28:12 [INFO] [stderr] | [INFO] [stderr] 28 | Ok(num as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(num)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/response/serde.rs:35:12 [INFO] [stderr] | [INFO] [stderr] 35 | Ok(num as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(num)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/response/serde.rs:49:12 [INFO] [stderr] | [INFO] [stderr] 49 | Ok(num as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(num)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/response/serde.rs:56:12 [INFO] [stderr] | [INFO] [stderr] 56 | Ok(num as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(num)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/response/serde.rs:28:12 [INFO] [stderr] | [INFO] [stderr] 28 | Ok(num as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(num)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/response/serde.rs:35:12 [INFO] [stderr] | [INFO] [stderr] 35 | Ok(num as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(num)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/response/serde.rs:49:12 [INFO] [stderr] | [INFO] [stderr] 49 | Ok(num as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(num)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/response/serde.rs:56:12 [INFO] [stderr] | [INFO] [stderr] 56 | Ok(num as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(num)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> examples/get_commands.rs:22:8 [INFO] [stderr] | [INFO] [stderr] 22 | if cmd.options.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!cmd.options.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> examples/get_commands.rs:29:8 [INFO] [stderr] | [INFO] [stderr] 29 | if cmd.subcommands.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!cmd.subcommands.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 43.36s [INFO] running `"docker" "inspect" "fb9bc5a8ce1f9ae59e01ef0500f6d00b64c4df702b51a565fd69392fc662c47e"` [INFO] running `"docker" "rm" "-f" "fb9bc5a8ce1f9ae59e01ef0500f6d00b64c4df702b51a565fd69392fc662c47e"` [INFO] [stdout] fb9bc5a8ce1f9ae59e01ef0500f6d00b64c4df702b51a565fd69392fc662c47e