[INFO] crate ipfix 0.1.1 is already in cache [INFO] extracting crate ipfix 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/ipfix/0.1.1 [INFO] extracting crate ipfix 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ipfix/0.1.1 [INFO] validating manifest of ipfix-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ipfix-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ipfix-0.1.1 [INFO] finished frobbing ipfix-0.1.1 [INFO] frobbed toml for ipfix-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/ipfix/0.1.1/Cargo.toml [INFO] started frobbing ipfix-0.1.1 [INFO] finished frobbing ipfix-0.1.1 [INFO] frobbed toml for ipfix-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ipfix/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ipfix-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ipfix/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f250c8db653d52c8402ad189d5c03a8eaa5a92ae9db15b73cd837853b3bd0788 [INFO] running `"docker" "start" "-a" "f250c8db653d52c8402ad189d5c03a8eaa5a92ae9db15b73cd837853b3bd0788"` [INFO] [stderr] Checking ipfix v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:286:47 [INFO] [stderr] | [INFO] [stderr] 286 | field_length: field_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_length` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:295:47 [INFO] [stderr] | [INFO] [stderr] 295 | field_length: field_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:397:17 [INFO] [stderr] | [INFO] [stderr] 397 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:482:17 [INFO] [stderr] | [INFO] [stderr] 482 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:529:35 [INFO] [stderr] | [INFO] [stderr] 529 | records.push(DataRecord { values: values }); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:535:28 [INFO] [stderr] | [INFO] [stderr] 535 | records: records, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `records` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:572:35 [INFO] [stderr] | [INFO] [stderr] 572 | records.push(DataRecord { values: values }); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:578:28 [INFO] [stderr] | [INFO] [stderr] 578 | records: records, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `records` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:286:47 [INFO] [stderr] | [INFO] [stderr] 286 | field_length: field_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_length` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:295:47 [INFO] [stderr] | [INFO] [stderr] 295 | field_length: field_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:397:17 [INFO] [stderr] | [INFO] [stderr] 397 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:482:17 [INFO] [stderr] | [INFO] [stderr] 482 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:529:35 [INFO] [stderr] | [INFO] [stderr] 529 | records.push(DataRecord { values: values }); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:535:28 [INFO] [stderr] | [INFO] [stderr] 535 | records: records, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `records` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:572:35 [INFO] [stderr] | [INFO] [stderr] 572 | records.push(DataRecord { values: values }); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:578:28 [INFO] [stderr] | [INFO] [stderr] 578 | records: records, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `records` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:289:16 [INFO] [stderr] | [INFO] [stderr] 289 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 290 | | if let nom::IResult::Done(remaining_data, field_length) = field_length(bytes) { [INFO] [stderr] 291 | | return nom::IResult::Done(remaining_data, [INFO] [stderr] 292 | | FieldSpecifier { [INFO] [stderr] ... | [INFO] [stderr] 297 | | } [INFO] [stderr] 298 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 289 | } else if let nom::IResult::Done(remaining_data, field_length) = field_length(bytes) { [INFO] [stderr] 290 | return nom::IResult::Done(remaining_data, [INFO] [stderr] 291 | FieldSpecifier { [INFO] [stderr] 292 | enterprise_number: None, [INFO] [stderr] 293 | ident: id, [INFO] [stderr] 294 | field_length: field_length, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:289:16 [INFO] [stderr] | [INFO] [stderr] 289 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 290 | | if let nom::IResult::Done(remaining_data, field_length) = field_length(bytes) { [INFO] [stderr] 291 | | return nom::IResult::Done(remaining_data, [INFO] [stderr] 292 | | FieldSpecifier { [INFO] [stderr] ... | [INFO] [stderr] 297 | | } [INFO] [stderr] 298 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 289 | } else if let nom::IResult::Done(remaining_data, field_length) = field_length(bytes) { [INFO] [stderr] 290 | return nom::IResult::Done(remaining_data, [INFO] [stderr] 291 | FieldSpecifier { [INFO] [stderr] 292 | enterprise_number: None, [INFO] [stderr] 293 | ident: id, [INFO] [stderr] 294 | field_length: field_length, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/printer.rs:9:17 [INFO] [stderr] | [INFO] [stderr] 9 | formatters: HashMap String)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/printer.rs:16:22 [INFO] [stderr] | [INFO] [stderr] 16 | 1 => s[0] as u64, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(s[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/printer.rs:17:22 [INFO] [stderr] | [INFO] [stderr] 17 | 2 => conversions::be_buf_to_u16(s) as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(conversions::be_buf_to_u16(s))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/printer.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | 4 => conversions::be_buf_to_u32(s) as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(conversions::be_buf_to_u32(s))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/printer.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | / format!(r#"{{"label":{},"exp":{},"bottom":{}}}"#, [INFO] [stderr] 61 | | label, [INFO] [stderr] 62 | | exp, [INFO] [stderr] 63 | | bottom == 1) [INFO] [stderr] 64 | | .into() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 60 | format!(r#"{{"label":{},"exp":{},"bottom":{}}}"#, [INFO] [stderr] 61 | label, [INFO] [stderr] 62 | exp, [INFO] [stderr] 63 | bottom == 1) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `printer::IpfixPrinter` [INFO] [stderr] --> src/printer.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | / pub fn new() -> IpfixPrinter { [INFO] [stderr] 87 | | // TODO: handle non-default settings here [INFO] [stderr] 88 | | IpfixPrinter { formatters: IpfixPrinter::get_default_parsers() } [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/printer.rs:112:33 [INFO] [stderr] | [INFO] [stderr] 112 | fn get_default_parsers() -> HashMap String)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `IpfixConsumer` [INFO] [stderr] --> src/lib.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | / pub fn new() -> IpfixConsumer { [INFO] [stderr] 101 | | IpfixConsumer { [INFO] [stderr] 102 | | templates: HashMap::new(), [INFO] [stderr] 103 | | options_templates: HashMap::new(), [INFO] [stderr] 104 | | } [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/lib.rs:130:38 [INFO] [stderr] | [INFO] [stderr] 130 | let set_bytes = &bytes.clone()[0..set_length]; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 130 | let set_bytes = &&(*bytes).clone()[0..set_length]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 130 | let set_bytes = &&[u8]::clone(bytes)[0..set_length]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:136:37 [INFO] [stderr] | [INFO] [stderr] 136 | let set = match set_header.set_id.clone() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `set_header.set_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:149:37 [INFO] [stderr] | [INFO] [stderr] 149 | self.templates.get(&set_header.set_id).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.templates[&set_header.set_id]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:154:37 [INFO] [stderr] | [INFO] [stderr] 154 | self.options_templates.get(&set_header.set_id).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.options_templates[&set_header.set_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:205:13 [INFO] [stderr] | [INFO] [stderr] 205 | Err("Data too short".into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"Data too short"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:215:13 [INFO] [stderr] | [INFO] [stderr] 215 | Err("Data too short".into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"Data too short"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `ipfix`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/printer.rs:9:17 [INFO] [stderr] | [INFO] [stderr] 9 | formatters: HashMap String)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/printer.rs:16:22 [INFO] [stderr] | [INFO] [stderr] 16 | 1 => s[0] as u64, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(s[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/printer.rs:17:22 [INFO] [stderr] | [INFO] [stderr] 17 | 2 => conversions::be_buf_to_u16(s) as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(conversions::be_buf_to_u16(s))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/printer.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | 4 => conversions::be_buf_to_u32(s) as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(conversions::be_buf_to_u32(s))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/printer.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | / format!(r#"{{"label":{},"exp":{},"bottom":{}}}"#, [INFO] [stderr] 61 | | label, [INFO] [stderr] 62 | | exp, [INFO] [stderr] 63 | | bottom == 1) [INFO] [stderr] 64 | | .into() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 60 | format!(r#"{{"label":{},"exp":{},"bottom":{}}}"#, [INFO] [stderr] 61 | label, [INFO] [stderr] 62 | exp, [INFO] [stderr] 63 | bottom == 1) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `printer::IpfixPrinter` [INFO] [stderr] --> src/printer.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | / pub fn new() -> IpfixPrinter { [INFO] [stderr] 87 | | // TODO: handle non-default settings here [INFO] [stderr] 88 | | IpfixPrinter { formatters: IpfixPrinter::get_default_parsers() } [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/printer.rs:112:33 [INFO] [stderr] | [INFO] [stderr] 112 | fn get_default_parsers() -> HashMap String)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `IpfixConsumer` [INFO] [stderr] --> src/lib.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | / pub fn new() -> IpfixConsumer { [INFO] [stderr] 101 | | IpfixConsumer { [INFO] [stderr] 102 | | templates: HashMap::new(), [INFO] [stderr] 103 | | options_templates: HashMap::new(), [INFO] [stderr] 104 | | } [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/lib.rs:130:38 [INFO] [stderr] | [INFO] [stderr] 130 | let set_bytes = &bytes.clone()[0..set_length]; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 130 | let set_bytes = &&(*bytes).clone()[0..set_length]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 130 | let set_bytes = &&[u8]::clone(bytes)[0..set_length]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:136:37 [INFO] [stderr] | [INFO] [stderr] 136 | let set = match set_header.set_id.clone() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `set_header.set_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:149:37 [INFO] [stderr] | [INFO] [stderr] 149 | self.templates.get(&set_header.set_id).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.templates[&set_header.set_id]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:154:37 [INFO] [stderr] | [INFO] [stderr] 154 | self.options_templates.get(&set_header.set_id).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.options_templates[&set_header.set_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:205:13 [INFO] [stderr] | [INFO] [stderr] 205 | Err("Data too short".into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"Data too short"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:215:13 [INFO] [stderr] | [INFO] [stderr] 215 | Err("Data too short".into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"Data too short"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `ipfix`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "f250c8db653d52c8402ad189d5c03a8eaa5a92ae9db15b73cd837853b3bd0788"` [INFO] running `"docker" "rm" "-f" "f250c8db653d52c8402ad189d5c03a8eaa5a92ae9db15b73cd837853b3bd0788"` [INFO] [stdout] f250c8db653d52c8402ad189d5c03a8eaa5a92ae9db15b73cd837853b3bd0788