[INFO] crate ip_api 0.1.3 is already in cache [INFO] extracting crate ip_api 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/ip_api/0.1.3 [INFO] extracting crate ip_api 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ip_api/0.1.3 [INFO] validating manifest of ip_api-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ip_api-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ip_api-0.1.3 [INFO] finished frobbing ip_api-0.1.3 [INFO] frobbed toml for ip_api-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/ip_api/0.1.3/Cargo.toml [INFO] started frobbing ip_api-0.1.3 [INFO] finished frobbing ip_api-0.1.3 [INFO] frobbed toml for ip_api-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ip_api/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ip_api-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ip_api/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fc77c443e3ed4a23262395127e6ced150a4a973e86e30aef12287b7b41c48e2a [INFO] running `"docker" "start" "-a" "fc77c443e3ed4a23262395127e6ced150a4a973e86e30aef12287b7b41c48e2a"` [INFO] [stderr] Checking ip_api v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:118:23 [INFO] [stderr] | [INFO] [stderr] 118 | Err(_) => return Err(IpApiError::OtherError( [INFO] [stderr] | _______________________^ [INFO] [stderr] 119 | | format!("Error deserializing json to GeoIp; the body is: {}", body))), [INFO] [stderr] | |_____________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 118 | Err(_) => Err(IpApiError::OtherError( [INFO] [stderr] 119 | format!("Error deserializing json to GeoIp; the body is: {}", body))), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:118:23 [INFO] [stderr] | [INFO] [stderr] 118 | Err(_) => return Err(IpApiError::OtherError( [INFO] [stderr] | _______________________^ [INFO] [stderr] 119 | | format!("Error deserializing json to GeoIp; the body is: {}", body))), [INFO] [stderr] | |_____________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 118 | Err(_) => Err(IpApiError::OtherError( [INFO] [stderr] 119 | format!("Error deserializing json to GeoIp; the body is: {}", body))), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:80:57 [INFO] [stderr] | [INFO] [stderr] 80 | Err(e) => return Err(IpApiError::OtherError(format!("{}", e.description()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `e.description().to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:198:22 [INFO] [stderr] | [INFO] [stderr] 198 | fn as_option(string: &String) -> Option { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 198 | fn as_option(string: &str) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `string.clone()` to [INFO] [stderr] | [INFO] [stderr] 202 | Some(string.to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:80:57 [INFO] [stderr] | [INFO] [stderr] 80 | Err(e) => return Err(IpApiError::OtherError(format!("{}", e.description()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `e.description().to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:198:22 [INFO] [stderr] | [INFO] [stderr] 198 | fn as_option(string: &String) -> Option { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 198 | fn as_option(string: &str) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `string.clone()` to [INFO] [stderr] | [INFO] [stderr] 202 | Some(string.to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> examples/lookup.rs:15:27 [INFO] [stderr] | [INFO] [stderr] 15 | us.country().unwrap_or("unknown".to_owned())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "unknown".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> examples/lookup.rs:26:27 [INFO] [stderr] | [INFO] [stderr] 26 | google.isp().unwrap_or("unknown".to_owned())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "unknown".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.79s [INFO] running `"docker" "inspect" "fc77c443e3ed4a23262395127e6ced150a4a973e86e30aef12287b7b41c48e2a"` [INFO] running `"docker" "rm" "-f" "fc77c443e3ed4a23262395127e6ced150a4a973e86e30aef12287b7b41c48e2a"` [INFO] [stdout] fc77c443e3ed4a23262395127e6ced150a4a973e86e30aef12287b7b41c48e2a