[INFO] crate iot_center 0.0.1 is already in cache [INFO] extracting crate iot_center 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/iot_center/0.0.1 [INFO] extracting crate iot_center 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/iot_center/0.0.1 [INFO] validating manifest of iot_center-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of iot_center-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing iot_center-0.0.1 [INFO] finished frobbing iot_center-0.0.1 [INFO] frobbed toml for iot_center-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/iot_center/0.0.1/Cargo.toml [INFO] started frobbing iot_center-0.0.1 [INFO] finished frobbing iot_center-0.0.1 [INFO] frobbed toml for iot_center-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/iot_center/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting iot_center-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/iot_center/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5386bef20aa402ae4104933702b1ae0a53e5fd37da323a4d29ceb46d2ec5d946 [INFO] running `"docker" "start" "-a" "5386bef20aa402ae4104933702b1ae0a53e5fd37da323a4d29ceb46d2ec5d946"` [INFO] [stderr] Checking chan-signal v0.3.2 [INFO] [stderr] Checking log4rs v0.8.1 [INFO] [stderr] Checking mqtt-protocol v0.3.1 [INFO] [stderr] Checking rumqtt v0.10.1 [INFO] [stderr] Checking iot_center v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: field is never used: `client` [INFO] [stderr] --> src/mqtt/mod.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | client: MqttClient [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/config/mod.rs:43:42 [INFO] [stderr] | [INFO] [stderr] 43 | let mut f = File::open(location).expect(format!("fail to open config file: {}", location).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("fail to open config file: {}", location))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/config/mod.rs:46:40 [INFO] [stderr] | [INFO] [stderr] 46 | f.read_to_string(&mut content).expect(format!("fail to read config file: {}", location).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("fail to read config file: {}", location))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config/mod.rs:68:39 [INFO] [stderr] | [INFO] [stderr] 68 | let profile = env::var("PROFILE").unwrap_or("debug".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "debug".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/config/mod.rs:76:10 [INFO] [stderr] | [INFO] [stderr] 76 | .expect(format!("invalid level: {}", log.level).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("invalid level: {}", log.level))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: field is never used: `client` [INFO] [stderr] --> src/mqtt/mod.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | client: MqttClient [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/config/mod.rs:43:42 [INFO] [stderr] | [INFO] [stderr] 43 | let mut f = File::open(location).expect(format!("fail to open config file: {}", location).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("fail to open config file: {}", location))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/config/mod.rs:46:40 [INFO] [stderr] | [INFO] [stderr] 46 | f.read_to_string(&mut content).expect(format!("fail to read config file: {}", location).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("fail to read config file: {}", location))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config/mod.rs:68:39 [INFO] [stderr] | [INFO] [stderr] 68 | let profile = env::var("PROFILE").unwrap_or("debug".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "debug".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/config/mod.rs:76:10 [INFO] [stderr] | [INFO] [stderr] 76 | .expect(format!("invalid level: {}", log.level).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("invalid level: {}", log.level))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.34s [INFO] running `"docker" "inspect" "5386bef20aa402ae4104933702b1ae0a53e5fd37da323a4d29ceb46d2ec5d946"` [INFO] running `"docker" "rm" "-f" "5386bef20aa402ae4104933702b1ae0a53e5fd37da323a4d29ceb46d2ec5d946"` [INFO] [stdout] 5386bef20aa402ae4104933702b1ae0a53e5fd37da323a4d29ceb46d2ec5d946