[INFO] crate ios7crypt 0.0.5 is already in cache
[INFO] extracting crate ios7crypt 0.0.5 into work/ex/clippy-test-run/sources/stable/reg/ios7crypt/0.0.5
[INFO] extracting crate ios7crypt 0.0.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ios7crypt/0.0.5
[INFO] validating manifest of ios7crypt-0.0.5 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ios7crypt-0.0.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ios7crypt-0.0.5
[INFO] finished frobbing ios7crypt-0.0.5
[INFO] frobbed toml for ios7crypt-0.0.5 written to work/ex/clippy-test-run/sources/stable/reg/ios7crypt/0.0.5/Cargo.toml
[INFO] started frobbing ios7crypt-0.0.5
[INFO] finished frobbing ios7crypt-0.0.5
[INFO] frobbed toml for ios7crypt-0.0.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ios7crypt/0.0.5/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ios7crypt-0.0.5 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ios7crypt/0.0.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 338e1849dd08ad4694589a322e48b3ac55fb85457413b7502bd3090daf6cbc5b
[INFO] running `"docker" "start" "-a" "338e1849dd08ad4694589a322e48b3ac55fb85457413b7502bd3090daf6cbc5b"`
[INFO] [stderr]     Checking ios7crypt v0.0.5 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib/ios7crypt.rs:23:3
[INFO] [stderr]    |
[INFO] [stderr] 23 |   return XLAT_PRIME.iter().cycle().skip(*offset);
[INFO] [stderr]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `XLAT_PRIME.iter().cycle().skip(*offset)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib/ios7crypt.rs:29:3
[INFO] [stderr]    |
[INFO] [stderr] 29 |   return a ^ (*b);
[INFO] [stderr]    |   ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `a ^ (*b)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib/ios7crypt.rs:48:3
[INFO] [stderr]    |
[INFO] [stderr] 48 | /   return match str::from_utf8(s) {
[INFO] [stderr] 49 | |     Ok(v) => match u8::from_str_radix(v, 16) {
[INFO] [stderr] 50 | |       Ok(w) => Some(w),
[INFO] [stderr] 51 | |       Err(_) => None
[INFO] [stderr] 52 | |     },
[INFO] [stderr] 53 | |     Err(_) => None
[INFO] [stderr] 54 | |   };
[INFO] [stderr]    | |____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 48 |   match str::from_utf8(s) {
[INFO] [stderr] 49 |     Ok(v) => match u8::from_str_radix(v, 16) {
[INFO] [stderr] 50 |       Ok(w) => Some(w),
[INFO] [stderr] 51 |       Err(_) => None
[INFO] [stderr] 52 |     },
[INFO] [stderr] 53 |     Err(_) => None
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib/ios7crypt.rs:84:3
[INFO] [stderr]    |
[INFO] [stderr] 84 |   return String::from_utf8(plainbytes.collect()).ok();
[INFO] [stderr]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf8(plainbytes.collect()).ok()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/lib/ios7crypt.rs:22:26
[INFO] [stderr]    |
[INFO] [stderr] 22 | pub fn xlat<'a>(offset : &'a usize) -> iter::Skip<iter::Cycle<slice::Iter<'a, u8>>> {
[INFO] [stderr]    |                          ^^^^^^^^^ help: consider passing by value instead: `usize`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/lib/ios7crypt.rs:38:45
[INFO] [stderr]    |
[INFO] [stderr] 38 |                                        .map(|pair| xor(pair))
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^^^ help: remove closure as shown: `xor`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/lib/ios7crypt.rs:82:52
[INFO] [stderr]    |
[INFO] [stderr] 82 |                                               .map(|pair| xor(pair));
[INFO] [stderr]    |                                                    ^^^^^^^^^^^^^^^^ help: remove closure as shown: `xor`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib/ios7crypt.rs:23:3
[INFO] [stderr]    |
[INFO] [stderr] 23 |   return XLAT_PRIME.iter().cycle().skip(*offset);
[INFO] [stderr]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `XLAT_PRIME.iter().cycle().skip(*offset)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib/ios7crypt.rs:29:3
[INFO] [stderr]    |
[INFO] [stderr] 29 |   return a ^ (*b);
[INFO] [stderr]    |   ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `a ^ (*b)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib/ios7crypt.rs:48:3
[INFO] [stderr]    |
[INFO] [stderr] 48 | /   return match str::from_utf8(s) {
[INFO] [stderr] 49 | |     Ok(v) => match u8::from_str_radix(v, 16) {
[INFO] [stderr] 50 | |       Ok(w) => Some(w),
[INFO] [stderr] 51 | |       Err(_) => None
[INFO] [stderr] 52 | |     },
[INFO] [stderr] 53 | |     Err(_) => None
[INFO] [stderr] 54 | |   };
[INFO] [stderr]    | |____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 48 |   match str::from_utf8(s) {
[INFO] [stderr] 49 |     Ok(v) => match u8::from_str_radix(v, 16) {
[INFO] [stderr] 50 |       Ok(w) => Some(w),
[INFO] [stderr] 51 |       Err(_) => None
[INFO] [stderr] 52 |     },
[INFO] [stderr] 53 |     Err(_) => None
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib/ios7crypt.rs:84:3
[INFO] [stderr]    |
[INFO] [stderr] 84 |   return String::from_utf8(plainbytes.collect()).ok();
[INFO] [stderr]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf8(plainbytes.collect()).ok()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/lib/ios7crypt.rs:22:26
[INFO] [stderr]    |
[INFO] [stderr] 22 | pub fn xlat<'a>(offset : &'a usize) -> iter::Skip<iter::Cycle<slice::Iter<'a, u8>>> {
[INFO] [stderr]    |                          ^^^^^^^^^ help: consider passing by value instead: `usize`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/lib/ios7crypt.rs:38:45
[INFO] [stderr]    |
[INFO] [stderr] 38 |                                        .map(|pair| xor(pair))
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^^^ help: remove closure as shown: `xor`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/lib/ios7crypt.rs:82:52
[INFO] [stderr]    |
[INFO] [stderr] 82 |                                               .map(|pair| xor(pair));
[INFO] [stderr]    |                                                    ^^^^^^^^^^^^^^^^ help: remove closure as shown: `xor`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/bin/ios7crypt.rs:14:18
[INFO] [stderr]    |
[INFO] [stderr] 14 | fn usage(brief : &String, opts : &getopts::Options) {
[INFO] [stderr]    |                  ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/bin/ios7crypt.rs:14:18
[INFO] [stderr]    |
[INFO] [stderr] 14 | fn usage(brief : &String, opts : &getopts::Options) {
[INFO] [stderr]    |                  ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.47s
[INFO] running `"docker" "inspect" "338e1849dd08ad4694589a322e48b3ac55fb85457413b7502bd3090daf6cbc5b"`
[INFO] running `"docker" "rm" "-f" "338e1849dd08ad4694589a322e48b3ac55fb85457413b7502bd3090daf6cbc5b"`
[INFO] [stdout] 338e1849dd08ad4694589a322e48b3ac55fb85457413b7502bd3090daf6cbc5b