[INFO] crate io-at 0.4.1 is already in cache [INFO] extracting crate io-at 0.4.1 into work/ex/clippy-test-run/sources/stable/reg/io-at/0.4.1 [INFO] extracting crate io-at 0.4.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/io-at/0.4.1 [INFO] validating manifest of io-at-0.4.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of io-at-0.4.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing io-at-0.4.1 [INFO] finished frobbing io-at-0.4.1 [INFO] frobbed toml for io-at-0.4.1 written to work/ex/clippy-test-run/sources/stable/reg/io-at/0.4.1/Cargo.toml [INFO] started frobbing io-at-0.4.1 [INFO] finished frobbing io-at-0.4.1 [INFO] frobbed toml for io-at-0.4.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/io-at/0.4.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting io-at-0.4.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/io-at/0.4.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bf1a72d807aa97fd2209c3620946766930c7eba1058317017ffbc011759aad65 [INFO] running `"docker" "start" "-a" "bf1a72d807aa97fd2209c3620946766930c7eba1058317017ffbc011759aad65"` [INFO] [stderr] Checking io-at v0.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:121:16 [INFO] [stderr] | [INFO] [stderr] 121 | Take { max_offs : max_offs, inner: v } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_offs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:208:27 [INFO] [stderr] | [INFO] [stderr] 208 | BlockLimitWrite { max_per_block: max_per_block, inner: v } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_per_block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:300:14 [INFO] [stderr] | [INFO] [stderr] 300 | At { offs : offs, inner: v } [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `offs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:121:16 [INFO] [stderr] | [INFO] [stderr] 121 | Take { max_offs : max_offs, inner: v } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_offs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:208:27 [INFO] [stderr] | [INFO] [stderr] 208 | BlockLimitWrite { max_per_block: max_per_block, inner: v } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_per_block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:300:14 [INFO] [stderr] | [INFO] [stderr] 300 | At { offs : offs, inner: v } [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `offs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: item `Take` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:119:1 [INFO] [stderr] | [INFO] [stderr] 119 | / impl Take { [INFO] [stderr] 120 | | pub fn new(v: T, max_offs: u64) -> Self { [INFO] [stderr] 121 | | Take { max_offs : max_offs, inner: v } [INFO] [stderr] 122 | | } [INFO] [stderr] ... | [INFO] [stderr] 126 | | } [INFO] [stderr] 127 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:153:5 [INFO] [stderr] | [INFO] [stderr] 153 | / fn deref<'a>(&'a self) -> &'a T { [INFO] [stderr] 154 | | &self.inner [INFO] [stderr] 155 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:159:5 [INFO] [stderr] | [INFO] [stderr] 159 | / fn deref_mut<'a>(&'a mut self) -> &'a mut T { [INFO] [stderr] 160 | | &mut self.inner [INFO] [stderr] 161 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:226:5 [INFO] [stderr] | [INFO] [stderr] 226 | / fn deref<'a>(&'a self) -> &'a T { [INFO] [stderr] 227 | | &self.inner [INFO] [stderr] 228 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:232:5 [INFO] [stderr] | [INFO] [stderr] 232 | / fn deref_mut<'a>(&'a mut self) -> &'a mut T { [INFO] [stderr] 233 | | &mut self.inner [INFO] [stderr] 234 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:318:5 [INFO] [stderr] | [INFO] [stderr] 318 | / fn deref<'a>(&'a self) -> &'a T { [INFO] [stderr] 319 | | &self.inner [INFO] [stderr] 320 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:324:5 [INFO] [stderr] | [INFO] [stderr] 324 | / fn deref_mut<'a>(&'a mut self) -> &'a mut T { [INFO] [stderr] 325 | | &mut self.inner [INFO] [stderr] 326 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/os/raw.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / fn deref<'a>(&'a self) -> &'a T { [INFO] [stderr] 28 | | &self.0 [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/os/raw.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / fn deref_mut<'a>(&'a mut self) -> &'a mut T { [INFO] [stderr] 34 | | &mut self.0 [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/vec.rs:28:12 [INFO] [stderr] | [INFO] [stderr] 28 | if buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: item `Take` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:119:1 [INFO] [stderr] | [INFO] [stderr] 119 | / impl Take { [INFO] [stderr] 120 | | pub fn new(v: T, max_offs: u64) -> Self { [INFO] [stderr] 121 | | Take { max_offs : max_offs, inner: v } [INFO] [stderr] 122 | | } [INFO] [stderr] ... | [INFO] [stderr] 126 | | } [INFO] [stderr] 127 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:153:5 [INFO] [stderr] | [INFO] [stderr] 153 | / fn deref<'a>(&'a self) -> &'a T { [INFO] [stderr] 154 | | &self.inner [INFO] [stderr] 155 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:159:5 [INFO] [stderr] | [INFO] [stderr] 159 | / fn deref_mut<'a>(&'a mut self) -> &'a mut T { [INFO] [stderr] 160 | | &mut self.inner [INFO] [stderr] 161 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:226:5 [INFO] [stderr] | [INFO] [stderr] 226 | / fn deref<'a>(&'a self) -> &'a T { [INFO] [stderr] 227 | | &self.inner [INFO] [stderr] 228 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:232:5 [INFO] [stderr] | [INFO] [stderr] 232 | / fn deref_mut<'a>(&'a mut self) -> &'a mut T { [INFO] [stderr] 233 | | &mut self.inner [INFO] [stderr] 234 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:318:5 [INFO] [stderr] | [INFO] [stderr] 318 | / fn deref<'a>(&'a self) -> &'a T { [INFO] [stderr] 319 | | &self.inner [INFO] [stderr] 320 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:324:5 [INFO] [stderr] | [INFO] [stderr] 324 | / fn deref_mut<'a>(&'a mut self) -> &'a mut T { [INFO] [stderr] 325 | | &mut self.inner [INFO] [stderr] 326 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/os/raw.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / fn deref<'a>(&'a self) -> &'a T { [INFO] [stderr] 28 | | &self.0 [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/os/raw.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / fn deref_mut<'a>(&'a mut self) -> &'a mut T { [INFO] [stderr] 34 | | &mut self.0 [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/vec.rs:28:12 [INFO] [stderr] | [INFO] [stderr] 28 | if buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.45s [INFO] running `"docker" "inspect" "bf1a72d807aa97fd2209c3620946766930c7eba1058317017ffbc011759aad65"` [INFO] running `"docker" "rm" "-f" "bf1a72d807aa97fd2209c3620946766930c7eba1058317017ffbc011759aad65"` [INFO] [stdout] bf1a72d807aa97fd2209c3620946766930c7eba1058317017ffbc011759aad65