[INFO] crate intrusive-collections 0.7.8 is already in cache [INFO] extracting crate intrusive-collections 0.7.8 into work/ex/clippy-test-run/sources/stable/reg/intrusive-collections/0.7.8 [INFO] extracting crate intrusive-collections 0.7.8 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/intrusive-collections/0.7.8 [INFO] validating manifest of intrusive-collections-0.7.8 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of intrusive-collections-0.7.8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing intrusive-collections-0.7.8 [INFO] finished frobbing intrusive-collections-0.7.8 [INFO] frobbed toml for intrusive-collections-0.7.8 written to work/ex/clippy-test-run/sources/stable/reg/intrusive-collections/0.7.8/Cargo.toml [INFO] started frobbing intrusive-collections-0.7.8 [INFO] finished frobbing intrusive-collections-0.7.8 [INFO] frobbed toml for intrusive-collections-0.7.8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/intrusive-collections/0.7.8/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting intrusive-collections-0.7.8 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/intrusive-collections/0.7.8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ddd467a89009d1b808670f7134c3849d160e0c3068faf3a1f67434a4d17268a9 [INFO] running `"docker" "start" "-a" "ddd467a89009d1b808670f7134c3849d160e0c3068faf3a1f67434a4d17268a9"` [INFO] [stderr] Checking intrusive-collections v0.7.8 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/linked_list.rs:1003:13 [INFO] [stderr] | [INFO] [stderr] 1003 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rbtree.rs:1682:13 [INFO] [stderr] | [INFO] [stderr] 1682 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/singly_linked_list.rs:773:13 [INFO] [stderr] | [INFO] [stderr] 773 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/linked_list.rs:1003:13 [INFO] [stderr] | [INFO] [stderr] 1003 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rbtree.rs:1682:13 [INFO] [stderr] | [INFO] [stderr] 1682 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/singly_linked_list.rs:773:13 [INFO] [stderr] | [INFO] [stderr] 773 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/rbtree.rs:1251:28 [INFO] [stderr] | [INFO] [stderr] 1251 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 1252 | | if tree.right().is_null() { [INFO] [stderr] 1253 | | tree.insert_right(new, &mut self.root); [INFO] [stderr] 1254 | | break; [INFO] [stderr] ... | [INFO] [stderr] 1257 | | } [INFO] [stderr] 1258 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1251 | } else if tree.right().is_null() { [INFO] [stderr] 1252 | tree.insert_right(new, &mut self.root); [INFO] [stderr] 1253 | break; [INFO] [stderr] 1254 | } else { [INFO] [stderr] 1255 | tree = tree.right(); [INFO] [stderr] 1256 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_ptr_alignment` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/adapter.rs:103:52 [INFO] [stderr] | [INFO] [stderr] 103 | #[cfg_attr(feature = "cargo-clippy", allow(cast_ptr_alignment))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cast_ptr_alignment` [INFO] [stderr] | [INFO] [stderr] ::: src/linked_list.rs:997:5 [INFO] [stderr] | [INFO] [stderr] 997 | intrusive_adapter!(ObjAdapter1 = UnsafeRef: Obj { link1: Link }); [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `unneeded_field_pattern` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/adapter.rs:65:52 [INFO] [stderr] | [INFO] [stderr] 65 | #[cfg_attr(feature = "cargo-clippy", allow(unneeded_field_pattern))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unneeded_field_pattern` [INFO] [stderr] | [INFO] [stderr] ::: src/linked_list.rs:997:5 [INFO] [stderr] | [INFO] [stderr] 997 | intrusive_adapter!(ObjAdapter1 = UnsafeRef: Obj { link1: Link }); [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: lint name `forget_copy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/adapter.rs:74:52 [INFO] [stderr] | [INFO] [stderr] 74 | #[cfg_attr(feature = "cargo-clippy", allow(forget_copy))] [INFO] [stderr] | ^^^^^^^^^^^ help: change it to: `clippy::forget_copy` [INFO] [stderr] | [INFO] [stderr] ::: src/linked_list.rs:997:5 [INFO] [stderr] | [INFO] [stderr] 997 | intrusive_adapter!(ObjAdapter1 = UnsafeRef: Obj { link1: Link }); [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_ptr_alignment` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/adapter.rs:103:52 [INFO] [stderr] | [INFO] [stderr] 103 | #[cfg_attr(feature = "cargo-clippy", allow(cast_ptr_alignment))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cast_ptr_alignment` [INFO] [stderr] | [INFO] [stderr] ::: src/linked_list.rs:998:5 [INFO] [stderr] | [INFO] [stderr] 998 | intrusive_adapter!(ObjAdapter2 = UnsafeRef: Obj { link2: Link }); [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: lint name `unneeded_field_pattern` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/adapter.rs:65:52 [INFO] [stderr] | [INFO] [stderr] 65 | #[cfg_attr(feature = "cargo-clippy", allow(unneeded_field_pattern))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unneeded_field_pattern` [INFO] [stderr] | [INFO] [stderr] ::: src/linked_list.rs:998:5 [INFO] [stderr] | [INFO] [stderr] 998 | intrusive_adapter!(ObjAdapter2 = UnsafeRef: Obj { link2: Link }); [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: lint name `forget_copy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/adapter.rs:74:52 [INFO] [stderr] | [INFO] [stderr] 74 | #[cfg_attr(feature = "cargo-clippy", allow(forget_copy))] [INFO] [stderr] | ^^^^^^^^^^^ help: change it to: `clippy::forget_copy` [INFO] [stderr] | [INFO] [stderr] ::: src/linked_list.rs:998:5 [INFO] [stderr] | [INFO] [stderr] 998 | intrusive_adapter!(ObjAdapter2 = UnsafeRef: Obj { link2: Link }); [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/unsafe_ref.rs:67:21 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn into_raw(ptr: Self) -> *mut T { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/unsafe_ref.rs:89:28 [INFO] [stderr] | [INFO] [stderr] 89 | pub unsafe fn into_box(ptr: Self) -> Box { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_ptr_alignment` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/adapter.rs:103:52 [INFO] [stderr] | [INFO] [stderr] 103 | #[cfg_attr(feature = "cargo-clippy", allow(cast_ptr_alignment))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cast_ptr_alignment` [INFO] [stderr] | [INFO] [stderr] ::: src/linked_list.rs:1343:9 [INFO] [stderr] | [INFO] [stderr] 1343 | intrusive_adapter!(ObjAdapter<'a, T> = &'a Obj<'a, T>: Obj<'a, T> {link: Link} where T: 'a); [INFO] [stderr] | -------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: lint name `unneeded_field_pattern` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/adapter.rs:65:52 [INFO] [stderr] | [INFO] [stderr] 65 | #[cfg_attr(feature = "cargo-clippy", allow(unneeded_field_pattern))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unneeded_field_pattern` [INFO] [stderr] | [INFO] [stderr] ::: src/linked_list.rs:1343:9 [INFO] [stderr] | [INFO] [stderr] 1343 | intrusive_adapter!(ObjAdapter<'a, T> = &'a Obj<'a, T>: Obj<'a, T> {link: Link} where T: 'a); [INFO] [stderr] | -------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: lint name `forget_copy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/adapter.rs:74:52 [INFO] [stderr] | [INFO] [stderr] 74 | #[cfg_attr(feature = "cargo-clippy", allow(forget_copy))] [INFO] [stderr] | ^^^^^^^^^^^ help: change it to: `clippy::forget_copy` [INFO] [stderr] | [INFO] [stderr] ::: src/linked_list.rs:1343:9 [INFO] [stderr] | [INFO] [stderr] 1343 | intrusive_adapter!(ObjAdapter<'a, T> = &'a Obj<'a, T>: Obj<'a, T> {link: Link} where T: 'a); [INFO] [stderr] | -------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/rbtree.rs:1251:28 [INFO] [stderr] | [INFO] [stderr] 1251 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 1252 | | if tree.right().is_null() { [INFO] [stderr] 1253 | | tree.insert_right(new, &mut self.root); [INFO] [stderr] 1254 | | break; [INFO] [stderr] ... | [INFO] [stderr] 1257 | | } [INFO] [stderr] 1258 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1251 | } else if tree.right().is_null() { [INFO] [stderr] 1252 | tree.insert_right(new, &mut self.root); [INFO] [stderr] 1253 | break; [INFO] [stderr] 1254 | } else { [INFO] [stderr] 1255 | tree = tree.right(); [INFO] [stderr] 1256 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_ptr_alignment` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/adapter.rs:103:52 [INFO] [stderr] | [INFO] [stderr] 103 | #[cfg_attr(feature = "cargo-clippy", allow(cast_ptr_alignment))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cast_ptr_alignment` [INFO] [stderr] | [INFO] [stderr] ::: src/rbtree.rs:1672:5 [INFO] [stderr] | [INFO] [stderr] 1672 | intrusive_adapter!(ObjAdapter = UnsafeRef: Obj { link: Link }); [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: lint name `unneeded_field_pattern` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/adapter.rs:65:52 [INFO] [stderr] | [INFO] [stderr] 65 | #[cfg_attr(feature = "cargo-clippy", allow(unneeded_field_pattern))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unneeded_field_pattern` [INFO] [stderr] | [INFO] [stderr] ::: src/rbtree.rs:1672:5 [INFO] [stderr] | [INFO] [stderr] 1672 | intrusive_adapter!(ObjAdapter = UnsafeRef: Obj { link: Link }); [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: lint name `forget_copy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/adapter.rs:74:52 [INFO] [stderr] | [INFO] [stderr] 74 | #[cfg_attr(feature = "cargo-clippy", allow(forget_copy))] [INFO] [stderr] | ^^^^^^^^^^^ help: change it to: `clippy::forget_copy` [INFO] [stderr] | [INFO] [stderr] ::: src/rbtree.rs:1672:5 [INFO] [stderr] | [INFO] [stderr] 1672 | intrusive_adapter!(ObjAdapter = UnsafeRef: Obj { link: Link }); [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_ptr_alignment` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/adapter.rs:103:52 [INFO] [stderr] | [INFO] [stderr] 103 | #[cfg_attr(feature = "cargo-clippy", allow(cast_ptr_alignment))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cast_ptr_alignment` [INFO] [stderr] | [INFO] [stderr] ::: src/rbtree.rs:2358:9 [INFO] [stderr] | [INFO] [stderr] 2358 | intrusive_adapter!(ObjAdapter<'a, T> = &'a Obj<'a, T>: Obj<'a, T> {link: Link} where T: 'a); [INFO] [stderr] | -------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: lint name `unneeded_field_pattern` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/adapter.rs:65:52 [INFO] [stderr] | [INFO] [stderr] 65 | #[cfg_attr(feature = "cargo-clippy", allow(unneeded_field_pattern))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unneeded_field_pattern` [INFO] [stderr] | [INFO] [stderr] ::: src/rbtree.rs:2358:9 [INFO] [stderr] | [INFO] [stderr] 2358 | intrusive_adapter!(ObjAdapter<'a, T> = &'a Obj<'a, T>: Obj<'a, T> {link: Link} where T: 'a); [INFO] [stderr] | -------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: lint name `forget_copy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/adapter.rs:74:52 [INFO] [stderr] | [INFO] [stderr] 74 | #[cfg_attr(feature = "cargo-clippy", allow(forget_copy))] [INFO] [stderr] | ^^^^^^^^^^^ help: change it to: `clippy::forget_copy` [INFO] [stderr] | [INFO] [stderr] ::: src/rbtree.rs:2358:9 [INFO] [stderr] | [INFO] [stderr] 2358 | intrusive_adapter!(ObjAdapter<'a, T> = &'a Obj<'a, T>: Obj<'a, T> {link: Link} where T: 'a); [INFO] [stderr] | -------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_ptr_alignment` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/adapter.rs:103:52 [INFO] [stderr] | [INFO] [stderr] 103 | #[cfg_attr(feature = "cargo-clippy", allow(cast_ptr_alignment))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cast_ptr_alignment` [INFO] [stderr] | [INFO] [stderr] ::: src/singly_linked_list.rs:767:5 [INFO] [stderr] | [INFO] [stderr] 767 | intrusive_adapter!(ObjAdapter1 = UnsafeRef: Obj { link1: Link }); [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: lint name `unneeded_field_pattern` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/adapter.rs:65:52 [INFO] [stderr] | [INFO] [stderr] 65 | #[cfg_attr(feature = "cargo-clippy", allow(unneeded_field_pattern))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unneeded_field_pattern` [INFO] [stderr] | [INFO] [stderr] ::: src/singly_linked_list.rs:767:5 [INFO] [stderr] | [INFO] [stderr] 767 | intrusive_adapter!(ObjAdapter1 = UnsafeRef: Obj { link1: Link }); [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: lint name `forget_copy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/adapter.rs:74:52 [INFO] [stderr] | [INFO] [stderr] 74 | #[cfg_attr(feature = "cargo-clippy", allow(forget_copy))] [INFO] [stderr] | ^^^^^^^^^^^ help: change it to: `clippy::forget_copy` [INFO] [stderr] | [INFO] [stderr] ::: src/singly_linked_list.rs:767:5 [INFO] [stderr] | [INFO] [stderr] 767 | intrusive_adapter!(ObjAdapter1 = UnsafeRef: Obj { link1: Link }); [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_ptr_alignment` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/adapter.rs:103:52 [INFO] [stderr] | [INFO] [stderr] 103 | #[cfg_attr(feature = "cargo-clippy", allow(cast_ptr_alignment))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cast_ptr_alignment` [INFO] [stderr] | [INFO] [stderr] ::: src/singly_linked_list.rs:768:5 [INFO] [stderr] | [INFO] [stderr] 768 | intrusive_adapter!(ObjAdapter2 = UnsafeRef: Obj { link2: Link }); [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: lint name `unneeded_field_pattern` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/adapter.rs:65:52 [INFO] [stderr] | [INFO] [stderr] 65 | #[cfg_attr(feature = "cargo-clippy", allow(unneeded_field_pattern))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unneeded_field_pattern` [INFO] [stderr] | [INFO] [stderr] ::: src/singly_linked_list.rs:768:5 [INFO] [stderr] | [INFO] [stderr] 768 | intrusive_adapter!(ObjAdapter2 = UnsafeRef: Obj { link2: Link }); [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: lint name `forget_copy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/adapter.rs:74:52 [INFO] [stderr] | [INFO] [stderr] 74 | #[cfg_attr(feature = "cargo-clippy", allow(forget_copy))] [INFO] [stderr] | ^^^^^^^^^^^ help: change it to: `clippy::forget_copy` [INFO] [stderr] | [INFO] [stderr] ::: src/singly_linked_list.rs:768:5 [INFO] [stderr] | [INFO] [stderr] 768 | intrusive_adapter!(ObjAdapter2 = UnsafeRef: Obj { link2: Link }); [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_ptr_alignment` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/adapter.rs:103:52 [INFO] [stderr] | [INFO] [stderr] 103 | #[cfg_attr(feature = "cargo-clippy", allow(cast_ptr_alignment))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cast_ptr_alignment` [INFO] [stderr] | [INFO] [stderr] ::: src/singly_linked_list.rs:1083:9 [INFO] [stderr] | [INFO] [stderr] 1083 | intrusive_adapter!(ObjAdapter<'a, T> = &'a Obj<'a, T>: Obj<'a, T> {link: Link} where T: 'a); [INFO] [stderr] | -------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: lint name `unneeded_field_pattern` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/adapter.rs:65:52 [INFO] [stderr] | [INFO] [stderr] 65 | #[cfg_attr(feature = "cargo-clippy", allow(unneeded_field_pattern))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unneeded_field_pattern` [INFO] [stderr] | [INFO] [stderr] ::: src/singly_linked_list.rs:1083:9 [INFO] [stderr] | [INFO] [stderr] 1083 | intrusive_adapter!(ObjAdapter<'a, T> = &'a Obj<'a, T>: Obj<'a, T> {link: Link} where T: 'a); [INFO] [stderr] | -------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: lint name `forget_copy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/adapter.rs:74:52 [INFO] [stderr] | [INFO] [stderr] 74 | #[cfg_attr(feature = "cargo-clippy", allow(forget_copy))] [INFO] [stderr] | ^^^^^^^^^^^ help: change it to: `clippy::forget_copy` [INFO] [stderr] | [INFO] [stderr] ::: src/singly_linked_list.rs:1083:9 [INFO] [stderr] | [INFO] [stderr] 1083 | intrusive_adapter!(ObjAdapter<'a, T> = &'a Obj<'a, T>: Obj<'a, T> {link: Link} where T: 'a); [INFO] [stderr] | -------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_ptr_alignment` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/adapter.rs:103:52 [INFO] [stderr] | [INFO] [stderr] 103 | #[cfg_attr(feature = "cargo-clippy", allow(cast_ptr_alignment))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cast_ptr_alignment` [INFO] [stderr] | [INFO] [stderr] ::: src/linked_list.rs:997:5 [INFO] [stderr] | [INFO] [stderr] 997 | intrusive_adapter!(ObjAdapter1 = UnsafeRef: Obj { link1: Link }); [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/unsafe_ref.rs:67:21 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn into_raw(ptr: Self) -> *mut T { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/unsafe_ref.rs:89:28 [INFO] [stderr] | [INFO] [stderr] 89 | pub unsafe fn into_box(ptr: Self) -> Box { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 37 [INFO] [stderr] --> src/linked_list.rs:1033:5 [INFO] [stderr] | [INFO] [stderr] 1033 | / fn test_cursor() { [INFO] [stderr] 1034 | | let a = make_obj(1); [INFO] [stderr] 1035 | | let b = make_obj(2); [INFO] [stderr] 1036 | | let c = make_obj(3); [INFO] [stderr] ... | [INFO] [stderr] 1112 | | assert_eq!(cur.get().unwrap() as *const _, c.as_ref() as *const _); [INFO] [stderr] 1113 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/linked_list.rs:1141:5 [INFO] [stderr] | [INFO] [stderr] 1141 | / fn test_split_splice() { [INFO] [stderr] 1142 | | let mut l1 = LinkedList::new(ObjAdapter1::new()); [INFO] [stderr] 1143 | | let mut l2 = LinkedList::new(ObjAdapter1::new()); [INFO] [stderr] 1144 | | let mut l3 = LinkedList::new(ObjAdapter1::new()); [INFO] [stderr] ... | [INFO] [stderr] 1214 | | assert_eq!(l3.iter().map(|x| x.value).collect::>(), []); [INFO] [stderr] 1215 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/linked_list.rs:1218:5 [INFO] [stderr] | [INFO] [stderr] 1218 | / fn test_iter() { [INFO] [stderr] 1219 | | let mut l = LinkedList::new(ObjAdapter1::new()); [INFO] [stderr] 1220 | | let a = make_obj(1); [INFO] [stderr] 1221 | | let b = make_obj(2); [INFO] [stderr] ... | [INFO] [stderr] 1287 | | assert!(!d.link1.is_linked()); [INFO] [stderr] 1288 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/rbtree.rs:1717:5 [INFO] [stderr] | [INFO] [stderr] 1717 | / fn test_cursor() { [INFO] [stderr] 1718 | | let a = make_obj(1); [INFO] [stderr] 1719 | | let b = make_obj(2); [INFO] [stderr] 1720 | | let c = make_obj(3); [INFO] [stderr] ... | [INFO] [stderr] 1783 | | ); [INFO] [stderr] 1784 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/rbtree.rs:1787:5 [INFO] [stderr] | [INFO] [stderr] 1787 | / fn test_insert_remove() { [INFO] [stderr] 1788 | | let v = (0..100).map(make_obj).collect::>(); [INFO] [stderr] 1789 | | assert!(v.iter().all(|x| !x.link.is_linked())); [INFO] [stderr] 1790 | | let mut t = RBTree::new(ObjAdapter::new()); [INFO] [stderr] ... | [INFO] [stderr] 1902 | | } [INFO] [stderr] 1903 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/rbtree.rs:1841:30 [INFO] [stderr] | [INFO] [stderr] 1841 | for _ in 0..(index + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `0..=index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/rbtree.rs:1858:21 [INFO] [stderr] | [INFO] [stderr] 1858 | / loop { [INFO] [stderr] 1859 | | if let Some(x) = c.get() { [INFO] [stderr] 1860 | | if x.value > v[i].value { [INFO] [stderr] 1861 | | break; [INFO] [stderr] ... | [INFO] [stderr] 1866 | | c.move_next(); [INFO] [stderr] 1867 | | } [INFO] [stderr] | |_____________________^ help: try: `while let Some(x) = c.get() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/rbtree.rs:1886:21 [INFO] [stderr] | [INFO] [stderr] 1886 | / loop { [INFO] [stderr] 1887 | | if let Some(x) = c.get() { [INFO] [stderr] 1888 | | if x.value < v[i].value { [INFO] [stderr] 1889 | | break; [INFO] [stderr] ... | [INFO] [stderr] 1894 | | c.move_prev(); [INFO] [stderr] 1895 | | } [INFO] [stderr] | |_____________________^ help: try: `while let Some(x) = c.get() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 45 [INFO] [stderr] --> src/rbtree.rs:1906:5 [INFO] [stderr] | [INFO] [stderr] 1906 | / fn test_iter() { [INFO] [stderr] 1907 | | let v = (0..10).map(|x| make_obj(x * 10)).collect::>(); [INFO] [stderr] 1908 | | let mut t = RBTree::new(ObjAdapter::new()); [INFO] [stderr] 1909 | | for x in v.iter() { [INFO] [stderr] ... | [INFO] [stderr] 2148 | | assert_eq!(v2, vec![90, 80, 70, 60, 50, 40, 30, 20, 10, 0]); [INFO] [stderr] 2149 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/rbtree.rs:2152:5 [INFO] [stderr] | [INFO] [stderr] 2152 | / fn test_find() { [INFO] [stderr] 2153 | | let v = (0..10).map(|x| make_obj(x * 10)).collect::>(); [INFO] [stderr] 2154 | | let mut t = RBTree::new(ObjAdapter::new()); [INFO] [stderr] 2155 | | for x in v.iter() { [INFO] [stderr] ... | [INFO] [stderr] 2277 | | } [INFO] [stderr] 2278 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/singly_linked_list.rs:803:5 [INFO] [stderr] | [INFO] [stderr] 803 | / fn test_cursor() { [INFO] [stderr] 804 | | let a = make_obj(1); [INFO] [stderr] 805 | | let b = make_obj(2); [INFO] [stderr] 806 | | let c = make_obj(3); [INFO] [stderr] ... | [INFO] [stderr] 880 | | assert_eq!(cur.get().unwrap() as *const _, c.as_ref() as *const _); [INFO] [stderr] 881 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 34 [INFO] [stderr] --> src/singly_linked_list.rs:884:5 [INFO] [stderr] | [INFO] [stderr] 884 | / fn test_split_splice() { [INFO] [stderr] 885 | | let mut l1 = SinglyLinkedList::new(ObjAdapter1::new()); [INFO] [stderr] 886 | | let mut l2 = SinglyLinkedList::new(ObjAdapter1::new()); [INFO] [stderr] 887 | | let mut l3 = SinglyLinkedList::new(ObjAdapter1::new()); [INFO] [stderr] ... | [INFO] [stderr] 973 | | assert_eq!(l3.iter().map(|x| x.value).collect::>(), []); [INFO] [stderr] 974 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.97s [INFO] running `"docker" "inspect" "ddd467a89009d1b808670f7134c3849d160e0c3068faf3a1f67434a4d17268a9"` [INFO] running `"docker" "rm" "-f" "ddd467a89009d1b808670f7134c3849d160e0c3068faf3a1f67434a4d17268a9"` [INFO] [stdout] ddd467a89009d1b808670f7134c3849d160e0c3068faf3a1f67434a4d17268a9