[INFO] crate inth-oauth2 0.16.0 is already in cache [INFO] extracting crate inth-oauth2 0.16.0 into work/ex/clippy-test-run/sources/stable/reg/inth-oauth2/0.16.0 [INFO] extracting crate inth-oauth2 0.16.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/inth-oauth2/0.16.0 [INFO] validating manifest of inth-oauth2-0.16.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of inth-oauth2-0.16.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing inth-oauth2-0.16.0 [INFO] finished frobbing inth-oauth2-0.16.0 [INFO] frobbed toml for inth-oauth2-0.16.0 written to work/ex/clippy-test-run/sources/stable/reg/inth-oauth2/0.16.0/Cargo.toml [INFO] started frobbing inth-oauth2-0.16.0 [INFO] finished frobbing inth-oauth2-0.16.0 [INFO] frobbed toml for inth-oauth2-0.16.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/inth-oauth2/0.16.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting inth-oauth2-0.16.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/inth-oauth2/0.16.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e8a8ec6ac4d58c5810fbb6c588007bd1585f91c717d83500890c5686c033e282 [INFO] running `"docker" "start" "-a" "e8a8ec6ac4d58c5810fbb6c588007bd1585f91c717d83500890c5686c033e282"` [INFO] [stderr] Checking inth-oauth2 v0.16.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token/bearer.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | lifetime: lifetime, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `lifetime` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token/bearer.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | lifetime: lifetime, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `lifetime` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/provider.rs:49:34 [INFO] [stderr] | [INFO] [stderr] 49 | pub const REDIRECT_URI_OOB: &'static str = "urn:ietf:wg:oauth:2.0:oob"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/provider.rs:56:39 [INFO] [stderr] | [INFO] [stderr] 56 | pub const REDIRECT_URI_OOB_AUTO: &'static str = "urn:ietf:wg:oauth:2.0:oob:auto"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/provider.rs:49:34 [INFO] [stderr] | [INFO] [stderr] 49 | pub const REDIRECT_URI_OOB: &'static str = "urn:ietf:wg:oauth:2.0:oob"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/provider.rs:56:39 [INFO] [stderr] | [INFO] [stderr] 56 | pub const REDIRECT_URI_OOB_AUTO: &'static str = "urn:ietf:wg:oauth:2.0:oob:auto"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/token/refresh.rs:50:14 [INFO] [stderr] | [INFO] [stderr] 50 | .or(Some(&prev.refresh_token)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(&prev.refresh_token))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/token/bearer.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | assert!(refresh.expires() > &Utc::now()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^----------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `Utc::now()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/token/bearer.rs:138:17 [INFO] [stderr] | [INFO] [stderr] 138 | assert!(refresh.expires() <= &(Utc::now() + Duration::seconds(3600))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^--------------------------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(Utc::now() + Duration::seconds(3600))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/token/bearer.rs:165:17 [INFO] [stderr] | [INFO] [stderr] 165 | assert!(refresh.expires() > &Utc::now()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^----------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `Utc::now()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/token/bearer.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | assert!(refresh.expires() <= &(Utc::now() + Duration::seconds(3600))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^--------------------------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(Utc::now() + Duration::seconds(3600))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/token/refresh.rs:50:14 [INFO] [stderr] | [INFO] [stderr] 50 | .or(Some(&prev.refresh_token)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(&prev.refresh_token))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 20.56s [INFO] running `"docker" "inspect" "e8a8ec6ac4d58c5810fbb6c588007bd1585f91c717d83500890c5686c033e282"` [INFO] running `"docker" "rm" "-f" "e8a8ec6ac4d58c5810fbb6c588007bd1585f91c717d83500890c5686c033e282"` [INFO] [stdout] e8a8ec6ac4d58c5810fbb6c588007bd1585f91c717d83500890c5686c033e282