[INFO] crate interval_tree 0.2.0 is already in cache [INFO] extracting crate interval_tree 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/interval_tree/0.2.0 [INFO] extracting crate interval_tree 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/interval_tree/0.2.0 [INFO] validating manifest of interval_tree-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of interval_tree-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing interval_tree-0.2.0 [INFO] finished frobbing interval_tree-0.2.0 [INFO] frobbed toml for interval_tree-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/interval_tree/0.2.0/Cargo.toml [INFO] started frobbing interval_tree-0.2.0 [INFO] finished frobbing interval_tree-0.2.0 [INFO] frobbed toml for interval_tree-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/interval_tree/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting interval_tree-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/interval_tree/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d2f4439ea20d2d7b30fdbe0dd804a0244c6f71db4d7f18f4fc0d3b0939314411 [INFO] running `"docker" "start" "-a" "d2f4439ea20d2d7b30fdbe0dd804a0244c6f71db4d7f18f4fc0d3b0939314411"` [INFO] [stderr] Checking interval_tree v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/segmentpoint.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | combine: combine [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `combine` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/segmentpoint.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/segmentpoint.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pointsegment.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | lower_bound: lower_bound, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lower_bound` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pointsegment.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | upper_bound: upper_bound, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `upper_bound` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pointsegment.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | combine: combine, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `combine` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pointsegment.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pointsegment.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/segmentpoint.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | combine: combine [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `combine` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/segmentpoint.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/segmentpoint.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pointsegment.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | lower_bound: lower_bound, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lower_bound` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pointsegment.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | upper_bound: upper_bound, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `upper_bound` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pointsegment.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | combine: combine, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `combine` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pointsegment.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pointsegment.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/segmentpoint.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | return (self.lower_bound.clone(), self.upper_bound.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.lower_bound.clone(), self.upper_bound.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/segmentpoint.rs:55:60 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn insert(&mut self, start: N, end: N, segment: S) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/segmentpoint.rs:93:44 [INFO] [stderr] | [INFO] [stderr] 93 | default: &S, combine: &F) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/pointsegment.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | acc_r [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/pointsegment.rs:105:25 [INFO] [stderr] | [INFO] [stderr] 105 | let acc_r = match self.right { [INFO] [stderr] | _________________________^ [INFO] [stderr] 106 | | None => acc_l, [INFO] [stderr] 107 | | Some(ref n) => n.query(mid + One::one(), end_q, combine, acc_l) [INFO] [stderr] 108 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/segmentpoint.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | return (self.lower_bound.clone(), self.upper_bound.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.lower_bound.clone(), self.upper_bound.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/segmentpoint.rs:55:60 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn insert(&mut self, start: N, end: N, segment: S) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/segmentpoint.rs:93:44 [INFO] [stderr] | [INFO] [stderr] 93 | default: &S, combine: &F) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/pointsegment.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | acc_r [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/pointsegment.rs:105:25 [INFO] [stderr] | [INFO] [stderr] 105 | let acc_r = match self.right { [INFO] [stderr] | _________________________^ [INFO] [stderr] 106 | | None => acc_l, [INFO] [stderr] 107 | | Some(ref n) => n.query(mid + One::one(), end_q, combine, acc_l) [INFO] [stderr] 108 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/segmentpoint.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | let ref son = if point <= mid_n { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 81 | let son = &(if point <= mid_n { [INFO] [stderr] 82 | &self.left [INFO] [stderr] 83 | } else { [INFO] [stderr] 84 | &self.right [INFO] [stderr] 85 | }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/segmentpoint.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | / self.left.as_mut().map(|n| n.insert(start_s, end_s, [INFO] [stderr] 106 | | value_s, default, combine)); [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 105 | if let Some(n) = self.left.as_mut() { n.insert(start_s, end_s, [INFO] [stderr] 106 | value_s, default, combine) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/segmentpoint.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | / self.right.as_mut().map(|n| n.insert(start_s, end_s, [INFO] [stderr] 113 | | value_s, default, combine)); [INFO] [stderr] | |____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 112 | if let Some(n) = self.right.as_mut() { n.insert(start_s, end_s, [INFO] [stderr] 113 | value_s, default, combine) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/segmentpoint.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | / self.left.as_mut().map(|n| n.insert(start_s, mid_n.clone(), [INFO] [stderr] 120 | | value_s, default, combine)); [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 119 | if let Some(n) = self.left.as_mut() { n.insert(start_s, mid_n.clone(), [INFO] [stderr] 120 | value_s, default, combine) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/segmentpoint.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / self.right.as_mut().map(|n| n.insert(mid_n + One::one(), end_s, [INFO] [stderr] 125 | | value_s, default, combine)); [INFO] [stderr] | |____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 124 | if let Some(n) = self.right.as_mut() { n.insert(mid_n + One::one(), end_s, [INFO] [stderr] 125 | value_s, default, combine) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/pointsegment.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | self.left.as_mut().map(|n| n.insert(point_n, point_data, default, combine)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(n) = self.left.as_mut() { n.insert(point_n, point_data, default, combine) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/pointsegment.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | self.right.as_mut().map(|n| n.insert(point_n, point_data, default, combine)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(n) = self.right.as_mut() { n.insert(point_n, point_data, default, combine) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/segmentpoint.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | let ref son = if point <= mid_n { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 81 | let son = &(if point <= mid_n { [INFO] [stderr] 82 | &self.left [INFO] [stderr] 83 | } else { [INFO] [stderr] 84 | &self.right [INFO] [stderr] 85 | }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/segmentpoint.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | / self.left.as_mut().map(|n| n.insert(start_s, end_s, [INFO] [stderr] 106 | | value_s, default, combine)); [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 105 | if let Some(n) = self.left.as_mut() { n.insert(start_s, end_s, [INFO] [stderr] 106 | value_s, default, combine) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/segmentpoint.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | / self.right.as_mut().map(|n| n.insert(start_s, end_s, [INFO] [stderr] 113 | | value_s, default, combine)); [INFO] [stderr] | |____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 112 | if let Some(n) = self.right.as_mut() { n.insert(start_s, end_s, [INFO] [stderr] 113 | value_s, default, combine) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/segmentpoint.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | / self.left.as_mut().map(|n| n.insert(start_s, mid_n.clone(), [INFO] [stderr] 120 | | value_s, default, combine)); [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 119 | if let Some(n) = self.left.as_mut() { n.insert(start_s, mid_n.clone(), [INFO] [stderr] 120 | value_s, default, combine) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/segmentpoint.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / self.right.as_mut().map(|n| n.insert(mid_n + One::one(), end_s, [INFO] [stderr] 125 | | value_s, default, combine)); [INFO] [stderr] | |____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 124 | if let Some(n) = self.right.as_mut() { n.insert(mid_n + One::one(), end_s, [INFO] [stderr] 125 | value_s, default, combine) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/pointsegment.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | self.left.as_mut().map(|n| n.insert(point_n, point_data, default, combine)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(n) = self.left.as_mut() { n.insert(point_n, point_data, default, combine) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/pointsegment.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | self.right.as_mut().map(|n| n.insert(point_n, point_data, default, combine)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(n) = self.right.as_mut() { n.insert(point_n, point_data, default, combine) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/pointsegments.rs:150:14 [INFO] [stderr] | [INFO] [stderr] 150 | for i in (1..10) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.11s [INFO] running `"docker" "inspect" "d2f4439ea20d2d7b30fdbe0dd804a0244c6f71db4d7f18f4fc0d3b0939314411"` [INFO] running `"docker" "rm" "-f" "d2f4439ea20d2d7b30fdbe0dd804a0244c6f71db4d7f18f4fc0d3b0939314411"` [INFO] [stdout] d2f4439ea20d2d7b30fdbe0dd804a0244c6f71db4d7f18f4fc0d3b0939314411