[INFO] crate interval-heap 0.0.5 is already in cache [INFO] extracting crate interval-heap 0.0.5 into work/ex/clippy-test-run/sources/stable/reg/interval-heap/0.0.5 [INFO] extracting crate interval-heap 0.0.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/interval-heap/0.0.5 [INFO] validating manifest of interval-heap-0.0.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of interval-heap-0.0.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing interval-heap-0.0.5 [INFO] finished frobbing interval-heap-0.0.5 [INFO] frobbed toml for interval-heap-0.0.5 written to work/ex/clippy-test-run/sources/stable/reg/interval-heap/0.0.5/Cargo.toml [INFO] started frobbing interval-heap-0.0.5 [INFO] finished frobbing interval-heap-0.0.5 [INFO] frobbed toml for interval-heap-0.0.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/interval-heap/0.0.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting interval-heap-0.0.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/interval-heap/0.0.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4c9199ab3e8411d2e810321bfd78f2573332e43080b0b9152acdf0d2f45735dd [INFO] running `"docker" "start" "-a" "4c9199ab3e8411d2e810321bfd78f2573332e43080b0b9152acdf0d2f45735dd"` [INFO] [stderr] Checking compare v0.0.6 [INFO] [stderr] Checking interval-heap v0.0.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:222:38 [INFO] [stderr] | [INFO] [stderr] 222 | IntervalHeap { data: vec![], cmp: cmp } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cmp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:228:60 [INFO] [stderr] | [INFO] [stderr] 228 | IntervalHeap { data: Vec::with_capacity(capacity), cmp: cmp } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cmp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:222:38 [INFO] [stderr] | [INFO] [stderr] 222 | IntervalHeap { data: vec![], cmp: cmp } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cmp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:228:60 [INFO] [stderr] | [INFO] [stderr] 228 | IntervalHeap { data: Vec::with_capacity(capacity), cmp: cmp } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cmp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:237:46 [INFO] [stderr] | [INFO] [stderr] 237 | let heap = IntervalHeap { data: vec, cmp: cmp }; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cmp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:612:28 [INFO] [stderr] | [INFO] [stderr] 612 | IntervalHeap { data: data, cmp: ::compare::natural() } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:237:46 [INFO] [stderr] | [INFO] [stderr] 237 | let heap = IntervalHeap { data: vec, cmp: cmp }; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cmp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:612:28 [INFO] [stderr] | [INFO] [stderr] 612 | IntervalHeap { data: data, cmp: ::compare::natural() } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / if right < v.len() { [INFO] [stderr] 117 | | if cmp.compares_gt(&v[left], &v[right]) { v.swap(left, right); } [INFO] [stderr] 118 | | } [INFO] [stderr] | |_____________^ help: try: `if right < v.len() && cmp.compares_gt(&v[left], &v[right]) { v.swap(left, right); }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:73:19 [INFO] [stderr] | [INFO] [stderr] 73 | debug_assert!(v.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:234:19 [INFO] [stderr] | [INFO] [stderr] 234 | for to in 2 .. vec.len() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `2..=vec.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:448:21 [INFO] [stderr] | [INFO] [stderr] 448 | self.extend(iter.into_iter().map(|&item| item)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `iter.into_iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / if right < v.len() { [INFO] [stderr] 117 | | if cmp.compares_gt(&v[left], &v[right]) { v.swap(left, right); } [INFO] [stderr] 118 | | } [INFO] [stderr] | |_____________^ help: try: `if right < v.len() && cmp.compares_gt(&v[left], &v[right]) { v.swap(left, right); }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:73:19 [INFO] [stderr] | [INFO] [stderr] 73 | debug_assert!(v.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:234:19 [INFO] [stderr] | [INFO] [stderr] 234 | for to in 2 .. vec.len() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `2..=vec.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:448:21 [INFO] [stderr] | [INFO] [stderr] 448 | self.extend(iter.into_iter().map(|&item| item)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `iter.into_iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.70s [INFO] running `"docker" "inspect" "4c9199ab3e8411d2e810321bfd78f2573332e43080b0b9152acdf0d2f45735dd"` [INFO] running `"docker" "rm" "-f" "4c9199ab3e8411d2e810321bfd78f2573332e43080b0b9152acdf0d2f45735dd"` [INFO] [stdout] 4c9199ab3e8411d2e810321bfd78f2573332e43080b0b9152acdf0d2f45735dd