[INFO] crate internment 0.3.6 is already in cache
[INFO] extracting crate internment 0.3.6 into work/ex/clippy-test-run/sources/stable/reg/internment/0.3.6
[INFO] extracting crate internment 0.3.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/internment/0.3.6
[INFO] validating manifest of internment-0.3.6 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of internment-0.3.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing internment-0.3.6
[INFO] finished frobbing internment-0.3.6
[INFO] frobbed toml for internment-0.3.6 written to work/ex/clippy-test-run/sources/stable/reg/internment/0.3.6/Cargo.toml
[INFO] started frobbing internment-0.3.6
[INFO] finished frobbing internment-0.3.6
[INFO] frobbed toml for internment-0.3.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/internment/0.3.6/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting internment-0.3.6 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/internment/0.3.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 71601a5d72fe18ab9b8193f0f0ce4f7dbab5b77e64768d823820c31ff01be7a1
[INFO] running `"docker" "start" "-a" "71601a5d72fe18ab9b8193f0f0ce4f7dbab5b77e64768d823820c31ff01be7a1"`
[INFO] [stderr]     Checking tinyset v0.2.2
[INFO] [stderr]     Checking thread_local v0.3.3
[INFO] [stderr]     Checking state v0.4.1
[INFO] [stderr]     Checking internment v0.3.6 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:129:9
[INFO] [stderr]     |
[INFO] [stderr] 129 |         return Intern { pointer: p };
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Intern { pointer: p }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: operator precedence can trip the unwary
[INFO] [stderr]    --> src/lib.rs:159:29
[INFO] [stderr]     |
[INFO] [stderr] 159 |         Intern { pointer: ((x ^ heap_location() / sz::<T>()) * sz::<T>() ) as *const T }
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `x ^ (heap_location() / sz::<T>())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::precedence)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
[INFO] [stderr] 
[INFO] [stderr] warning: operator precedence can trip the unwary
[INFO] [stderr]    --> src/lib.rs:162:9
[INFO] [stderr]     |
[INFO] [stderr] 162 |         self.pointer as u64 / sz::<T>() ^ heap_location() / sz::<T>()
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self.pointer as u64 / sz::<T>()) ^ (heap_location() / sz::<T>())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
[INFO] [stderr] 
[INFO] [stderr] warning: operator precedence can trip the unwary
[INFO] [stderr]    --> src/lib.rs:173:34
[INFO] [stderr]     |
[INFO] [stderr] 173 |         LocalIntern { pointer: ((x ^ heap_location() / sz::<T>()) * sz::<T>() ) as *const T }
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `x ^ (heap_location() / sz::<T>())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
[INFO] [stderr] 
[INFO] [stderr] warning: operator precedence can trip the unwary
[INFO] [stderr]    --> src/lib.rs:176:9
[INFO] [stderr]     |
[INFO] [stderr] 176 |         self.pointer as u64 / sz::<T>() ^ heap_location() / sz::<T>()
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self.pointer as u64 / sz::<T>()) ^ (heap_location() / sz::<T>())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:133:33
[INFO] [stderr]     |
[INFO] [stderr] 133 |     pub fn num_objects_interned(&self) -> usize {
[INFO] [stderr]     |                                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/lib.rs:287:10
[INFO] [stderr]     |
[INFO] [stderr] 287 |         *m.counts.get(&Intern{ pointer: self.pointer }).unwrap()
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&m.counts[&Intern{ pointer: self.pointer }]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:403:50
[INFO] [stderr]     |
[INFO] [stderr] 403 |                 T::deserialize(deserializer).map(|x: T| Self::new(x))
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Self::new`
[INFO] [stderr] ...
[INFO] [stderr] 447 | create_impls!(ArcIntern, arcintern_impl_tests, [Eq,Hash,Send], [Eq,Hash,Send] );
[INFO] [stderr]     | -------------------------------------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:403:50
[INFO] [stderr]     |
[INFO] [stderr] 403 |                 T::deserialize(deserializer).map(|x: T| Self::new(x))
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Self::new`
[INFO] [stderr] ...
[INFO] [stderr] 448 | create_impls!(Intern, intern_impl_tests, [], [Eq,Hash,Send]);
[INFO] [stderr]     | ------------------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:403:50
[INFO] [stderr]     |
[INFO] [stderr] 403 |                 T::deserialize(deserializer).map(|x: T| Self::new(x))
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Self::new`
[INFO] [stderr] ...
[INFO] [stderr] 449 | create_impls!(LocalIntern, localintern_impl_tests, [], [Eq,Hash]);
[INFO] [stderr]     | ------------------------------------------------------------------ in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:571:33
[INFO] [stderr]     |
[INFO] [stderr] 571 |     pub fn num_objects_interned(&self) -> usize {
[INFO] [stderr]     |                                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:129:9
[INFO] [stderr]     |
[INFO] [stderr] 129 |         return Intern { pointer: p };
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Intern { pointer: p }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: operator precedence can trip the unwary
[INFO] [stderr]    --> src/lib.rs:159:29
[INFO] [stderr]     |
[INFO] [stderr] 159 |         Intern { pointer: ((x ^ heap_location() / sz::<T>()) * sz::<T>() ) as *const T }
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `x ^ (heap_location() / sz::<T>())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::precedence)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
[INFO] [stderr] 
[INFO] [stderr] warning: operator precedence can trip the unwary
[INFO] [stderr]    --> src/lib.rs:162:9
[INFO] [stderr]     |
[INFO] [stderr] 162 |         self.pointer as u64 / sz::<T>() ^ heap_location() / sz::<T>()
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self.pointer as u64 / sz::<T>()) ^ (heap_location() / sz::<T>())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
[INFO] [stderr] 
[INFO] [stderr] warning: operator precedence can trip the unwary
[INFO] [stderr]    --> src/lib.rs:173:34
[INFO] [stderr]     |
[INFO] [stderr] 173 |         LocalIntern { pointer: ((x ^ heap_location() / sz::<T>()) * sz::<T>() ) as *const T }
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `x ^ (heap_location() / sz::<T>())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
[INFO] [stderr] 
[INFO] [stderr] warning: operator precedence can trip the unwary
[INFO] [stderr]    --> src/lib.rs:176:9
[INFO] [stderr]     |
[INFO] [stderr] 176 |         self.pointer as u64 / sz::<T>() ^ heap_location() / sz::<T>()
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self.pointer as u64 / sz::<T>()) ^ (heap_location() / sz::<T>())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:133:33
[INFO] [stderr]     |
[INFO] [stderr] 133 |     pub fn num_objects_interned(&self) -> usize {
[INFO] [stderr]     |                                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/lib.rs:287:10
[INFO] [stderr]     |
[INFO] [stderr] 287 |         *m.counts.get(&Intern{ pointer: self.pointer }).unwrap()
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&m.counts[&Intern{ pointer: self.pointer }]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:403:50
[INFO] [stderr]     |
[INFO] [stderr] 403 |                 T::deserialize(deserializer).map(|x: T| Self::new(x))
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Self::new`
[INFO] [stderr] ...
[INFO] [stderr] 447 | create_impls!(ArcIntern, arcintern_impl_tests, [Eq,Hash,Send], [Eq,Hash,Send] );
[INFO] [stderr]     | -------------------------------------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:403:50
[INFO] [stderr]     |
[INFO] [stderr] 403 |                 T::deserialize(deserializer).map(|x: T| Self::new(x))
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Self::new`
[INFO] [stderr] ...
[INFO] [stderr] 448 | create_impls!(Intern, intern_impl_tests, [], [Eq,Hash,Send]);
[INFO] [stderr]     | ------------------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:403:50
[INFO] [stderr]     |
[INFO] [stderr] 403 |                 T::deserialize(deserializer).map(|x: T| Self::new(x))
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Self::new`
[INFO] [stderr] ...
[INFO] [stderr] 449 | create_impls!(LocalIntern, localintern_impl_tests, [], [Eq,Hash]);
[INFO] [stderr]     | ------------------------------------------------------------------ in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:571:33
[INFO] [stderr]     |
[INFO] [stderr] 571 |     pub fn num_objects_interned(&self) -> usize {
[INFO] [stderr]     |                                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 4.49s
[INFO] running `"docker" "inspect" "71601a5d72fe18ab9b8193f0f0ce4f7dbab5b77e64768d823820c31ff01be7a1"`
[INFO] running `"docker" "rm" "-f" "71601a5d72fe18ab9b8193f0f0ce4f7dbab5b77e64768d823820c31ff01be7a1"`
[INFO] [stdout] 71601a5d72fe18ab9b8193f0f0ce4f7dbab5b77e64768d823820c31ff01be7a1